Re: Request for sponsoring: dcmtk to experimental

2016-05-09 Thread Gert Wollny
Hello Mattia, 

> Okay, done, tested, and pushed.  I also pushed the new upstream tag
> > now, forgot to do it before. 
> uploaded, enjoy! :)
> I just did a couple of tiny (hopefully uncontroversial) changes
> before
> it.  I hope that's fine.
Thanks for the cleanup, 

With the URL's I saw the lintian info, and thought, okay, next time.  
As for the predantic lintian message, fine as well, I usually don't run
these checks though. 

> For the next one, could you please have a look at enabling parallel
> building it, and maybe enabling hardening?
The parallel build are enabled, at least in the way I know (i.e. 
d/rules contains : 

%: 
dh  $@ --parallel

And when I run "gbp buildpackage -j7" it compiles in parallel. 

Hardening should also be enabled, at least I see the 
-D_FORTIFY_SOURCE=2 compile flag when compiling.  I know that there are
some lintian warnings that indicate otherwise, but in my experience the
compiler sometimes just optimizee things away because it sees that the
hardening code is not needed, and then lintian warns about it. 

Best, 
Gert 



Re: Request for sponsoring: dcmtk to experimental

2016-05-08 Thread Mattia Rizzolo
On Sun, May 08, 2016 at 07:46:00PM +0200, Gert Wollny wrote:
> Am Sonntag, den 08.05.2016, 17:36 + schrieb Mattia Rizzolo:
> > 
> > > 
> > > I'll ping you on the list when this is done. 
> > Thanks.
> > 
> 
> Okay, done, tested, and pushed.  I also pushed the new upstream tag
> now, forgot to do it before. 

uploaded, enjoy! :)
I just did a couple of tiny (hopefully uncontroversial) changes before
it.  I hope that's fine.

For the next one, could you please have a look at enabling parallel
building it, and maybe enabling hardening?

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature


Re: Request for sponsoring: dcmtk to experimental

2016-05-08 Thread Gert Wollny
Am Sonntag, den 08.05.2016, 17:36 + schrieb Mattia Rizzolo:
> 
> > 
> > I'll ping you on the list when this is done. 
> Thanks.
> 

Okay, done, tested, and pushed.  I also pushed the new upstream tag
now, forgot to do it before. 

many thanks, 
Gert 



Re: Request for sponsoring: dcmtk to experimental

2016-05-08 Thread Gert Wollny
Am Sonntag, den 08.05.2016, 16:42 + schrieb Mattia Rizzolo:
> On Sun, May 08, 2016 at 05:31:07PM +0200, Gert Wollny wrote:
> > 
> > - Because upstream set the so-version to 8 I also changed the
> > library
> > package version to libdcmtk8 (instead of 6). 
> > - d/copyright overhaul
> What about dropping the manual -dbg in favour of the automatic ones?
> 
Well, I'm a bit concerned about the proper upgrade path from these
packages. It seems this is not really defined, and since debsym
packages don't go into d/control, I also seems that there is no option
to define a virtual package -dbg to get this automatically. 

On the other hand the -dbg popcorn count is very low (2), so maybe
there is no real harm in dropping the -dbg package. 

I'll ping you on the list when this is done. 

Best, 
Gert 




Re: Request for sponsoring: dcmtk to experimental

2016-05-08 Thread Mattia Rizzolo
On Sun, May 08, 2016 at 05:31:07PM +0200, Gert Wollny wrote:
> - Because upstream set the so-version to 8 I also changed the library
> package version to libdcmtk8 (instead of 6). 
> - d/copyright overhaul

What about dropping the manual -dbg in favour of the automatic ones?

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature


Re: Request for sponsoring: dcmtk to experimental

2016-05-08 Thread Mattia Rizzolo
I'll do it, hopefully in a bunch of hours.

On Sun, May 08, 2016 at 05:31:07PM +0200, Gert Wollny wrote:
> I've prepared the latest version of dcmtk in the packaging git for
> uploading. The version changes the SO-Name of the library, hence I'd
> suggest to upload first to experimental so I can later check whether
> all reveres dependencies build properly. 

this is not really a "suggestion", it's very very very recommended by
the Release Team, and it's part of the transitions workflow.
https://wiki.debian.org/Teams/ReleaseTeam/Transitions

Exceptions occour for very simple transitions involving a handful of
rdeps, or stuff already ack'ed by the release team.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature


Request for sponsoring: dcmtk to experimental

2016-05-08 Thread Gert Wollny
Dear all, 

I've prepared the latest version of dcmtk in the packaging git for
uploading. The version changes the SO-Name of the library, hence I'd
suggest to upload first to experimental so I can later check whether
all reveres dependencies build properly. 

Major changes: 

- Because upstream set the so-version to 8 I also changed the library
package version to libdcmtk8 (instead of 6). 
- d/copyright overhaul


Many thanks, 
Gert