Re: RFS: opencpn
Hi, an update on ITP progress for the OpenCPN software (opencpn.org). | the debian/ dir can be viewed here: |http://anonscm.debian.org/viewvc/pkg-grass/packages/opencpn/trunk/ | | the .orig tarball can be found here: |http://pkg-grass.alioth.debian.org/tarballs/ | |sample data to test it with can be found here: | https://trac.osgeo.org/osgeo/browser/livedvd/gisvm/trunk/bin/install_opencpn.sh#L75 wrt open issues that I'm aware of: re. upstream +dfsg version of the tarball in alioth svn: Paul Wise wrote: Another solution is to use the alioth web space, like pkg-games do: http://pkg-games.alioth.debian.org/tarballs/ --ok, created http://pkg-grass.alioth.debian.org/tarballs/ with audit-trail md5sum held in alioth svn re. prebuilt icons vs. build-depends on Inkscape to regenerate them from svn each time: --no action taken. re. paypal graphics: --gave up on waiting for a reply from them. replaced by a nice substitute graphic from upstream. we should consider filing bugs against others found by `apt-file search`, but our replacement is not generic enough for other projects to use directly. (as it includes the opencpn logo) re. dropping unused embedded code as part of debian/rules --done. Build-Depend on libtinyxml-dev and add any patches needed to build against the system version. --done. note the library doesn't exist before squeeze,maverick. Added README.lucid to explain how to back-build there ( for lenny). helper-templates-in-copyright x3: I don't see what it's talking about, the debian/copyright files are custom crafted. http://lintian.debian.org/tags/helper-templates-in-copyright.html --false positive debian/changelog does not close the ITP. --done. re. support debhelper --parallel --done, works. (earlier problems were PBKAC) re. executable bit set on regular text files --fixed upstream, mostly in the current beta release, the few stragglers are already fixed for the next one. compiler warnings: there are a few warnings we're not sure how to fix. no segfaults reported.. ? src/garmin/jeeps/gpsusbcommon.c: warning: array subscript is above array bounds [-Warray-bounds] ? and many like these: /usr/bin/ld: Warning: alignment 8 of symbol `gps_waypt_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) ? valgrind analysis: --volunteers welcome. Your Standards-Version is out of date, --todo. A lot of the source code contains CVS $Id lines --further cleaned out in the lastest push. thanks, Hamish -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1309506879.55919.yahoomailclas...@web110011.mail.gq1.yahoo.com
Re: RFS: kamerka
Hi Sebastian,
Sebastian Krzyszkowiak wrote:
I am looking for a sponsor for my package kamerka.
* Package name: kamerka
Version : 0.6-1
Upstream Author : Sebastian Krzyszkowiak d...@dosowisko.net
* URL : http://dos1.github.com/kamerka/
* License : GPLv2+
Section : kde
It builds these binary packages:
kamerka- Take photos using your webcam and shiny animated QML interface
I had a look at your package, so here are a few comments that might
help:
- Your short and long descriptions are too technical; have a look at
[1] for the best practices.
[1]
http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-debian-control
- In debian/control, you recommend dolphin, gimp and inkscape; this is
way too strong. In fact, I would not even suggest them, so I think
you should drop that line entirely.
Same thing for suggesting kdebase-workspace-bin; why would someone
who doesn't have it installed already want to add this package with
all its dependencies?
- You depend explicitly on a few libraries, but if your application is
linking to them, they should be listed in ${shlibs:Depends} already.
- Your debian/copyright is not DEP-5 compliant; there's no Name or
Maintainer field, and you should use a versioned Format URL.
- licensecheck reports that po/extract-messages.sh is missing a
copyright header, and that the other files have a GPL header with an
incorrect FSF address; please ask upstream to correct this.
- You could raise the debhelper compat level to 8 in debian/compat and
debian/control.
Cheers,
--
Benoît Knecht
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110701082945.ga20...@marvin.lan
Re: RFS: sxiv
Hi Daniel,
non-D{D,M} speaking, but i have used sxiv now and then and even
did a quickdirty package for myself, so let me comment your
welcomed package effort for inclusion sxiv in debian main:
On Fri, Jul 1, 2011 at 03:37, Daniel Echeverry epsilo...@gmail.com wrote:
The package appears to be lintian clean.
Thats true for lintian without any option, but its a good idea to let it watch
a bit more pedantic at times. Not everything it suggests in these modes
is necessarily a good suggestion, but some are worthwhile:
$ lintian -I -E --pedantic sxiv_0.8.2-1_i386.changes
P: sxiv: no-upstream-changelog
I: sxiv: hyphen-used-as-minus-sign usr/share/man/man1/sxiv.1.gz:79
I: sxiv: hyphen-used-as-minus-sign usr/share/man/man1/sxiv.1.gz:239
The first can be ignored as upstream doesn't provide a changelog
(you can ask for one of course if you want), but the others are easy
to fix. Don't forget to sent them upstream. :)
Apropos patches: You have a patch to not install the manpage from
the Makefile. Why? I don't see a reason for it as debhelper does
the right thing (TM), but either way that is something you should
note in the description of the patch if you keep it that way.
A small thing regarding debian/copyright in dep5:
The Format: links to dep5 homepage. You need to link to a versioned
spec so a machine knows how to interpret your file.
And as i am really pedantic at times (feel free to ignore it):
* spec allows it to say 'GPL-2.0+' but 'GPL-2+' is a lot more used
so the first looks like it would be special in some way
(the emphasis on 2.0 instead of 'just' 2 i mean).
* you don't need to move the license text to a new 'License:' block
All in all i can't find something really serious,
so i hope you will find a sponsor soon.
Best regards
David Kalnischkies
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/BANLkTin8DaeZycqppp+=hjoaujnftcn...@mail.gmail.com
Re: RFS: sxiv
Hi Daniel, On Thu, 2011-06-30 at 20:37 -0500, Daniel Echeverry wrote: I am looking for a sponsor for my package sxiv. * Package name: sxiv Version : 0.8.2-1 Upstream Author : Bert Münnich muenn...@informatik.hu-berlin.de * URL : https://github.com/muennich/sxiv * License : GPL2+ Section : graphics It builds these binary packages: sxiv - simple X image viewer The package appears to be lintian clean. The upload would fix these bugs: 631728 My motivation for maintaining this package is: Always I wanted a lightweight viewer for my debian, I recently met sxiv and I liked for its ease and simplicity. I hope to keep the package and provide for this in debian for a long time I see you've found feh already which I would have proposed as very slim image viewer. ;-) The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/s/sxiv - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_0.8.2-1.dsc Comments are: - all upstream copyright still has old FSF address - Your installation of the manpage does break upstream's logic to write the version number into the manpage. I would consider installing the manpages like upstream proposes the preferred approach. So IMHO your patch should be removed (and the sxiv.manpages file in debian/) - The upstream manpage however still has two hyphen-used-as-minus-sign issues: usr/share/man/man1/sxiv.1.gz:79 usr/share/man/man1/sxiv.1.gz:239 I would be glad if someone uploaded this package for me. I've taken the liberty to remove your patch, build, sign and upload your package. For your info the package is at http://people.debian.org/~kilian/sxiv/ as was uploaded. Thanks for your work! -- Best regards, Kilian signature.asc Description: This is a digitally signed message part
Re: RFS: sxiv
* Kilian Krause kil...@debian.org [110701 15:40]: Always I wanted a lightweight viewer for my debian, I recently met sxiv and I liked for its ease and simplicity. I hope to keep the package and provide for this in debian for a long time I see you've found feh already which I would have proposed as very slim image viewer. ;-) There a few other lightweight image viewers in debian (qiv, xli come to my mind). What makes sxiv necessary for inclusion in debian that others packages do not provide ? -- Etienne Millon -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110701134408.ga25...@john.ssi.corp
Re: RFS: peak-linux-driver
Hi Markus, I'm not a DD but I took a look at your package. I'm not very familiar with source for kernel module but my assumptions were that the .in files are for the binary package which will be created from the source included in your package. and here are my remarks: * Switch to source format 3.0 (quilt) Source format 3.0 (git) is still experimental, I don't even think it is accepted by Debian yet. Please switch to format 3.0 (quilt) instead, which is the closest source format. * Generate manpages from xml It seems the manpages are generated from the xml via xsltproc but I didn't see any call to xsltproc in the rules file. * Drop any reference to libpcan debian/changelog mention that libpcan is not built anymore but libpcan*.install files are still included and there are still lines about it in debian/rules. * Try using debhelper compatibility 8 debian/changelog mention using compat 7 but debian/compat still contain 6 (debian/control is ok though). Compat 8 is the recommended compatibility now. This remark apply both to debian/control and debian/control.modules.in * Handle RFP correctly (RFP - ITP + Closes in changelog) As you said this package would fix RFP #486470. You should first rename the RFP to ITP and makes yourself the owner of the bug as described at [WNPP howto]. You must then add a 'Closes: #486470' to your changelog * Merge history entries of debian/changelog This package has never been part of Debian and debian/changelog must describe the change made to the debian packaging. Hence your changelog should only contains one entry for the to-be-uploaded package version which merge all the current entries. * Conform your package to policy 3.9.2 Bump Standards-Version to 3.9.2 and make sure your package is compliant with this version of the Debian policy. This remark apply to both debian/control and debian/control.modules.in * Depends on make-kpkg (?) I'm not sure about this one since I could not find the policy about binary package. But it seems to me that if you depends on bzip2 and make, you should maybe also Depends, or Recommends, make-kpkg. * Try using dh-style makefile for debian/rules debhelper 7 introduced dh-style Makefile. This makes debian/rules much shorter in most cases and thus easier to read. You will then need to configure the behaviour of all dh_* function you use in your debian/rules via some special files like the *.install files you use to configure dh_install behaviour. * Use DEP5 for debian/copyright Try using DEP5 as format of your debian/copyright. This ensure that your copyright is machine readable and hence makes information it contains easy to extract from it * Apply the same rules to *.in files Your control.modules.in currently use compat 7 and comply to policy 3.8.4 [WNPP howto] http://www.debian.org/devel/wnpp/#l3 signature.asc Description: This is a digitally signed message part.
Re: RFS: php-pager (updated package)
Hi Luis, On Thu, 2011-06-30 at 23:06 -0500, Luis Uribe wrote: I'm looking for a sponsor for the new version of [1]php-pager. Thanks for stepping up as new maintainer of an orphaned package! I would be glad if someone checks and/or upload this package for me. The package closes the bug #569464. [1] http://mentors.debian.net/debian/pool/main/p/php-pager/php-pager_2.4.8-1.dsc I have an issue with lintian: php-pager: duplicate-files usr/share/doc/php-pager/changelog.Debian.gz usr/share/doc/php-pager/changelog.gz But the package has no upstream changelog, so dh_installchangelogs installs the same file two times. Because you tell it to. Just don't add it explicitly to the dh_installchangelogs. ;-) Full Comments are: - You have bumped standards-version but left debhelper at 7. Update to 8 would be highly apprechiated - Changing the Section also needs to happen in the ftp. Did FTPmasters request this or have you informed them regarding this update by filing a bug against the ftp.debian.org package? - Your changelog entry entirely misses New upstream version. ;-) - Your debian-changes patch needlessly patches 3 lines more than just that single one you actually wanted to affect Moreover it reads in the description: Undocumented upstream changes What's that supposed to mean? - Your debian/rules is still old-style and would largely benefit from an update to debhelper =7 version using dh - Your install target eventually may want to use $(PEAR) install ... debian/tmp and then use dh_install logic to only extract wanted parts from there instead of shipping that much rm lines - dh_installchangelogs debian/changelog as said above is wrong. The Debian changelog is debian/changelog and will be installed as changelog.Debian.gz in the resulting package. If there is an upstream changelog you may put this here. If there is none, just don't put anything. - the tests and examples seem to not have a copyright. Would be nice if they could be assigned one by upstream. I've taken the liberty of removing the debian/copyright from the call to dh_installchangelogs in debian/rules and build, sign, upload your package. Thanks again for stepping up as new maintainer! -- Best regards, Kilian signature.asc Description: This is a digitally signed message part
Re: RFS: sxiv
Hi Kilian. 2011/7/1 Kilian Krause kil...@debian.org Hi Daniel, On Thu, 2011-06-30 at 20:37 -0500, Daniel Echeverry wrote: I am looking for a sponsor for my package sxiv. * Package name: sxiv Version : 0.8.2-1 Upstream Author : Bert Münnich muenn...@informatik.hu-berlin.de * URL : https://github.com/muennich/sxiv * License : GPL2+ Section : graphics It builds these binary packages: sxiv - simple X image viewer The package appears to be lintian clean. The upload would fix these bugs: 631728 My motivation for maintaining this package is: Always I wanted a lightweight viewer for my debian, I recently met sxiv and I liked for its ease and simplicity. I hope to keep the package and provide for this in debian for a long time I see you've found feh already which I would have proposed as very slim image viewer. ;-) The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/s/sxiv - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_0.8.2-1.dsc Comments are: - all upstream copyright still has old FSF address - Your installation of the manpage does break upstream's logic to write the version number into the manpage. I would consider installing the manpages like upstream proposes the preferred approach. So IMHO your patch should be removed (and the sxiv.manpages file in debian/) - The upstream manpage however still has two hyphen-used-as-minus-sign issues: usr/share/man/man1/sxiv.1.gz:79 usr/share/man/man1/sxiv.1.gz:239 I would be glad if someone uploaded this package for me. I've taken the liberty to remove your patch, build, sign and upload your package. For your info the package is at http://people.debian.org/~kilian/sxiv/ as was uploaded. Thanks for your work! -- Best regards, Kilian Thank you very much for the suggestions and uploaded the package! -- Epsilon http://www.rinconinformatico.net http://www.fitnessdeportes.com http://www.dragonjar.org Linux user: #477840 Debian user
Re: RFS: Jampal (2nd try)
Hi Peter, Peter Bennett wrote: I am looking for a sponsor for my package jampal. This is my second attempt. I have fixed errors that were pointed out to me last time. * Package name: jampal Version : 02.01.03-1 Upstream Author : I am the upstream author. Peter Bennett pgbenn...@comcast.net. * URL : http://jampal.sourceforge.net * License : GPLv3 or higher Section : sound It builds these binary packages: tagbkup- back up and restore mp3 tags jampal - mp3 song library management system and player I reviewed your package, and here's a list of things that could be improved: - Your debian/watch file currently matches the upstream version 'build-Linux-x86_64-02.01.04', which is not what you want; you need to refine it; also, this file shouldn't be executable. - lintian -I --pedantic jampal_02.01.03-1.dsc reports the following: P: jampal source: source-contains-svn-commit-file svn-commit.2.tmp P: jampal source: source-contains-svn-commit-file svn-commit.tmp P: jampal source: source-contains-prebuilt-windows-binary misc/windows-32/mbrola.exe P: jampal source: source-contains-prebuilt-windows-binary misc/windows-32/pttsjni.dll P: jampal source: source-contains-prebuilt-windows-binary misc/windows-32/libgcc_s_dw2-1.dll P: jampal source: source-contains-prebuilt-windows-binary misc/windows-32/ptts.exe P: jampal source: unneeded-build-dep-on-quilt W: jampal source: out-of-date-standards-version 3.9.1.0 (current is 3.9.2) - debian/copyright: I don't think ID3V2 is a free license; it doesn't seem to allow modifications, only redistribution. Also, you may want to upgrade to the latest DEP-5 revision. - debian/control: you recommend openoffice packages, it seems overkill. The Recommends field should list packages that would be found together with this one in all but unusual installations [1], would you say it's the case here? [1] http://www.debian.org/doc/debian-policy/ch-relationships.html#s-binarydeps Your long description seems a bit convoluted and you repeat the words the library a lot. Also, your spelling of ID3v2 is not consistent. Have a look at [2] for the best practices. [2] http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-debian-control - debian/patches: if you're upstream, you shouldn't have any patches here, you can merge them directly. - debhelper compatibility level should be 8 (in debian/compat and debian/control). Cheers, -- Benoît Knecht -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110701220157.ga11...@marvin.lan
Re: RFS: phing (Another try)
Hi Nicolas, Nicolas wrote: I am looking for a sponsor for my package phing. * Package name: phing Version : 2.4.5-1 Upstream Author : Hans Lellelid h...@xmpl.org * URL : http://phing.info/ * License : LGPG-3 Section : devel It builds these binary packages: phing - PHP based build tool Two quick comments: - I don't think you should be shipping debian/gbp.conf. - Your man page advises users to report bugs to some email address; I think you should let them follow their distribution's recommendation (in Debian, report bugs to the Debian BTS and let the maintainer decide if they should be forwarded upstream). - (Okay three comments actually.) Your debian/copyright file doesn't use a versioned Format URL; in the latest version of DEP-5, the Name and Maintainer fields do not exist. The first Copyright and License should not be in their own paragraphs. Cheers, -- Benoît Knecht -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110701222040.gb11...@marvin.lan
Re: RFS: libzipper
Hi Michael, Michael McMaster wrote: I am looking for a sponsor for my package libzipper. * Package name: libzipper Version : 1.0.1-1 Upstream Author : Michael McMaster mich...@codesrc.com (myself) * URL : http://www.codesrc.com/src/libzipper * License : GPLv3+ Section : libs It builds these binary packages: libzipper-dev - simple interface for reading and writing compressed files libzipper-doc - simple interface for reading and writing compressed files libzipper-tools - utilities for reading and writing compressed files libzipper1 - simple interface for reading and writing compressed files The package appears to be lintian clean. I didn't look much into your package yet, but lintian gives a bunch of warnings and errors that you might want to look into: I: libzipper source: binary-control-field-duplicates-source field homepage in package libzipper-dev I: libzipper source: binary-control-field-duplicates-source field homepage in package libzipper1 I: libzipper source: binary-control-field-duplicates-source field section in package libzipper1 I: libzipper source: binary-control-field-duplicates-source field homepage in package libzipper-tools I: libzipper source: binary-control-field-duplicates-source field homepage in package libzipper-doc I: libzipper source: duplicate-short-description libzipper-dev libzipper1 libzipper-doc P: libzipper1: no-upstream-changelog W: libzipper1: copyright-has-url-from-dh_make-boilerplate I: libzipper1: no-symbols-control-file usr/lib/libzipper.so.1.0.0 P: libzipper-dev: no-upstream-changelog W: libzipper-dev: copyright-has-url-from-dh_make-boilerplate E: libzipper-dev: non-empty-dependency_libs-in-la-file usr/lib/libzipper.la P: libzipper-doc: no-upstream-changelog W: libzipper-doc: copyright-has-url-from-dh_make-boilerplate P: libzipper-tools: no-upstream-changelog W: libzipper-tools: copyright-has-url-from-dh_make-boilerplate Cheers, -- Benoît Knecht -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110701224819.gc11...@marvin.lan
RFS: creepy (updated package) (New Upstream release)
Dear mentors, I am looking for a sponsor for the new version 0.1.94-1 of my package creepy. It builds these binary packages: creepy - geolocation information aggregator The package appears to be lintian clean. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/c/creepy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/c/creepy/creepy_0.1.94-1.dsc I would be glad if someone uploaded this package for me. Kind regards Daniel Echeverry -- Epsilon http://www.rinconinformatico.net http://www.fitnessdeportes.com http://www.dragonjar.org Linux user: #477840 Debian user
