Bug#662955: review
Hi, I'm not a DD so I can't sponsor your package, but I would be using this
package if it was in the archive. Thanks for packaging it. A few points about
the package:
* You don't need the substvar ${shlibs:Depends} in the control file for the
binary packages, since they are not compiled code. This gives a warning
currently.
* Why is the package priority extra? It should probably be optional.
* Consider switching off DH_VERBOSE in debian/rules before release, or at least
remove the comment above it.
* The translations seem to be being compiled twice, once during dh_auto_build
and once during dh_auto_install. This is probably unnecessary.
* You may want to Recommend or Suggest the 'vorbisgain' and 'mp3gain' package,
if rubyripper can use them. The same goes for 'normalize' but this may
require a patch, since Debian uses the name 'normalize-audio' for this
command. These were mentioned by the configure script.
* Grepping the source it seems that rubyripper can also use 'cdrdao' and 'sox'
for certain things -- consider the same for them.
* Consider changing your DEP-5 format URL now that this has become official.
http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
* Do you need to patch the prefix '/usr' into the configure script? It seems
you already specify the /usr prefix by an override in debian/rules anyway, so
that seems redundant.
* You might consider splitting your patch into multiple patches, which would
allow you to give a more detailed rationale for each change. For instance,
your patch removes some code from the configure script probably to solve some
build issue, but the patch header doesn't explain this.
* Since you use the same man page for both rrip_cli and rrip_gui, you may want
to remove (command-line interface) from the NAME section of the manual
page.
Minor bugs that should probably be fixed by upstream:
* Consider fixing the example copyright headers on the .po files, they have
pasted in boilerplate.
* I get this message when running configure:
'gettext/utils.rb' is deprecated. Use gettext/tools.rb.
* Many translations are generating warnings like:
- Obsolete msgid exists
- Fuzzy message was ignored
Thanks for your work! I will certainly be using this when it is uploaded.
Cheers,
David
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/caobnz7yeup9ko8istrg1zbdjl-x6igcs_-zk1w-p0m+kaza...@mail.gmail.com
Bug#663132: RFS: blueman/1.23-1
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a new sponsor for my package blueman * Package name: blueman Version : 1.23-1 Upstream Author : Valmantas Palikša wal...@balticum-tv.lt * URL : http://blueman-project.org/ * License : GPLv3 Section : x11 It builds those binary packages: blueman- Graphical bluetooth manager To access further information about this package, please visit the following URL: http://mentors.debian.net/package/blueman Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/b/blueman/blueman_1.23-1.dsc Changes since the last upload: * New upstream release * Replaced python-central by dh_python2 * Added dependency for gnome-icon-theme (Closes: #631838) My present sponsor, Andres Salomon, has recently been too busy for sponsoring, so he asked me to see if I can find someone else. Regards, Christopher Schramm -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f58fae4.7050...@shakaweb.org
Repost: RFS: tk-html3/3.0~fossil20110109-1 [ITP ] -- Render HTML and CSS content with tk
Dear mentors, I just want to repost this sponsorship request so that it does not get forgotten :-) Also, I fixed a few minor glitches since the first request. http://mentors.debian.net/package/tk-html3 The highlights of this package are - the HV3 browser is a light-weight web browser - the tkhtml3 widget and hv3 mega-widget offering a complete (with CSS) html solution for Tcl/Tk, In the internet, there are some pages dealing with how to install HV3 on Debian http://uzivatel.wordpress.com/2011/04/10/how-to-install-hv3-browser-in-debian-squeeze/, so there is definitely some user's interest in this browser. HV3 is able to support ECMAScript/Javascript, but the according library SEE http://www.adaptive-enterprises.com.au/~d/software/see/ is not packaged yet for Debian. Once this is done, we would have a full-featured, completely independent Web engine suitable f.e. for smaller computers, and for the seemless inclusion into Tcl/Tk. My personal interest in getting tk-html3 into Debian is that I need this widget for the astronomical saods9 package. A would appreciate for a review and/or upload of the package. Best regards Ole On 27.02.2012 19:19, Ole Streicher wrote: Package: sponsorship-requests Severity: wishlist X-Debbugs-Cc: pkg-tcltk-de...@lists.alioth.debian.org Dear mentors, I am looking for a sponsor for my package tk-html3. * Package name: tk-html3 Version : 3.0~fossil20110109-1 Upstream Author : Dan Kennedy danielk1...@gmail.com * URL : http://tkhtml.tcl.tk/index.html * License : BSD Section : interpreters It builds those binary packages: hv3 - Lightweight web browser tk-html3 - Render HTML and CSS content with tk To access further information about this package, please visit the following URL: http://mentors.debian.net/package/tk-html3 Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/t/tk-html3/tk-html3_3.0~fossil20110109-1.dsc This is a repost; the old posting was done last week, but outside of the bug system. Since then, I added some minor changes. The tk-html3 package is needed in order to re-debianize the astronomy program saods9 http://bugs.debian.org/655648. I would be glad if someone uploaded this package for me. I am also interested in a review of the package. Best regards, Ole Streicher -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f590766.6040...@liska.ath.cx
Bug#662035: RFS: vorbisgain/0.37-1 [ITA] -- add Replay Gain volume tags to Ogg Vorbis files
tags 662035 - moreinfo thanks Benoît, I've tried carefully solving all the issues you mentioned above. Thanks for your time and support. Here is the dsc file up at mentors.d.n: http://mentors.debian.net/debian/pool/main/v/vorbisgain/vorbisgain_0.37-1.dsc And here is the full changelog entry for this upload: vorbisgain (0.37-1) unstable; urgency=low * New Maintainer (Closes: #547233) * New upstream release. - Refreshed all patches. * Bumped debhelper compat level to 8. * debian/copyright is now in DEP-5 format version 1.0. * debian/rules now removes automake's .log and .status in clean. * Bumped standards version to 3.9.3; No changes needed. * debian/patches/0006-manpage_hyphens.patch: - Corrected many hyphen-used-as-minus-sign lintian complaints in the manpage. * debian/patches/0007-recursively_spelling.patch: - Corrected a spelling mistake, recursivly. (Closes: #661999) * debian/patches/0008-manpage_recursion_mistake.patch: - The manpage no longer shows examples which don't work. (Closes: #447402) * debian/watch has been fixed. * NEWS has been removed from docs and is now installed as upstream's changelog file. I'd be very glad if someone were to upload this package for me. Regards, Daniel -- Daniel Martí - mvdan.cc - 0x58BF72C3 signature.asc Description: Digital signature
Processed: RFS: vorbisgain/0.37-1 [ITA] -- add Replay Gain volume tags to Ogg Vorbis files
Processing commands for cont...@bugs.debian.org: tags 662035 - moreinfo Bug #662035 [sponsorship-requests] RFS: vorbisgain/0.37-1 [ITA] -- add Replay Gain volume tags to Ogg Vorbis files Removed tag(s) moreinfo. thanks Stopping processing here. Please contact me if you need assistance. -- 662035: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=662035 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.13312430734651.transcr...@bugs.debian.org
Bug#663151: RFS: rhinote/0.7.4-2
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package rhinote * Package name: rhinote Version : 0.7.4-2 Upstream Author : Marv Boyes greysp...@tuxfamily.org * URL : http://rhinote.tuxfamily.org/ * License : GPL-2+ Section : x11 It builds those binary packages: rhinote- virtual sticky-notes for your desktop To access further information about this package, please visit the following URL: http://mentors.debian.net/package/rhinote Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/r/rhinote/rhinote_0.7.4-2.dsc More information about rhinote can be obtained from http://rhinote.tuxfamily.org/ . Changes since the last upload: * 001-simplify-imports.diff: - improve the way modules are imported. * 002-use-secure-printfile.diff: - avoid potential symlink attacks and cluttering the user's home. * 003-test-for-external-commands.diff: - ensure external commands are available before calling them. * 004-use-popen.diff: - replace os.system() with the more secure subprocess.Popen(). * 005-support-lp.diff: - add support for the lp command in addition to lpr. * 006-set-print-job-name.diff: - provide a descriptive name for the print job. * 007-set-class-name.diff: - set application name for use by window managers. * Simplify Depends: to cups-client | lpr. * Bump Standards-Version to 3.9.3 (no changes needed). The software has been heavily patched after Paul Wise has reviewed it[1] and found a bunch of issues with upstream’s code. He later took a look at the patches[2] and found them to be okay. [1] http://lists.debian.org/debian-mentors/2012/01/msg00579.html [2] http://lists.debian.org/debian-mentors/2012/02/msg00077.html -- Andrea Bolognani e...@kiyuko.org Resistance is futile, you will be garbage collected. signature.asc Description: Digital signature
Bug#662955: review
On Fri, 9 Mar 2012 01:02:42 David Banks wrote:
Hi, I'm not a DD so I can't sponsor your package, but I would be using this
package if it was in the archive. Thanks for packaging it.
Hi, wow thanks for the great detailed review!
* You don't need the substvar ${shlibs:Depends} in the control file for
the binary packages, since they are not compiled code. This gives a
warning currently.
Okay, I will remove this.
* Why is the package priority extra? It should probably be optional.
After re-reading the Policy Manual I see you are correct.
* Consider switching off DH_VERBOSE in debian/rules before release, or at
least remove the comment above it.
Yes, I missed that.
* The translations seem to be being compiled twice, once during
dh_auto_build and once during dh_auto_install. This is probably
unnecessary.
Hmm, I hadn't really noticed that but you're correct. I'll have to patch the
configure script to remove the 'all' prerequisite from the makefile's
'install' target. It seems to be there because upstream's installation
instructions don't require a separate 'make' and 'make install'.
* You may want to Recommend or Suggest the 'vorbisgain' and
'mp3gain' package, if rubyripper can use them. The same goes for
'normalize' but this may require a patch, since Debian uses the name
'normalize-audio' for this command. These were mentioned by the configure
script.
* Grepping the source it seems that rubyripper can also use 'cdrdao' and
'sox' for certain things -- consider the same for them.
Yes, I will Suggest these packages. Strange that the last two aren't mentioned
in any documentation that I've read (they're in the changelog though). I'll
file a bug report with upstream about it.
* Consider changing your DEP-5 format URL now that this has become
official.
http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Yep, I need to run lintian with -pedantic.
* Do
you need to patch the prefix '/usr' into the configure script? It seems
you already specify the /usr prefix by an override in debian/rules anyway,
so that seems redundant.
This was left-over from my attempts to fix a build issue. I'll remove it.
* You might consider splitting your patch into multiple patches, which
would allow you to give a more detailed rationale for each change. For
instance, your patch removes some code from the configure script probably
to solve some build issue, but the patch header doesn't explain this.
There were actually multiple build issues, which I didn't fully understand
until I had patched them.. so yes, I will split these patches out properly.
* Since you use the same man page for both rrip_cli and rrip_gui, you may
want to remove (command-line interface) from the NAME section of the
manual page.
Totally missed that, thanks!
Minor bugs that should probably be fixed by upstream:
* Consider fixing the example copyright headers on the .po files, they
have pasted in boilerplate.
I haven't filed a bug report with upstream over this, but it's on my TODO.
* I get this message when running configure:
'gettext/utils.rb' is deprecated. Use gettext/tools.rb.
Yep, that can be patched.
* Many translations are generating warnings like:
- Obsolete msgid exists
- Fuzzy message was ignored
This is another issue I have to raise with upstream. I did notice this, but
translations seemed to work fine anyway. Do you know what these warnings
actually mean? 'info gettext' doesn't provide any documentation for warnings.
Thanks for your work! I will certainly be using this when it is uploaded.
Cheers,
David
No problem, thanks for taking the time to review the package! I should be able
to upload another version with the changes sometime this weekend..
--
Regards,
Scott.
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/201203091444.43932.sc...@sl.id.au
