Hi Jakub
2014-05-14 14:17 GMT-05:00 Jakub Wilk <jw...@debian.org>: > * Daniel Echeverry <epsilo...@gmail.com>, 2014-05-13, 13:02: > > It appears to me that files that are currently installed to >>> /usr/share/sxiv/exec/ are just examples. If this is the case, then they >>> should live in /usr/share/doc/sxiv/examples/. >>> >> Done! >> > > Let me see: > > Description: Install examples files with DH instead from Makefile > > What does DH stand for? Diffie-Hellman? dh(1)? debhelper? I was genuinely > confused for a moment, especially since the patch doesn't itself contain > any references to debhelper. > > - mkdir -p $(DESTDIR)$(PREFIX)/share/sxiv/exec > - cp exec/* $(DESTDIR)$(PREFIX)/share/sxiv/exec/ > - chmod 755 $(DESTDIR)$(PREFIX)/share/sxiv/exec/* > + #mkdir -p $(DESTDIR)$(PREFIX)/share/sxiv/exec > + #cp exec/* $(DESTDIR)$(PREFIX)/share/sxiv/exec/ > + #chmod 755 $(DESTDIR)$(PREFIX)/share/sxiv/exec/* > > When I see commented-out code, I automatically assume that someone added > comments for debugging and then forgot to clean it up. I'd recommend to > either remove the code we don't want completely, or add a code comment > explaining why the lines are commented-out. > > Or maybe just remove share/sxiv/exec in debian/rules, instead of patching > the Makefile? > I updated the patch, Could you check it out, again? http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_1.2-1.dsc Thank you very much! Regards -- Daniel Echeverry http://wiki.debian.org/DanielEcheverry Linux user: #477840 Debian user Software libre <http://www.rinconinformatico.net>
