Bug#839623: RFS: Cutecom 0.30.3 update

2016-10-02 Thread Roman Khimov 
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a new sponsor for my package "cutecom":

* Package name: cutecom
  Version : 0.30.3-1
  Upstream Author : Alexander Neundorf 
* URL : https://github.com/neundorf/CuteCom/
* License : GPL-3+
  Section : comm

It builds those binary packages:

  cutecom - Graphical serial terminal, like minicom
  cutecom-dbgsym - Debug symbols for cutecom

You can download the package with dget using this command:

 dget -x https://roman.khimov.ru/temp/deb-cutecom/cutecom_0.30.3-1.dsc

Changes since the last upload:

   * New upstream release based on Qt5 (Closes: #788179, #696221)
   * Update license to GPLv3+, upstream changed to that in 2015
   * Update homepage, source and watch information (upstream
 development moved to github)
   * Switch to dpkg-source 3.0 (quilt) format
   * Upgrade package to standards 3.9.8
   * Upgrade to debhelper 9
   * Drop "cutecom-0.22.0-nolinebreak.diff", obsolete
   * Drop "cutecom-remove-deprecated-desktop-entries.patch", obsolete
   * Drop "fix_pathes_for_debian.patch", obsolete
   * Remove obsolete menu support
   * Use Cmake RelWithDebInfo build type to get '-O2 -g' flags
   * Install desktop file (for 'System' category) system-wide (previously
 it was installed into kde directory) (Closes: #614793) (LP: #1575347)
   * Install an icon

-- 
 http://roman.khimov.ru
mailto: ro...@khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

Bug#838679: [Debian-science-sagemath] Fwd: Bug#838679: RFS: cysignals/1.1.1+ds-1 [ITP] -- interrupt and signal handling for Cython

2016-10-02 Thread Jerome BENOIT 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Hi Ximin, thanks again for the review and the suggestions.

On 28/09/16 19:21, Ximin Luo wrote:
> Ximin Luo:
>> Hey, nice work. I'm taking a look now.
>> 
> 
> Hey, it looks good! I couldn't spot any problems.
> 
> Just the following minor things:
> 
> (1)
> 
> d/rules: override_dh_install-arch: true
> 
> Could you add a comment explaining this? I didn't look in too much
> detail but I couldn't figure out the reason for this. I did run
> dpkg-buildpackage -A and -B checked they still work, so that's good.
> It would be good to add a comment, so future readers don't get
> confused.

I added a short comment: in fact dh_install-arch is bypassed by dh_python

> 
> (2)
> 
> Instead of maintaining two separate git branches, I suggest using
> build profiles:
> 
> https://wiki.debian.org/BuildProfileSpec


This is definitely a good idea.

> 
> I've pushed some commits to the git repo that makes this work
> already, see if you like them, or revert if you don't :p
> 
> The default build will leave out the -pari stuff. To enable the pari
> stuff, you can either :
> 
> a. use `(dpkg-buildpackage|gbp buildpackage) -Ppkg.cysignals.pari`
> or b. set DEB_BUILD_PROFILES=pkg.cysignals.pari for lower-level tools
> like `debian/rules`
> 
> I had to use a slight hack in debian/tests/control but I thought it
> was still worth it, to avoid switching between branches all the
> time.
> 
> If you like this, please also edit debian/README.source to describe
> this new workflow.

Done. I have also deleted the experimental branches.

> 
> (3)
> 
> You tagged debian/1.1.1+ds-1 already in the git repo. I suggest not
> doing this yet, and delete the current tag - we have some newer
> unreleased commits anyway.

I deleted the last tag but I added a new one.

> 
> My preferred workflow is to keep UNRELEASED in d/changelog, then when
> everything is ready I git push, then `dch -r`, commit, build, dput
> and wait for the ACCEPTED email from ftp-masters. Only after I get
> email, do I then run `gbp buildpackage --git-tag-only` and then push
> this last commit plus the tag that was just created.
> 
> Sometimes (like now) there's no point using UNRELEASED if d/changelog
> already says something else, but the rest of the above still works.

For now I am looking for sponsorship, signed tagging the pertinent commit
makes thing clear.

Thanks,
Jerome

> 
> X
> 

- -- 
Jerome BENOIT | calculus+at-rezozer^dot*net
https://qa.debian.org/developer.php?login=calcu...@rezozer.net
AE28 AE15 710D FF1D 87E5  A762 3F92 19A6 7F36 C68B
-BEGIN PGP SIGNATURE-

iQQcBAEBCgAGBQJX8am2AAoJED+SGaZ/NsaLbKwgAIcMNW5N4S/csnqTFFcSvYiT
lxknqDw/tMH01TlPQiXC6qOOZLNP825bty6TpTMoxZNBNcR9uEegdvpl4Qp3lI0e
M8wymoMJf58dkfJTgoSruAUIyYrW7mYzS/xHU1zGB2cn9UTsqmiXPoK25dltpo5y
gjL30DIMM5SS57ov8m2roj7sfeYYYDZdlCRJ4vlh2UzQexqWaeP9vwFFyxpT728S
gy4lYhWx9qXvJLRT1Jy+OAjS7b4gd2B28YrA84ld7MWxz0lAhgwuq/hamo+Oh6jQ
cMXqzkRRv3vpw6EQ5VvVvaXD+C5+Iq/ssEMgQ6Ez+KXVZ1TY4g2xTxOWyM9npAEC
wGkSL1ZD1sM/Mnr0EAkbL2MUngbU027yNH+xtm/ksyL1t/UPf/bWEpgSuYbzqr9w
NhKxL/bQFeNOofsWaISY1nz55M6AlkmTdYNwe5x4KTXNnO0JiJ04bsOO6+ExfZkB
gzxNAhhq4YvEuQSpmIBTQLU/zpvuIV9uMvM7WSgXMYUndGyW0joPOs4ZBfDAG1cR
XOtadMIGZUBsiNNfa6o+Jqkkk0nXEV1EhyojrbmwEU9elmW3j8fToAktqG7+e1pn
g9J2lNni4QnRBsehHhXD19PNnsM3MBGA6lTBXUpnIBX7wz3Kczta2K+grdAPUeGB
iPuHJNVgd6Xh6nyBGyUVNuZQSKfSGizcE5bFWfL5uUDv9gQ0QsMUZstNEgamJoWV
3LF4j8ZlK2v3vSx09V3rQG1Laps47l0L6iuLtA5p+T45EPida2K7rQodPUGadlQq
3yxo68IcHXekbwwlhQhL/m0C3+VRZ+db0vx2HPcui5EgB0PMZjiawfYfQpDDbaE2
TX6n/GfsoWkzLTOVibDMLg8UnhoGcuzf6hHgndQCfFKbQ0NwKFtZI5I51ycNHdBd
4WJvDwy4Vj12/04zq2KfUFUYfOUy81bLf9hrxHVnU5gPORzG9hEsJKaQuc3tp93z
rCXDsRyJhQEM0q2MIpW7p1gwMw+keP78Kv76AKMy3GmXQBoLytYqHDrxD8CxVzgM
LZGoDnG4AZbczKO0edvNWD+JHjjFMGd4iKbbeX8tH2JJHJF5c/kLnmRvTlfZXXbk
FKkpvVCaV3doy+YWqT+KqwgNyg0jzc+y/dG5DSuu5zCtvRyW9/xyYPe4lI/YK+Kq
kyfiB+f0XhOIqU0+Jr8RMiFBmtPPoH3OEW7dhkCWmbKX+w8L45HzqLWZTMO7tqnK
U8T3SnpT+rXy+IAYbjQtDIHtS9PHE77yAV481J7ZaHYTD0E0Bqc4rpW+Oc8/07I1
sjHT3B2qzRky8ibzjtCMRPpljpGsf/9EuDT99h4z4XzztPfrIn4nBoYrLCIs0As=
=j3xO
-END PGP SIGNATURE-

Re: Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications

2016-10-02 Thread Thomas Pircher 

On 2016-09-28 22:37, Gianfranco Costamagna wrote:

[..] drop the explicit dependencies since dh-autoreconf already
depends on automake and libtool? If this is the customary way then 
I'll

drop the explicit dependencies on automake and libtool.


I think so. dh-autoreconf should be enough (with an added pkg-config if 
needed,

IIRC)


Hi Gianfranco,

automake and libtool are no longer explicit dependencies in my latest 
upload to mentors [1]. But I haven't added pkg-config. It is not 
required for building libcgicc and I could not find a mention of 
pkg-config in the dh-autoreconf documentation. But if I'm missing 
something than I'll be happy to add the build dependency.


I think patching it to be architecture independent might be the best 
solution


Thanks for that. I had not appreciated that packages may contain 
bit-identical files. That does indeed solve my problem, and I have 
patched out the --host and --libdir options and re-added the script to 
the package.


Thanks again for your continuing efforts!

Thomas


[1] https://mentors.debian.net/package/libcgicc

Bug#839289: RFS: pnmixer/0.7-1 [ITP] -- Simple mixer application for system tray

2016-10-02 Thread Gianfranco Costamagna 
tags 839289 moreinfo
thanks

Bug#839289: RFS: pnmixer/0.7-1 [ITP] -- Simple mixer application for system tray

2016-10-02 Thread Paul Wise 
On Sat, Oct 1, 2016 at 2:23 PM, Arnaud Rébillout wrote:

>   I am looking for a sponsor for my package "pnmixer"

I don't intend to sponsor this but here is a review:

These issues block the upload:

>   pnmixer (0.7-1) UNRELEASED; urgency=medium

You should list the suite (usually unstable) where you intend the
upload to be added to instead of UNRELEASED.

The file downloaded by uscan is different to the one you have included
in your Debian source package. Please adjust your debian/watch file to
use the correct one.

These issues would be nice to fix:

I suggest that you try and make the github generated tarball as
similar as possible to the `make dist` generated tarball. You can use
`diffoscope` to compare the two tarballs.

The debian/watch tells uscan that v0.7-rc1 is newer than v0.7. I think
you want uversionmangle=s/-rc/~rc/

You may want to sign your upstream tarballs, git tags and git commits:

https://wiki.debian.org/debian/watch#Cryptographic_signature_verification
https://mikegerwitz.com/papers/git-horror-story

The images say they were produced in GIMP and look like multi-layer
images that have been rendered to flat bitmaps, did you discard the
XCF images or are they hidden away somewhere? How were these images
produced? In general it is best to render final images from the source
material at build time, using xcf2png or similar.

The bug #816124 should have be tagged fixed-upstream when you commented:

https://www.debian.org/Bugs/server-control#tag

Generated and stamp files should be removed from the upstream git repo
and added to .gitignore:

stamp-h.in

I expect most of autogen.sh can be replaced with a call to autoreconf:

autoreconf --force --install --symlink --warnings=all

Running wrap-and-sort would make diffs of the Debian packaging easier to read:

wrap-and-sort --short-indent --wrap-always --sort-binary-packages
--trailing-comma

The system() and g_spawn_command_line_async() functions should not be
used and I don't think `which` is very portable. Instead of
system()+`which` you should use g_find_program_in_path(). Instead of
g_spawn_command_line_async() you should use g_spawn_async().

http://bonedaddy.net/pabs3/log/2014/02/17/pid-preservation-society/

Please add some upstream metadata:

https://wiki.debian.org/UpstreamMetadata

Since you are upstream, please read our guide for upstreams:

https://wiki.debian.org/UpstreamGuide

Automatic checks:

build:

ui-tray-icon.c:340:2: warning: ‘gtk_status_icon_set_from_pixbuf’ is
deprecated [-Wdeprecated-declarations]
ui-tray-icon.c:358:2: warning: ‘gtk_status_icon_set_tooltip_text’ is
deprecated [-Wdeprecated-declarations]
ui-tray-icon.c:400:2: warning: ‘gtk_status_icon_position_menu’ is
deprecated [-Wdeprecated-declarations]
ui-tray-icon.c:578:2: warning: ‘gtk_status_icon_new’ is deprecated
[-Wdeprecated-declarations]
ui-tray-icon.c:604:2: warning: ‘gtk_status_icon_set_visible’ is
deprecated [-Wdeprecated-declarations]

lintian:

P: pnmixer source: debian-watch-may-check-gpg-signature

check-all-the-things:

$ env PERL5OPT=-m-lib=. duck
E: debian/control: Vcs-Git:
https://anonscm.debian.org/collab-maint/pnmixer.git: ERROR
(Certainty:certain)
   fatal: repository
'https://anonscm.debian.org/collab-maint/pnmixer.git/' not found

E: debian/control: Vcs-Browser:
https://anonscm.debian.org/gitweb/?p=collab-maint/pnmixer.git;a=summary:
ERROR (Certainty:certain)
   Curl:0 HTTP:404 No error

$ env PERL5OPT=-m-lib=. cme check dpkg
...
Warning in 'control source Vcs-Browser' value
'https://anonscm.debian.org/gitweb/?p=collab-maint/pnmixer.git;a=summary':
URL to debian system is not the recommended one
Warning in 'control source Vcs-Git' value
'https://anonscm.debian.org/collab-maint/pnmixer.git': URL to debian
system is not the recommended one

# This command checks style. While a consistent style
# is a good idea, people who have different style
# preferences will want to ignore some of the output.
$ find -type f \( -iname '*.sh' -o -iname '*.bash' \) -exec bashate
--ignore E002,E003 {} +
E001: Trailing Whitespace: 'echo '
 - ./autogen.sh : L25
E010: Do not on same line as for: 'for coin in `find $srcdir -name
configure.ac -print`'
 - ./autogen.sh : L96
E001: Trailing Whitespace: 'do '
 - ./autogen.sh : L97
E001: Trailing Whitespace: ' if test -z "$NO_LIBTOOLIZE" ; then '
 - ./autogen.sh : L124
4 bashate error(s) found

# Check with upstream where the GIMP XCF source files are.
$ find -type f \( -iname '*.png' -o -iname '*.gif' -o -iname '*.jpg'
-o -iname '*.jpeg' \) -exec grep -iF gimp {} +
Binary file ./data/icons/pnmixer.png matches
Binary file ./data/pixmaps/pnmixer-high.png matches
Binary file ./data/pixmaps/pnmixer-muted.png matches
Binary file ./data/pixmaps/pnmixer-low.png matches
Binary file ./data/pixmaps/pnmixer-medium.png matches
Binary file ./data/pixmaps/pnmixer-about.png matches

$ find -type f -iname '*.sh' -exec checkbashisms {} +
could not find any possible bashisms in bash script ./.travis/script.sh
could not find any

Bug#839544: RFS: btrfs-progs/4.7.3-1~bpo8+1

2016-10-02 Thread Gianfranco Costamagna 
Hi, wonderful!

sponsored,

G.

Bug#824900: iroffer-dinoex packaging : some more checks

2016-10-02 Thread Frederic Bonnard 

Hi Weilu,

here are some other remarks on your packaging :

- d/copyright :
 * src/strnatcmp.* : looks more like zlib/libpng than MIT
 * dtd/iroffer-model-10.mod : this one is not GPL-2 with OpenSSL exception
 * missing copyright :
   o src/dinoex_curl.c : from curl tool_cb_hdr.c, Copyright (C) 1998 - 2011, 
Daniel Stenberg
 * Not sure you can extend the copyright period from what is actually in the
   files : d/copyright : "Copyright: 2000-2016 Dirk Meyer"
   You may only merge
   : https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#fields
 * btw, could you confirm the false positive lintian
   "unused-file-paragraph-in-dep5-copyright" ?
   If so could you just re-order paragraphs with wildcards from more general to
   less, that'll also ease reading of the file :
   o put 1st : Files: *
   o then: Files: src/upnp.* debian/*
   o all others
   I'll reopen #776796 if you confirm that (lintian 2.5.47 here)
- d/control : I can't find the link anymore, but I think that the iroffer
  package should declare the same Conflicts/Replaces relationship with 
iroffer-dinoex. 
- d/patches : 
  * did you pushed them upstream ?
  * remove # lines in the DEP3 header if not filled upstream or if done
add "Bug: "
- wrap-and-sort can help tidying some d/ files (minor but this is a tip)
- as a general advice, try to fix all lintians >= Informational : make a patch
  for typos and submit upstream.

Thanks for the work, there was much improvements since the 1st draft.

F.