Bug#841222: Acknowledgement (RFS: patat)

[Sean Whitton]

control: owner -1 !
control: tag -1 +moreinfo

Dear Félix,

Thank you for your work to bring this new package to Debian.  I can't
sponsor the upload, but I hope this review is useful to you.

I've split it into two sections: things that I would consider must-fixes
before an upload to Debian, and suggested improvements.  The latter
aren't strictly necessary, but they would help demonstrate to a
potential sponsor that you are committed to maintaining this package in
Debian.

Must-fixes
==

1. You need to run `dch -r` again so that your changelog is up-to-date
with your latest commit.

2. As I mentioned previously, please add patat to the Haskell team's
package-plan.git and run the scripts provided to confirm that the
versions of all the libraries package by the Haskell team are compatible
with patat.

3. Could you confirm that the package builds with ghc 8, please?  The
Haskell team is working to have that version of ghc in stretch.

Suggestions
===

1. The header of your patch to the README needs some work.  You didn't
"update" the README -- that implies the patch should be forwarded, but
it looks to be Debian-specific.  Please add some explanatory text, or a
better subject, explaining why you made the changes (e.g. "patch README
for Debian").  Also, add a Forwarded: header.

2. You can fix all of these Lintian tags, except possibly
hardening-no-fortify-functions.  You should definitely deal with the
warnings.

W: patat-dbgsym: debug-file-with-no-debug-symbols
I: patat: hardening-no-fortify-functions usr/bin/patat
I: patat: spelling-error-in-binary usr/bin/patat Nam Name
I: patat: spelling-error-in-binary usr/bin/patat isn't isn't
I: patat: spelling-error-in-binary usr/bin/patat forward forward
I: patat: spelling-error-in-binary usr/bin/patat upto up to
I: patat: spelling-error-in-binary usr/bin/patat discontigous discontiguous
I: patat: spelling-error-in-binary usr/bin/patat uncomplete incomplete
I: patat: spelling-error-in-binary usr/bin/patat The The
I: patat: hardening-no-bindnow usr/bin/patat
I: patat: hardening-no-pie usr/bin/patat

I think that in order to pass hardening options to gcc, if you're
willing to work on that, you'll need to abandon the CDBS build system
you're using at present.  See the Makefile for keysafe[1] (not yet in
Debian) to see how to pass the options, and the rules file for the
stylish-haskell package to see how to do without CDBS.

3. Please run upstream's test suite during the package build.

4. The screenshot should probably be installed into
/usr/share/doc/patat/examples.

That should be enough for now!

[1] https://joeyh.name/code/keysafe/

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#841749: RFS: adjtimex/1.29-8 -- kernel time variables configuration utility

[Roger Shimizu]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "adjtimex"

* Package name: adjtimex
* Version : 1.29-8
* Upstream Author : Steven S. Dick , James R. Van
Zandt 
* URL : http://metalab.unc.edu/pub/Linux/system/admin/time
* License : GPL-2
* Section : admin

It builds those binary packages:

  adjtimex   - kernel time variables configuration utility

To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/adjtimex

Alternatively, one can download the package with dget using this command:

dget -x 
http://mentors.debian.net/debian/pool/main/a/adjtimex/adjtimex_1.29-8.dsc

or you can use git-buildpackage to build:
  gbp clone --pristine-tar https://github.com/rogers0/adjtimex
  cd adjtimex
  git checkout mentors
  gbp buildpackage -uc -us --git-ignore-branch --git-pristine-tar

Changes since the last upload:
  * debian/patches:
  - Improve precision. Thanks Christopher Alexander Tobias Schulze.
(Closes: #633082).
  - Update patches to make compatible with "gbp pq" command.
  * Upgrade to support debhelper 10
  * debian/copyright:
  - Update URL to make use of https instead of http, when possible
  * debian/control:
  - Add lsb-base as dependency to package shadowsocks-libev, since
the init script sources /lib/lsb/init-functions utility functions
  - Bump policy version to 3.9.8 (no actual change required)
  * debian/adjtimex.service:
  - Add documentation line. Thanks to lintian.
  * debian/rules:
  - Add a few comments
  - Remove hardening setting already enabled by default since compat=9

I pushed my changes to git repo: https://github.com/rogers0/adjtimex
branch: mentors

If it's convenient for you, please kindly setup DM upload permission
of this package for me.
I have maintained this package for a few releases.
Thank you!

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1

Bug#841536: hdparm/9.50+ds-1

[Alex Mestiashvili]

Hi Niels,

thank you for the comments and upload.
I've prepared an updated package addressing the issues and uploaded it to
mentors:

 https://mentors.debian.net/debian/pool/main/h/hdparm/hdparm_9.50+ds-2.dsc


On Fri, Oct 21, 2016 at 7:07 PM, Niels Thykier  wrote:

> Control: tags -1 moreinfo
>
> On Fri, 21 Oct 2016 14:46:32 +0200 Alex Mestiashvili
>  wrote:
> > Package: sponsorship-requests
> > Severity: wishlist
> > X-Debbugs-Cc: mailatgo...@gmail.com
> >
> > Dear mentors,
> >
> >  [...]
> >
> > Best regards,
> > Alex
>
>
> Hi Alex,
>
> Thanks for your contribution.
>
> Have you informed upstream about the following compiler warning?
> """
> hdparm.c: In function 'process_dev':
> hdparm.c:2256:2: warning: this 'if' clause does not guard...
> [-Wmisleading-indentation]
>   if (!quiet)
>   ^~
> hdparm.c:2258:3: note: ...this statement, but the latter is misleadingly
> indented as if it is guarded by the 'if'
>if (do_drive_cmd(fd, args, 0)) {
>^~
> """
>
> I checked it seems benign, so I am not blocking the upload on this.  The
> code in question being:
>
>
> """
> if (security_freeze) {
> __u8 args[4] = {ATA_OP_SECURITY_FREEZE_LOCK,0,0,0};
> if (!quiet)
> ^^^ (should be 1 tab further in)
> printf(" issuing security freeze command\n");
> ^^ (should be 1 tab further in as well)
> if (do_drive_cmd(fd, args, 0)) {
> err = errno;
> perror(" HDIO_DRIVE_CMD[...] failed");
> }
> }
>
> """
>

The wrong indentation comes from the quiet_security_freeze.patch fixing the
bug #512175
The indentation is fixed in the latest package.


>
> Other minor nits:
>  * Spelling error in hdparm binary "Removeable" -> "Removable"
>- NB: Upstream is inconsistent with the spelling, but seems to prefer
>  the "Removable" variant.
>

I know about this typo, but didn't want to fix it because the fix would
change the output of the program
and it might impact scripts trying to identify that flag. I'll forward this
and other typos to upstream.


>  * Upstream's build system hardcodes -j2 on "make all" and the packaging
>uses that without any respect to DEB_BUILD_OPTIONS
>- Given the small size and low parallel limit, I don't think it is a
>  huge issue (but it would have been for other packages).
>

Fixed with the makefile.patch


>  * The debian/hdparm.preinst file appears to be redundant (its replaced
>by the debian/hdparm.maintscript)
>

Thanks, fixed too.

Bug#841070: RFS: gnome-shell-extensions-remove-dropdown-arrows/7-1, ITP: 829071 -- removes drop down, arrows from panel on GNOME shell

[Tobias Frost]

Control: owner -1 !
Control: tags -1 moreinfo

Hi highvoltage,

Package does not build using pbuilder, I think a B-D on zip is missing

dh build
   dh_testdir
   dh_update_autotools_config
   dh_auto_configure
   dh_auto_build
make -j1
make[1]: Entering directory '/build/gnome-shell-extension-remove-
dropdown-arrows-7'
zip -j remove-dropdown-arr...@mpdeimos.com.zip README.md LICENSE
extension.js metadata.json
make[1]: zip: Command not found
Makefile:13: recipe for target 'dist' failed
make[1]: *** [dist] Error 127
make[1]: Leaving directory '/build/gnome-shell-extension-remove-
dropdown-arrows-7'
dh_auto_build: make -j1 returned exit code 2
debian/rules:4: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2


Two additonal nitpicks:
- Maybe a versioned dependency on gnome-shell?
- The patch for gnome-shell 3.22 is not needed, as with newer gnome-
shells the default has been changed, so that no longer needed.
Details: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=837594#19

--
tobi

Bug#841065: RFS: gnome-shell-extensions-dashtodock/55-1, ITP: 829185 -- dash-to-dock extension for GNOME shell

[Tobias Frost]

Control: owner -1 !
Control: tags -1 moreinfo

Hallo highvoltage,

Can you check if you think those comments are valid? 

- the patch for the installation directory should be upstreamed,
(I had something similar for one of my extensions, I solved it this
way:)
https://github.com/laserb/gnome-shell-extension-suspend-button/pull/19

- I guess the README should also not installed to /usr/share/gnome-
shell/extensions/dash-to.../ but /usr/share/doc/gnome-shell-extensions-
dashtodock (probably an extra "docs" in the filename of debian/gnome-
shell-extension-dashtodock-docs.docs)

- you're shipping in the debian.tar an autoreconf.(before|after)..
Probably stray files

- maybe also a versioned dependency on gnome-shell >=3.18 won't hurt
here as well to avoid issues when (partially) upgrading from jessie
 
- translators copyright should be also recorded in d/copyright.

Thanks!

--
tobi

Bug#841066: RFS: gnome-shell-extensions-pixelsaver/1.9-1, ITP: 829089 -- pixel saver extension for GNOME shell

[Tobias Frost]

Control: owner -1 !
Control: tag -1 moreinfo

Hi highvoltage,

Package is fine, however one thing needs fixing:
The themes have authorship attributed, but this is not reflected in 
the copyright file. Those themes also do not necessarily have the same
license as the extension itself (e.g Arc-dark says it is based on
https://github.com/horst3180/Arc-theme, which is GPL-3+; though I did
not check which files have been taken or if it was only for
inspiration)

Another nitpick: As the extension does not support all gnome-shell
versions, can you add a versioned depends on gnome-shell > = 3.16 ?

Thanks for packaging this extension!

--
tobi

Bug#840424: RFS: verilog-mode/0:20160910.debfc6d.vpo-1

[Kiwamu Okabe]

Hi Sean,

On Mon, Oct 17, 2016 at 11:32 PM, Sean Whitton  wrote:
> As the manpage says:
>
>> Certain Debian upstream version strings cannot be translated into
>> version strings Emacs will accept (see the docstring for the Emacs
>> function `version-to-list' for details). dh_elpa will error out if the
>> version cannot be translated.  You should resort to patching in a
>> Package-Version header or adding a *-pkg.el file.

Thanks.
I understand it's not a problem for me. Because I should not use
dh_elpa to support xemacs.

Best regards,
-- 
Kiwamu Okabe at METASEPI DESIGN

Bug#841660: marked as done (RFS: budgie-desktop/10.2.8-1)

[Debian Bug Tracking System]

Your message dated Sat, 22 Oct 2016 11:34:00 + (UTC)
with message-id <352345379.325652.1477136040...@mail.yahoo.com>
and subject line Re: Bug#841660: RFS: budgie-desktop/10.2.8-1
has caused the Debian Bug report #841660,
regarding RFS: budgie-desktop/10.2.8-1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
841660: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841660
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: sponsorship-requests
Severity: normal

  Dear mentors,

  I am looking for a sponsor for my package "budgie-desktop"

 * Package name: budgie-desktop
   Version : 10.2.8-1
   Upstream Author : i...@solus-project.com
 * URL : https://github.com/solus-project/budgie-desktop
 * License : LGPL-2.1/GPL2.0
   Section : x11

  It builds those binary packages:

budgie-core - Core package for Budgie-Desktop
 budgie-core-dev - Development package for budgie-desktop
 budgie-desktop - Desktop package for budgie-desktop
 budgie-desktop-doc - documentation files for the budgie-desktop
 gir1.2-budgie-desktop-1.0 - GNOME introspection library for budgie-desktop
 libbudgie-plugin0 - Plugin library for budgie-desktop
 libbudgietheme0 - Theme library for budgie-desktop
 libraven0  - Raven library for budgie-desktop

  To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/budgie-desktop


  Alternatively, one can download the package with dget using this command:

dget -x 
https://mentors.debian.net/debian/pool/main/b/budgie-desktop/budgie-desktop_10.2.8-1.dsc

Notes:
1. I noticed on mentors.debian.net that the watch file failed - this
is very strange since nothing has changed for months now - is there a
bug on mentors at the moment causing the watch to fail?
2. ran check-all-the-things - this did not find anything new from
previous uploads
3. ran lintian -i -I on the sources - no new items listed in previous uploads

 - to reiterate - current linitian items are known upstream
budgie-desktop.  relnow, bindnow will be resolved once the VALA stuff
is recoded to C
- rpath is necessary due to upstream GNOME GTK_3.22 private mutter API changes
- the patches added are upstream budgie-desktop released since v10.2.8
- bugs found after release that are necessary for ibus capability on
debian/ubuntu


  Changes since the last upload:

  * New upstream release
- GTK+3.22 fixes
- new places indicator
- new ibus indicator
- refreshed panel icons
- updated translations
- general fixes for the desktop
  * Packaging changes:
- Drop all now obsolete previous patches named 000*
- add new build dependency libibus-1.0-dev
- Updated debian/copyright with revised info for new source files
- add recommendation to install gnome-screensaver; screenlock capability
  in budgie-desktop does not work without this package
  * add patch upstream patch to allow the ibus applet to compile:
  0001-Lower-the-ibus-requirement-to-1.5.11-for-our-Debuntu.patch
  * add patch to ensure ibus is connected correctly if already running
  0002-wm-ibus-Always-try-to-use-an-existing-ibus-daemon-if.patch


  Regards,
   David Mohammed
--- End Message ---
--- Begin Message ---
Hi,

>  quite correct data/icons/* was marked as CC-BY-SA-4.0 in
>debian/copyright ... my bad.  Have corrected this to CC-BY-SA-3.0



ok done
G.--- End Message ---

Re: [ANOUNCE] Debtemplate

[Gianfranco Costamagna]

Hi,

>Looking for sponsor.

still waiting for devscripts answer, remove moreinfo once they
ack/nack inclusion of your tool

thanks

G.

Bug#841686: marked as done (RFS: wand/0.4.3-1 [RC])

[Debian Bug Tracking System]

Your message dated Sat, 22 Oct 2016 11:25:42 + (UTC)
with message-id <1679334808.306678.1477135542...@mail.yahoo.com>
and subject line Re: Bug#841686: RFS: wand/0.4.3-1 [RC]
has caused the Debian Bug report #841686,
regarding RFS: wand/0.4.3-1 [RC]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
841686: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841686
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: sponsorship-requests
Severity: important

Dear mentors,


I am looking for a sponsor for my package "wand":

* Package name: wand
  Version : 0.4.3-1
  Section : python

It builds those binary packages:

 pypy-wand  - Python interface for ImageMagick library (PyPy build)
 python-wand - Python interface for ImageMagick library (Python 2 build)
 python3-wand - Python interface for ImageMagick library (Python 3 build)
 wand-doc   - Python interface for ImageMagick library - documentation

Download the package with dget using this command:

dget -x https://people.debian.org/~cwryu/debian/wand_0.4.3-1.dsc

Or you can use the alioth git:

https://anonscm.debian.org/git/users/cwryu/wand.git


Changes since the last upload:

   * New upstream release
   * Fix TypeError on ImageMagick 6.9.6.2 (Closes: #841548)
   * Standards-Version: 3.9.8
   * Fix lintian errors
 - debian/control: Use https protocol for Vcs-* fields
 - debian/copyright: Fix the copyright format
   * debian/gbp.conf: upstream-0.4 branch for upstream


My new gpg key is not in the keyring yet since the weak key 
removal so I can't upload this update myself. So RFS.
--- End Message ---
--- Begin Message ---
Hi


>I am looking for a sponsor for my package "wand":


I sponsored because you are already a DD, but I would appreciate if you
(NOTE: it is just a suggestion)

could fix/have a look at:
d/rules: use pybuild
(this should remove almost everything from that file) and also install files
or whatever

Vcs-Browser: https://anonscm.debian.org/gitweb/?p=users/cwryu/wand.git;a=summary

^^ this should be
Vcs-Browser: https://anonscm.debian.org/cgit/users/cwryu/wand.git

I would appreciate some refactoring for a next upload :)

thanks
Gianfranco--- End Message ---

Bug#841686: RFS: wand/0.4.3-1 [RC]

[Changwoo Ryu]

Package: sponsorship-requests
Severity: important

Dear mentors,


I am looking for a sponsor for my package "wand":

* Package name: wand
  Version : 0.4.3-1
  Section : python

It builds those binary packages:

 pypy-wand  - Python interface for ImageMagick library (PyPy build)
 python-wand - Python interface for ImageMagick library (Python 2 build)
 python3-wand - Python interface for ImageMagick library (Python 3 build)
 wand-doc   - Python interface for ImageMagick library - documentation

Download the package with dget using this command:

dget -x https://people.debian.org/~cwryu/debian/wand_0.4.3-1.dsc

Or you can use the alioth git:

https://anonscm.debian.org/git/users/cwryu/wand.git


Changes since the last upload:

   * New upstream release
   * Fix TypeError on ImageMagick 6.9.6.2 (Closes: #841548)
   * Standards-Version: 3.9.8
   * Fix lintian errors
 - debian/control: Use https protocol for Vcs-* fields
 - debian/copyright: Fix the copyright format
   * debian/gbp.conf: upstream-0.4 branch for upstream


My new gpg key is not in the keyring yet since the weak key 
removal so I can't upload this update myself. So RFS.