Bug#915694: RFS: clamav-unofficial-sigs/5.6.2

2019-02-17 Thread Paul Wise
On Thu, Dec 6, 2018 at 2:03 PM Brent Clark wrote:

> I am looking for a sponsor for my package "clamav-unofficial-sigs":
...
> The respective dsc file can be found at:
>   
> https://mentors.debian.net/debian/pool/main/c/clamav-unofficial-sigs/clamav-unofficial-sigs_5.6.2-1.dsc

Sorry for the long delay, here is a review:

These things need to be done before any upload:

The upstream tarball fetched by uscan (using debian/watch) needs to be
identical to the one you upload to mentors, the one on mentors
currently has both missing files and additional files. If any changes
are needed to upstream files, they should be represented as patches in
debian/patches/ (or possibly other files in debian/). I generally
don't use git for packaging but I hear that there are tools that can
generate those patches from git commits.

About the manual page, cron job and logrotate config, there is an
upstream bug that means that `./clamav-unofficial-sigs.sh --config
somedir/ --information` doesn't work as it always checks
/etc/clamav-unofficial-sigs instead. If it worked, then you could have
asked the script to install the files at package build time. A
workaround for this bug would be to extract the snippets at build time
instead using sed. Unfortunately that isn't feasible since the
snippets in the script are only templates and the full output gets
created dynamically. Since the fix for this bug is a one-liner, I
think it would be best to include the change, since it allows creation
of the files at build time and also fixes a bug that users might run
into. Place the following line just before the second time that the
config_files array is set.

config_dir="$custom_config"

The upgrade from the old version needs to be checked (with piuparts)
to check that it works, that conffiles are handled correctly and that
the package still works afterwards.

These things would be nice to fix at some point:

The second and third stansas of debian/copyright should probably be
merged, details in the copyright format guide:

https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

The package description probably needs to be updated for the
new/changed features of the new upstream.

The Vcs-* fields in debian/control should point at the packaging VCS
rather than the upstream VCS.

There are some warnings when I run it on the .changes file after
building the package.

The new upstream doesn't appear to very active, you might want to
offer your assistance or create a new upstream project to maintain the
upstream code in, possibly within the ClamAV github organisation:

https://github.com/clamav

-- 
bye,
pabs

https://wiki.debian.org/PaulWise



Bug#921403: RFS: pyfltk/1.3.4.1-1 [ITP]

2019-02-17 Thread Bart Martens
Hi Robert,

This package has been removed from Debian some time ago. Are you sure that
bringing it back has good value?
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=870935

Also, there should be an ITP (not to be confused with an RFS with [ITA]).

Cheers,

Bart



Bug#922523: marked as done (RFS: dav-text/0.8.9-1 - minimalist ncurses-based text editor)

2019-02-17 Thread Debian Bug Tracking System
Your message dated Mon, 18 Feb 2019 00:21:04 +0100
with message-id <20190217232104.qyru7elbsl742...@angband.pl>
and subject line Re: Bug#922523: RFS: dav-text/0.8.9-1 - minimalist 
ncurses-based text editor
has caused the Debian Bug report #922523,
regarding RFS: dav-text/0.8.9-1 - minimalist ncurses-based text editor
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
922523: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=922523
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "dav-text"

 Package name: dav-text
 Version: 0.8.9-1
 Upstream Author : Adam Bilbrough 
 URL: https://github.com/atsb/dav-text
 License: GPLv2
 Section: text

  It builds those binary packages:

dav-text - minimalist ncurses-based text editor

  To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/dav-text


  Alternatively, one can download the package with dget using this command:

dget -x 
https://mentors.debian.net/debian/pool/main/d/dav-text/dav-text_0.8.9-1.dsc

  More information about dav-text can be obtained from
https://github.com/atsb/dav-text

  Changes since the last upload:

  * Removed some warnings from GCC8.
  * Fixed incorrect casting from int to long unsigned int.

  Regards,
   Adam
--- End Message ---
--- Begin Message ---
On Sun, Feb 17, 2019 at 06:12:28PM +0100, Adam Bilbrough wrote:
>  Package name: dav-text
>  Version: 0.8.9-1

>   Changes since the last upload:
> 
>   * Removed some warnings from GCC8.
>   * Fixed incorrect casting from int to long unsigned int.

✓

-- 
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁
⢿⡄⠘⠷⠚⠋⠀ Have you accepted Khorne as your lord and saviour?
⠈⠳⣄--- End Message ---


Bug#904462: RFS: uefitool/0.25.1-1 [ITP]

2019-02-17 Thread Andrey Rahmatullin
Thank you, uploaded.

-- 
WBR, wRAR


signature.asc
Description: PGP signature


Bug#922523: RFS: dav-text/0.8.9-1 - minimalist ncurses-based text editor

2019-02-17 Thread Adam Bilbrough
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "dav-text"

 Package name: dav-text
 Version: 0.8.9-1
 Upstream Author : Adam Bilbrough 
 URL: https://github.com/atsb/dav-text
 License: GPLv2
 Section: text

  It builds those binary packages:

dav-text - minimalist ncurses-based text editor

  To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/dav-text


  Alternatively, one can download the package with dget using this command:

dget -x 
https://mentors.debian.net/debian/pool/main/d/dav-text/dav-text_0.8.9-1.dsc

  More information about dav-text can be obtained from
https://github.com/atsb/dav-text

  Changes since the last upload:

  * Removed some warnings from GCC8.
  * Fixed incorrect casting from int to long unsigned int.

  Regards,
   Adam



Bug#904462: RFS: uefitool/0.25.1-1 [ITP]

2019-02-17 Thread Yangfl
Andrey Rahmatullin  于2019年2月17日周日 下午6:42写道:
>
> Control: owner -1 !
>
> Please upgrade to the new upstream version and the new packaging
> standards and I'll sponsor it.
>
> --
> WBR, wRAR

Updated. Thank you.



Bug#904462: RFS: uefitool/0.25.1-1 [ITP]

2019-02-17 Thread Andrey Rahmatullin
Control: owner -1 !

Please upgrade to the new upstream version and the new packaging
standards and I'll sponsor it.

-- 
WBR, wRAR


signature.asc
Description: PGP signature