Re: Guidance on how to update an old package [editline/libeditline]

2020-08-16 Thread Paul Wise
On Sun, Aug 16, 2020 at 10:52 PM Joel Rivera wrote:

> I hope that some Debian mentor in this list could give me any guidance on how 
> to move on given the current situation.

You could report Sam as MIA:

https://www.debian.org/doc/manuals/developers-reference/ch07.en.html#mia-qa

You could salvage the editline package:

https://www.debian.org/doc/manuals/developers-reference/pkgs.en.html#package-salvaging

-- 
bye,
pabs

https://wiki.debian.org/PaulWise



Bug#968543: RFS: ungoogled-chromium/83.0.4103.116-3 [ITP] -- web browser

2020-08-16 Thread Thomas
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "ungoogled-chromium":

* Package name : ungoogled-chromium
Version : 83.0.4103.116-3
Upstream Author : Eloston 
* URL : https://github.com/Eloston/ungoogled-chromium
* License : LGPL-2.0+, GPL-2+, ISC, LGPL-2+, LGPL-2.1+, BSD-3-clause or 
LGPL-2+, MIT, zlib, BSD-3-Clause, MPL-1.1 or GPL-2+ or LGPL-2.1+, Ms-PL, ICU, 
Apache-2.0, Public-domain, BSD-2-clause, MPL-1.1 or GPL-2.0 or LGPL-2.1, 
APPLE-license, BSD-3-clause, GPL-2.0, LGPL-2, MPL-2.0, LGPL-2.1, BSD-3-clause 
or LGPL-2.1+ or MPL-1.1, LGPL-2+ or MPL-1.1, PHP, LGPL-2.1+ or MPL-1.1
* Vcs : https://github.com/Eloston/ungoogled-chromium
Section : web

It builds those binary packages:

ungoogled-chromium - web browser
ungoogled-chromium-l10n - web browser - language packs
ungoogled-chromium-shell - web browser - minimal shell
ungoogled-chromium-driver - web browser - WebDriver support
ungoogled-chromium-common - web browser - common resources used by 
ungoogled-chromium packages
ungoogled-chromium-sandbox - web browser - setuid security sandbox for 
ungoogled-chromium

To access further information about this package, please visit the following 
URL:

https://mentors.debian.net/package/ungoogled-chromium/

Alternatively, one can download the package with dget using this command:

dget -x 
https://mentors.debian.net/debian/pool/main/u/ungoogled-chromium/ungoogled-chromium_83.0.4103.116-3.dsc

Changes for the initial release:

ungoogled-chromium (83.0.4103.116-3) unstable; urgency=low
.
* Initial Release. (Closes: #939406)
* Released 83.x instead of 84.x due to bugs found in 84.x

Best Regards,
--
Thomas Liang

Bug#968543: RFS: ungoogled-chromium/83.0.4103.116-3 [ITP] -- web browser

2020-08-16 Thread Daniel Gröber
Hi Thomas,

Thanks for working on this package!

I did a quick review I noticed the Vcs-* fields in debian/control are
pointing at the upstream git repo when they should be pointing to the
debianized one instead, see
https://www.debian.org/doc/debian-policy/ch-controlfields.html#version-control-system-vcs-fields.

--Daniel

On Mon, Aug 17, 2020 at 12:41:10AM +, Thomas wrote:
> Package: sponsorship-requests
> Severity: wishlist
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "ungoogled-chromium":
> 
> * Package name : ungoogled-chromium
> Version : 83.0.4103.116-3
> Upstream Author : Eloston 
> * URL : https://github.com/Eloston/ungoogled-chromium
> * License : LGPL-2.0+, GPL-2+, ISC, LGPL-2+, LGPL-2.1+, BSD-3-clause or 
> LGPL-2+, MIT, zlib, BSD-3-Clause, MPL-1.1 or GPL-2+ or LGPL-2.1+, Ms-PL, ICU, 
> Apache-2.0, Public-domain, BSD-2-clause, MPL-1.1 or GPL-2.0 or LGPL-2.1, 
> APPLE-license, BSD-3-clause, GPL-2.0, LGPL-2, MPL-2.0, LGPL-2.1, BSD-3-clause 
> or LGPL-2.1+ or MPL-1.1, LGPL-2+ or MPL-1.1, PHP, LGPL-2.1+ or MPL-1.1
> * Vcs : https://github.com/Eloston/ungoogled-chromium
> Section : web
> 
> It builds those binary packages:
> 
> ungoogled-chromium - web browser
> ungoogled-chromium-l10n - web browser - language packs
> ungoogled-chromium-shell - web browser - minimal shell
> ungoogled-chromium-driver - web browser - WebDriver support
> ungoogled-chromium-common - web browser - common resources used by 
> ungoogled-chromium packages
> ungoogled-chromium-sandbox - web browser - setuid security sandbox for 
> ungoogled-chromium
> 
> To access further information about this package, please visit the following 
> URL:
> 
> https://mentors.debian.net/package/ungoogled-chromium/
> 
> Alternatively, one can download the package with dget using this command:
> 
> dget -x 
> https://mentors.debian.net/debian/pool/main/u/ungoogled-chromium/ungoogled-chromium_83.0.4103.116-3.dsc
> 
> Changes for the initial release:
> 
> ungoogled-chromium (83.0.4103.116-3) unstable; urgency=low
> .
> * Initial Release. (Closes: #939406)
> * Released 83.x instead of 84.x due to bugs found in 84.x
> 
> Best Regards,
> --
> Thomas Liang



Guidance on how to update an old package [editline/libeditline]

2020-08-16 Thread Joel Rivera
Hello everybody,

I'm looking to get some guidance on how to update a package that seems to be in 
the packaging limbo.

The package in question is editline [1], which from what I understand, it is 
integrated into the debian sources. Somewhere  around 2010 it was integrated 
into an external repo and continue to be developed there [2], it has been 
around ten years since the last change in the version that is packaged in 
Debian.

Recently I reached to the author of the newer editline and created an issue to 
get additional context on why that has been the case [3], from what the current 
maintainer of the upstream project replied, it seems that the debian maintainer 
is either no longer interested on updating the package or has some additional 
opinion on why is not a good idea to include the new version in debian. 

Quoting from the issue in the upstream editline project:

>>> I have contacted the Debian maintainer several times, proposing they switch 
>>> to my version,
>>> but not even once has he written back, so after a while I gave up and added 
>>> my own 
>>> debian/ packaging, based on the official. But if someone else is willing to 
>>> put in the time
>>> and effort to talk to the Debian people, I'm more than willing to help out 
>>> any way I can.

The Debian maintainer in question is Sam Hocevar, which from I could gather, he 
is no longer active in the Debian project, at least not as a package 
maintainer. 

And just to wrap up (also mentioned in the GitHub issue), personally I have a 
particular interest in this package because is a dependency of Nix and the 
packaging effort of nix in debian [4] would benefit itself by having a recent 
editline in the official repos, currently they have opted for trying to 
implement readline support in nix PR1/merged [5] PR2/pending  [6] instead of 
packaging this library. At this time, Nix doesn't have the autocomplete 
functionality for the readline build option and it seems that the the Nix 
maintainers are even reconsidering the idea of allowing the extra option to 
support readline and stick only to editline.

I hope that some Debian mentor in this list could give me any guidance on how 
to move on given the current situation.

Thanks.
--
Joel Rivera

[1]: https://tracker.debian.org/pkg/editline
[2]: https://github.com/troglobit/editline/
[3]: https://github.com/troglobit/editline/issues/42
[4]: https://salsa.debian.org/debian/nix
[5]: https://github.com/NixOS/nix/pull/2551
[6]: https://github.com/NixOS/nix/pull/3196



Bug#968506: RFS: re2c/2.0.2-1 -- lexer generator for C, C++ and Go

2020-08-16 Thread JCF Ploemen
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "re2c":

 * Package name: re2c
   Version : 2.0.2-1
   Upstream Author : https://github.com/skvadrik/re2c
 * URL : https://re2c.org
 * License : public-domain, Zend-2.00, Apache-2, PHP-3.01
 * Vcs : https://salsa.debian.org/jcfp/re2c
   Section : devel

It builds those binary packages:

  re2c - lexer generator for C, C++ and Go

To access further information about this package, please visit the following 
URL:

  https://mentors.debian.net/package/re2c/

Alternatively, one can download the package with dget using this command:

  dget -x https://mentors.debian.net/debian/pool/main/r/re2c/re2c_2.0.2-1.dsc

Changes since the last upload:

 re2c (2.0.2-1) unstable; urgency=medium
 .
   * New upstream release.
   * Patches: remove 01 (fix released upstream), refresh 02.
   * Copyright:
 + account for renamed test files.
 + update current upstream maintainer info.
   * Control: refresh description, mention newly added support for Go.
   * Rules: don't install the __run_all scripts with the examples.


Thanks!


pgpqOhukixVXz.pgp
Description: OpenPGP digital signature


Bug#964164: Bug#947017: Bug#964164: RFS: org-drill/2.7.0-1 [ITP] -- spaced repetition drills in Emacs for accelerated study/learning

2020-08-16 Thread Nicholas D Steeves
Hi Thomas,

Thank you for taking a look at this.

Thomas Koch  writes:

> Thank you Nicholas for the reminder and sorry for keeping you waiting.
>
> Unfortunately, I don't believe the package would pass the NEW queue in its 
> current state. You did remove the apple.jpg file but you added a new 
> apple.png file that is not mentioned in debian/copyright.
>
> I know how annoying these copyright issues are!
>

Which package are you looking at?  I have insufficient permissions to
rewrite history or delete the org-drill repo Emacsen Team project, thus
insufficient permissions to clean the git repo.

Going from the provided source package:
  
https://mentors.debian.net/debian/pool/main/o/org-drill/org-drill_2.7.0+dfsg-1.dsc

Copyright and source of apple.png is documented, and the license is CC0,
which does not require specific documentation or attribution in
copyright.  CC0 Allows implicit relicensing, thus the debian/* rule in
copyright applies GPL-3+ to
debian/patches/0001-add-a-more-freely-licenced-image-of-an-apple.patch 

So the package is license-compliant.

When upstream merges the PR the new apple.png will fall under the
upstream "Files: *" GPL-3+ rule.  At that time the package will also be
license-compliant.  I admit that documentation of this file's CC0 would
be nice to have, to highlight the fact that one is free to do more with
that file than the GPL-3+ permits, but this is not a license-compliance
issue.

> I think the easiest would be to just remove the file and its references 
> without any replacement. You might then help upstream with a pull request to 
> provide a dfsg free picture for the next version.
>

I filed such a PR the 28th of July.  Please see the Forwarded header of
that patch.

> The following remarks are maybe not strictly required:
>
> Even if you add a new file, you should not use debian/patches to add it but 
> just include it in the debian tarball. I actually never had to do this 
> myself, so I have no experience with adding a binary file.
>

I chose to use a cherry picked patch from the PR I filed because then
everything is documented in two places (the patch and the PR), and so
that the patch can be automatically dropped in a future release
(prioritises human time).  I'm familiar with the alternative, which
would additionally require additional documentation in README.source.

> Please also add a version number to dfsg suffix like dfsg1 or dfsg-1. It 
> happened to me before that I needed multiple uploads to the new queue before 
> I found all non dfsg-unfree files: https://tracker.debian.org/pkg/nix
>
> Especially the version number of the orig tarball is different from the 
> changelog. I wonder how this worked in the first place.
>

Ah, you're looking at the non-dfsg git repo...

> If you want to reflect the dfsg cleaning work also in your git packaging 
> branch, I started a knowledge base article  here:
> https://wiki.debian.org/kb/git_packaging_dfsg_clean_branch
> An example of this: https://salsa.debian.org/debian/nix
>
> My nix package also contains a debian/watch example to produce a dfsg clean 
> orig tarball.
>
> The git packaging repo does not contain the latest commits apparently, there 
> is no debian/patches folder:
> https://salsa.debian.org/emacsen-team/org-drill/-/tree/master/debian
>

Yes, that project should be deleted.  The plan is to use a gbp-style
repo that leverages uscan's Files-Excluded.

> Thank you very much for your contribution and especially for your patience!

You're welcome!
Nicholas


signature.asc
Description: PGP signature


Bug#968505: RFS: lebiniou/3.43.1-1 -- [Fixes 3.43-1 FTBFS] -- displays images that evolve with sound

2020-08-16 Thread Olivier Girondel


Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "lebiniou":

 * Package name: lebiniou
   Version : 3.43.1-1
   Upstream Author : Olivier Girondel 
 * URL : https://biniou.net
 * License : GPL-2+
   Section : graphics

It builds this binary package:

  lebiniou - displays images that evolve with sound

The package appears to be lintian-clean.

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/lebiniou

Alternatively, one can download the package with dget using this command:

  dget -x
https://mentors.debian.net/debian/pool/main/l/lebiniou/lebiniou_3.43.1-1.dsc

Changes since the last upload:

  * Fix FTBFS on armel/armhf/i386/mipsel.
  * New upstream release 3.43.1.

Regards,
  Olivier Girondel



Bug#968504: RFS: aqemu/0.9.2-2.4 [NMU] [RC] -- Qt5 front-end for QEMU and KVM

2020-08-16 Thread Alexis Murzeau
Package: sponsorship-requests
Severity: important
X-Debbugs-CC: Ignace Mouzannar 

Dear mentors,

I am looking for a sponsor for a NMU of "aqemu" to fix this RC bug:
  #957003 - aqemu: ftbfs with GCC-10 [0]

And these additional bugs:
  #966261 - please drop `qemu' from Depends [1]
  #874050 - aqemu depends on meta-package qemu, which pulls in all supported 
emulation architectures [2]

The maintainer has not responded to this bug, nor other bugs on
this package and orphaned the package in #955988.

This NMU :
 - Add a patch to fix the build issue with GCC 10
 - Remove the dependency on "qemu" dummy package to let it be removed.
   - This is not a RC bug, but I deemed the ratio usefulness/impact
 to be high enough to include it with the fact that the package is orphaned.
 Let me know if this should be avoided anyway.

I'm in the process to try to put this package under the Debian group on Salsa 
when
I will be able to retrieve all available VCS histories from Ignace to keep them 
on Salsa.
But that's not ready yet.



 * Package name: aqemu
   Version : 0.9.2-2.4
   Upstream Author : Andrey Rijov, Tobias Gläßer
 * URL : https://sourceforge.net/projects/aqemu/,
 https://github.com/tobimensch/aqemu
 * License : GPL-2+, BSD-3-clause
   Section : x11

It builds those binary packages:

  aqemu - Qt5 front-end for QEMU and KVM

To access further information about this package, please visit the
following URL:
  https://mentors.debian.net/package/aqemu


Alternatively, one can download the package with dget using this command:

  dget -x
https://mentors.debian.net/debian/pool/main/a/aqemu/aqemu_0.9.2-2.4.dsc

Changes since the last upload to unstable:
aqemu (0.9.2-2.4) unstable; urgency=medium

  * Non-maintainer upload.
  * debian/patches/0003-Fix-build-with-GCC-10.patch:
- Fix build with GCC 10 (For: #957003)
  * debian/control:
- Drop qemu dummy package from Depends (Closes: 966261, 874050)

 -- Alexis Murzeau   Sun, 16 Aug 2020 15:12:30 +0200


Note: the "For: #957003" is intended to not close the bug automatically as 
requested in the
bug description. The bug will be closed only after a successful build.


Source packages diff is in attachment and can be viewed here:
https://salsa.debian.org/amurzeau-guest/aqemu/compare/debian%2F0.9.2-2.3...debian%2F0.9.2-2.4


[0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=957003
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=966261
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=874050

Regards,
-- 
Alexis Murzeau
PGP: B7E6 0EBB 9293 7B06 BDBC  2787 E7BD 1904 F480 937F
diff --git a/debian/changelog b/debian/changelog
index 24da78a..549387f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+aqemu (0.9.2-2.4) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * debian/patches/0003-Fix-build-with-GCC-10.patch:
+- Fix build with GCC 10 (For: #957003)
+  * debian/control:
+- Drop qemu dummy package from Depends (Closes: 966261, 874050)
+
+ -- Alexis Murzeau   Sun, 16 Aug 2020 15:12:30 +0200
+
 aqemu (0.9.2-2.3) unstable; urgency=medium
 
   * Non-maintainer upload.
diff --git a/debian/control b/debian/control
index 1c0d123..fb685cb 100644
--- a/debian/control
+++ b/debian/control
@@ -13,7 +13,7 @@ Homepage: http://aqemu.sourceforge.net/
 
 Package: aqemu
 Architecture: amd64 arm arm64 armel armhf hppa i386 ia64 kfreebsd-amd64 
kfreebsd-i386 mips mipsel powerpc powerpcspe ppc64 ppc64el s390x sparc sparc64 
x32
-Depends: qemu, ${shlibs:Depends}, ${misc:Depends}, libqt5dbus5
+Depends: ${shlibs:Depends}, ${misc:Depends}, libqt5dbus5
 Recommends: qemu-kvm
 Description: Qt5 front-end for QEMU and KVM
  aqemu is a Qt5 graphical interface used to manage QEMU and KVM virtual
diff --git a/debian/patches/0003-Fix-build-with-GCC-10.patch 
b/debian/patches/0003-Fix-build-with-GCC-10.patch
new file mode 100644
index 000..ef15057
--- /dev/null
+++ b/debian/patches/0003-Fix-build-with-GCC-10.patch
@@ -0,0 +1,21 @@
+From: Alexis Murzeau 
+Date: Sat, 15 Aug 2020 15:39:47 +0200
+Subject: Fix build with GCC 10 (Closes: #957003)
+
+Forwarded: https://github.com/tobimensch/aqemu/issues/74
+---
+ src/docopt/docopt_value.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/docopt/docopt_value.h b/src/docopt/docopt_value.h
+index 8f32778..bc2b029 100644
+--- a/src/docopt/docopt_value.h
 b/src/docopt/docopt_value.h
+@@ -13,6 +13,7 @@
+ #include 
+ #include  // std::hash
+ #include 
++#include 
+ 
+ namespace docopt {
+ 
diff --git a/debian/patches/series b/debian/patches/series
index 4b5ddb7..5e05242 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
 01_qemu_parallel_typo.diff
 0002-Remove-VLAN-stuff-QEMU-doesn-t-support-it-anymore.patch
+0003-Fix-build-with-GCC-10.patch


signature.asc
Description: OpenPGP digital signature


Bug#964164: Bug#947017: Bug#964164: RFS: org-drill/2.7.0-1 [ITP] -- spaced repetition drills in Emacs for accelerated study/learning

2020-08-16 Thread Thomas Koch
Thank you Nicholas for the reminder and sorry for keeping you waiting.

Unfortunately, I don't believe the package would pass the NEW queue in its 
current state. You did remove the apple.jpg file but you added a new apple.png 
file that is not mentioned in debian/copyright.

I know how annoying these copyright issues are!

I think the easiest would be to just remove the file and its references without 
any replacement. You might then help upstream with a pull request to provide a 
dfsg free picture for the next version.

The following remarks are maybe not strictly required:

Even if you add a new file, you should not use debian/patches to add it but 
just include it in the debian tarball. I actually never had to do this myself, 
so I have no experience with adding a binary file.

Please also add a version number to dfsg suffix like dfsg1 or dfsg-1. It 
happened to me before that I needed multiple uploads to the new queue before I 
found all non dfsg-unfree files: https://tracker.debian.org/pkg/nix

Especially the version number of the orig tarball is different from the 
changelog. I wonder how this worked in the first place.

If you want to reflect the dfsg cleaning work also in your git packaging 
branch, I started a knowledge base article  here:
https://wiki.debian.org/kb/git_packaging_dfsg_clean_branch
An example of this: https://salsa.debian.org/debian/nix

My nix package also contains a debian/watch example to produce a dfsg clean 
orig tarball.

The git packaging repo does not contain the latest commits apparently, there is 
no debian/patches folder:
https://salsa.debian.org/emacsen-team/org-drill/-/tree/master/debian

Thank you very much for your contribution and especially for your patience!