Bug#980562: RFS: shellingham/1.3.2-1 [ITP] -- Tool to Detect Surrounding Shell
Control: owner -1 ! On Wednesday, January 20 2021, Emmanuel Arias wrote: > shellingham (1.3.2-1) unstable; urgency=medium > . >* Initial release (Closes: #980483) Thanks for the interest in packaging. Some things I'd like you to fix before the upload: 1) You don't need to specify "--test=pytest" on d/rules. 2) python3-shellingham is Suggesting python3-shellingham-doc, which doesn't exist. 3) The package ships with a README.rst. I prefer installing it as part of the documentation. Just add README.rst to a debian/docs file. 4) You're licensing the contents under debian/ as GPL-3+, which is a different license than what upstream is using. Is there any particular reason that made you choose to do this? Do you understand the implications of choosing a different license than the one upstream is using here? 5) On d/copyright, the text of the ISC license should be formatted with one leading space only. I'd also prefer if you could include the full text of the license. 6) There's an empty line at the end of d/watch. Please remove it. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible https://sergiodj.net/ signature.asc Description: PGP signature
Re: [d/watch] Need to modify name of upstream tar ball
Am 30.01.2021 um 17:28 teilte Mattia Rizzolo mit: On Sat, Jan 30, 2021 at 04:37:23PM +0100, Hilmar Preuße wrote: Hi, The part of the Debian udd database, which lists new upstream versions [1] prints that error message, hence there was a scan. BTW, that's also visible here: https://qa.debian.org/cgi-bin/watch?pkg=texworks-manual Well, it shows that the pattern does not work, but not really why. I tested the watch file only on unstable. :-( Hence I'd deduce that your pattern does only work on testing/unstable and I have to modify by watch file again. that was fixed in devscripts version 2.20.5, which ftbfs in buster-backports, which is fixed in the devscripts' git, and I'll likely release in a few days, so it wasn't that strictly needed to do that :) Unfortunate coincidence I guess. ;-) Many thanks to all who helped me! Hilmar -- sigfault OpenPGP_signature Description: OpenPGP digital signature
Re: [d/watch] Need to modify name of upstream tar ball
On Sat, Jan 30, 2021 at 04:37:23PM +0100, Hilmar Preuße wrote: > The part of the Debian udd database, which lists new upstream versions [1] > prints that error message, hence there was a scan. BTW, that's also visible here: https://qa.debian.org/cgi-bin/watch?pkg=texworks-manual > I now tested your pattern > using uscan from Debian stable and now get the same message as in the udd. > After reverting back to my tags based pattern the scan works fine on stable > & unstable. > > Hence I'd deduce that your pattern does only work on testing/unstable and I > have to modify by watch file again. that was fixed in devscripts version 2.20.5, which ftbfs in buster-backports, which is fixed in the devscripts' git, and I'll likely release in a few days, so it wasn't that strictly needed to do that :) But guess it works either way. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. More about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Re: [d/watch] Need to modify name of upstream tar ball
Am 30.01.2021 um 04:21 teilte Eriberto Mota mit: Em sex., 29 de jan. de 2021 às 07:44, Hilmar Preuße escreveu: Hi, Unfortunately when looking at the tracker page [1], it tells "uscan had problems while searching for a new upstream version: In debian/watch no matching files for watch line https://github.com/TeXworks/manual/releases archive/(\d\S+)\.tar\.gz" What it wrong? How can I check if the tracker would be able to use the watch file too? Many thanks! For me it sounds like the tracker page updated the rule from the watch file but it didn't make a new scan yet. The part of the Debian udd database, which lists new upstream versions [1] prints that error message, hence there was a scan. I now tested your pattern using uscan from Debian stable and now get the same message as in the udd. After reverting back to my tags based pattern the scan works fine on stable & unstable. Hence I'd deduce that your pattern does only work on testing/unstable and I have to modify by watch file again. Hilmar [1] https://udd.debian.org/cgi-bin/upstream-status.json.cgi -- sigfault OpenPGP_signature Description: OpenPGP digital signature
