Re: Wrestling with debconf
On Tue, 2022-01-04 at 12:34 +0100, Niels Thykier wrote:
> (Having seen your enquiry on IRC, I presume this issue was still
> relevant)
Hey Niels. Yes, indeed. Still trying to solve this problem.
> I read the "newly unpacked /etc/myfoo/server.conf" as you shipping
> "/etc/myfoo/server.conf" directly inside the package in that path. If
> that is correctly understood, then I think that is the source of your
> woes.
Yes, that is what I was trying to do.
> As I recall, when you manage a file via debconf, you should *not* ship
> it directly in the package. You can ship a template in a different
> location (e.g., /usr/share/myfoo/server.conf.template) and then use
> that combined with the debconf answers to generate the initial
> /etc/myfoo/server.conf.
Ok, I see that now buried in the last paragraph in DPM s 5.1:
"Note that a package should not modify a dpkg-handled conffile in its
maintainer scripts. Doing this will lead to dpkg giving the user
confusing and possibly dangerous options for conffile update when the
package is upgraded."
> Perhaps have a look at openssh-server (postinst + config + file
> listing) as an example, which does something similar. It does use
> "ucf" for handling the merge on updates, which is a different approach
> than yours for creating/updating the configuration file.
> I can recommend that from a consistency PoV, so your package would
> behave the same as other Debian packages if the user were to change the
> file directly. However, I do not think it would be strictly
> necessary to migrate to ucf in order to fix your immediate issue.
I've taken a look at openssh-server.{config,postinst} and the contents
of the package in what's shipped to /etc (nothing). The way they are
doing it is a bit complicated and I am surprised there isn't an elegant
solution yet with debconf. Although it could be I just don't understand
what they were doing, in which case it's probably even more
complicated.
I also still can't figure out why the .config is run twice during
installation.
Anyways, what I am trying to do now is ship server.conf as
server.conf.template in /usr/share/myserver/ and then have .postinst
attempt the following:
new_config="$(mktemp)"
cp -a /usr/share/myserver/server.conf.template "$new_config"
mkdir -p /etc/myserver/
ucf --three-way --debconf-ok \
"$new_config" /etc/myserver/server.conf
ucfr myserver-server /etc/myserver/server.conf
But it's not really clear to be what needs to be done within .config.
Should the script check for /etc/myserver/server.conf early, and if
it's not available, exit 0?
--
Kip Warner -- Senior Software Engineer
OpenPGP signed/encrypted mail preferred
https://www.thevertigo.com
signature.asc
Description: This is a digitally signed message part
Bug#1002617: RFS: carl9170fw/1.9.9-399-gcd480b9-1 [ITP] -- firmware for AR9170 USB wireless adapters
On Sat, 2021-12-25 at 18:25 +, John Scott wrote: > https://mentors.debian.net/debian/pool/main/c/carl9170fw/carl9170fw_1.9.9-399-gcd480b9-1.dsc Some things that prevent the upload of this package: I don't think udebs are needed for firmware packages, none of the other WiFi firmware packages in Debian have them. If the package is actually needed it should be named -udeb not -di, since other udebs use -udeb. Several files have missing/incorrect information in debian/copyright, please do a full audit of the code looking for copyright/license info. * tools/include/list.h is LGPL * tools/include/frame.h is partly from Linux, unknown copyright * include/shared/eeprom.h also contains ISC code DEB_BUILD_OPTION_PARALLEL doesn't appear to be a standard variable, please switch to DEB_BUILD_OPTIONS=parallel=N instead, see Debian Policy, section 4.9.1 and debhelper(7) and dpkg-buildpackage(1). Some things that would be nice to fix at some stage: Nothing in debian/rules references .config so you can drop that from before the execute_before_dh_auto_configure target. It seems like the Homepage should be the carl9170.fw firmware wiki page instead of the carl9170 driver wiki page. https://wireless.wiki.kernel.org/en/users/drivers/carl9170.fw I would express the license of include/shared/fwcmd.h etc as GPL-2-only && ISC rather than putting a copy of the ISC license in a comment. bug-presubj isn't well wrapped. I'm not sure if wrapped or unwrapped is the best option for this file though. Please ask upstream to make a new release, it has been a very long time since the last one. Please ask upstream to update their copies of code from the Linux kernel and other external sources to the latest versions. Please ask upstream to send FindUSB-1.0.cmake & libusb-zeropacket.diff to libusb upstream and then remove them from carl9170fw. Please ask upstream to delete FindPackageHandleStandardArgs.cmake, since that is now available from cmake upstream and from Debian cmake. Potentially cmake_minimum_required will need to be bumped for this. Please ask upstream to include the copyright information for carlfw/src/memcpy.S and carlfw/src/memset.S in the files. Please ask upstream to update the COPYRIGHT file. Please send upstream some changes that would allow building the upstream source using a pre-packaged toolchain like the Debian one. Please also figure out how to eliminate the other debian/rules workarounds. It would be nice if the Linux kernel community or the Debian src:linux package could split kconfig off into a reusable component. Please add an upstream metadata file: https://wiki.debian.org/UpstreamMetadata I suggest these arguments to wrap-and-sort: wrap-and-sort --short-indent --wrap-always --sort-binary-packages --trailing-comma --dry-run These tests from check-all-the-things suggest some polishing for upstream and or yourself: anorack codespell cppcheck cpuinfo debmake-k duck http path-max proselint shellcheck spellintian todo https://github.com/collab-qa/check-all-the-things -- bye, pabs https://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Re: salsa git workflows - import or mirror or?
> Sorry, it's just small overview, how I do it. Brilliant, thank you Juri! Did you add this to the UpstreamGuide wiki at all? -- Kind Regards, Gavin Henry. https://sentrypeer.org
Bug#1002649: RFS: check-mk-agent/1:2.0.0p17+dfsg-4 [ITP] -- general purpose monitoring plugin for retrieving data
Control: untags -1 moreinfo
Re: salsa git workflows - import or mirror or?
Hello, After reading of official documentation I have started like this: Added DEB_SIGN_KEYID DEBEMAIL DEBFULLNAME to environment variables. apt-get install build-essential pkg-config sbuild-debian-developer-setup dput-ng packaging-dev Depends on packages, what you want to build: apt install dh-acc dh-ada-library dh-apache2 dh-apparmor dh-buildinfo dh-consoledata dh-di dh-dist-zilla dh-elpa dh-exec dh-golang dh-haskell dh-kpatches dh-linktree dh-lisp dh-lua dh-make-drupal dh-make-elpa dh-make-golang dh-make-perl dh-metainit dh-ocaml dh-php dh-r dh-rebar dh-runit dh-systemd dh-sysuser dh-virtualenv dh-xsp sbuild-debian-developer-setup after this I've tried to rebuild one package with sbuild -v -d unstable To create skeleton for you new package you can take dh_make or debmake I decided to take a way with just debian folder in debian/master and debian/$(lsb_release -cs) branches. dh_make --help give you a small overview about some options, for small template, it should be enough: dh_make -s -c gpl3 -p $PACKAGE_0.0.0.1 or debmake -T -P -L -x3 -f "$DEBFULLNAME" -e "$DEBEMAIL" -p $YOUR_PACKAGENAME -u $PACKAGEVERSION -r 1 -d unstable -n to have more templates. Add d/watch for your package and try to check new version with uscan --dehs After changing debian/* files for you needs wrap-and-sort -sav for d/copyright licensecheck can be helpfull enable CI/CD on salsa for debian/salsa.yml I use a little bit modified version of salsa.yml: https://salsa.debian.org/gratuxri/check-mk-agent/-/raw/debian/master/debian/salsa-ci.yml?inline=false add upstream/metadata with lintian-brush add d/gbp.conf with "debian-branch = debian/master" and "overlay = true" in section [DEFAULT] for clean debian branch. git commit gbp import-orig --uscan gbp dch -i git commit git push Sorry, it's just small overview, how I do it. Best Regards, Juri Grabowski
Re: salsa git workflows - import or mirror or?
> If I wanted to follow the pattern of: > > https://salsa.debian.org/pkg-voip-team/libosip2 > https://salsa.debian.org/vagrant/librecast (my friends project) Upon further reading, I think this workflow is: https://manpages.debian.org/testing/git-buildpackage/gbp-import-orig.1.en.html like: https://www.kali.org/docs/development/public-packaging/ -- Kind Regards, Gavin Henry. https://sentrypeer.org
Bug#1003140: RFS: libfilezilla/0.35.0-2 -- build high-performing platform-independent programs (runtime lib)
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "libfilezilla": * Package name: libfilezilla Version : 0.35.0-2 Upstream Author : Tim Kosse * URL : https://lib.filezilla-project.org/ * License : GPL-2+ * Vcs : https://salsa.debian.org/debian/libfilezilla Section : libs It builds those binary packages: libfilezilla-dev - build high-performing platform-independent programs (development) libfilezilla-common - build high-performing platform-independent programs (translations) libfilezilla23 - build high-performing platform-independent programs (runtime lib) To access further information about this package, please visit the following URL: https://mentors.debian.net/package/libfilezilla/ Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/libf/libfilezilla/libfilezilla_0.35.0-2.dsc Changes since the last upload: libfilezilla (0.35.0-2) unstable; urgency=medium . * Remove additional whitespace from d/control * Source only upload for migration to testing Note: Will be added to salsa once clears and uploaded. Regards Phil -- *** Playing the game for the games own sake. *** WWW: https://kathenas.org Twitter: @kathenasorg IRC: kathenas GPG: 724AA9B52F024C8B signature.asc Description: This is a digitally signed message part
salsa git workflows - import or mirror or?
Hi all, I've created https://salsa.debian.org/ghenry/sentrypeer as an import from my main GitHub repo. If I wanted to follow the pattern of: https://salsa.debian.org/pkg-voip-team/libosip2 https://salsa.debian.org/vagrant/librecast (my friends project) How best do I start? I note the debian folder is in the repo too, where as I have mine as a branch: https://github.com/SentryPeer/SentryPeer/tree/debian-packaging I can't find the answer in the mentor FAQ or dev guides listed here (unless I have missed it): https://mentors.debian.net/intro-maintainers/ https://www.debian.org/doc/manuals/developers-reference/resources.en.html#salsa-debian-org-git-repositories-and-collaborative-development-platform https://wiki.debian.org/Salsa/Doc Thanks, Gavin. -- Kind Regards, Gavin Henry. https://sentrypeer.org
Bug#1002649: RFS: check-mk-agent/1:2.0.0p17+dfsg-4 [ITP] -- general purpose monitoring plugin for retrieving data
Control: tags -1 moreinfo On Sun, 26 Dec 2021 17:24:19 +0100 Juri Grabowski wrote: I am looking for a sponsor for my package "check-mk-agent": * Package name: check-mk-agent Version : 1:2.0.0p17+dfsg-4 I have not looked at the package. Just by looking at the RFS, the -4 revision is wrong for the initial version. It has to be -1. While you are changing your package according to the remarks, please always keep the -1. When you have fixed this, please untag moreinfo.
Bug#1002735: marked as done (RFS: sphinx-sitemap/2.2.0-3 [ITP] -- Sphinx HTML extension to generate sitemaps)
Your message dated Tue, 4 Jan 2022 16:51:09 +0100 with message-id <734a5464-79ab-342d-8ebe-871f344e2...@debian.org> and subject line Re: RFS: sphinx-sitemap/2.2.0-3 [ITP] -- Sphinx HTML extension to generate sitemaps has caused the Debian Bug report #1002735, regarding RFS: sphinx-sitemap/2.2.0-3 [ITP] -- Sphinx HTML extension to generate sitemaps to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 1002735: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1002735 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems --- Begin Message --- Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "sphinx-sitemap": * Package name: sphinx-sitemap Version : 2.2.0-3 Upstream Author : Jared Dillard * URL : https://github.com/jdillard/sphinx-sitemap * License : MIT * Vcs : https://salsa.debian.org/python-team/packages/sphinx-sitemap Section : python It builds those binary packages: python3-sphinx-sitemap - Sphinx HTML extension to generate sitemaps To access further information about this package, please visit the following URL: https://mentors.debian.net/package/sphinx-sitemap/ Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/s/sphinx-sitemap/sphinx-sitemap_2.2.0-3.dsc Changes for the initial release: sphinx-sitemap (2.2.0-3) unstable; urgency=medium . * Set upstream metadata fields: Bug-Database, Bug-Submit. * Initial release (Closes: #1002731) Regards, -- Juri Grabowski --- End Message --- --- Begin Message --- On Tue, 28 Dec 2021 15:49:06 +0100 Juri Grabowski wrote: Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "sphinx-sitemap": * Package name: sphinx-sitemap Version : 2.2.0-3 Upstream Author : Jared Dillard * URL : https://github.com/jdillard/sphinx-sitemap * License : MIT * Vcs : https://salsa.debian.org/python-team/packages/sphinx-sitemap Section : python Please have a look at the changes that I have commited to the git repo. I am closing this request; please ask in the Python Team's IRC channel for sponsors, which is their way of RFS.--- End Message ---
Re: Wrestling with debconf
Kip Warner: > Hey list, > > [...] > The problem here is this re-running of the myfoo-server.config happens > before the myfoo-server.postinst. This is bad because the latter is > supposed to update the values in /etc/myfoo/server.conf to whatever the > user just entered via debconf prompts. > > Because myfoo-server.config's second invocation sees the newly unpacked > /etc/myfoo/server.conf, it unintentionally seeds debconf with the > values contained therein. > > [...] Hi, (Having seen your enquiry on IRC, I presume this issue was still relevant) I read the "newly unpacked /etc/myfoo/server.conf" as you shipping "/etc/myfoo/server.conf" directly inside the package in that path. If that is correctly understood, then I think that is the source of your woes. As I recall, when you manage a file via debconf, you should *not* ship it directly in the package. You can ship a template in a different location (e.g., /usr/share/myfoo/server.conf.template) and then use that combined with the debconf answers to generate the initial /etc/myfoo/server.conf. Perhaps have a look at openssh-server (postinst + config + file listing) as an example, which does something similar. It does use "ucf" for handling the merge on updates, which is a different approach than yours for creating/updating the configuration file. I can recommend that from a consistency PoV, so your package would behave the same as other Debian packages if the user were to change the file directly. However, I do not think it would be strictly necessary to migrate to ucf in order to fix your immediate issue. I hope that helps. Thanks, ~Niels
