Bug#1064572: RFS: lighttpd/1.4.74-1 / usrmerge

[Alexandre Detiste]

9e6532694efb91a5da9d39acee0c9a6ce43eb180

Hi,

I uploaded 1.4.74-1 but I noticed just now
that this would create a UsrMerge regression.

If the .timer & .service are correctly named (too early in the morning
for me to think)
then the two lines in lighttpd.install are not needed at all.

@Helmut: you can correct us directly on Salsa,
no need to file a bug.

Greetings

git diff 
9e6532694efb91a5da9d39acee0c9a6ce43eb180~1..9e6532694efb91a5da9d39acee0c9a6ce43eb180
diff --git a/debian/lighttpd.install b/debian/lighttpd.install
index 4f8d403..21e2134 100644
--- a/debian/lighttpd.install
+++ b/debian/lighttpd.install
@@ -24,4 +24,6 @@ debian/use-ipv6.pl
/usr/share/lighttpd/
 debian/lighty-enable-mod/usr/sbin/
 debian/index.html   /usr/share/lighttpd/
 debian/lighttpd.tmpfile.conf/usr/lib/tmpfiles.d/
+debian/lighttpd-maint.service   /lib/systemd/system/
+debian/lighttpd-maint.timer /lib/systemd/system/
 doc/systemd/lighttpd.service/lib/systemd/system/

Bug#1037098: RFS: serious-engine

[Alexandre Detiste]

Is this in a good shape ?

Bug#1023119: RFS: cruft-ng/0.9.47 with new dh-cruft binary package -- tool that help identify system files)

[Alexandre Detiste]

I made a new interim change with the Ubuntu / PopOS / BeagleBone /
KaliLinux rules.
(some also apply to Debian proper)

https://mentors.debian.net/package/cruft-ng/

> Please review the current package. 0.9.49
>
> > Please upload a source package to mentors.debian.net or elsewhere
> > and I will review and upload the package including dh-cruft.
> >
> > --
> > bye,
> > pabs

Bug#1023119: RFS: cruft-ng/0.9.47 with new dh-cruft binary package -- tool that help identify system files)

[Alexandre Detiste]

Hi again,

Please review the current package. 0.9.49

https://mentors.debian.net/package/cruft-ng/

It's in a really good shape and can also be trivially backported to Bullseye.

Greetings

> Please upload a source package to mentors.debian.net or elsewhere
> and I will review and upload the package including dh-cruft.
>
> --
> bye,
> pabs

Bug#1023119: RFS: cruft-ng/0.9.47 with new dh-cruft binary package -- tool that help identify system files)

[Alexandre Detiste]

Hi,

I did another interim upload to untangle the CI bugs,
the DebCI job now succeeds.


PiuParts job is still flaky, sometimes working sometimes not.

To avoid to many non-migrating-to-testing uploads
an option would be to NMU plocate first,
it's a one-liner. (and yes I pinged maintainer already,
sadly there's no VCS to propose a MR)



https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1023371
maintainer: Steinar H. Gunderson (DMD) (LowNMU)

Alexandre Detiste 
   cruft-ng: buggy deps plocate, flagged for removal in 29.9 days

Greetings,

Le jeu. 17 nov. 2022 à 04:19, Alexandre Detiste
 a écrit :
>
> Please also close 1024168 with this upload.
I did

Bug#1023119: RFS: cruft-ng/0.9.47 with new dh-cruft binary package -- tool that help identify system files)

[Alexandre Detiste]

Hi,

Please also close 1024168 with this upload.

Greetings

Bug#1023119: RFS: cruft-ng/0.9.47 with new dh-cruft binary package -- tool that help identify system files)

[Alexandre Detiste]

It's there:

https://mentors.debian.net/package/cruft-ng/

Bug#1023119: RFS: cruft-ng/0.9.47 with new dh-cruft binary package -- tool that help identify system files)

[Alexandre Detiste]

Hi,

I implemented all the corrections suggested by various people and more.

I also got a lot of patches from Christian Göttsche which
makes this tool quite fast for the first time ever.

I think that dh-cruft is ready for it's first upload.

The changelog of 0.9.47 was huge (compared to all the previous years)
so I uploaded it as-is, with some fears about the DebCI integration.

...which worked but found one bug #1023336
which is actually #35042 from 1999 coming back again;
it is now definitively fixed.

So this will be 0.9.48.

Greetings,

Alexandre

Bug#1023119: RFS: cruft-ng/0.9.47 with new dh-cruft binary package -- tool that help identify system files

[Alexandre Detiste]

Package: sponsorship-requests
Severity: normal

I am looking for a sponsor for my package "cruft-ng".

This is a Debian native package.

 * Package name : cruft-ng
   Version  : 0.9.47
   Upstream contact : me
 * URL  : https://github.com/a-detiste/cruft-ng
 * License  : GPL+2

I have been maintaining since 2014 as a Debian Maintainer.

I recenlty found how to make it much more usefull
for some task at work; about 100 proprietary packages
were rebuilt with this new "dh-cruft" DebHelper plugin.

As a DM I don't have the right to publish a NEW package;
this why I need sponsor today.



Moreover, as it is the first time I have to write Perl
code in 15 years I welcome some peer review.
This is just temporary, I hope this will get merged
into DebHelper proper.


I plan to move the repository to Salsa with C.I.
as soon as I get my DD namespace;
or alternatively it could also be immediatly
maintained under some welcoming existing Salsa group.

Greetings,

Alexandre Detiste

Bug#807099: closed by Bart Martens <ba...@quantz.debian.org> (closing RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.)

[Alexandre Detiste]

Le mardi 5 janvier 2016 16:36:57, vous avez écrit :
> This is an automatic notification regarding your Bug report
> which was filed against the sponsorship-requests package:
> 
> #807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine 
> reimplementation.
> 
> It has been closed by Bart Martens .
> 

Hi,

Thanks Bart,

My original plan was to close the RFS automatically via the changelog.

Maybe that was not hte right way to do it ;-)


http://anonscm.debian.org/cgit/pkg-games/corsix-th.git/tree/debian/changelog

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

[Alexandre Detiste]

Le samedi 26 décembre 2015, 22:46:05 Markus Koschany a écrit :
> The package looks good to me. Please add the missing license of tinyxml
> to debian/copyright. 

Done

> After that I will upload the package.

Thanks, that would be nice to finally close this ITP from 2011.


signature.asc
Description: This is a digitally signed message part.

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

[Alexandre Detiste]

Hi,

I spent some time merging your advices & Simon's ones [1]
in a way that don't trigger new lintian false positives.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=807099#74

> Am 11.12.2015 um 12:35 schrieb Alexandre Detiste:
> I would add the following paragraph to debian/copyright to avoid any
> confusion.
> 
> License: GPL-3+-with-exception
>  On Debian systems, the complete text of the GNU General Public License
>  version 3 can be found in `/usr/share/common-licenses/GPL-3'.
>  .
>  As a special exception,
>
> Bonus points if these files are generated automatically during the build.

I'll see for the next release if that's usefull; now this part of the code is 
not used anyway.

I sent a pull request for this lintian advice:
 "I: corsix-th: spelling-error-in-binary usr/lib/games/corsix-th/CorsixTH 
occured occurred"

I feel this problem isn't enought important to warrant a patch for 0.50.

The patch for the segfault I found in Arch packaging is well there.

Greets & best wishes,

Alexandre


signature.asc
Description: This is a digitally signed message part.

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

[Alexandre Detiste]

Le dimanche 6 décembre 2015, 20:34:42 Markus Koschany a écrit :
> Several Expat copyright holder are missing in
> CorsixTH/Lua/languages
> CorsixTH/Src/jit_opt.h
> SpriteEncoder/*
> LevelEdit/*
> 
> GPL-3+
> SpriteEncoder/parser.cpp
> SpriteEncoder/tokens.h

This license has this special exception; does this mean
it can be considered Expat-licensed as the whole game ?

   As a special exception, you may create a larger work that contains
   part or all of the Bison parser skeleton and distribute that work
   under terms of your choice

> 
> zlib:
> WindowsInstaller/ReplaceInFile.nsh


signature.asc
Description: This is a digitally signed message part.

Bug#807099: [corsix-th] 01/01: copyright: add last missing BSD-licensed files:

[Alexandre Detiste]

Ok, let's forward this to the RFS bug so other can have a look at it too.

I'm going through the pain of documenting all those file in the source
package instead of simply repacking it as "+ds1" or something
in the hope these features (level editor...) can be enabled
in a future release.

> [Simon McVittie <s...@debian.org>]
> On 11/12/15 11:58, Alexandre Detiste wrote:
> > +Files: SpriteEncoder/*
> > +Copyright: 2013 Albert "Alberth" Hofkamp
> > +License: BSD-3-Clause
> > +Comment:
> > + SpriteEncoder/parser.cpp & SpriteEncoder/tokens.h are G.P.L-3+
> > + but have this exception:
> > + .
> > + "As a special exception, you may create a larger work that contains
> > + part or all of the Bison parser skeleton and distribute that work
> > + under terms of your choice, so long as that work isn't itself a
> > + parser generator using the skeleton or a modified version thereof
> > + as a parser skeleton."
> 
> I think that's better spelled as:
> 
> Files: SpriteEncoder/*
> Copyright: ...
> License: BSD-3-Clause
> 
> Files:
>  SpriteEncoder/parser.cpp
>  SpriteEncoder/tokens.h
> Copyright: ...
> License: BSD-3-Clause and GPL-3+ with Bison exception
>  [normal GPL-3 stuff copied from the file itself]
>  .
>  As a special exception, you may create a larger work that contains
>  part or all of the Bison parser skeleton and distribute that work
>  under terms of your choice, so long as that work isn't itself a
>  parser generator using the skeleton or a modified version thereof
>  as a parser skeleton.
> Comment:
>  The source for these files is parser.y, which is BSD-3-Clause.
>  .
>  On Debian systems, ... /usr/share/common-licenses ...
> 
> 

Bug#807700: RFS: steamcmd - Command-line interface for Steam

[Alexandre Detiste]

Package: sponsorship-requests
Version: RFS: steamcmd - Command-line interface for Steam
Severity: wishlist

Dear mentors,

  I am looking for a sponsor for my package "hello":

 * Package name: steamcmd
   Version : upstream package is sadly not versioned
   Upstream Author : Valve
 * URL : https://developer.valvesoftware.com/wiki/SteamCMD
 * License : commercial
   Section : non-free/games

  It builds those binary packages:

steamcd:i386 - Command-line interface for Steam

  To access further information about this package, please visit the following
URL:

  http://anonscm.debian.org/cgit/pkg-games/steamcmd.git/

  This is the initial upload.

  A few considerations: this program needs to run from a writable
  location & will automatically update itself the first time it's ran.

  So, I could have stuffed the current 'steamcmd' binary & 'steamcmd.sh'
  of the day in the package, but that would hadn't enabled someone to
  reproduce that package, so instead I used the binary
  timestamped 2013/02/05 from the tarball.

  https://steamcdn-a.akamaihd.net/client/installer/steamcmd_linux.tar.gz

  This package reuse much work done on the src:steam package
  & depends on steam:i386 binary package to ensure that all needed
  depedencies are already installed and that user has already
  accepted the EULA.

  Regards,

  Alexandre Detiste



-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing'), (450, 'unstable'), (400, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.2.0-1-amd64 (SMP w/6 CPU cores)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

[Alexandre Detiste]

Le mardi 8 décembre 2015, 12:32:33 Paul Wise a écrit :
> On Mon, Dec 7, 2015 at 8:36 PM, Alexandre Detiste wrote:
> 
> > There's one library missing: "lua-socket", which is solely used
> > for a call-home / breach of privacy anti-feature.
> >
> > I would disable it at build-time with sed.
> > (beacause lua-socket might have been pulled
> > by an other package)
> ...
> >   print "Checking for CorsixTH updates..."
> >   local update_body, status, headers = http.request(update_url)
> 
> I don't know that it is fair to call it that, it is only checking for
> updates. Obviously doing that is pointless for users of a Debian
> package, but it would be helpful for users of platforms without a sane
> update system.

I didn't wanted to sound harsh but I just didn't thought of any other name for 
this.

The lintian tags are named privacy-breach-* as well.

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

[Alexandre Detiste]

Hi,

Thanks for having a look at this.

> so are you saying that the package is doing some dlopen-hack to use the 
> libraries?
> 
> because otherwise the package needs to link the libraries, and then shlibs 
> should
> do the subst work.
> 
> (note: I didn't clone the repository, but in my opinion the cleaner way 
> should be to find,
> link and use them, not to find them at runtime if available and dlopen them, 
> but I might be
> wrong, because I don't know the context)

The context is that this is game is mainly written in Lua +
some C++ glue code and I've no idea how Lua libraries work.

So I'll spend some time to learn that properly.


This lua-lpeg depedency is there because I was until recently a user
of the  .deb provided by GetDeb and I noticed after an update
that the game was spewing a runtime error about this missing lib;
installing lua-lpeg solved the problem 

I told GetDeb maintainer to add this to the package depedencies,
without explicitely stating weither this should go in Build-Dep or Dep.

And then I started from this list of depedencies to build my package.

> cheers,
> 
> G.

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

[Alexandre Detiste]

Le lundi 7 décembre 2015, 12:06:55 Gianfranco Costamagna a écrit :
>
> I guess the libraries are somewhat opened in the lines below
> "local lfs = require "lfs"" <<- lua-filesystem
> "local lpeg = require "lpeg"" <<- lua-lpeg
> 
> but I don't think you are actually opening the sofiles but the .lua version
> http://www.lua.org/pil/8.1.html
> (require keyword)
> 
> also please check the "luaL_openlibs" function in the source code.
> 
> there are many "require" in the code, I would check all of them :)

I trust what I know:  strace.

There's one library missing: "lua-socket", which is solely used
for a call-home / breach of privacy anti-feature.

I would disable it at build-time with sed.
(beacause lua-socket might have been pulled
by an other package)


CorsixTH/Lua/config_finder.lua
-- Create config.txt if it doesn't exist
local config_defaults = {
  check_for_updates = true
}


strace -e open -F corsix-th  2>&1 | grep /usr/lib | cut -f2 -d\" | sort -u | 
grep lua
/usr/lib/lua/5.2/socket.so
/usr/lib/x86_64-linux-gnu/liblua5.2.so.0
/usr/lib/x86_64-linux-gnu/lua/5.2/lfs.so
/usr/lib/x86_64-linux-gnu/lua/5.2/lpeg.so
/usr/lib/x86_64-linux-gnu/lua/5.2/socket.so

LANG=C dpkg -S $(strace -e open -F corsix-th  2>&1 | grep /usr/lib | cut -f2 
-d\" | sort -u | grep lua)
dpkg-query: no path found matching pattern /usr/lib/lua/5.2/socket.so
liblua5.2-0:amd64: /usr/lib/x86_64-linux-gnu/liblua5.2.so.0
lua-filesystem:amd64: /usr/lib/x86_64-linux-gnu/lua/5.2/lfs.so
lua-lpeg:amd64: /usr/lib/x86_64-linux-gnu/lua/5.2/lpeg.so
dpkg-query: no path found matching pattern 
/usr/lib/x86_64-linux-gnu/lua/5.2/socket.so

-

CorsixTH/Lua/app.lua

  local success, socket = pcall(require, "socket")

  if not success then
-- LuaSocket is not available, just return
print "Cannot check for updates since LuaSocket is not available."
return
  else
self.lua_socket_available = true
  end
  local http = require "socket.http"
  local url = require "socket.url"

  print "Checking for CorsixTH updates..."
  local update_body, status, headers = http.request(update_url)

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

[Alexandre Detiste]

Le dimanche 6 décembre 2015 21:28:35, vous avez écrit :
> I saw that they provided a desktop file within the DebianPackager
> directory. desktop files should definitely be provided with the upstream
> sources because they are not Debian specific. Other distributions would
> also benefit from this change.

A manpage would be usefull too :-)

I merged mine with the one writen back then by Chris Butler.

I can't even find how the arguments are parsed in the program source
code.

---

I've copied a segfault-preventing patch from Arch Linux too.

> >> Please ask upstream to remove the embedded copy
> > That's downstream work.
> 
> No, it is not. Please point them to
> https://wiki.debian.org/UpstreamGuide#No_inclusion_of_third_party_code

I guess they just don't care about this;
better start winning some karma points by providing a man page
+ .desktop then this will be the next step.

Greets,


Alexandre

signature.asc
Description: This is a digitally signed message part.

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

[Alexandre Detiste]

Le dimanche 6 décembre 2015, 20:34:42 Markus Koschany a écrit :
> Hi Alexandre,
> 
> here is my initial review. I am working with the pkg-games Git
> repository of corsix-th and I suggest we continue to use it instead of
> the mentors.debian.net packages.

Ok

> debian/control:
> 
> You build-depend on wx2.8-headers but this package is obsolete and will
> be removed soon. Please either use wx3.0-headers instead or remove the
> build-dependency because I don't see anything in the sources that may
> need it.

find . -type f -exec grep ^#include {} \; | grep wx | sort -u
#include 
#include 
#include 
#include 
#include 
#include 
#include 
#include 
#include 
#include 
#include 
#include 
#include 
#include 
...

It's used in MapEdit/ (currently disabled) and AnimView/
I need to check if this second direcotry is a depedency of MapEdit only or
if it is used somewhere else.

> Why do you depend on lua-filesystem and lua-lpeg explicitly? If those
> dependencies are really required, the ${shlibs:Depends} substvar should
> include them already. Otherwise the build system should be updated to
> require and incorporate those libraries.

Because they are only needed at runtime...
does they really need to get pulled in the build chroot for nothing ?
I guess it's cleaner that way.

> desktop file: I have already fixed a few things that bothered me. I
> believe it's a simulation game and StartupNotify should be set to false.
> I also added keywords and a comment in German. Please tell me if you can
> live with the changes or if there is a reason to stick with the old
> values. Please forward the new desktop file upstream.

Upstream doesn't ship a .png icon either and had removed
the non-maintained DebianPackager... 

It's not the kind of thing I really want to bother an upstream with; 
ut rather more usefull things, like having appropriate configure
scripts to avoid the need to patch the build system.

> Please use Debian's system library of tinyxml. The embedded copy of
> tinyxml in AnimView/ is neither mentioned in upstream's LICENSE.txt file
> nor in debian/copyright.

As stated for WX, I need to check if AnimView is needed.

> Please ask upstream to remove the embedded copy
That's downstream work.
> or to offer a build system option to use the system library instead.
I'll come with a P.R if the situation is still applicable for current git 
master.

> They should also mention the copyright holders and license in
> LICENSE.txt. You can take a look at my Bullet package how I used
> Debian's tinyxml library.

Ok

> There are several issues with debian/copyright:
> Some copyright holders and licenses are missing.
> 
> BSD-3-clause
> CMake/CMakeFFmpegLibavMacros.cmake
> CMake/FindFFmpeg.cmake
> CMake/FindLibAV.cmake
> CMake/FindSDL2.cmake
> CMake/FindSDL2_mixer.cmake
> 
> public-domain
> CMake/FindDirectX.cmake
> CMake/FindLua.cmake
> CMake/FindPkgMacros.cmake

Oops, I just assumed all these *.cmake files were autogenerated ...


> Several Expat copyright holder are missing in
> CorsixTH/Lua/languages
> CorsixTH/Src/jit_opt.h


> SpriteEncoder/*
> SpriteEncoder/parser.cpp
> SpriteEncoder/tokens.h
This is a small external tool not used during the build.
Well, the debian/copyright must cover the whole source package.


> LevelEdit/*
> 
> zlib:
> WindowsInstaller/ReplaceInFile.nsh


> Why don't you build the level editor? Wouldn't this be a useful addition
> to the game?

It is disabled by default in the 0.50 release:

From the release notes:
"The Map Editor is not included in 0.50 due to incompatibilities with the 
engine change.
We hope to have a new improved map editor available in a future release.
In the mean time we suggest that level designers copy their full 0.40 install 
to another location before installing 0.50."


> Lintian error:  source-contains-unsafe-symlink
> 
> I think it is safe to override this error and since upstream already
> removed the debian directory from Git master it will be fixed with the
> next release of corsix-th. Another option might be to remove the
> directory for the current version and to append +ds to the upstream version.

I prefer avoiding repacking if I don't absolutely have to (example: in case of 
non DFSG assets),
here it's about 1 lintian override + document some non needed
files in d/copyright, so I'll keep the original tarball.

> Forwarding the Lua patch upstream is a good idea.

Well, upstream is already aware of the issue & had planned
to fix it in another way; https://github.com/CorsixTH/CorsixTH/pull/899

I've added a "Forwarded: not needed, see 
https://github.com/CorsixTH/CorsixTH/pull/899;
DEP-3 tag to the patch.


> I would change usr/lib/games/corsix-th/CorsixTH to
> /usr/lib/corsix-th/CorsixTH. We still use /usr/games and
> /usr/share/games for historical reasons but I think it is OK to omit the
> games subdirectory here.

Will have a look 

> debian/scripts/corsix-th
> 
> Please use the exec command. It replaces the current process without
> forking a new process.

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

[Alexandre Detiste]

Package: sponsorship-requests
Severity: wishlist

  Dear mentors,

  I am looking for a sponsor for my package "corsix-th":

 * Package name: corsix-th
   Version : 0.50-1
   Upstream Author : Peter "Corsix" Cawley
 * URL : https://github.com/CorsixTH/CorsixTH/
 * License : GPL-3
   Section : contrib/games

  It builds those binary packages:

corsix-th - the engine
corsix-th-data - platform independant the Lua Scripts

  To access further information about this package, please visit the following
URLs:

  http://anonscm.debian.org/cgit/pkg-games/corsix-th.git/

I didn't succeeded into creating the source package.

The binary package ("debuild -us -uc -b") is fine though
and is a 1:1 replacement for the one from GetDeb.

(this package _does_ work fine too, even if
FrankenDebian is a bad idea; that's why
I'm packaging this)

dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building corsix-th using existing ./corsix-
th_0.50.orig.tar.gz
dpkg-source: info: local changes detected, the modified files are:
 corsix-th/CMakeCache.txt
 corsix-th/CMakeFiles/3.3.2/CMakeCCompiler.cmake
 corsix-th/CMakeFiles/3.3.2/CMakeCXXCompiler.cmake
 corsix-th/CMakeFiles/3.3.2/CMakeSystem.cmake
 corsix-th/CMakeFiles/3.3.2/CompilerIdC/CMakeCCompilerId.c
 corsix-th/CMakeFiles/3.3.2/CompilerIdCXX/CMakeCXXCompilerId.cpp
 corsix-th/CMakeFiles/CMakeDirectoryInformation.cmake



  Changes since the last upload:

  - Initial release


  Regards,
  Alexandre Detiste



-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing'), (450, 'unstable'), (400, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.2.0-1-amd64 (SMP w/6 CPU cores)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Bug#781622: RFS: opentyrian/2.1.20130907-1 [ITP]

[Alexandre Detiste]

 Thanks for taking the time to look at this.
Thanks too.


I fixed the icon location.

for size in 22 24 32 48 128 ; do \
- mkdir -p usr/share/icons/hicolor/$${size}x$${size}/apps ;\
- install linux/icons/tyrian-$${size}.png
usr/share/icons/hicolor/$${size}x$${size}/apps/opentyrian.png ;\
+ mkdir -p debian/opentyrian/usr/share/icons/hicolor/$${size}x$${size}/apps ;\
+ install linux/icons/tyrian-$${size}.png
debian/opentyrian/usr/share/icons/hicolor/$${size}x$${size}/apps/opentyrian.png
;\
done

Alexandre


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/CADsTwjKJzcAQh=jejypqeqdug5dcxjdd0vuwzmqcwi0cmca...@mail.gmail.com

Bug#781622: RFS: opentyrian/2.1.20130907-1 [ITP]

[Alexandre Detiste]

Le mercredi 1 avril 2015, 20:38:30 Dmitry Smirnov a écrit :
 Hmm, how about doing it gnu-make-style?
 
I tried that too, but this doesn't work as I expected (Only the first ‘%’ in 
the pattern and replacement is treated this way; any subsequent ‘%’ is 
unchanged. from the manual)

--

icons := $(patsubst 
linux/icons/tyrian-%.png,debian/opentyrian/usr/share/icons/hicolor/%x%/apps/opentyrian.png,$(wildcard
 linux/icons/tyrian-*.png))

debian/opentyrian/usr/share/icons/hicolor/%x%/apps/opentyrian.png: 
linux/icons/tyrian-%.png
install -D --mode=644 --preserve-timestamps $ $@

override_dh_install: $(icons)
dh_install


 Please note that in make files make is usually spelled as $(MAKE).
Oops, I overloked that.
I had to add even more boilerplate to make parallel build actually work.

signature.asc
Description: This is a digitally signed message part.

Bug#763810: RFS: cruft/0.9.16+nmu1 NMU

[Alexandre Detiste]

Hi,

 You should sometime read them

I have already read them many times in random order;
I will browse those again from start to begin to see if i missed
something important.
 
 As [1] is emtpy, I will be a little more verbose below, apologizes if I
 tell you something you already know.

Indeed. I have till now very little experience with packaging.
I just built some dummy ones with equivs.

 - Change the Orphaning Bug to an Intent-To-Adopt-Title (ITA:) one and
 set yourself as owner (see https://www.debian.org/devel/wnpp/#howto-o
 and https://www.debian.org/Bugs/server-control; bts(1) is also a useful
 tool for manipulating bug status)

Done, I wish I knew bts existed before.

 - Close the Bug in your d/changelog. (some entry like New maintainer
 (Closes: #763888) -- (d/ is short for the debian/ directory in your
 package)
Ok

 - Set yourself as Maintainer in d/control (and remove the likely
 inactive Uplpoader; he can be added in case of again)
Ok

  I already solved 3 bugs, they will be automaticaly closed by the amended 
  changelog.
 Thats the way to go. If you like, you can also tag those bugs pending
In fact, those fixes are already included in the last upload from Marcin
that is already in sid.


(cruft-ng)
 Just one remark: Depends should be only used when
 appropriate -- refer to Policy §7.2  -- so only if cruft-ng requires
 cruft to operate)
It does well requires all the _rules_ from the explain/  filters-unex/
directories. The proper way to do it would be to have an
arch-indepedant cruft-data package with theses rules,
with two arc-dependant cruft  cruft-ng that depend on this.

Though, this is much work; I guess that people willing to rewrite
cruft could also just do a git clone ; cd ; make to try it out.

 NM is to become a DD.
Ok, I mixed it up; I thought taht was needed to recognize the gpg key.

 (Lintian Error )
 This error will go away after you adopted the package (as described
 above)
 
Ok

 - d/changelog:
 
 There was an upload Oct3 - you need to rebase your d/changelog to
 include the changes from 0.9.17
 (skip the unreleased nmu)

Ok, I did the rebase, the nmu is gone

 Standard Version 3.9.6 is out ;-)
Ok

 Regarding VCS-*, they need some update as you need to keep them actual
Marcin transfered me the root GitHub repository 
after I deleted my fork, I adapted the URL everywere.

 (Note: Seems that Marcin did not push the tag for 0.9.17 -- please make
 sure to tag this release. Tool recommendation: git-buildpackage

I set the tag.

 - d/copyright
 
 Comment: should go, not needed.
 
 You need to add your name to the * section
 (as you are also becoming upstream, I guess. Its a native package
 afterall :))
Ok, I just didn't want to rush it/hurt people feelings;
It's nothing technical. This is correct now.

I removed the links to the wiki  alioth page;
those are not much usefull anyway.

 - d/cruft.lintian-overrides
 Please remove the lines when no longer needed, not just only comment it.
Ok

 - d/docs is empty
 Remove file if not needed.
Ok
 
 - d/dirs *might* not be needed, as debhelper will create the dirs for
 you usually. So check if can be cleaned up
I've forgotten this little bit in my last upload to mentors.
Only the empty folders should be there. (/var/...  /etc...)

 
 Ok, the list is not really long. Good job!
 Please update the package, replay to this mail and say what you changed,
 put it to mentors, and give me a ping.
https://mentors.debian.net/package/cruft - 2014-10-06 05:09
 
 
 --
 Tobi
Thanks for the review

Alexandre


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/3197009.dka1B10lbq@antec

Bug#763810: RFS: cruft/0.9.16+nmu1 NMU

[Alexandre Detiste]

I fixed the changelog, I only kept what was really fixed in 0.9.18 

   - d/dirs *might* not be needed, as debhelper will create the dirs for
   you usually. So check if can be cleaned up
  I've forgotten this little bit in my last upload to mentors.
  Only the empty folders should be there. (/var/...  /etc...)
 
 You did not touch that file...

Removing any line from d/dirs breaks the build;
I reverted changes to this file.

 As said, if you are quick, I will upload today. (Otherwise after my
 VAC.)

Ok thanks, theres is a new upload on mentors.d.o


signature.asc
Description: This is a digitally signed message part.

Bug#763810: RFS: cruft/0.9.16+nmu1 NMU

[Alexandre Detiste]

Hi,

 cruft is orphaned (#763888), so you dont do a NMU, as technically there
 is no maintainer. Instead, do a QA-upload. See
 https://www.debian.org/doc/manuals/developers-reference/pkgs.html#nmu-qa-upload

Ok, it wasn't orphaned at the time I did the RFS.

Here is a new package:

http://mentors.debian.net/package/cruft

 Of course, it would be even better if would consider adopting the
 package...

I would like to.

 As a QA upload allows you to fix litteraly everything, it would be great
 if you could reduce the bug count a little bit :)

I already solved 3 bugs, they will be automaticaly closed by the amended 
changelog.

Most others are not bugs, but feature requests;
my own biggest complaint is that it is s slow, even on a new PC.

After one week of thinkering, I had rewritten the cruft engine from scratch and 
it is already 30x to 100x faster.
https://github.com/a-detiste/cruft-ng
https://github.com/a-detiste/cruft-ng/wiki/Benchmark

It tries to have an output identical to cruft.

It doesn't support any command line argument at the moment
but it is already usefull to myself for testing the cruft ruleset, and fix it 
faster.

This let me also find new bugs in cruft: it doesn't grok multiarch,
and can't realise that libc6:amd64  libc6 are the same thing.

I would like at first to package this as cruft-ng (with Depends: cruft)
so that users can compare output.

It's my first C++ program after 10 years of SQL  SAS, the code is ugly.

This in not even real C++, just C + strings + vectors + lot of calls to C 
library;
I would better rewrite it in plain C. Of course this won't be completed for 
Jessie.
 
 (So, yes, I'm willing to sponsor you if you bring the package into
 shape :-)
Ok, that would be great.

I've filled up the needed form for Debian Maintainer
https://nm.debian.org/public/person/detiste

 
 (Antonjy: You are listed as uploader... I assume that this is obsolete
 as your last upload for this package was 1998. please confirm)
Lintian complaints about that too.

Thanks !



signature.asc
Description: This is a digitally signed message part.

Bug#763810: RFS: cruft/0.9.16+nmu1 NMU

[Alexandre Detiste]

Package: sponsorship-requests
Severity: normal

Dear Maintainer,

I am looking for a sponsor for my updated cruft package.

This includes fixes for all the changes that happened since 2011,
like devtmpfs, systemd, ...

 * Package name: cruft
   Version : 0.9.16+nmu1
   Upstream Author : Marcin Owsiany porri...@debian.org
 * URL : https://github.com/a-detiste/cruft
 * License : no change
   Section : admin

Here is a colordiff:
  https://github.com/porridge/cruft/pull/3/files

  It builds those binary packages:

cruft - program that finds any cruft built up on your system

  To access further information about this package, please visit the following 
URL:

  http://mentors.debian.net/package/cruft

  Alternatively, one can download the package with dget using this command:

dget -x 
http://mentors.debian.net/debian/pool/main/c/cruft/cruft_0.9.16+nmu1.dsc

  More information about hello can be obtained from http://www.example.com.


-- System Information:
Distributor ID: Raspbian (also applicable for vanilla Debian)
Description:Raspbian GNU/Linux testing (jessie)
Release:testing
Codename:   jessie
Architecture: armv6l

Kernel: Linux 3.12.28+ (PREEMPT)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20141002203526.4393.47887.reportbug@localhost

Bug#763810: RFS: cruft/0.9.16+nmu1 NMU

[Alexandre Detiste]

Dear Maintainer, Uploaded, User

I am looking for a sponsor for my updated cruft package.

This includes fixes for all the changes that happened in Debian since 2011,
like devtmpfs, systemd, grub2, cupsys - cups ...

 * Package name: cruft
Version : 0.9.16+nmu1 
 * URL : https://github.com/a-detiste/cruft
 * License : no change
Section : admin

Here is a colordiff:
  https://github.com/porridge/cruft/pull/3/files

  It builds those binary packages:
cruft - program that finds any cruft built up on your system

 
My plan was not to touch the cruft engine at all, only update the ruleset,
but the current source won't even build without removing non existent 
directories 
filters-frbn filters-miss from DATADIRS in Makefile.in .

If this update succeds, I'll then have a look a the build  packaging too;
using Lintian output as a starting point.



  To access further information about this package, please visit the following 
URL:

  http://mentors.debian.net/package/cruft

  Alternatively, one can download the package with dget using this command:

dget -x 
http://mentors.debian.net/debian/pool/main/c/cruft/cruft_0.9.16+nmu1.dsc

Alexandre Detiste

--

By the way, reportbug is itself broken at the moment (758619),
so I didn't manage to CC you to the original RFS bug repport;
you'll have to subscribe yourself manually to this bug.

signature.asc
Description: This is a digitally signed message part.