Bug#904765: looking-glass packaging questions

2019-01-08 Thread Lennart Weller
Hello everyone I do have some changes I want to make to the package to make it 
more comfortable to use.

Before the first use the looking-glass host (this package) requires some 
changes to the libvirt-qemu abstract apparmor profile. Explicility changing 
"/{dev,run}/shm r," to read-write
The problem is I have to either change this file or libvirts apparmor template 
both of which are not owned by my own package. In the later case only future 
VMs would have the correct option.
Or I could just print a dialog saying change it yourself. What would be the 
preferred way here?

Another possible step that could be taken is to create the shm device 
automatically on install i.e. with a oneshot systemd service. That would be 
easy and remove an additional step without much interference with the rest of 
the system. Does anyone know of a package which has to do something similar?

The last change is something maybe for the future. The software depends on a 
client component for windows which currently needs to be downloaded from the 
authors website. I imagine one could supply a self cross-compiled windows 
executable on an iso that could be easily mounted into the vm and installed 
from there. Has anyone done something similar to this? So far I know only of 
virtio drivers but they are not supplied by debian anywhere as far as i can see.

- Lennart



looking-glass packaging questions

2019-01-07 Thread Lennart Weller
Hello everyone I do have some changes I want to make to the package to make it 
more comfortable to use.

Before the first use the looking-glass host (this package) requires some 
changes to the libvirt-qemu abstract apparmor profile. Explicility changing 
"/{dev,run}/shm r," to read-write
The problem is I have to either change this file or libvirts apparmor template 
both of which are not owned by my own package. In the later case only future 
VMs would have the correct option.
Or I could just print a dialog saying change it yourself. What would be the 
preferred way here?

Another possible step that could be taken is to create the shm device 
automatically on install i.e. with a oneshot systemd service. That would be 
easy and remove an additional step without much interference with the rest of 
the system. Does anyone know of a package which has to do something similar?

The last change is something maybe for the future. The software depends on a 
client component for windows which currently needs to be downloaded from the 
authors website. I imagine one could supply a self cross-compiled windows 
executable on an iso that could be easily mounted into the vm and installed 
from there. Has anyone done something similar to this? So far I know only of 
virtio drivers but they are not supplied by debian anywhere as far as i can see.

- Lennart


January 4, 2019 5:09 PM, "Lennart Weller"  wrote:

> It's already open again. Just a slight delay in processing on the bts.
> .
> January 4, 2019 4:41 PM, "Andrey Rahmatullin"  wrote:
> 
>> On Fri, Jan 04, 2019 at 03:34:22PM +, Lennart Weller wrote:
>> 
>>> I recently uploaded a new version tagged 0+a12 of looking-glass. I'm still 
>>> looking for sponsors.
>> 
>> In that case you should reopen the bug.
>> 
>> --
>> WBR, wRAR



Re: Bug#904765: closed by Bart Martens (closing RFS: looking-glass/0+a11-1 [ITP])

2019-01-04 Thread Lennart Weller
It's already open again. Just a slight delay in processing on the bts.
.
January 4, 2019 4:41 PM, "Andrey Rahmatullin"  wrote:

> On Fri, Jan 04, 2019 at 03:34:22PM +0000, Lennart Weller wrote:
> 
>> I recently uploaded a new version tagged 0+a12 of looking-glass. I'm still 
>> looking for sponsors.
> 
> In that case you should reopen the bug.
> 
> --
> WBR, wRAR



Bug#904765: closed by Bart Martens (closing RFS: looking-glass/0+a11-1 [ITP])

2019-01-04 Thread Lennart Weller
I recently uploaded a new version tagged 0+a12 of looking-glass. I'm still 
looking for sponsors.
In case the use-case for this software is not clear a short description from 
the official website:

> Looking Glass is an open source application that allows the use of a KVM 
> (Kernel-based Virtual Machine) configured for
> VGA PCI Pass-through without an attached physical monitor, keyboard or mouse. 
> This is the final step required to move
> away from dual booting with other operating systems for legacy programs that 
> require high performance graphics.

It an extremly useful software for these kinds of setups. And in combination 
with software such as barrier (which was recently added to the repos) it makes 
VFIO a basically flawless experience.

Happy new year,
Lennart



Bug#904765:

2018-12-18 Thread Lennart Weller
And another upstream release before I could find a sponsor.


* Package name : looking-glass
  Packaging link : https://salsa.debian.org/lhw-guest/looking-glass
  Version : 0+a12
  Upstream Author : Geoffrey McRae 
* URL : https://github.com/gnif/LookingGlass
* License : GPL2+
  Programming Lang: C
  Description : An extremely low latency KVM FrameRelay implementation for 
guests with VGA PCI Passthrough



Bug#904765: RFS: looking-glass/0+a11-1

2018-07-27 Thread Lennart Weller
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "looking-glass"

* Package name: looking-glass
  Packaging link  : https://salsa.debian.org/lhw-guest/looking-glass
  Version : 0+a11-1
  Upstream Author : Geoffrey McRae 
* URL : https://github.com/gnif/LookingGlass
* License : GPL2+
  Programming Lang: C
  Description : An extremely low latency KVM FrameRelay implementation for 
guests with VGA PCI Passthrough
Section:: admin

It builds those binary packages:

looking-glass-client - Low latency KVM FrameRelay implementation for 
VGA Passthrough

To access further information about this package, please visit the following 
URL:

https://mentors.debian.net/package/looking-glass

Alternatively, one can download the package with dget using this command:

dget -x 
https://mentors.debian.net/debian/pool/main/l/looking-glass/looking-glass_0+a11-1.dsc

Regards,
 Lennart Weller



Bug#807310: RFS: network-manager-ssh/0.9.4-1 [ITP] - ssh vpn for network manager

2015-12-08 Thread Lennart Weller
> Examples of what I mean: dz.po ug.po sl.po ro.po ps.po pa.po nb.po

The files still contain the author information in the po header.
They are just missing in the  file header. I'll report it upstream anyway
so he can add the information to the file header.

> It isn't about scientific references, that is a common misconception.
> 
> At least these fields are probably applicable:
> 
> Bug-*
> Changelog
> Contact
> Name
> Repository
> Repository-Browse
> Screenshots
> Security-Contact

Yes. Those fields can be filled out, but technically the information is 
already available in debian/control and debian/copyright. Especially in cases 
of Github and other code hosting sites most of these entries would be the same. 
I added it anyway as it doesn't really require that much extra work in the end.

Well. Thanks again. I have some upstream reporting to do now to get this package
into better state, though I think it's already in a good enough state for debian
as of now.

Lennart



Bug#807310: RFS: network-manager-ssh/0.9.4-1 [ITP] - ssh vpn for network manager

2015-12-08 Thread Lennart Weller
Thank you for the extensive review. I went through your suggestions/comments 
and either fixed them or mentioned them here.

> I don't think the package descriptions should describe NetworkManager,
> that is a job for the network-manager package description. Instead,
> they should describe the network-manager-ssh packages.

I know it's weird and somewhat unusual but all the other nm plugins do the 
same. So I went with it:
http://anonscm.debian.org/cgit/pkg-utopia/network-manager-openvpn.git/tree/debian/control
http://anonscm.debian.org/cgit/pkg-utopia/network-manager-pptp.git/tree/debian/control
http://anonscm.debian.org/cgit/pkg-utopia/network-manager-vpnc.git/tree/debian/control

> It would be great if there were a DEP-8 test:
> 
> http://dep.debian.net/deps/dep8
> http://ci.debian.net

This would definitely be a nice-to-have but it would require a decent test in 
the source package or writing one myself. As of now the test under test/ really
doesn't do much. It basically just setups the env to actually start testing. 
So I'd say its more of a long term goal.

> I always wonder if screenshots like images/*.png should be generated
> at build time so they never get out of date.

Screenshots don't change all that often and even if they are slightly 
out-of-date 
most people won't care. I'd say many just check the screenshots to check if its
a GTK1 application last maintained in the 90s.

> I wonder what "PCF" in the icon means, probably it would be better to
> have "SSH" in there?

The icon seems to be from nm-pptp. But even there it doesn't really make sense.
So I guess the icon went x -> pptp -> openvpn -> ssh. 

> Upstream's po files look like they have poorly maintained or
> unmaintained copyright headers.

Most of them seem alright to me. A few have missing source package information 
but that information is available in debian/copyright anyhow. The translators 
seem
to be attributed in all of them.

> Upstream's test suite is using an IP address belonging to the USA
> Department of Defence. I would strongly suggest using a proper private
> IP address according to RFC 6761.
> 
> http://tools.ietf.org/html/rfc6761

inetnum:1.1.1.0 - 1.1.1.255
netname:APNIC-LABS
descr:  Research prefix for APNIC Labs
address:South Brisbane, QLD 4101
address:Australia
e-mail: ab...@apnic.net

I know you are not supposed to use these. But the test is not executed and 
won't be unless upstream changes it as it is useless right now.

> Please add some upstream metadata:
> 
> https://wiki.debian.org/UpstreamMetadata

Following the links on the page it seems to be mostly used by scientific 
libraries to reference algorithms used in the packages. All the basic 
repository/issue/copyright information is already present in other files
in my current version.

> Automated checks:
> 
> check-all-the-things:
> $ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not
> find or open any of the paths given.'
> [properties/nm-ssh.c:1287]: (error) Possible null pointer dereference: gateway
> [properties/nm-ssh.c:1289]: (error) Possible null pointer dereference: 
> remote_ip
> [properties/nm-ssh.c:1290]: (error) Possible null pointer dereference: 
> local_ip
> [properties/nm-ssh.c:1291]: (error) Possible null pointer dereference: netmask
> [properties/nm-ssh.c:1316]: (error) Possible null pointer dereference:
> preferred_authentication
> $ flawfinder -Q -c .
> 

I'll report these upstream as these check seems to be of valid concern.
Not security wise but to avoid errors.

Thanks again,

Lennart Weller



Bug#807310: RFS: network-manager-ssh/0.9.4-1 [ITP] - ssh vpn for network manager

2015-12-07 Thread Lennart Weller
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "network-manager-ssh"

 * Package name: network-manager-ssh
   Version : 0.9.4-1
   Upstream Author : Dan Fruehauf 
 * URL : https://github.com/danfruehauf/NetworkManager-ssh
 * License : GPL-2+
   Section : net

It builds those binary packages:
network-manager-ssh - network management framework (SSH plugin core)
network-manager-ssh-gnome - network management framework (SSH plugin 
GNOME GUI)

To access further information about this package, please visit the following 
URL:
http://mentors.debian.net/package/network-manager-ssh

Alternatively, one can download the package with dget using this command:
dget -x 
http://mentors.debian.net/debian/pool/main/n/network-manager-ssh/network-manager-ssh_0.9.4-1.dsc

More information about hello can be obtained from 
https://github.com/danfruehauf/NetworkManager-ssh

Changes since the last upload:
  * Initial release. (Closes: #725396)

Regards,
 Lennart Weller



Bug#806311: RFS: s3backer/1.4.2-1 [ITP]

2015-11-26 Thread Lennart Weller
Hey again,

> Please help to update the license file for s3backer.spec.in.

I added the license information to the copyright file. As it is not part
of the final binary or included in the package itself there should be no
license compatibility issues between the GPLv2 source and this APL-2
documentation file.

Lennart



Bug#806311: RFS: s3backer/1.4.2-1 [ITP]

2015-11-26 Thread Lennart Weller
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "s3backer"

* Package name: s3backer
  Version : 1.4.2-1
  Upstream Author : Archie L. Cobbs 
* URL : https://github.com/archiecobbs/s3backer
* License : GPL-2+ with OpenSSL exception
  Section : misc

It builds those binary packages:
s3backer   - Amazon AWS S3-backed virtual hard disk device

To access further information about this package, please visit the following 
URL:
http://mentors.debian.net/package/s3backer

Alternatively, one can download the package with dget using this command:
dget -x 
http://mentors.debian.net/debian/pool/main/s/s3backer/s3backer_1.4.2-1.dsc

More information about s3backer can be obtained from 
https://github.com/archiecobbs/s3backer

Changes since the last upload:
  * Initial release.

Regards,
 Lennart Weller