Bug#876027: RFS: libcgicc/3.2.19-0.2 [NMU] -- C++ class library for writing CGI applications

[Thomas Pircher]

On 2017-09-17 20:59, Gianfranco Costamagna wrote:

BTW the only patch the package is carrying at this moment, has been
created to make the package multiarch. So, moving the configurator
outside usr/bin, will make the patch even useless.


Hi,

yes, you have a good point there...
I have uploaded a new version that just removes the -fdebug-prefix-map 
option from the old-style config file.


Let me know if there are any other problems.

Thanks,
Thomas

Bug#876027: RFS: libcgicc/3.2.19-0.2 [NMU] -- C++ class library for writing CGI applications

[Thomas Pircher]

On 2017-09-17 16:14, Andrey Rahmatullin wrote:

On Sun, Sep 17, 2017 at 02:59:48PM +, Gianfranco Costamagna wrote:

hello, I find this approach a little bit too invasive

-cxxflags="-Wall -W -pedantic -g -O2 
-fdebug-prefix-map=/build/libcgicc-GEfIf8/libcgicc-3.2.19=. 
-fstack-protector-strong -Wformat -Werror=format-security"
+cxxflags="-Wall -W -pedantic -g -O2 
-fdebug-prefix-map=/build/libcgicc-pUjh6F/libcgicc-3.2.19=. 
-fstack-protector-strong -Wformat -Werror=format-security"


What's that? Have you diffed the build logs instread of the source
packages?


This is the diff of /usr/bin/cgicc-config between packages from 
different architectures (or possibly between two different builds?).
That's why #874225 was raised: the libcgicc-dev package had this 
conflicting file for multi-arch.


I'll try to get the debug-prefix-map removed from the cgicc-config file 
and will do a new upload to mentors.


Cheers,
Thomas

Bug#876027: RFS: libcgicc/3.2.19-0.2 [NMU] -- C++ class library for writing CGI applications

[Thomas Pircher]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "libcgicc"

* Package name: libcgicc
  Version : 3.2.19-0.2
  Upstream Author : Sebastien Diaz <sebastien.d...@gmail.com>
* URL : http://www.gnu.org/software/cgicc/
* License : GPL-2+
  Section : libs

It builds those binary packages:

  libcgicc-dev - C++ class library for writing CGI applications 
(development files
  libcgicc-doc - C++ class library for writing CGI applications 
(documentation)

  libcgicc3  - C++ class library for writing CGI applications (library)

To access further information about this package, please visit the 
following URL:

https://mentors.debian.net/package/libcgicc


Alternatively, one can download the package with dget using this 
command:


  dget -x 
https://mentors.debian.net/debian/pool/main/libc/libcgicc/libcgicc_3.2.19-0.2.dsc


More information about cgicc can be obtained from 
http://www.gnu.org/software/cgicc/.


Changes since the last upload:

  * Non-maintainer upload.
  * Updated to Standards-Version 4.1.0 (no changes required).
  * Move the old-style config file to the multi-arch directory under 
/usr/lib

(Closes: #874225).

I have deferred the package by 10 days to give the maintainer the 
opportunity to intervene, should he wish to do so.


Regards,
 Thomas Pircher

Bug#866046: closed by Gianfranco Costamagna <locutusofb...@debian.org> (Re: Bug#866046: RFS: libcgicc/3.2.18-0.1 NMU)

[Thomas Pircher]

On 2017-06-28 12:36, ow...@bugs.debian.org wrote:

#866046: RFS: libcgicc/3.2.19-0.1 NMU

It has been closed by Gianfranco Costamagna .


Hi Gianfranco,

I meant to write a short mail for this upload, but you found it 
already...

Thanks for doing the reviews!

Thomas

Bug#866046: RFS: libcgicc/3.2.18-0.1 NMU

[Thomas Pircher]

On 2017-06-27 06:59, Gianfranco Costamagna wrote:

Adam Borowski wrote:


Please get an ok from the maintainer.


this is true in general, unfortunately Chrisb is inactive since one 
year or so,

and his last upload is around 5 years ago.


Hi Adam, Gianfranco,

thanks for looking into this. Apologies for not including the maintainer 
in the original mail, it wasn't intentional. Deferring the packet is 
probably a wise move to give the maintainer an opportunity to step in (I 
consider that unlikely, to be honest), should you consider going ahead 
with the review.


Should I re-upload this package with a high deferred number or can this 
be done from mentors?



BTW all of the diff, except for ~100 lines is about autotools
autogenerated stuff :)


Yes, the actual diff in the source code is much smaller than the 400 
kloc. Unfortunately this release tar ball contains a lot of 
autogenerated stuff, in addition to full a archive of the previous 
release. I considered removing some files in a patch, but that would 
have increased the total change rather than reducing it.


As far as I can see the changes in the source code since the last 
package are listed below. The latter two bugs were previously patched in 
the Debian package; these patches are now incorporated upstream, hence I 
could drop them from the Debian package.


bug #49557: XHTMLDoctype.h fails to include MStreamable.h
http://savannah.gnu.org/bugs/index.php?49557

bug #49120: cgicc should not call exit()
http://savannah.gnu.org/bugs/index.php?49120

bug #48677: Generated index.html is empty
http://savannah.gnu.org/bugs/index.php?48677

bug #46426: Pkg-config file does not provide flags for include path or 
the library itself

http://savannah.gnu.org/bugs/index.php?46426

Thanks,
Thomas

Bug#866046: RFS: libcgicc/3.2.18-0.1 NMU

[Thomas Pircher]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "libcgicc"

* Package name: libcgicc
  Version : 3.2.18-0.1
  Upstream Author : Sebastien Diaz <sebastien.d...@gmail.com>
* URL : http://www.gnu.org/software/cgicc/
* License : GPL-2+
  Section : libs

It builds those binary packages:

libcgicc-dev - C++ class library for writing CGI applications 
(development files
libcgicc-doc - C++ class library for writing CGI applications 
(documentation)
libcgicc3  - C++ class library for writing CGI applications 
(library)


To access further information about this package, please visit the 
following URL:


https://mentors.debian.net/package/libcgicc


Alternatively, one can download the package with dget using this 
command:


dget -x 
https://mentors.debian.net/debian/pool/main/libc/libcgicc/libcgicc_3.2.18-0.1.dsc


More information about cgicc can be obtained from 
http://www.gnu.org/software/cgicc/.


Changes since the last upload:

  * New upstream release.
- fixes include statement for MStreamable.h. (Closes: #865275).
- upstream includes patches for pkgconfig file and empty index.html.
  * Updated to Standards-Version 4.0.0 (no changes required).


Regards,
 Thomas Pircher

Re: Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications

[Thomas Pircher]

On 2016-10-17 08:07, Gianfranco Costamagna wrote:

Hi all
changed something and sponsored in deferred/12


Thanks, this has been a good learning experience.
Also thanks for fixing the bug references!

Thomas

Re: Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications

[Thomas Pircher]

On 2016-10-16 10:00, Gianfranco Costamagna wrote:
dh_auto_configure already injects some flags such as libdir and 
multiarch stuff

it would be nice to remove them
[..]
Also, please take the opportunity to fix the changelog as josch
pointed out :)


Hi Gianfranco and Johannes,

the issues you mentioned should be now fixed in the last update on 
mentors.


Thanks,
Thomas

Re: Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications

[Thomas Pircher]

On 2016-10-15 12:35, Gianfranco Costamagna wrote:

BTW for a next update would be nice to consider using dh_auto_configure
instead of directly calling ./configure


Hi Gianfranco,

I have uploaded a new version to mentors with the two changes you 
mentioned in your mails today:

- Using dh_auto_configure instead of calling ./configure directly.
- Removed the Replaces and Conflicts directive for the binary package.

Use this package if you deem those changes worth the hassle of 
re-uploading the package to deferred/15. If not, then I'm happy to keep 
the changes for the next time I need to update the cgicc package.


Thanks,
Thomas

Re: Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications

[Thomas Pircher]

On 2016-10-11 22:22, Gianfranco Costamagna wrote:

I see you forgot to probably run dh_clean
(I see debian/autoreconf.before and debian/autoreconf.after files)


D'oh. They were leftovers from a previous build and are gone now.


and I still see a libcgicc3-dev package (instead of libcgicc-dev)


Yes, that was my mistake; I misunderstood your suggestion and made 
libcgicc-dev a virtual package.
The last update on mentors now consists of libcgicc3, libcgicc-dev and 
libcgicc-doc.


Thanks,
Thomas

Re: Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications

[Thomas Pircher]

On 2016-10-11 16:18, Gianfranco Costamagna wrote:

let me know that last two bits and I'll probably sponsor in deferred/10
(due to the high changes number)
(Adding Chris to the loop, in case he as maintainer has a different 
opinion)


Hi Gianfranco,

I have uploaded a new package to mentors, with the two outstanding 
issues fixed.


Thanks again for your patient and thorough reviews!
Thomas

Re: Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications

[Thomas Pircher]

Hi Gianfranco,

I missed to add you and 837...@bugs.debian.org in my last mail. In the 
upload to mentors from last week I have addressed your feedback (at 
least I think I did, that is). The only thing I'm not entirely sure 
about is the missing build-dependency on pkg-config as build-dependency, 
as described below.


Cheers,
Thomas

On 2016-10-02 18:07, Thomas Pircher wrote:

On 2016-09-28 22:37, Gianfranco Costamagna wrote:

[..] drop the explicit dependencies since dh-autoreconf already
depends on automake and libtool? If this is the customary way then 
I'll

drop the explicit dependencies on automake and libtool.


I think so. dh-autoreconf should be enough (with an added pkg-config 
if needed,

IIRC)


Hi Gianfranco,

automake and libtool are no longer explicit dependencies in my latest
upload to mentors [1]. But I haven't added pkg-config. It is not
required for building libcgicc and I could not find a mention of
pkg-config in the dh-autoreconf documentation. But if I'm missing
something than I'll be happy to add the build dependency.

I think patching it to be architecture independent might be the best 
solution


Thanks for that. I had not appreciated that packages may contain
bit-identical files. That does indeed solve my problem, and I have
patched out the --host and --libdir options and re-added the script to
the package.

Thanks again for your continuing efforts!

Thomas


[1] https://mentors.debian.net/package/libcgicc

Re: Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications

[Thomas Pircher]

On 2016-09-28 22:37, Gianfranco Costamagna wrote:

[..] drop the explicit dependencies since dh-autoreconf already
depends on automake and libtool? If this is the customary way then 
I'll

drop the explicit dependencies on automake and libtool.


I think so. dh-autoreconf should be enough (with an added pkg-config if 
needed,

IIRC)


Hi Gianfranco,

automake and libtool are no longer explicit dependencies in my latest 
upload to mentors [1]. But I haven't added pkg-config. It is not 
required for building libcgicc and I could not find a mention of 
pkg-config in the dh-autoreconf documentation. But if I'm missing 
something than I'll be happy to add the build dependency.


I think patching it to be architecture independent might be the best 
solution


Thanks for that. I had not appreciated that packages may contain 
bit-identical files. That does indeed solve my problem, and I have 
patched out the --host and --libdir options and re-added the script to 
the package.


Thanks again for your continuing efforts!

Thomas


[1] https://mentors.debian.net/package/libcgicc

Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications

[Thomas Pircher]

On 2016-09-18 19:11, Thomas Pircher wrote:

Thinking again, I guess that's not correct. This would require the
packages to be renamed to libcgicc3.


Hi,

I have uploaded a new build to debian mentors for further review.
https://mentors.debian.net/package/libcgicc

This build should address the issues raised on my previous upload, 
modulo mistakes and misinterpretations on my side.
This version does rename the libraries to libcgicc3 (from libcgicc5), 
replacing and conflicting with the previous name.


Thanks,
Thomas

Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications

[Thomas Pircher]

On 2016-09-18 17:39, Thomas Pircher wrote:

W: libcgicc5: package-name-doesnt-match-sonames libcgicc3


This should be fixed by the renaming from libcgicc5* -> libcgicc*.


Thinking again, I guess that's not correct. This would require the 
packages to be renamed to libcgicc3.


Thomas

Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications

[Thomas Pircher]

On 2016-09-15 10:49, Gianfranco Costamagna wrote:

changes are huge, but being half mia, and on lowNMU threshold...
(and too many bugs here, so lets do it)


First of all, thanks for the detailed review.
I have addressed most issues but not yet uploaded a new version to 
mentors, pending a couple of questions.



1) have patches been upstreamed?


Patch 0001 (pkg-config change) comes from the upstream bug tracker and 
patch 0002 (empty index.html) has been upstreamed.
Patch 0003 (removal of /usr/bin/cgicc-config, see also below, point 7) 
is not, since I see this as a packaging issue rather than an upstream 
problem.



2) patch description might be nice
3) d/p/003-no-old-style-config.patch
So, in case please patch Makefile.am
4) automake, libtool, doxygen, dh-autoreconf
doxygen might be needed only for arch:all builds, so you might want to 
move

it into Build-Depends-Indep


Fair points, my next upload to mentors will fix these.


5) automake, libtool, are them useful?


They are both used in the build. But if I understand you right, are you 
suggesting to drop the explicit dependencies since dh-autoreconf already 
depends on automake and libtool? If this is the customary way then I'll 
drop the explicit dependencies on automake and libtool.



6) new files
diff -Nru libcgicc-3.2.9/debian/libcgicc-dev.dirs
diff -Nru libcgicc-3.2.9/debian/libcgicc-dev.install

why?


Uh, these files are not needed and are leftovers from my experiments 
with a multi-arch library and will be removed in my next upload.



7) /usr/bin/cgicc-config
this was shipped before, why are you removing it?


This file is made obsolete by the pkg-config file, and it was creating a 
problem for multiarch packages: it would install in 
/usr/bin/cgicc-config, making it impossible to install two architectures 
of this package.

Also, https://lintian.debian.org/tags/old-style-config-script.html says:

| Using this kind of system to pass compile file is obsolete and will 
likely introduce bugs in a multi-arch system.
| Particularly, this kind of script could only belong to a package that 
is not Multi-Arch.


So I took this as excuse to remove the file from the package.

One possible solution (suggested by lintian) is to move the file out of 
the way (to /usr/share/doc, I presume) so it is still shipped, but it 
won't be found by build tools, which kind of defeats its purpose. I'm 
doubtful there is any benefit in shipping this file.



8) library changed soname?
from libcgicc.so.5.0.2 to libcgicc.so.3.2.10


As far as I can see from the CVS changes, the 'current' value in the 
soname was increased in the early 2000's, presumably due to ABI changes. 
Then in 2013 the soname was decreased from 5 to 3 in order to match the 
library version. This was done as part of these bugs:


https://savannah.gnu.org/bugs/?func=detailitem_id=38053
https://savannah.gnu.org/bugs/?func=detailitem_id=38224

I presume the package should follow the upstream soname. And this would 
probably also justify the renamed package, as you were musing in your 
mail. If there are no objections, I will rename the packages from 
libcgicc5 to libcgicc.



W: libcgicc5: package-name-doesnt-match-sonames libcgicc3


This should be fixed by the renaming from libcgicc5* -> libcgicc*.

X: libcgicc5: shlib-calls-exit 
usr/lib/x86_64-linux-gnu/libcgicc.so.3.2.10 (^^ this is something for 
upstream)


Raised as https://savannah.gnu.org/bugs/index.php?49120

Thanks,
Thomas

Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU --

[Thomas Pircher]

Package: sponsorship-requests
Severity: normal

Dear mentors,

having been unsuccessful in contacting the maintainer of this package 
and after
having consulted m...@debian.org, I am looking for a sponsor for the 
package

"libcgicc"

 * Package name: libcgicc
   Version : 3.2.16-0.1
   Upstream Author : Sebastien Diaz <sebastien.d...@gmail.com>
 * URL : https://www.gnu.org/software/cgicc/
 * License : LGPL-3+, GFDL-1.1+ for documentation
   Section : libs

It builds those binary packages:

libcgicc-doc - C++ class library for writing CGI applications 
(documentation)
libcgicc5  - C++ class library for writing CGI applications 
(library)
libcgicc5-dev - C++ class library for writing CGI applications 
(development files


To access further information about this package, please visit the 
following URL:


https://mentors.debian.net/package/libcgicc


Alternatively, one can download the package with dget using this 
command:


  dget -x 
https://mentors.debian.net/debian/pool/main/libc/libcgicc/libcgicc_3.2.16-0.1.dsc


More information about libcgicc can be obtained from 
https://savannah.gnu.org/p/cgicc


Changes since the last upload:

  * Non-maintainer upload.
  * New upstream release (closes: #833081, #811988, #798624, #645616).
  * Updated to Standards-Version 3.9.8 (no changes required).
  * Updated to debhelper 9, updated Build-Depends.
  * Added Multiarch support.
  * Updated debian/*.install and removed the install directory where 
source and

destination directories are the same.
  * Added patch to generate non-empty index.html in the documentation.
  * Removed old-style config file.
  * Commented out the broken Vcs URLs in debian/control.

Regards,
 Thomas Pircher