Bug#1034282: RFS: ukui-app-widget/1.0.1-1 [ITP] -- ukui app widget test
Hi, Boyuan, Sorry for this rookie, stupid mistake, Bowen only checked the results of 'lintian' and 'licensecheck -r' when reviewing the package, not the other parts, including the incorrect copyright statement. And I also confirmed the problem with the upstream author, when she took over the code, the headers of some files in QtSingleApplication have been accidentally blanked out, and she added the company's copyrights without checking in order to deal with the "No copyright Unknow" warnings. The problem has been fixed upstream, and we'll improve the guidebook and training to avoid this kind of problem from occurring again. > Your package embeds multiple copies of QtSimpleApplication. This is not a good > practice at all. Can you work with upstream to only include one copy? This is fixed upstream. > Besides, I don't understand upstream commit 2e15e13. Can you explain why you > revert version 4.x to 1.0.1? Yes, It's no need to revert version 4.x to 1.0.1, we will upload the fixed version to mentors later. Regards, handsome_feng
Bug#1034282: RFS: ukui-app-widget/1.0.1-1 [ITP] -- ukui app widget test
Control: tags -1 +moreinfo Hi, On Thu, 13 Apr 2023 01:11:05 +0800 xibowen wrote: > Package: sponsorship-requests > Severity: wishlist > > Dear mentors, > > I am looking for a sponsor for my package "ukui-app-widget": > https://mentors.debian.net/package/ukui-app-widget/ > > Alternatively, you can download the package with 'dget' using this command: > > dget -x https://mentors.debian.net/debian/pool/main/u/ukui-app-widget/ukui- > app-widget_1.0.1-1.dsc Several issues: * Your package embeds multiple copies of QtSimpleApplication. This is not a good practice at all. Can you work with upstream to only include one copy? * All QtSimpleApplication source code files have executable permission. Please consider fixing it upstream as well. * Your debian/copyright file did not include copyright information for most QtSimpleApplication source code files. Please fix it. Thanks, Boyuan Yang signature.asc Description: This is a digitally signed message part
Bug#1034282: RFS: ukui-app-widget/1.0.1-1 [ITP] -- ukui app widget test
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "ukui-app-widget": * Package name : ukui-app-widget Version : 1.0.1-1 Upstream contact : wangyan * URL : https://gitee.com/openkylin/ukui-app-widget * License : BSD-3-clause, GPL-3 * Vcs : https://gitee.com/openkylin/ukui-app-widget Section : x11 The source builds the following binary packages: libukui-appwidget-manager-dev - libukui app widget manager dev libukui-appwidget-manager0 - libukui app widget manager libukui-appwidget-provider-dev - libukui app widget provider dev libukui-appwidget-qmlplugin0 - ukui app widget plugin libukui-appwidget-provider0 - libukui app widget provider ukui-appwidget-manager - ukui app widget manager ukui-appwidget-test - ukui app widget test To access further information about this package, please visit the following URL: https://mentors.debian.net/package/ukui-app-widget/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/u/ukui-app-widget/ukui- app-widget_1.0.1-1.dsc Changes for the initial release: ukui-app-widget (1.0.1-1) unstable; urgency=medium . * Initial release. (Closes: #1034274) Regards, -- xibowen
