Bug#1059503: RFS: blanket/0.6.0-1 [RFP] -- listen to relaxing sounds

[Matthias Geiger]

Hi Danial,

once I become a DD (which is hopefully by the end of this month) I will 
sponsor this upload.


best,


--
Matthias Geiger 
Debian Maintainer

Bug#1059503: RFS: blanket/0.6.0-1 [RFP] -- listen to relaxing sounds

[Matthias Geiger]

On Tue, 09 Apr 2024 18:06:08 + Danial Behzadi 
 wrote:

> New version (0.7.0) has been released yesterday and it's now updated in
> salsa and mentors.
> Please take a look there:
>
>
> * Package name : blanket
> Version : 0.7.0-1
> Upstream contact : Rafael Mardojai CM 
> * URL : https://github.com/rafaelmardojai/blanket
> * License : CC-BY-SA-3.0, CC-BY-1.0, CC-BY-3.0, GPL-3+,
> Public-Domain, CC0-1.0, CC-BY-4.0
> * Vcs : https://salsa.debian.org/danialbehzadi/blanket
> Section : utils
>
> The source builds the following binary packages:
>
> blanket - Listen to relaxing sounds
>
> To access further information about this package, please visit the
> following URL:
> https://mentors.debian.net/package/blanket/
>
> Alternatively, you can download the package with 'dget' using this
> command:
>
> dget -x
> https://mentors.debian.net/debian/pool/main/b/blanket/blanket_0.7.0-1.dsc
>
> Changes for the initial release:
>
> blanket (0.7.0-1) unstable; urgency=medium
> .
> * Initial packaging. (Closes: #1053209)
>
> Regards,
> --
> Danial Behzadi
>

>

Hi Danial,


thanks  for your work. Looks good to me so far. I CC'd Jeremy so he can 
weigh in and upload then hopefully as I am no  DD (yet).


best,

--
Matthias Geiger 
Debian Maintainer



OpenPGP_0x18BD106B3B6C5475.asc
Description: OpenPGP public key


OpenPGP_signature.asc
Description: OpenPGP digital signature

Bug#1059503: RFS: blanket/0.6.0-1 [RFP] -- listen to relaxing sounds

[Danial Behzadi]

New version (0.7.0) has been released yesterday and it's now updated in
salsa and mentors.
Please take a look there:


 * Package name : blanket
   Version  : 0.7.0-1
   Upstream contact : Rafael Mardojai CM 
 * URL  : https://github.com/rafaelmardojai/blanket
 * License  : CC-BY-SA-3.0, CC-BY-1.0, CC-BY-3.0, GPL-3+,
Public-Domain, CC0-1.0, CC-BY-4.0
 * Vcs  : https://salsa.debian.org/danialbehzadi/blanket
   Section  : utils

The source builds the following binary packages:

  blanket - Listen to relaxing sounds

To access further information about this package, please visit the
following URL:
  https://mentors.debian.net/package/blanket/

Alternatively, you can download the package with 'dget' using this
command:

  dget -x
https://mentors.debian.net/debian/pool/main/b/blanket/blanket_0.7.0-1.dsc

Changes for the initial release:

 blanket (0.7.0-1) unstable; urgency=medium
 .
   * Initial packaging. (Closes: #1053209)

Regards,
-- 
  Danial Behzadi

Bug#1059503: RFS: blanket/0.6.0-1 [RFP] -- listen to relaxing sounds

[Danial Behzadi]

The best solution is here to add the train sound under a slightly 
different name then and patch the source accordingly.
Ok. I did change the name and the new version is up in salsa and 
mentors.


--
Danial Behzadi

در دوشنبه, فوریه 26 2024 at ۲۳:۰۸:۵۸ +01:00:00, 
Matthias Geiger  نوشته بود:

On Mon, 26 Feb 2024 16:08:57 +0330 Danial Behzadi
mailto:dani.be...@ubuntu.com>> wrote:
> Thanks for clarifying. I added the comment, but the Files-Excluded 
part
> will trigger a source-ships-excluded-file error, as I replaced the 
old


> non-free file with a new free one in DFSG source branch.

Ah, I see. The best solution is here to add the train sound under a
slightly different name then and patch the source accordingly. This 
way

you can still import the dfsg'd tarballs. Let me know if you need help
with this.

--

Matthias Geiger 
Debian Maintainer
"Freiheit ist immer Freiheit des anders Denkenden" -- Rosa Luxemburg

Bug#1059503: RFS: blanket/0.6.0-1 [RFP] -- listen to relaxing sounds

[Matthias Geiger]

On Mon, 26 Feb 2024 16:08:57 +0330 Danial Behzadi 
 wrote:

> Thanks for clarifying. I added the comment, but the Files-Excluded part
> will trigger a source-ships-excluded-file error, as I replaced the old

> non-free file with a new free one in DFSG source branch.

Ah, I see. The best solution is here to add the train sound under a 
slightly different name then and patch the source accordingly. This way 
you can still import the dfsg'd tarballs. Let me know if you need help 
with this.


--

Matthias Geiger 
Debian Maintainer
"Freiheit ist immer Freiheit des anders Denkenden" -- Rosa Luxemburg



OpenPGP_0x18BD106B3B6C5475.asc
Description: OpenPGP public key


OpenPGP_signature.asc
Description: OpenPGP digital signature

Bug#1059503: RFS: blanket/0.6.0-1 [RFP] -- listen to relaxing sounds

[Danial Behzadi]

Thanks for clarifying. I added the comment, but the Files-Excluded part 
will trigger a source-ships-excluded-file error, as I replaced the old 
non-free file with a new free one in DFSG source branch.


در یکشنبه, فوریه 25 2024 at ۱۳:۱۳:۱۳ +01:00:00, 
Matthias Geiger  نوشته بود:

Am 25.02.24 um 03:04 schrieb Danial Behzadi:

Hi Danial.

Hey


The watch file does not repack the source; do it like this:

version=4
opts=\
repacksuffix=+dfsg,\
repack,compression=gz,\
dversionmangle=s/\+(dfsg)(\.\d+)?$//,\
filenamemangle=s/.*\/v?([\d\.-]+)\.tar\.gz

...

Done in the new version on Salsa and mentors.


Minor nitpick: I would add a Comment: for each sound file with the
freesound url from sound_licensing.md.
I already did that for train.ogg in d/copyright. Is there anything 
else

I should do?


d/copyright is missing a Files-Excluded: section specifying the
train.ogg file. Otherwise, the repack does not work.

I would add a Comment: under each sound file stating the freesound url
so ftpmasters can review it faster.

Apart from that it looks good. Maybe  ask jbicha to create a blanket
repo under the gnome-team umbrella if you want to team-maintain it.

--
Matthias Geiger 
Debian Maintainer
"Freiheit ist immer Freiheit des anders Denkenden" -- Rosa Luxemburg

Bug#1059503: RFS: blanket/0.6.0-1 [RFP] -- listen to relaxing sounds

[Matthias Geiger]

Am 25.02.24 um 03:04 schrieb Danial Behzadi:

Hi Danial.

Hey


The watch file does not repack the source; do it like this:

version=4
opts=\
repacksuffix=+dfsg,\
repack,compression=gz,\
dversionmangle=s/\+(dfsg)(\.\d+)?$//,\
filenamemangle=s/.*\/v?([\d\.-]+)\.tar\.gz

...

Done in the new version on Salsa and mentors.


Minor nitpick: I would add a Comment: for each sound file with the
freesound url from sound_licensing.md.

I already did that for train.ogg in d/copyright. Is there anything else
I should do?

d/copyright is missing a Files-Excluded: section specifying the 
train.ogg file. Otherwise, the repack does not work.


I would add a Comment: under each sound file stating the freesound url 
so ftpmasters can review it faster.


Apart from that it looks good. Maybe  ask jbicha to create a blanket 
repo under the gnome-team umbrella if you want to team-maintain it.


--
Matthias Geiger 
Debian Maintainer
"Freiheit ist immer Freiheit des anders Denkenden" -- Rosa Luxemburg



OpenPGP_0x18BD106B3B6C5475.asc
Description: OpenPGP public key


OpenPGP_signature.asc
Description: OpenPGP digital signature

Bug#1059503: RFS: blanket/0.6.0-1 [RFP] -- listen to relaxing sounds

[Danial Behzadi]

> Hi Danial. 
Hey

> The watch file does not repack the source; do it like this: 
> 
> version=4
> opts=\
> repacksuffix=+dfsg,\
> repack,compression=gz,\
> dversionmangle=s/\+(dfsg)(\.\d+)?$//,\
> filenamemangle=s/.*\/v?([\d\.-]+)\.tar\.gz
> 
> ...
Done in the new version on Salsa and mentors.

> Minor nitpick: I would add a Comment: for each sound file with the
> freesound url from sound_licensing.md. 
I already did that for train.ogg in d/copyright. Is there anything else
I should do?

sincerely,
--
Danial Behzadi

Bug#1059503: RFS: blanket/0.6.0-1 [RFP] -- listen to relaxing sounds

[Matthias Geiger]

On Thu, 18 Jan 2024 18:26:43 +0330 Danial Behzadi 
 wrote:

> Thanks for your recommendations.
> There is new upload in mentors and the salsa is updated too:
>
> در سه‌شنبه, ژانویه 2 2024 at ۱۴:۱۵:۵۹ -05:00:00,
> Jeremy Bícha  نوشته بود:
> > Thank you very much for working on this package. Here are some
> > recommended improvements:
> >
> > According to the links in SOUNDS_LICENSING.md :
> >
> > 1. city is CC-BY-3.0
> >
> > 2. white noise is CC-BY-3.0

> >

Hi Danial.

The watch file does not repack the source; do it like this:

**

*version=4 opts=\ repacksuffix=+dfsg,\ repack,compression=gz,\ 
dversionmangle=s/\+(dfsg)(\.\d+)?$//,\ 
filenamemangle=s/.*\/v?([\d\.-]+)\.tar\.gz ... *


**

Minor nitpick: I would add a Comment: for each sound file with the 
freesound url from sound_licensing.md.



best,


werdahias

Bug#1059503: RFS: blanket/0.6.0-1 [RFP] -- listen to relaxing sounds

[Danial Behzadi]

Thanks for your recommendations.
There is new upload in mentors and the salsa is updated too:

* Package name : blanket
  Version  : 0.6.0+dfsg-1
  Upstream contact : Rafael Mardojai CM 
* URL  : 
* License  : Public-Domain, CC-BY-1.0, CC-BY-4.0, GPL-3+, 
CC-BY-SA-3.0, CC0-1.0, CC-BY-3.0

* Vcs  : 
  Section  : utils

The source builds the following binary packages:

 blanket - Listen to relaxing sounds

To access further information about this package, please visit the 
following URL:


 

Alternatively, you can download the package with 'dget' using this 
command:


 dget -x 



Changes for the initial release:

blanket (0.6.0+dfsg-1) unstable; urgency=medium
.
  * Initial packaging. (Closes: #1053209)

Regards,
--
 Danial Behzadi

در سه‌شنبه, ژانویه 2 2024 at ۱۴:۱۵:۵۹ -05:00:00, 
Jeremy Bícha  نوشته بود:

Thank you very much for working on this package. Here are some
recommended improvements:

According to the links in SOUNDS_LICENSING.md :

1. city is CC-BY-3.0

2. white noise is CC-BY-3.0

3. pink noise links to the Spanish wikipedia page. But here's the
English version:

which says that the file is licensed as CC-BY-3.0 or
GFDL-1.2-no-invariants-or-later
It technically also allows the option of earlier CC-BY licenses but I
think we may be able to ignore that in our debian/copyright

4. debian/copyright is easier to review if the files are in 
alphabetical order.


5. Also, you can use the one line license name for the files and then
only include the longer license text once in a separate paragraph to
reduce the length of debian/copyright and improve its readability.
This is mentioned in
 
and

there are many examples in existing Debian packages.

6. data/com.rafaelmardojai.Blanket.metainfo.xml* is licensed CC-BY-1.0

7. blanket/mpris.py has several copyright holders that should be
mentioned in debian/copyright

8. I believe you need to add python3-gi to the Depends list so that
Python gobject-introspection works.

9. I suggest adding this to the end of the package description:

 .
 Blanket is a GNOME Circle app.

Thank you,
Jeremy Bícha

Bug#1059503: RFS: blanket/0.6.0-1 [RFP] -- listen to relaxing sounds

[Jeremy Bícha]

Thank you very much for working on this package. Here are some
recommended improvements:

According to the links in SOUNDS_LICENSING.md :

1. city is CC-BY-3.0

2. white noise is CC-BY-3.0

3. pink noise links to the Spanish wikipedia page. But here's the
English version:
https://en.wikipedia.org/wiki/File:Pink_noise.ogg
which says that the file is licensed as CC-BY-3.0 or
GFDL-1.2-no-invariants-or-later
It technically also allows the option of earlier CC-BY licenses but I
think we may be able to ignore that in our debian/copyright

4. debian/copyright is easier to review if the files are in alphabetical order.

5. Also, you can use the one line license name for the files and then
only include the longer license text once in a separate paragraph to
reduce the length of debian/copyright and improve its readability.
This is mentioned in
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ and
there are many examples in existing Debian packages.

6. data/com.rafaelmardojai.Blanket.metainfo.xml* is licensed CC-BY-1.0

7. blanket/mpris.py has several copyright holders that should be
mentioned in debian/copyright

8. I believe you need to add python3-gi to the Depends list so that
Python gobject-introspection works.

9. I suggest adding this to the end of the package description:

 .
 Blanket is a GNOME Circle app.

Thank you,
Jeremy Bícha

Bug#1059503: RFS: blanket/0.6.0-1 [RFP] -- listen to relaxing sounds

[Danial Behzadi]

I fixed the copyrights an created a DFSG-comaptible version and 
uploaded it to mentors as 0.6.0+dfsg-1:


* Package name : blanket
  Version  : 0.6.0+dfsg-1
  Upstream contact : Rafael Mardojai CM 
* URL  : 
* License  : Public-Domain, CC-BY-4.0, CC-BY-SA-4.0, GPL-3+, 
CC0-1.0, CC-BY-3.0

* Vcs  : 
  Section  : utils

The source builds the following binary packages:

 blanket - Listen to relaxing sounds

To access further information about this package, please visit the 
following URL:


 

Alternatively, you can download the package with 'dget' using this 
command:


 dget -x 



Changes for the initial release:

blanket (0.6.0+dfsg-1) unstable; urgency=medium
.
  * Initial packaging. (Closes: #1053209)

Regards,
--
 Danial Behzadi

در شنبه, دسامبر 30 2023 at ۲۳:۵۳:۵۳ +01:00:00, 
Matthias Geiger  نوشته بود:

On Wed, 27 Dec 2023 05:13:39 +0330 Danial Behzadi
mailto:dani.be...@ubuntu.com>> wrote:
> Package: sponsorship-requests
> Severity: wishlist
>
> Dear mentors,
>
> I am looking for a sponsor for my package "blanket":
>
> * Package name : blanket
> Version : 0.6.0-1
> Upstream contact : Rafael Mardojai CM >

> * URL : <>
> * License : GPL-3+
> * Vcs : <>
> Section : utils
>
> The source builds the following binary packages:
>
> blanket - listen to relaxing sounds
>
> To access further information about this package, please visit the
> following URL:
>
> <>

>

Hi Danial,

blankets sounds are licensed not under the GPL but different CC
licenses. Furthermore, the train sound in 0.6.0 is still not dfsg (see
).

You can look into patching this maybe. Feel free to reach out if you
have any questions.

best,


Matthias Geiger 
Debian Maintainer
"Freiheit ist immer Freiheit des anders Denkenden" -- Rosa Luxemburg

Bug#1059503: RFS: blanket/0.6.0-1 [RFP] -- listen to relaxing sounds

[Matthias Geiger]

On Wed, 27 Dec 2023 05:13:39 +0330 Danial Behzadi 
 wrote:

> Package: sponsorship-requests
> Severity: wishlist
>
> Dear mentors,
>
> I am looking for a sponsor for my package "blanket":
>
> * Package name : blanket
> Version : 0.6.0-1
> Upstream contact : Rafael Mardojai CM 
> * URL : 
> * License : GPL-3+
> * Vcs : 
> Section : utils
>
> The source builds the following binary packages:
>
> blanket - listen to relaxing sounds
>
> To access further information about this package, please visit the
> following URL:
>
> 

>

Hi Danial,

blankets sounds are licensed not under the GPL but different CC 
licenses. Furthermore, the train sound in 0.6.0 is still not dfsg (see 
https://github.com/rafaelmardojai/blanket/issues/297).


You can look into patching this maybe. Feel free to reach out if you 
have any questions.


best,


Matthias Geiger 
Debian Maintainer
"Freiheit ist immer Freiheit des anders Denkenden" -- Rosa Luxemburg



OpenPGP_0x18BD106B3B6C5475.asc
Description: OpenPGP public key


OpenPGP_signature.asc
Description: OpenPGP digital signature

Bug#1059503: RFS: blanket/0.6.0-1 [RFP] -- listen to relaxing sounds

[Danial Behzadi]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "blanket":

* Package name : blanket
  Version  : 0.6.0-1
  Upstream contact : Rafael Mardojai CM 
* URL  : 
* License  : GPL-3+
* Vcs  : 
  Section  : utils

The source builds the following binary packages:

 blanket - listen to relaxing sounds

To access further information about this package, please visit the 
following URL:


 

Alternatively, you can download the package with 'dget' using this 
command:


 dget -x 



Changes for the initial release:

blanket (0.6.0-1) unstable; urgency=medium
.
  * Initial packaging. (Closes: #1053209)

Regards,
--
Danial Behzadi