Bug#661857: RFS: libre-jigsaw/2012.02.25-1 [ITP]

2012-03-02 Thread Ansgar Burchardt
On 03/02/2012 12:33 AM, Jon Hulka wrote:
  dget -x 
 http://mentors.debian.net/debian/pool/main/libr/libre-jigsaw/libre-jigsaw_2012.02.25-1.dsc
 
 Libre Jigsaw is written in Java

I'm not familiar with Java so I only took a brief look at the package:

debian/rules refers to your home directory. That will not work for other
people building the package.

The short description should not just repeat the package name.
Something generic like jigsaw puzzle might be better.

I did not see what you install to /usr/games/libre-jigsaw which is
started by the .desktop and menu files. But I might have missed it.

Regards,
Ansgar



-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4f50adac.4040...@debian.org



Bug#661857: RFS: libre-jigsaw/2012.02.25-1 [ITP]

2012-03-02 Thread Jon Hulka
On Fri, Mar 2, 2012 at 3:23 AM, Ansgar Burchardt ans...@debian.org wrote:
 debian/rules refers to your home directory. That will not work for other
 people building the package.

 The short description should not just repeat the package name.
 Something generic like jigsaw puzzle might be better.

I'll get those fixed.

 I did not see what you install to /usr/games/libre-jigsaw which is
 started by the .desktop and menu files. But I might have missed it.

/usr/games/libre-jigsaw is a link to
/usr/share/games/libre-jigsaw/libre-jigsaw.jar - built by javahelper.


 Regards,
 Ansgar

Thanks for your feedback,

 - Jon



-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/CALkGRC8yw1AyTAEN46x95izUF=5gHPs=ojnpob4qghvqcxu...@mail.gmail.com