Bug#664766: RFS: ember/0.6.2-1 [ITA]
On 04/09/2012 10:34 AM, Ansgar Burchardt wrote:
tag 664766 + moreinfo confirmed
Hi,
sorry for taking a while, but here is the first round of comments:
Stephen M. Webb stephen.w...@bregmasoft.ca writes:
ember (0.6.2-1) unstable; urgency=low
* new upstream release (closes: #633854)
- removed dependency on libceguiogre-dev (closes: #629767)
* removed old unused build dependencies
* converted to 3.0 (quilt) source format, removed obsolete patches
* converted to use dh sequencer
* new maintainer: Debian games team (closes: #653970)
-added myself as uploader
^^^
There is a space missing here.
Fixed.
* adjusted paths in installed launcher script to use defaults
* used xz compression in packaging
* debian/control: updated Standards-Version to 3.9.3
* debian/copyright: changed to computer-readable format (DEP-5)
Comments about the packaging:
Looks good, only some minor nitpicks:
- debian/ember.1: Debian GNU/Linux should be changed to just Debian.
Done.
- Are the patches forwarded upstream?
Either reported as bugs or proposed pull requests.
- d/rules: find -exec rm can be replaced with find -delete
- d/rules: find . could be replaced with find debian/tmp as I
understand you only want to remove duplicate COPYING files.
- d/rules: # force use of local version of tolua++ and newer libtool
doesn't seem related to the command below it.
Rules file adjusted.
About copyright information:
- src/components/ogre/environment/pagedgeometry/include/MersenneTwister.h:
BSD-*3*-clause, also:
When you use this, send an email to: m-...@math.sci.hiroshima-u.ac.jp
with an appropriate reference to your work.
This additional clause makes the license non-free (postcardware),
see also the first example in question 12 of the [DFSGFAQ].
The postcard request was a part of the reference implementation that
accompanied the original JACM paper by
Makoto Matsumoto and Takuji Nishimura. The included file is a reimplementation
of the published algorithm by
Richard J. Wagner and does not include any of the reference implementation
code. The use this in the quoted
clause refers to the reference implementation, which Richard J. Wagner
consulted in creating his work, but does
not apply to his work. Rather, the clause in the license text of the header
reads as follows.
// It would be nice to CC: wagn...@umich.edu and co...@math.washington.edu
// when you write.
The wording in the reply to question 12 of the DFSGFAQ implies this is
compliant.
- FastDelegate.h: released under CPOL according to [FASTDELEGATE].
See [CPOL] for the license. I haven't read the license text yet,
please check it fulfills the DFSG requirements and is compatible with
the other licenses.
The licensing on this is ambiguous at best. I, working with upstream,
attempted to get clarification
from the author but so far have not been able to. I have replaced the code
with an alternate implementation
that has a clear and acceptable license (boost).
- DRGNURBSSurface.{h,cpp}: Copyright 1999 Intel Corporation.
See file for license.
- EmberPagingSceneManager/*: mostly LGPL-2+, not -2.1+
Adjusted.
There are additional copyright holders and years of copyright should
probably be updated as well. I noticed at least these, but didn't look
that careful:
- years of copyright need to be updated:
Erik Hjortsberg erik.hjortsb...@gmail.com, (C) 2011
(from EmberPagingTerrainObserver.h and others)
- Copyright (C) 2009 Manuel A. Fernandez Montecelo
- Copyright (C) 2011 Erik Ogenvik GPL-2+
- src/components/ogre/gui/RenderedColourStringTextComponent.cpp:
contains code lifted from the CEGUI project. Has additional
copyright holder and license.
- Copyright (c) 2000-2006 Torus Knot Software Ltd
Adjusted. I found a couple of additional copyright holders I missed and added
them.
Note that Erik Hjortsberg legally changed his name in July 2011 to Erik
Ogenvik. All interest
in copyright under the original name should be deemed to be under the new name.
About upstream code:
- ./ember should probably use `set -e' and maybe also `set -u'.
Also it's not possible to pass both --home and --debug.
- ./ember.in seems to be no longer needed (it has the same contents as
./ember).
I have modified ember.in to better handle arguments and exit on error, as
suggested.
This is being forwarded upstream.
The ember.in and the ember file generated from it are different. There is some
variable substitution.
- src/components/ogre/terrain/ICompilerTechniqueProvider.h:
The header states C++ Interface: ITerrainMaterialFinalizer which
looks like a copy-and-paste error. The include guards use
EMBER_OGREVIEW_ITERRAINMATERIALFINALIZER_H as well.
- spelling error: To switch bach to attached mode, close the frame
window with the dialog: bach - back
I will forward these upstream.
These changes are commited
Bug#664766: RFS: ember/0.6.2-1 [ITA]
tag 664766 + moreinfo confirmed
Hi,
sorry for taking a while, but here is the first round of comments:
Stephen M. Webb stephen.w...@bregmasoft.ca writes:
ember (0.6.2-1) unstable; urgency=low
* new upstream release (closes: #633854)
- removed dependency on libceguiogre-dev (closes: #629767)
* removed old unused build dependencies
* converted to 3.0 (quilt) source format, removed obsolete patches
* converted to use dh sequencer
* new maintainer: Debian games team (closes: #653970)
-added myself as uploader
^^^
There is a space missing here.
* adjusted paths in installed launcher script to use defaults
* used xz compression in packaging
* debian/control: updated Standards-Version to 3.9.3
* debian/copyright: changed to computer-readable format (DEP-5)
Comments about the packaging:
Looks good, only some minor nitpicks:
- debian/ember.1: Debian GNU/Linux should be changed to just Debian.
- Are the patches forwarded upstream?
- d/rules: find -exec rm can be replaced with find -delete
- d/rules: find . could be replaced with find debian/tmp as I
understand you only want to remove duplicate COPYING files.
- d/rules: # force use of local version of tolua++ and newer libtool
doesn't seem related to the command below it.
About copyright information:
- src/components/ogre/environment/pagedgeometry/include/MersenneTwister.h:
BSD-*3*-clause, also:
When you use this, send an email to: m-...@math.sci.hiroshima-u.ac.jp
with an appropriate reference to your work.
This additional clause makes the license non-free (postcardware),
see also the first example in question 12 of the [DFSGFAQ].
I believe having seeing this before and it might have changed by
upstream, but I haven't checked.
- FastDelegate.h: released under CPOL according to [FASTDELEGATE].
See [CPOL] for the license. I haven't read the license text yet,
please check it fulfills the DFSG requirements and is compatible with
the other licenses.
- DRGNURBSSurface.{h,cpp}: Copyright 1999 Intel Corporation.
See file for license.
- EmberPagingSceneManager/*: mostly LGPL-2+, not -2.1+
There are additional copyright holders and years of copyright should
probably be updated as well. I noticed at least these, but didn't look
that careful:
- years of copyright need to be updated:
Erik Hjortsberg erik.hjortsb...@gmail.com, (C) 2011
(from EmberPagingTerrainObserver.h and others)
- Copyright (C) 2009 Manuel A. Fernandez Montecelo
- Copyright (C) 2011 Erik Ogenvik GPL-2+
- src/components/ogre/gui/RenderedColourStringTextComponent.cpp:
contains code lifted from the CEGUI project. Has additional
copyright holder and license.
- Copyright (c) 2000-2006 Torus Knot Software Ltd
About upstream code:
- ./ember should probably use `set -e' and maybe also `set -u'.
Also it's not possible to pass both --home and --debug.
- ./ember.in seems to be no longer needed (it has the same contents as
./ember).
- src/components/ogre/terrain/ICompilerTechniqueProvider.h:
The header states C++ Interface: ITerrainMaterialFinalizer which
looks like a copy-and-paste error. The include guards use
EMBER_OGREVIEW_ITERRAINMATERIALFINALIZER_H as well.
- spelling error: To switch bach to attached mode, close the frame
window with the dialog: bach - back
Regards,
Ansgar
[CPOL] http://www.codeproject.com/info/cpol10.aspx
[DFSGFAQ] http://people.debian.org/~bap/dfsg-faq.html
[FASTDELEGATE] http://www.codeproject.com/cpp/FastDelegate.asp
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/87hawtas9v@deep-thought.43-1.org
Processed (with 5 errors): Re: Bug#664766: RFS: ember/0.6.2-1 [ITA]
Processing commands for cont...@bugs.debian.org: tag 664766 + moreinfo confirmed Bug #664766 [sponsorship-requests] RFS: ember/0.6.2-1 [ITA] Added tag(s) confirmed and moreinfo. Hi, Unknown command or malformed arguments to command. sorry for taking a while, but here is the first round of comments: Unknown command or malformed arguments to command. Stephen M. Webb stephen.w...@bregmasoft.ca writes: Unknown command or malformed arguments to command. ember (0.6.2-1) unstable; urgency=low Unknown command or malformed arguments to command. Unknown command or malformed arguments to command. Too many unknown commands, stopping here. Please contact me if you need assistance. -- 664766: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=664766 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.133398205025448.transcr...@bugs.debian.org
Bug#664766: RFS: ember/0.6.2-1 [ITA]
Package: sponsorship-requests Severity: normal -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Dear mentors, I am looking for a sponsor for my package ember * Package name: ember Version : 0.6.2-1 Upstream Author : The WorldForge team * URL : http://www.worldforge.org/ * License : GPL-2 Section : games It builds this binary packages: ember - 3D client of the WorldForge project To access further information about this package, please visit the following URL: http://mentors.debian.net/package/ember Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/e/ember/ember_0.6.2-1.dsc More information about ember can be obtained from http://www.worldforge.org. Changes since the last upload: ember (0.6.2-1) unstable; urgency=low * new upstream release (closes: #633854) - removed dependency on libceguiogre-dev (closes: #629767) * removed old unused build dependencies * converted to 3.0 (quilt) source format, removed obsolete patches * converted to use dh sequencer * new maintainer: Debian games team (closes: #653970) -added myself as uploader * adjusted paths in installed launcher script to use defaults * used xz compression in packaging * debian/control: updated Standards-Version to 3.9.3 * debian/copyright: changed to computer-readable format (DEP-5) Regards, Stephen M. Webb -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJPaMl/AAoJEAoP+EW32zQnvoUP/1wB3kgMgZoblWZBrDMfXztP nunICE6wkwgacCCf6/DmDG84CRxaTMzlvLJydYLv5dfKDLrVrp2qtAciEmezMXRV M5FrwCogQCVHqp5rJ+sNaDalnM8n1xNK77ETA6u61qjGO6n1AvPIVI+lSZ6yN1G3 t95SkROpyjRlhinftm4qCMeoyMkB76CJawwyANKBN8CgpDxVp5N7cHyGX1PAHcYH rdnhMwkyLjPlj4G+4UQ8PhCOvqJPAlclqyaNchSYqzvJbwwUb7xAjr76PGY/brKL mIxrJtQs1OQZwFkyH+L6UPv96tskxaD97QZ+s8e6h7t/wNrYJPliVkji2+nrF8k7 jpztMn7VD6hIt9L4Dsq+TM8zG4ARd2djV9dEpXNAbyKNC08ttWbo/Hkaw/QrYPtj uiLbaboXO8V4BXJx/7/woYiyk4r3MTyUEp0KdIjuLxTvNOFyv9/CkkZjjiYriH/c W1d2SNRn3F/AmamQVbIGjYczOu1eA1CEHdFNQpuiEfrIZWWxHQ1oyciroxzF+g34 qxs1y+vieXT9Wi2VLJ+6FWRMh2hexTVUK9Ce96yk/wjVLtJlg9eOghWVBg2wgwGg DUlWFSgkmpQuIMhZ9PIoGbum4Rhu3WL7rFnT587PkywuOOl0ta2ryyEJvRBeCeXK 9XG9YsN6DUeRUmfQM3Hq =9B+L -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120320181635.21883.46105.reportbug@localhost6.localdomain6
Bug#664766: RFS: ember/0.6.2-1 [ITA]
owner 664766 ! owner 664765 ! thanks Stephen M. Webb stephen.w...@bregmasoft.ca writes: I am looking for a sponsor for my package ember I'll look at this and ember-media in the next days. Regards, Ansgar -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87sjh30yc6@eisei.43-1.org
Processed: Re: Bug#664766: RFS: ember/0.6.2-1 [ITA]
Processing commands for cont...@bugs.debian.org: owner 664766 ! Bug #664766 [sponsorship-requests] RFS: ember/0.6.2-1 [ITA] Owner recorded as Ansgar Burchardt ans...@debian.org. owner 664765 ! Bug #664765 [sponsorship-requests] RFS: ember-media/0.6.2.1-1 [ITA] Owner recorded as Ansgar Burchardt ans...@debian.org. thanks Stopping processing here. Please contact me if you need assistance. -- 664765: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=664765 664766: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=664766 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.133227917629231.transcr...@bugs.debian.org
