Bug#746620: RFS: sxiv/1.2-1
Hi Jakub! 2014-05-16 15:02 GMT-05:00 Jakub Wilk jw...@debian.org: * Daniel Echeverry epsilo...@gmail.com, 2014-05-15, 09:51: http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_1.2-1.dsc I think it should be s/Not install/Don't install/, both in the changelog and in the patch description. Done! Could you please check it out, again? http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_1.2-1.dsc Thank you very much! -- Daniel Echeverry http://wiki.debian.org/DanielEcheverry Linux user: #477840 Debian user Software libre http://www.rinconinformatico.net
Bug#746620: RFS: sxiv/1.2-1
* Daniel Echeverry epsilo...@gmail.com, 2014-05-15, 09:51: http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_1.2-1.dsc I think it should be s/Not install/Don't install/, both in the changelog and in the patch description. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140516200132.ga1...@jwilk.net
Bug#746620: RFS: sxiv/1.2-1
Hi Jakub 2014-05-14 14:17 GMT-05:00 Jakub Wilk jw...@debian.org: * Daniel Echeverry epsilo...@gmail.com, 2014-05-13, 13:02: It appears to me that files that are currently installed to /usr/share/sxiv/exec/ are just examples. If this is the case, then they should live in /usr/share/doc/sxiv/examples/. Done! Let me see: Description: Install examples files with DH instead from Makefile What does DH stand for? Diffie-Hellman? dh(1)? debhelper? I was genuinely confused for a moment, especially since the patch doesn't itself contain any references to debhelper. - mkdir -p $(DESTDIR)$(PREFIX)/share/sxiv/exec - cp exec/* $(DESTDIR)$(PREFIX)/share/sxiv/exec/ - chmod 755 $(DESTDIR)$(PREFIX)/share/sxiv/exec/* + #mkdir -p $(DESTDIR)$(PREFIX)/share/sxiv/exec + #cp exec/* $(DESTDIR)$(PREFIX)/share/sxiv/exec/ + #chmod 755 $(DESTDIR)$(PREFIX)/share/sxiv/exec/* When I see commented-out code, I automatically assume that someone added comments for debugging and then forgot to clean it up. I'd recommend to either remove the code we don't want completely, or add a code comment explaining why the lines are commented-out. Or maybe just remove share/sxiv/exec in debian/rules, instead of patching the Makefile? I updated the patch, Could you check it out, again? http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_1.2-1.dsc Thank you very much! Regards -- Daniel Echeverry http://wiki.debian.org/DanielEcheverry Linux user: #477840 Debian user Software libre http://www.rinconinformatico.net
Bug#746620: RFS: sxiv/1.2-1
* Daniel Echeverry epsilo...@gmail.com, 2014-05-13, 13:02: It appears to me that files that are currently installed to /usr/share/sxiv/exec/ are just examples. If this is the case, then they should live in /usr/share/doc/sxiv/examples/. Done! Let me see: Description: Install examples files with DH instead from Makefile What does DH stand for? Diffie-Hellman? dh(1)? debhelper? I was genuinely confused for a moment, especially since the patch doesn't itself contain any references to debhelper. - mkdir -p $(DESTDIR)$(PREFIX)/share/sxiv/exec - cp exec/* $(DESTDIR)$(PREFIX)/share/sxiv/exec/ - chmod 755 $(DESTDIR)$(PREFIX)/share/sxiv/exec/* + #mkdir -p $(DESTDIR)$(PREFIX)/share/sxiv/exec + #cp exec/* $(DESTDIR)$(PREFIX)/share/sxiv/exec/ + #chmod 755 $(DESTDIR)$(PREFIX)/share/sxiv/exec/* When I see commented-out code, I automatically assume that someone added comments for debugging and then forgot to clean it up. I'd recommend to either remove the code we don't want completely, or add a code comment explaining why the lines are commented-out. Or maybe just remove share/sxiv/exec in debian/rules, instead of patching the Makefile? This is all not very important, so I can upload the package as-is if you prefer so. icon/Makefile needs a “set -e”. Please see Policy §4.6. Done! Please don't forget to forward the patch upstream. Typo in sxiv.1: existance → existence. Done! Ditto. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140514191713.ga3...@jwilk.net
Bug#746620: RFS: sxiv/1.2-1
HI Jakub 2014-05-11 14:44 GMT-05:00 Jakub Wilk jw...@debian.org: * Daniel Echeverry epsilo...@gmail.com, 2014-05-10, 14:37: http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_1.2-1.dsc Don't put two unrelated changes into a single patch. Could you split allow-cflags-override.diff into two, one for compiler flags, another one for installing icons? Done! It appears to me that files that are currently installed to /usr/share/sxiv/exec/ are just examples. If this is the case, then they should live in /usr/share/doc/sxiv/examples/. Done! icon/Makefile needs a “set -e”. Please see Policy §4.6. Done! Typo in sxiv.1: existance → existence. Done! -- Jakub Wilk Could you check it out again? http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_1.2-1.dsc Thank you very much! Regards -- Daniel Echeverry http://wiki.debian.org/DanielEcheverry Linux user: #477840 Debian user Software libre http://www.rinconinformatico.net
Bug#746620: RFS: sxiv/1.2-1
* Daniel Echeverry epsilo...@gmail.com, 2014-05-10, 14:37: http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_1.2-1.dsc Don't put two unrelated changes into a single patch. Could you split allow-cflags-override.diff into two, one for compiler flags, another one for installing icons? It appears to me that files that are currently installed to /usr/share/sxiv/exec/ are just examples. If this is the case, then they should live in /usr/share/doc/sxiv/examples/. icon/Makefile needs a “set -e”. Please see Policy §4.6. Typo in sxiv.1: existance → existence. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140511194356.ga9...@jwilk.net
Bug#746620: RFS: sxiv/1.2-1
Hi Jakub 2014-05-02 0:27 GMT-05:00 Jakub Wilk jw...@debian.org: * Daniel Echeverry epsilo...@gmail.com, 2014-05-01, 20:21: http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_1.2-1.dsc There's something wrong with the changelog. It includes entries for 1.1-1 and 1.1-2, which were never uploaded AFAICT; but OTOH it doesn't include entries for 1.1.1-1 and 1.1.1-2, which the previous version did include. You were right, however was solved :) Could you check it out? http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_1.2-1.dsc Really, Thank you very much! Regards -- Daniel Echeverry http://wiki.debian.org/DanielEcheverry Linux user: #477840 Debian user Software libre http://www.rinconinformatico.net
Bug#746620: RFS: sxiv/1.2-1
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package sxiv * Package name: sxiv * Version : 1.2-1 * Upstream Author : Bert Münnich be.muenn...@googlemail.com * URL : https://github.com/muennich/sxiv * License : GPL-2.0+ Section : graphics It builds those binary packages: sxiv - simple X image viewer To access further information about this package, please visit the following URL: http://mentors.debian.net/package/sxiv Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_1.2-1.dsc Changes since the last upload: New upstream release * debian/control + Bump standard versions 3.9.5 (no changes) * debian/patches + Refresh allow-cflags-override.diff patch + Install icons + Refresh fix_sxiv.desktop-file.diff patch + Add fix_manpage.diff + Fix hyphen-used-as-minus-sign lintian warning in manpage * Add debian/sxiv.xpm * Add debian/sxiv.install * Add debian/sxiv.menu * debian/copyright + Update to DEP5 copyright format 1.0 + Extend copyright holders years Regards, Daniel Echeverry -- Daniel Echeverry http://wiki.debian.org/DanielEcheverry Linux user: #477840 Debian user Software libre http://www.rinconinformatico.net
Bug#746620: RFS: sxiv/1.2-1
* Daniel Echeverry epsilo...@gmail.com, 2014-05-01, 20:21: http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_1.2-1.dsc There's something wrong with the changelog. It includes entries for 1.1-1 and 1.1-2, which were never uploaded AFAICT; but OTOH it doesn't include entries for 1.1.1-1 and 1.1.1-2, which the previous version did include. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140502052715.ga8...@jwilk.net
