Bug#754202: Gamera/3.4.1-1
Here, everything's ready to push the updated dependency immediately after wxpython3.0 hits Sid, also for a 3.4.1-2. Greetings, Daniel On 23.07.2014 03:53, Dmitry Smirnov wrote: On Tue, 15 Jul 2014 19:21:35 Jakub Wilk wrote: As the bug says, there is no wxPython 3.0 in Debian yet... True, but the following bug was just filed: transition: wxpython3.0 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=755757 -- http://www.danielstender.com/blog/ PGP key: 2048R/E41BD2D0 C879 5E41 1ED7 EE80 0F2E 7D0C DBDD 4D96 E41B D2D0 -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/53cf7d77.8050...@danielstender.com
Bug#754202: Gamera/3.4.1-1
On Tue, 15 Jul 2014 19:21:35 Jakub Wilk wrote: As the bug says, there is no wxPython 3.0 in Debian yet... True, but the following bug was just filed: transition: wxpython3.0 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=755757 -- Regards, Dmitry Smirnov GPG key : 4096R/53968D1B signature.asc Description: This is a digitally signed message part.
Bug#754202: Gamera/3.4.1-1
On 14.07.2014 08:21, Dmitry Smirnov wrote: All right, Although debian/copyright is almost comprehensive it still misses some organisations, notably 2007 INRIA (AKA Dolphin?), 2006 LIFL (AKA OPAC?). Worth to clarify. Besides copyright file feels not very human-readable and therefore it is hard to review. I understand the effort that will be necessary but I still hope that eventually (when convenient) the following improvements can be made: * Sorting (please alphabetise copyright holders) * Padding with spaces (to make lists appears more like tables i.e. add spaces between copyright year and name if necessary to make all names begin from the same column). This will increase readability. * Ideally it will be nice to have contact emails listed as well. Many of them can be harvested from source files. * I prefer to be more precise regarding years of copyright so I would remove trailing commas after copyright years. When year of copyright written like 2007, it may create wrong impression that person is still actively contributing which is not true on many occasions. I believe it is better to write 2007-2011 and never use ambiguous trailing commas. I've improved the copyright file throughout, sorted, padded, removed trailing commas, enriched. I've noticed that package is not using dh_python2. I do not have enough experience with Python to say whether it is a good or bad thing. I also think that package could use more debhelper functionality. This is not a problem but I'd prefer someone (other than me) who have more Python experience to review and upload. Hopefully someone from Python team could help? In addition to the exchange of python_support with dh_python2 I've now changed also XS-Python-Version to X-Python-Version in deb/control. Gamera_gui exposes its modules globally which may be unnecessary. I understand that according to Python policy it is desirable to install application's modules privately. In that sense python-gamera obviously should be exposed in global name space but gamera-gui may be better to hide its modules. I've build with the gamera-gui modules in /usr/share/gamera-gui/ but there a deeper module import problems. I don't know if that could be solved w/o getting dirty, but I'll keep to that issue. `cme check dpkg-control` (from libconfig-model-dpkg-perl) reported unnecessary versioned dependencies. This is the opportunity to clean debian/control. Yes, right. I've checked against cme check dpkg-control and removed the needless b-ds. Finally my biggest concern is new dependency on wxwidgets2.8. There is on-going transition to wxwidgets3.0: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=748169 So if I understand situation properly your package will be blocking this transition (if uploaded as is) and therefore it will be affected by yet-to-be- filed serious bug. IMHO it will be ideal to migrate to wxwidgets3.0 before upload. If wxpython3.0 becomes available when this bug is still open changes on that could be pushed quickly. Otherwise I'm going to prepare another package immediately after it is available. Greetings, Daniel -- http://www.danielstender.com/blog/ PGP key: 2048R/E41BD2D0 C879 5E41 1ED7 EE80 0F2E 7D0C DBDD 4D96 E41B D2D0 -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/53c908d2.5030...@danielstender.com
Bug#754202: Gamera/3.4.1-1
* Dmitry Smirnov only...@debian.org, 2014-07-14, 16:21: Finally my biggest concern is new dependency on wxwidgets2.8. There is on-going transition to wxwidgets3.0: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=748169 As the bug says, there is no wxPython 3.0 in Debian yet... IMHO it will be ideal to migrate to wxwidgets3.0 before upload. ...so there isn't anything to migrate to, as far as Debian in concerned. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140715172135.ga5...@jwilk.net
Bug#754202: Gamera/3.4.1-1
Hi Daniel, I'm not sure if I have enough time to familiarise myself with the package to sponsor it but I had a quick look so here is my feedback and improvement ideas: Although debian/copyright is almost comprehensive it still misses some organisations, notably 2007 INRIA (AKA Dolphin?), 2006 LIFL (AKA OPAC?). Worth to clarify. Besides copyright file feels not very human-readable and therefore it is hard to review. I understand the effort that will be necessary but I still hope that eventually (when convenient) the following improvements can be made: * Sorting (please alphabetise copyright holders) * Padding with spaces (to make lists appears more like tables i.e. add spaces between copyright year and name if necessary to make all names begin from the same column). This will increase readability. * Ideally it will be nice to have contact emails listed as well. Many of them can be harvested from source files. * I prefer to be more precise regarding years of copyright so I would remove trailing commas after copyright years. When year of copyright written like 2007, it may create wrong impression that person is still actively contributing which is not true on many occasions. I believe it is better to write 2007-2011 and never use ambiguous trailing commas. I've noticed that package is not using dh_python2. I do not have enough experience with Python to say whether it is a good or bad thing. I also think that package could use more debhelper functionality. This is not a problem but I'd prefer someone (other than me) who have more Python experience to review and upload. Hopefully someone from Python team could help? Gamera_gui exposes its modules globally which may be unnecessary. I understand that according to Python policy it is desirable to install application's modules privately. In that sense python-gamera obviously should be exposed in global name space but gamera-gui may be better to hide its modules. `cme check dpkg-control` (from libconfig-model-dpkg-perl) reported unnecessary versioned dependencies. This is the opportunity to clean debian/control. Finally my biggest concern is new dependency on wxwidgets2.8. There is on-going transition to wxwidgets3.0: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=748169 So if I understand situation properly your package will be blocking this transition (if uploaded as is) and therefore it will be affected by yet-to-be- filed serious bug. IMHO it will be ideal to migrate to wxwidgets3.0 before upload. -- Regards, Dmitry Smirnov. signature.asc Description: This is a digitally signed message part.
Bug#754202: Gamera/3.4.1-1
Thanks Dmitry for the close review and the valuable hints for further improvements. I'll get through it, luckily there is still some time until the package really gets AUTORM. Greetings, Daniel On 14.07.2014 08:21, Dmitry Smirnov wrote: Hi Daniel, I'm not sure if I have enough time to familiarise myself with the package to sponsor it but I had a quick look so here is my feedback and improvement ideas: Although debian/copyright is almost comprehensive it still misses some organisations, notably 2007 INRIA (AKA Dolphin?), 2006 LIFL (AKA OPAC?). Worth to clarify. Besides copyright file feels not very human-readable and therefore it is hard to review. I understand the effort that will be necessary but I still hope that eventually (when convenient) the following improvements can be made: * Sorting (please alphabetise copyright holders) * Padding with spaces (to make lists appears more like tables i.e. add spaces between copyright year and name if necessary to make all names begin from the same column). This will increase readability. * Ideally it will be nice to have contact emails listed as well. Many of them can be harvested from source files. * I prefer to be more precise regarding years of copyright so I would remove trailing commas after copyright years. When year of copyright written like 2007, it may create wrong impression that person is still actively contributing which is not true on many occasions. I believe it is better to write 2007-2011 and never use ambiguous trailing commas. I've noticed that package is not using dh_python2. I do not have enough experience with Python to say whether it is a good or bad thing. I also think that package could use more debhelper functionality. This is not a problem but I'd prefer someone (other than me) who have more Python experience to review and upload. Hopefully someone from Python team could help? Gamera_gui exposes its modules globally which may be unnecessary. I understand that according to Python policy it is desirable to install application's modules privately. In that sense python-gamera obviously should be exposed in global name space but gamera-gui may be better to hide its modules. `cme check dpkg-control` (from libconfig-model-dpkg-perl) reported unnecessary versioned dependencies. This is the opportunity to clean debian/control. Finally my biggest concern is new dependency on wxwidgets2.8. There is on-going transition to wxwidgets3.0: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=748169 So if I understand situation properly your package will be blocking this transition (if uploaded as is) and therefore it will be affected by yet-to-be- filed serious bug. IMHO it will be ideal to migrate to wxwidgets3.0 before upload. -- http://www.danielstender.com/blog/ PGP key: 2048R/E41BD2D0 C879 5E41 1ED7 EE80 0F2E 7D0C DBDD 4D96 E41B D2D0 -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/53c37c9b.1020...@danielstender.com
