Bug#791463: closing RFS: udfclient/0.8-1 [ITP] -- userland implementation of the UDF filesystem
On Thursday 17 December 2015 15:51:51 Pali Rohár wrote: > On Monday 14 December 2015 12:37:24 Andrew Shadura wrote: > > On 14/12/15 12:33, Pali Rohár wrote: > > > On Friday 11 December 2015 18:04:06 Andrew Shadura wrote: > > >> > you just dropping the patch into the right place. > > > I know where and how. But I do not like idea to patching original source > > > code if it is possible to compile and use it without patching. > > > > > > Using patches has problem for inconsistency and upgrading if original > > > source code which patch modify changes. > > > > > > And also I see using patches as last option. Are not Debian want to > > > reduce patches if they are not really needed? > > > > I think it's appropriate to apply a patch (and submit it upstream) in > > this case, as this is certainly a bug in the upstream makefile, and it > > should be fixed. > > Ok. I can send patch to upstream project which fix compilation (on > debian). But, what is wrong with my original (and current) version which > use pmake and does not need patching original software? So what is current state? I would like to know what is wrong with my approach and if is really wrong... -- Pali Rohár pali.ro...@gmail.com
Bug#791463: closing RFS: udfclient/0.8-1 [ITP] -- userland implementation of the UDF filesystem
On Thursday 17 December 2015 15:51:51 Pali Rohár wrote: > On Monday 14 December 2015 12:37:24 Andrew Shadura wrote: > > On 14/12/15 12:33, Pali Rohár wrote: > > > On Friday 11 December 2015 18:04:06 Andrew Shadura wrote: > > >> > you just dropping the patch into the right place. > > > I know where and how. But I do not like idea to patching original source > > > code if it is possible to compile and use it without patching. > > > > > > Using patches has problem for inconsistency and upgrading if original > > > source code which patch modify changes. > > > > > > And also I see using patches as last option. Are not Debian want to > > > reduce patches if they are not really needed? > > > > I think it's appropriate to apply a patch (and submit it upstream) in > > this case, as this is certainly a bug in the upstream makefile, and it > > should be fixed. > > Ok. I can send patch to upstream project which fix compilation (on > debian). But, what is wrong with my original (and current) version which > use pmake and does not need patching original software? Andrew: ping -- Pali Rohár pali.ro...@gmail.com
Bug#791463: closing RFS: udfclient/0.8-1 [ITP] -- userland implementation of the UDF filesystem
On Monday 14 December 2015 12:37:24 Andrew Shadura wrote: > On 14/12/15 12:33, Pali Rohár wrote: > > On Friday 11 December 2015 18:04:06 Andrew Shadura wrote: > >> > you just dropping the patch into the right place. > > I know where and how. But I do not like idea to patching original source > > code if it is possible to compile and use it without patching. > > > > Using patches has problem for inconsistency and upgrading if original > > source code which patch modify changes. > > > > And also I see using patches as last option. Are not Debian want to > > reduce patches if they are not really needed? > > I think it's appropriate to apply a patch (and submit it upstream) in > this case, as this is certainly a bug in the upstream makefile, and it > should be fixed. Ok. I can send patch to upstream project which fix compilation (on debian). But, what is wrong with my original (and current) version which use pmake and does not need patching original software? -- Pali Rohár pali.ro...@gmail.com
Bug#791463: closing RFS: udfclient/0.8-1 [ITP] -- userland implementation of the UDF filesystem
On Friday 11 December 2015 18:04:06 Andrew Shadura wrote: > you just dropping the patch into the right place. I know where and how. But I do not like idea to patching original source code if it is possible to compile and use it without patching. Using patches has problem for inconsistency and upgrading if original source code which patch modify changes. And also I see using patches as last option. Are not Debian want to reduce patches if they are not really needed? -- Pali Rohár pali.ro...@gmail.com
Bug#791463: closing RFS: udfclient/0.8-1 [ITP] -- userland implementation of the UDF filesystem
On 14/12/15 12:33, Pali Rohár wrote: > On Friday 11 December 2015 18:04:06 Andrew Shadura wrote: >> > you just dropping the patch into the right place. > I know where and how. But I do not like idea to patching original source > code if it is possible to compile and use it without patching. > > Using patches has problem for inconsistency and upgrading if original > source code which patch modify changes. > > And also I see using patches as last option. Are not Debian want to > reduce patches if they are not really needed? I think it's appropriate to apply a patch (and submit it upstream) in this case, as this is certainly a bug in the upstream makefile, and it should be fixed. -- Cheers, Andrew
Bug#791463: closing RFS: udfclient/0.8-1 [ITP] -- userland implementation of the UDF filesystem
Hi Pali, can you please reupload? Andrew are you still interested in looking at it? cheers, G. >Hi Gianfranco, I did not updated package because I did not know that >some step is needed to do. My last uploaded version worked and I thought >that it was OK.
Bug#791463: closing RFS: udfclient/0.8-1 [ITP] -- userland implementation of the UDF filesystem
On Wednesday 09 December 2015 18:05:29 Gianfranco Costamagna wrote: > On Wed, 09 Dec 2015 16:40:21 + Bart Martens >wrote: > > Package udfclient has been removed from mentors. > > > > > Hi Pali, did you forget to update the package? > > cheers, > > G. > Hi Gianfranco, I did not updated package because I did not know that some step is needed to do. My last uploaded version worked and I thought that it was OK. -- Pali Rohár pali.ro...@gmail.com
Bug#791463: closing RFS: udfclient/0.8-1 [ITP] -- userland implementation of the UDF filesystem
On 11 December 2015 at 12:58, Gianfranco Costamagnawrote: > Hi Pali, can you please reupload? > > Andrew are you still interested in looking at it? Gianfranco, if you wish to sponsor it, please go ahead. And please make sure Pali uses the feature of bmake package I developed for his specific use case ;) -- Cheers, Andrew
Bug#791463: closing RFS: udfclient/0.8-1 [ITP] -- userland implementation of the UDF filesystem
Hi Andrew, >Gianfranco, if you wish to sponsor it, please go ahead. And please >make sure Pali uses the feature of bmake package I developed for his >specific use case ;) I'm not a bmake-savvy person, I don't think I'll be able to check if the packaging is really error prone... cheers, G.
Bug#791463: closing RFS: udfclient/0.8-1 [ITP] -- userland implementation of the UDF filesystem
Now I uploaded my last version of udfclient to mentors again. But I did not used bmake for two reasons: 1) I have older Debian and Ubuntu systems which do not support bmake, so cannot test or use that package 2) It needs to patch original tarball, my debian/rules file is also short and does not need to patch software just for compilation -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Bug#791463: closing RFS: udfclient/0.8-1 [ITP] -- userland implementation of the UDF filesystem
On 11 December 2015 at 18:01, Pali Rohárwrote: > Now I uploaded my last version of udfclient to mentors again. > > But I did not used bmake for two reasons: > > 1) I have older Debian and Ubuntu systems which do not support bmake, so > cannot test or use that package > > 2) It needs to patch original tarball, my debian/rules file is also > short and does not need to patch software just for compilation Please install the latest bmake and use it (you have to build and test your package on unstable anyway!), and it's not a big deal to patch the Makefile after all, you just dropping the patch into the right place. -- Cheers, Andrew
Bug#791463: closing RFS: udfclient/0.8-1 [ITP] -- userland implementation of the UDF filesystem
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Wed, 09 Dec 2015 16:40:21 + Bart Martenswrote: > Package udfclient has been removed from mentors. > > Hi Pali, did you forget to update the package? cheers, G. -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCAAGBQJWaF9ZAAoJEPNPCXROn13ZzAsP+wUPI+2gpA/qhbsx5SC9hkZE WGqdUrcB84lt4DeL/xXK3ipEQEjJ1x4sXuW0yI9RuG4uapcIK8+53+0981v0We3E +06ySBn8vhVIrvBREgTvWogc51nQ9NDFmQSwWfYePnerRe5Y17lUEWvZoj7tEmgT z0yr83v8r7vt7IrmDMW8wTSkMun3QRlTCk/xWERvo3JpMnyJ1FJXuiDz9s1H7W3u eucSephtxydV9wAEUEfW0FItFLN4BvB9YY4tVGqYkauBW/ul3yQdgUi+O3iKnPEh nQMHl6v5seKH4zumNRjPcfKR/MtMB0xbjvKurpY+Rh0kquqO2r3qipcYXloA7+uO JcHeVvq51ACS8BtfsZouokP1wvMHkxpV5Lc5cmhhnCZgd0nsjWMCzBEOANEJtgvC HkHE2fz9V3m1f+xp6/FKyHY7zDN0naPOCn55h/RxXDcK/FWFFOJOQ0lKtHXfS9vl GjZghN+uxU5hCCtudgtFTrQ/H3oCQCqm1cvMbh3do3Eg9wQKxJo0nP2IcUnR8ioO vB7mzO8NHZ5C0/7PUAmyarV2BfyHMfpnkmTM5KtjEZx/bS3b23ftdq8AvDBH8qZR GI447v8xZzEkKRhPHr+KJhVpyYXNg4ih/RgSgXBT/cjrPZCEU+QIhxHQi6xiei/v Opau3f/lC6nJZOqc+sYu =yxMb -END PGP SIGNATURE-