Bug#793876: RFS: chrony/1.31.1-1
On Tue, 08 Sep 2015 20:23:55 +0200 Paul Geverswrote: > Hi Hi, > On 07-09-15 01:16, Vincent Blut wrote: > > Sorry for the delay! > > np. > > > Pushed on alioth, hopefully everything is ok now. Subsequent changes > > start at > > commit 7355723cab155607765d9a631353063c8f6f6ae7. > > Build, signed & uploaded commit ce69b16b6a08a27e6fe8d2b4a20a3e466db2730e Perfect, I just tagged and signed that commit! > Thanks for you work, don't forget the challenge and feel free to ping me > next time you have an update for chrony. Thanks for your successive reviews Paul. Don’t worry, I’ll not forget the challenge. I do intend to fix a missing build dependency in Jessie, so I’ll ping you when I’ll have the authorization to upload from the release team. > Paul Thanks again, Vincent
Bug#793876: RFS: chrony/1.31.1-1
Hi Paul, Sorry for the delay! Le dim. 30 août 2015 à 1:58, Vincent Bluta écrit : Le jeu. 27 août 2015 à 21:58, Paul Gevers a écrit : Great. Not needed for this upload per se. So, please fix the dependencies in git (I don't need the dsc, just ping me when your done) and I will build and upload. Great, thanks Paul for your reviews, will ping you in the next few days! Pushed on alioth, hopefully everything is ok now. Subsequent changes start at commit 7355723cab155607765d9a631353063c8f6f6ae7. Paul Cheers, Vincent
Bug#793876: RFS: chrony/1.31.1-1
Le jeu. 27 août 2015 à 21:58, Paul Gevers elb...@debian.org a écrit : Hi Vincent, Hi Paul, On 24-08-15 23:52, Vincent Blut wrote: Which file do you have in common with ntp? Please re-read ¹. I guess I’ve been misled by § 7.6.2! The previous section shows the usage of the 'replaces:' field for packages providing *files* already provided by another package. However, the section 7.6.2 seems to be for *packages* that /do conflict/; I interpreted that /do conflict/ by packages providing the same functionality. I even was quite sure my interpretation was correct after seeing the usage example about MTAs. I didn't check if ntp is also doing the conflicts/replaces/provides dance on time-deamon. If so I than you don't need to mention ntp specifically at all¹¹. It does not. There is still an opened bug report² about adding ntp to the time-daemon virtual package, but the discussion has stalled since few years now. Anyway, depending on your answer, I’ll revert this commit. Lets not do that until we agree. :) Ok. Hmm, so I believe Conflicts or maybe even Breaks is indeed enough. Once ntp provides time-daemon, that can be removed as well. Ok, I'll revert to where we were previously then (i.e. just conflict on ntp). Oh, you not understanding me makes sense. It was me who didn't understand what you were doing. I was assuming there now was a new mechanism, but now you explained it is just a better implementation of the same thing. But then again, maybe make that a little clearer in your changelog for others like me? Ok, maybe adding something like: “Basically, this directive makes the detection of the standard (Local or UTC time) set in /etc/adjtime — and used by the hardware clock — clearer compared to the text processing method we used to use in the post install script to complete the same task.” What do you think? Sounds like some good text (but maybe a little long for the changelog. I believe the NEWS file is there for this purpose. Then it'll be in a NEWS file ;-) Can you please explain me how commit 1ce86d3 works (the Breaks of util-linux). As the hwclockfile directive can only deal with /etc/adjtime, we need to ensure that we migrated from /etc/default/rcS to /etc/adjtime. To be honest, I’m not sure that break is even needed, because this migration happened prior to Wheezy. I haven't looked it up, is util-linux in essential? Otherwise, shouldn't you depend on it with the higher than dependency? Indeed, util-linux is essential hence the fact it is not listed in the 'Depends:' field. Thus I think Depends: util-linux (= 2.20.1-5) is more correct. It is in essential, but you require a version higher than possible (when was 2.20.1-5 introduced?). It was uploaded prior to Wheezy, on May 17, 2012. You confirm my ideas here. But as I mentioned in my other mail (below), I challenge you to come up with a way to run them which is acceptable in Debian's autopkgtest framework. Challenge accepted, but I’ll have to document myself about autopkgtest, especially on the integration of upstream tests. Great. Not needed for this upload per se. So, please fix the dependencies in git (I don't need the dsc, just ping me when your done) and I will build and upload. Great, thanks Paul for your reviews, will ping you in the next few days! Paul Cheers, Vincent
Bug#793876: RFS: chrony/1.31.1-1
Hi Vincent, On 24-08-15 23:52, Vincent Blut wrote: Which file do you have in common with ntp? Please re-read ¹. I guess I’ve been misled by § 7.6.2! The previous section shows the usage of the 'replaces:' field for packages providing *files* already provided by another package. However, the section 7.6.2 seems to be for *packages* that /do conflict/; I interpreted that /do conflict/ by packages providing the same functionality. I even was quite sure my interpretation was correct after seeing the usage example about MTAs. I didn't check if ntp is also doing the conflicts/replaces/provides dance on time-deamon. If so I than you don't need to mention ntp specifically at all¹¹. It does not. There is still an opened bug report² about adding ntp to the time-daemon virtual package, but the discussion has stalled since few years now. Anyway, depending on your answer, I’ll revert this commit. Lets not do that until we agree. :) Ok. Hmm, so I believe Conflicts or maybe even Breaks is indeed enough. Once ntp provides time-daemon, that can be removed as well. Oh, you not understanding me makes sense. It was me who didn't understand what you were doing. I was assuming there now was a new mechanism, but now you explained it is just a better implementation of the same thing. But then again, maybe make that a little clearer in your changelog for others like me? Ok, maybe adding something like: “Basically, this directive makes the detection of the standard (Local or UTC time) set in /etc/adjtime — and used by the hardware clock — clearer compared to the text processing method we used to use in the post install script to complete the same task.” What do you think? Sounds like some good text (but maybe a little long for the changelog. I believe the NEWS file is there for this purpose. Can you please explain me how commit 1ce86d3 works (the Breaks of util-linux). As the hwclockfile directive can only deal with /etc/adjtime, we need to ensure that we migrated from /etc/default/rcS to /etc/adjtime. To be honest, I’m not sure that break is even needed, because this migration happened prior to Wheezy. I haven't looked it up, is util-linux in essential? Otherwise, shouldn't you depend on it with the higher than dependency? Indeed, util-linux is essential hence the fact it is not listed in the 'Depends:' field. Thus I think Depends: util-linux (= 2.20.1-5) is more correct. It is in essential, but you require a version higher than possible (when was 2.20.1-5 introduced?). You confirm my ideas here. But as I mentioned in my other mail (below), I challenge you to come up with a way to run them which is acceptable in Debian's autopkgtest framework. Challenge accepted, but I’ll have to document myself about autopkgtest, especially on the integration of upstream tests. Great. Not needed for this upload per se. So, please fix the dependencies in git (I don't need the dsc, just ping me when your done) and I will build and upload. Paul signature.asc Description: OpenPGP digital signature
Bug#793876: RFS: chrony/1.31.1-1
Le ven. 21 août 2015 à 9:21, Paul Gevers elb...@debian.org a écrit : Hi Vincent, Hey Paul, [I am merging the e-mails you send yesterday to make the thread easier again.] On 20-08-15 18:12, Vincent Blut wrote: Le jeu. 20 août 2015 à 12:10, Paul Gevers elb...@debian.org a écrit : Your priority switch from extra to optional may require a ping to somebody. I am not sure and I would need to search, so please do that yourself. Yes. I’ll have to send a bug report to the ftp.debian.org pseudo-package asking for the modification of the section/priority in the override-file. Will do later today… or tomorrow. Ack. Bug report sent¹. Which file do you have in common with ntp? Please re-read ¹. I guess I’ve been misled by § 7.6.2! The previous section shows the usage of the 'replaces:' field for packages providing *files* already provided by another package. However, the section 7.6.2 seems to be for *packages* that /do conflict/; I interpreted that /do conflict/ by packages providing the same functionality. I even was quite sure my interpretation was correct after seeing the usage example about MTAs. I didn't check if ntp is also doing the conflicts/replaces/provides dance on time-deamon. If so I than you don't need to mention ntp specifically at all¹¹. It does not. There is still an opened bug report² about adding ntp to the time-daemon virtual package, but the discussion has stalled since few years now. Anyway, depending on your answer, I’ll revert this commit. Lets not do that until we agree. :) Ok. Wouldn't the hwclockfile stuff in /etc not warrant an debian/NEWS update? Or at the very least some help in the changelog? I don’t think so. Finally, that change have no impact for the user. Previously we had to check (in the postinst script) if the RTC keeps local time or UTC by parsing /etc/adjtime and/or /etc/default/rcS. Depending on the result, we set (or no) the rtconutc directive in /etc/chrony.conf. But now chrony is grown enough to check that by itself. Each time it is started, it will parse the correspondent value in the /etc/adjtime file. So, as you can see, the whole point of using the hwclockfile directive is to have something cleaner than playing the text processing game for the same result. Doesn't this actually require a migration path? What if the /etc/chrony and /etc/adjtime are NOT answering the same? Well, I’m not sure I’m understanding you here. The chronyd daemon will use what /etc/adjtime returns, thanks to the 'hwclockfile /etc/adjtime' directive. Oh, you not understanding me makes sense. It was me who didn't understand what you were doing. I was assuming there now was a new mechanism, but now you explained it is just a better implementation of the same thing. But then again, maybe make that a little clearer in your changelog for others like me? Ok, maybe adding something like: “Basically, this directive makes the detection of the standard (Local or UTC time) set in /etc/adjtime — and used by the hardware clock — clearer compared to the text processing method we used to use in the post install script to complete the same task.” What do you think? Can you please explain me how commit 1ce86d3 works (the Breaks of util-linux). As the hwclockfile directive can only deal with /etc/adjtime, we need to ensure that we migrated from /etc/default/rcS to /etc/adjtime. To be honest, I’m not sure that break is even needed, because this migration happened prior to Wheezy. I haven't looked it up, is util-linux in essential? Otherwise, shouldn't you depend on it with the higher than dependency? Indeed, util-linux is essential hence the fact it is not listed in the 'Depends:' field. I assume you tested all migrations for admins that already ran chrony as a different users as described in the README.Debian. Are the manual steps even needed? Shouldn't this go into a NEWS file instead of the README file? I tested a lot of use cases, but Jerome Benoit informed me he had an issue possibly related to this change, but as he uses a custom init script etc., I will have to check his atypical configuration. Ack. After inspecting Jerome’s custom init script, it appreared it was buggy. However I’ll have to find a way not to mess with users who set the default chronyd user in the init script instead of using the user directive in /etc/chrony/chrony.conf. To be honest I don’t see an easy way of doing it, so a first good step will probably be to add a warning in a NEWS file. Line 36 of the README.Debian file ends weird now, you removed a filename but not the and in front. Indeed, will fix. You mean line 27 right? I am talking about The scripts /etc/ppp/ip-up.d/chrony, /etc/ppp/ip-down.d/chrony, and read key 1 from /etc/chrony/chrony.keys and use it as the password to send chronyc commands. In my version that is on line 36. My bad, I was checking the file with nl which doesn't
Bug#793876: RFS: chrony/1.31.1-1
Le mar. 25 août 2015 à 0:33, Jerome BENOIT calcu...@rezozer.net a écrit : -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi: On 24/08/15 23:52, Vincent Blut wrote: After inspecting Jerome’s custom init script, it appreared it was buggy. To my defence: 1] the buggy part was commented as obsoleted, 2] it contains more material, in particular support for /etc/network/if-*.d You're right, my sentence sounds like the whole init script was buggy, but that isn't the case. The context was about the supposedly breakage of the -u option expressed in 55d503b7.7050...@rezozer.net Sorry, if that offended you! However I’ll have to find a way not to mess with users who set the default chronyd user in the init script instead of using the user directive in /etc/chrony/chrony.conf. To be honest I don’t see an easy way of doing it, so a first good step will probably be to add a warning in a NEWS file. Note that regular users are not supposed to modify their /etc/init.d/chrony but they are supposed to configure properly their /etc/chrony/chrony.conf . Sure, but it'd be great to mitigate upgrade issues for those that did so. I modify my /etc/init.d/chrony mainly to get /etc/network/if-*.d support. BTW, is PPP stuff still needed ? Yes, there are still Dial-up only internet accesses here and there, but its usage dropped significantly in favor of broadband Internet access. In short, you may rather focus on #312092 and #633422 hth, Jerome Cheers, Vincent
Bug#793876: RFS: chrony/1.31.1-1
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi: On 24/08/15 23:52, Vincent Blut wrote: After inspecting Jerome’s custom init script, it appreared it was buggy. To my defence: 1] the buggy part was commented as obsoleted, 2] it contains more material, in particular support for /etc/network/if-*.d However I’ll have to find a way not to mess with users who set the default chronyd user in the init script instead of using the user directive in /etc/chrony/chrony.conf. To be honest I don’t see an easy way of doing it, so a first good step will probably be to add a warning in a NEWS file. Note that regular users are not supposed to modify their /etc/init.d/chrony but they are supposed to configure properly their /etc/chrony/chrony.conf . I modify my /etc/init.d/chrony mainly to get /etc/network/if-*.d support. BTW, is PPP stuff still needed ? In short, you may rather focus on #312092 and #633422 hth, Jerome -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQEcBAEBAgAGBQJV25urAAoJEIC/w4IMSybjGwMH/1mbGWS/iBvOfJBUG7od8wW9 ff22VEsvY8GoRw0qNXpVbI+FNRn2uroOS/Q1m8MWzNflnVjUnZ84DUsnsupfLFuV wUdDyU5/vVaK4KrouigPdGVHc7LTs4thmqlSP+FL/eSyvQIu4+XNB6BUDGtXKOOZ Ec5/Vep8MMzv/Cx9rr6oUPfx8pVk0RfmHnlWtH5q07PZNAOu3UyLeEPYVVIqY2VI ntYvEmlrw7aB05gDNFHKJmDYcI8mj6ZboJ18fzx5sdG6E4mLoRM/xr0LvlC/zxbJ XR/Q0tw2IzxjKrRMWiq+QvKkK/kPDoXhY+ZhVpAOyNq8MODXkpyY3Acqb4NHx2Q= =mRUF -END PGP SIGNATURE-
Bug#793876: RFS: chrony/1.31.1-1
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 25/08/15 02:00, Vincent Blut wrote: Le mar. 25 août 2015 à 0:33, Jerome BENOIT calcu...@rezozer.net a écrit : -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi: On 24/08/15 23:52, Vincent Blut wrote: After inspecting Jerome’s custom init script, it appreared it was buggy. To my defence: 1] the buggy part was commented as obsoleted, 2] it contains more material, in particular support for /etc/network/if-*.d You're right, my sentence sounds like the whole init script was buggy, but that isn't the case. The context was about the supposedly breakage of the -u option expressed in 55d503b7.7050...@rezozer.net Sorry, if that offended you! I just wanted to clarify :-) I am bad, but that bad. However I’ll have to find a way not to mess with users who set the default chronyd user in the init script instead of using the user directive in /etc/chrony/chrony.conf. To be honest I don’t see an easy way of doing it, so a first good step will probably be to add a warning in a NEWS file. Note that regular users are not supposed to modify their /etc/init.d/chrony but they are supposed to configure properly their /etc/chrony/chrony.conf . Sure, but it'd be great to mitigate upgrade issues for those that did so. 1] modified init.d scripts are managed by Debian at, so you do not have to worry about this; 2] most importantly, adventurous folks who modified their init.d scripts are supposed to know what they do. I modify my /etc/init.d/chrony mainly to get /etc/network/if-*.d support. BTW, is PPP stuff still needed ? Yes, there are still Dial-up only internet accesses here and there, but its usage dropped significantly in favor of broadband Internet access. In short, you may rather focus on #312092 and #633422 hth, Jerome Cheers, Vincent Best wishes, Jerome -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQEcBAEBAgAGBQJV27+EAAoJEIC/w4IMSybjRnYIAITEFF3Su3naL4SGDt0TpieR vxSqaN/lfgluHso5/HqmHMemMQM17WgVWSgVTMjO0kexl6/ZBJI1WoLiPL236vWY 1wOHu11ks1XD9S7WLDkoFUkg9gDUFMcT9T7GMUh9TAGTaEgfNauWSbIWNfl+fj2t c91W16WLldoFnKCIHfAjhRGLuvhfEKRDY08uo5Q35r6yUjTeHNeLZiggmuv5U8FT 1rc5lDEcGWmPX8gK0Z4X6m+CVdA+Xzowaq2qX2pBMLYn/H84+WOUvJmsaF93HD2g PyOj2WaZg9q7SZ5MsedY1sUItgunA9+gbtdKLoXbNkOZaKA5+GP/N/3b9L83AYI= =mxTm -END PGP SIGNATURE-
Bug#793876: RFS: chrony/1.31.1-1
Le ven. 21 août 2015 à 14:41, Jerome BENOIT calcu...@rezozer.net a écrit : -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Vincent: Hey Jerome, On 20/08/15 19:20, Vincent Blut wrote: Le jeu. 20 août 2015 à 16:07, Jerome BENOIT calcu...@rezozer.net a écrit : -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Vincent: Hey again Jerome, On 20/08/15 13:57, Vincent Blut wrote: Le jeu. 20 août 2015 à 0:31, Jerome BENOIT sphericaltrian...@rezozer.net a écrit : For something as one week, the current GIT version at Aliot works great on my box. (even if the option -u doent work). Thanks Jerome for testing! I just tried to run chrony with the '-u' option from the shell prompt, but at first glance the clock synchronizes flawlessly to the NTP server. Could you be more specific about what doesn’t work? Does chrony display any error messages? […] I can send this material if you want. Yes please, I’ll test your configuration in a VM. Don’t know when though, I have some high priority IRL stuff to do. [snip] I also obsoleted ('^##OBSOLETED##) the code that pass the user to the daemon: just uncommented it to test. Well I just take a look at your init script, and it appears that that part is buggy. You’re passing uid:gid values to 'chronyd -u'. The '-u' option only accept a username. Thus, just drop your UGID variable, and do something like this: if test $(uname -s) = Linux; then CHRONY_OPTS=$CHRONY_OPTS -u $DAEMONUSER fi Also, instead of defining a variable in your init script to set the user with which chronyd will be launch, I invite you to use the user directive in /etc/chrony/chrony.conf Best wishes, Jerome Cheers, Vincent
Bug#793876: RFS: chrony/1.31.1-1
Hi Vincent, [I am merging the e-mails you send yesterday to make the thread easier again.] On 20-08-15 18:12, Vincent Blut wrote: Le jeu. 20 août 2015 à 12:10, Paul Gevers elb...@debian.org a écrit : On 19-08-15 21:29, Vincent Blut wrote: Please add the CVE numbers that were fixed by upstream to your changelog such that the trackers can find it automatically. TIP: if you would have done that and mention that in your RFS you would have probably found a sponsor earlier. I didn’t include them because those fixes have been backported to chrony 1.30-2 in Debian (thanks Joachim btw) and consequently the CVE numbers have already been mentionned in this release’s changelog. Ack. Your priority switch from extra to optional may require a ping to somebody. I am not sure and I would need to search, so please do that yourself. Yes. I’ll have to send a bug report to the ftp.debian.org pseudo-package asking for the modification of the section/priority in the override-file. Will do later today… or tomorrow. Ack. Which file do you have in common with ntp? Please re-read ¹. I guess I’ve been misled by § 7.6.2! The previous section shows the usage of the 'replaces:' field for packages providing *files* already provided by another package. However, the section 7.6.2 seems to be for *packages* that /do conflict/; I interpreted that /do conflict/ by packages providing the same functionality. I even was quite sure my interpretation was correct after seeing the usage example about MTAs. I didn't check if ntp is also doing the conflicts/replaces/provides dance on time-deamon. If so I than you don't need to mention ntp specifically at all¹¹. Anyway, depending on your answer, I’ll revert this commit. Lets not do that until we agree. :) I assume that the change of maintainership has the consent of Joachim? Yes, we’ve discussed about this privately some times ago. Still ok Joachim? Ack on the other mail of Joachim. Wouldn't the hwclockfile stuff in /etc not warrant an debian/NEWS update? Or at the very least some help in the changelog? I don’t think so. Finally, that change have no impact for the user. Previously we had to check (in the postinst script) if the RTC keeps local time or UTC by parsing /etc/adjtime and/or /etc/default/rcS. Depending on the result, we set (or no) the rtconutc directive in /etc/chrony.conf. But now chrony is grown enough to check that by itself. Each time it is started, it will parse the correspondent value in the /etc/adjtime file. So, as you can see, the whole point of using the hwclockfile directive is to have something cleaner than playing the text processing game for the same result. Doesn't this actually require a migration path? What if the /etc/chrony and /etc/adjtime are NOT answering the same? Well, I’m not sure I’m understanding you here. The chronyd daemon will use what /etc/adjtime returns, thanks to the 'hwclockfile /etc/adjtime' directive. Oh, you not understanding me makes sense. It was me who didn't understand what you were doing. I was assuming there now was a new mechanism, but now you explained it is just a better implementation of the same thing. But then again, maybe make that a little clearer in your changelog for others like me? Can you please explain me how commit 1ce86d3 works (the Breaks of util-linux). As the hwclockfile directive can only deal with /etc/adjtime, we need to ensure that we migrated from /etc/default/rcS to /etc/adjtime. To be honest, I’m not sure that break is even needed, because this migration happened prior to Wheezy. I haven't looked it up, is util-linux in essential? Otherwise, shouldn't you depend on it with the higher than dependency? I assume you tested all migrations for admins that already ran chrony as a different users as described in the README.Debian. Are the manual steps even needed? Shouldn't this go into a NEWS file instead of the README file? I tested a lot of use cases, but Jerome Benoit informed me he had an issue possibly related to this change, but as he uses a custom init script etc., I will have to check his atypical configuration. Ack. Line 36 of the README.Debian file ends weird now, you removed a filename but not the and in front. Indeed, will fix. You mean line 27 right? I am talking about The scripts /etc/ppp/ip-up.d/chrony, /etc/ppp/ip-down.d/chrony, and read key 1 from /etc/chrony/chrony.keys and use it as the password to send chronyc commands. In my version that is on line 36. Nice to have, could you think of some autopkgtest test²? And why are the tests disabled. Unless they fail and can't be fixed, it is really recommended to run them. I’m definitely interested in autopkgtest. However I’ll need some times to dive through its meanders. I don’t known why tests have originally been disabled, but I guess it’s because they depend on the clknetsim tool which is not packaged in Debian. Also, if that tool isn’t installed on
Bug#793876: RFS: chrony/1.31.1-1
Hi On 20-08-15 22:33, Joachim Wiedorn wrote: Hello Vincent, Vincent Blut wrote on 2015-08-20 18:36: features. By the way, if I want to close these outdated bug reports, what’s the canonical way to do it? I guess I can’t do that from d/changelog? do it in the changelog: e.g. LP: #1313200 I think Vincent means bugs that are closed in a previous upload. Just send a mail to bug-number-d...@bugs.debian.org¹. Paul ¹ https://www.debian.org/Bugs/Developer#closing signature.asc Description: OpenPGP digital signature
Bug#793876: RFS: chrony/1.31.1-1
Hi Vincent, Live from Debconf15. On 19-08-15 21:29, Vincent Blut wrote: I am looking for a sponsor for my package chrony Please note this is a first manual inspection. Not all items are critical, most are just nitpicks or tips or questions. Please add the CVE numbers that were fixed by upstream to your changelog such that the trackers can find it automatically. TIP: if you would have done that and mention that in your RFS you would have probably found a sponsor earlier. Your priority switch from extra to optional may require a ping to somebody. I am not sure and I would need to search, so please do that yourself. Which file do you have in common with ntp? Please re-read ¹. I assume that the change of maintainership has the consent of Joachim? Wouldn't the hwclockfile stuff in /etc not warrant an debian/NEWS update? Or at the very least some help in the changelog? Doesn't this actually require a migration path? What if the /etc/chrony and /etc/adjtime are NOT answering the same? Can you please explain me how commit 1ce86d3 works (the Breaks of util-linux). I assume you tested all migrations for admins that already ran chrony as a different users as described in the README.Debian. Are the manual steps even needed? Shouldn't this go into a NEWS file instead of the README file? Line 36 of the README.Debian file ends weird now, you removed a filename but not the and in front. Nice to have, could you think of some autopkgtest test²? And why are the tests disabled. Unless they fail and can't be fixed, it is really recommended to run them. I think the comments you added in commit df80cd25 in the copyright file, should the Comment field.³ And tip to prevent the fix in commit 7245a4, use dch to write the timestamps (e.g. dch -rm) You could maybe remind upstream to update their copyright years when they make changes. Paul My TODO in the review Are the man pages regrenerated Are (new) examples installed Are (new) tests run (some seem to require network) check closed bugs ¹ https://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces ² http://dep.debian.net/deps/dep8/ ³ https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#comment-field signature.asc Description: OpenPGP digital signature
Re: Bug#793876: RFS: chrony/1.31.1-1
Le jeu. 20 août 2015 à 0:31, Jerome BENOIT sphericaltrian...@rezozer.net a écrit : For something as one week, the current GIT version at Aliot works great on my box. (even if the option -u doent work). Thanks Jerome for testing! I just tried to run chrony with the '-u' option from the shell prompt, but at first glance the clock synchronizes flawlessly to the NTP server. Could you be more specific about what doesn’t work? Does chrony display any error messages? Cheers, Jerome Have a good day, Vincent
Bug#793876: RFS: chrony/1.31.1-1
Hi On 20-08-15 12:10, Paul Gevers wrote: Are the man pages regrenerated Could you check with upstream that he/she really is generating the man pages by hand in groff format? If not, ask him to include the source. Are (new) examples installed Is there a reason why you don't install the examples? (I could imaging it is because you setup the package in Debian anyways, but please tell). Are (new) tests run (some seem to require network) It would be could if you investigated if you can run the upstream tests. I can come up with multiple ways to do this, I like you to at least give it a thought and maybe propose something (not required for this upload though). check closed bugs Ack... Have you been active in pursuing the other bugs as well? Paul signature.asc Description: OpenPGP digital signature
Bug#793876: RFS: chrony/1.31.1-1
Le jeu. 20 août 2015 à 18:32, Joachim Wiedorn joodeb...@joonet.de a écrit : Hello Vincent, Vincent Blut wrote on 2015-08-20 18:12: I assume that the change of maintainership has the consent of Joachim? Yes, we’ve discussed about this privately some times ago. Still ok Joachim? Yes, that is fully ok. Perfect! You make a very good job with maintaining chrony! Aaaah, hearing that makes me happy! Thank you Joachim. Thank you very much for overtaking. You’re welcome. By the way, I asked you another question in the previous mail about the deactivation of tests in d/rules. I gave Paul an answer based on my own guesses, but it would be cool if you could confirm or invalidate my statements. --- Have a nice day. Joachim (Germany) Good day to you too, Vincent
Bug#793876: RFS: chrony/1.31.1-1
Le mer. 19 août 2015 à 21:22, Vincent vincent.deb...@gmail.com a écrit : On Tue, 28 Jul 2015 14:18:54 +0200 Vincent Blut vincent.deb...@free.fr wrote: Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package chrony * Package name: chrony Version : 1.31.1-1 Upstream Author : Miroslav Lichvar mlich...@redhat.com * URL : http://chrony.tuxfamily.org * License : GPL-2 Section : net It builds those binary packages: chrony - Versatile implementation of the Network Time Protocol To access further information about this package, please visit the following URL: http://mentors.debian.net/package/chrony Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/c/chrony/chrony_1.31.1-1.dsc Changes since the last upload: * Import upstream version 1.31 and 1.31.1: - Please see /usr/share/doc/chrony/changelog.gz for release notes. * debian/chrony.conf: - Use the 'hwclockfile' directive. Avoid using text processing methods in the post install script to find out if the RTC keeps local time or UTC. (Closes: #778710) * debian/clean: - Add getdate.c * debian/control: - Move chrony from admin to net section. - Change priority from extra to optional. - Build depends on libcap-dev. (Closes: #768803) - Add ntp to the 'Replaces:' field. - Bump standards-version to 3.9.6 (no changes required). - Set myself as maintainer and Joachim as uploader. - Update Vcs-Browser URL to use cgit and https. - Build depends on pps-tools. Provides PPSAPI (RFC-2783) support. - Improve the synopsis. - Add Breaks on util-linux ( 2.20.1-5). Ensure that the 'UTC=' setting from the '/etc/default/rcS' file have been migrated to UTC/LOCAL in '/etc/adjtime'. - Depends on adduser. Needed to create _chrony system user/group. * debian/copyright: - Add myself to copyright holders. - Remove spaces from short name license (fix Lintian warning) - Filled short license field (RSA-MD) (fix Lintian warning) * debian/logrotate: - Simplify postrotate script. Thanks to Frédéric Brière fbri...@fbriere.net for reporting and diagnosing the issue. (Closes: #763542) * debian/patches: - Drop patches for issues fixed upstream. - Rename and update patch. Update the series file accordingly. * debian/postinst: - Pass the '--three-way' option to ucf. - Remove useless text processing methods as we now use the 'hwclockfile' directive. (Closes: #778711) - Create _chrony system user/group. - Update the new_file path in the ucf invocation. - Remove the MAILPASSWORD shell variable as we don’t use it. * debian/postrm: - Drop removal instruction of /etc/cron.weekly/chrony. - Remove _chrony system user/group on purge. - Don’t pass the --group option to deluser. * debian/rules: - Build with all hardening flags. - Ease the reading of configure options. - Specify _chrony as default chronyd user. This is the system user to which chronyd will drop root privileges. You'll find further information in /usr/share/doc/chrony/README.Debian. (Closes: #688971) Cheers, Vincent Hello there! So, nobody’s interested to see chrony updated in Debian? ;-) Regards, Vincent Oops, please disregard this mail, it was sent with the wrong mail address.
Bug#793876: RFS: chrony/1.31.1-1
On Tue, 28 Jul 2015 14:18:54 +0200 Vincent Blut vincent.deb...@free.fr wrote: Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package chrony * Package name: chrony Version : 1.31.1-1 Upstream Author : Miroslav Lichvar mlich...@redhat.com * URL : http://chrony.tuxfamily.org * License : GPL-2 Section : net It builds those binary packages: chrony - Versatile implementation of the Network Time Protocol To access further information about this package, please visit the following URL: http://mentors.debian.net/package/chrony Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/c/chrony/chrony_1.31.1-1.dsc Changes since the last upload: * Import upstream version 1.31 and 1.31.1: - Please see /usr/share/doc/chrony/changelog.gz for release notes. * debian/chrony.conf: - Use the 'hwclockfile' directive. Avoid using text processing methods in the post install script to find out if the RTC keeps local time or UTC. (Closes: #778710) * debian/clean: - Add getdate.c * debian/control: - Move chrony from admin to net section. - Change priority from extra to optional. - Build depends on libcap-dev. (Closes: #768803) - Add ntp to the 'Replaces:' field. - Bump standards-version to 3.9.6 (no changes required). - Set myself as maintainer and Joachim as uploader. - Update Vcs-Browser URL to use cgit and https. - Build depends on pps-tools. Provides PPSAPI (RFC-2783) support. - Improve the synopsis. - Add Breaks on util-linux ( 2.20.1-5). Ensure that the 'UTC=' setting from the '/etc/default/rcS' file have been migrated to UTC/LOCAL in '/etc/adjtime'. - Depends on adduser. Needed to create _chrony system user/group. * debian/copyright: - Add myself to copyright holders. - Remove spaces from short name license (fix Lintian warning) - Filled short license field (RSA-MD) (fix Lintian warning) * debian/logrotate: - Simplify postrotate script. Thanks to Frédéric Brière fbri...@fbriere.net for reporting and diagnosing the issue. (Closes: #763542) * debian/patches: - Drop patches for issues fixed upstream. - Rename and update patch. Update the series file accordingly. * debian/postinst: - Pass the '--three-way' option to ucf. - Remove useless text processing methods as we now use the 'hwclockfile' directive. (Closes: #778711) - Create _chrony system user/group. - Update the new_file path in the ucf invocation. - Remove the MAILPASSWORD shell variable as we don’t use it. * debian/postrm: - Drop removal instruction of /etc/cron.weekly/chrony. - Remove _chrony system user/group on purge. - Don’t pass the --group option to deluser. * debian/rules: - Build with all hardening flags. - Ease the reading of configure options. - Specify _chrony as default chronyd user. This is the system user to which chronyd will drop root privileges. You'll find further information in /usr/share/doc/chrony/README.Debian. (Closes: #688971) Cheers, Vincent Hello there! So, nobody’s interested to see chrony updated in Debian? ;-) Regards, Vincent
Bug#793876: RFS: chrony/1.31.1-1
Hello Vincent, Vincent Blut wrote on 2015-08-20 18:12: I don’t known why tests have originally been disabled, but I guess it’s because they depend on the clknetsim tool which is not packaged in Debian. Also, if that tool isn’t installed on the system, the test.common script will try to download and build the tool, which is a quite invasive method. Am I wrong Joachim? After the long time I don't know the detailed reason about disabling. But I know I had the problem in 1.30-1: building aborted with an error. I think your explanation is understandable. --- Have a nice day. Joachim (Germany) signature.asc Description: PGP signature
Bug#793876: RFS: chrony/1.31.1-1
Hello Vincent, Vincent Blut wrote on 2015-08-20 18:36: features. By the way, if I want to close these outdated bug reports, what’s the canonical way to do it? I guess I can’t do that from d/changelog? do it in the changelog: e.g. LP: #1313200 --- Have a nice day. Joachim (Germany) signature.asc Description: PGP signature
Bug#793876: RFS: chrony/1.31.1-1
Le jeu. 20 août 2015 à 13:54, Paul Gevers elb...@debian.org a écrit : Hi Hi again, On 20-08-15 12:10, Paul Gevers wrote: Are the man pages regrenerated Could you check with upstream that he/she really is generating the man pages by hand in groff format? If not, ask him to include the source. Will do. Are (new) examples installed Is there a reason why you don't install the examples? (I could imaging it is because you setup the package in Debian anyways, but please tell). Most of them can’t be applied as is due to not being Debianized, or because preliminary packaging stuff need to be done, etc. Are (new) tests run (some seem to require network) It would be could if you investigated if you can run the upstream tests. I can come up with multiple ways to do this, I like you to at least give it a thought and maybe propose something (not required for this upload though). See my answer on this front in the previous mail. check closed bugs Ack... Have you been active in pursuing the other bugs as well? Definitely, I intend to mark some of them as /wontfix/, some will be closed because there are outdated and some will be fixed by providing the necessary features. By the way, if I want to close these outdated bug reports, what’s the canonical way to do it? I guess I can’t do that from d/changelog? Paul Thanks again Paul, Vincent
Bug#793876: RFS: chrony/1.31.1-1
Hello Vincent, Vincent Blut wrote on 2015-08-20 18:12: I assume that the change of maintainership has the consent of Joachim? Yes, we’ve discussed about this privately some times ago. Still ok Joachim? Yes, that is fully ok. You make a very good job with maintaining chrony! Thank you very much for overtaking. --- Have a nice day. Joachim (Germany) signature.asc Description: PGP signature
Bug#793876: RFS: chrony/1.31.1-1
Le jeu. 20 août 2015 à 12:10, Paul Gevers elb...@debian.org a écrit : Hi Vincent, Hello Paul, Live from Debconf15. I’m watching you folks, you all look great. :-) On 19-08-15 21:29, Vincent Blut wrote: I am looking for a sponsor for my package chrony Please note this is a first manual inspection. Not all items are critical, most are just nitpicks or tips or questions. Please add the CVE numbers that were fixed by upstream to your changelog such that the trackers can find it automatically. TIP: if you would have done that and mention that in your RFS you would have probably found a sponsor earlier. I didn’t include them because those fixes have been backported to chrony 1.30-2 in Debian (thanks Joachim btw) and consequently the CVE numbers have already been mentionned in this release’s changelog. Your priority switch from extra to optional may require a ping to somebody. I am not sure and I would need to search, so please do that yourself. Yes. I’ll have to send a bug report to the ftp.debian.org pseudo-package asking for the modification of the section/priority in the override-file. Will do later today… or tomorrow. Which file do you have in common with ntp? Please re-read ¹. I guess I’ve been misled by § 7.6.2! The previous section shows the usage of the 'replaces:' field for packages providing *files* already provided by another package. However, the section 7.6.2 seems to be for *packages* that /do conflict/; I interpreted that /do conflict/ by packages providing the same functionality. I even was quite sure my interpretation was correct after seeing the usage example about MTAs. Anyway, depending on your answer, I’ll revert this commit. I assume that the change of maintainership has the consent of Joachim? Yes, we’ve discussed about this privately some times ago. Still ok Joachim? Wouldn't the hwclockfile stuff in /etc not warrant an debian/NEWS update? Or at the very least some help in the changelog? I don’t think so. Finally, that change have no impact for the user. Previously we had to check (in the postinst script) if the RTC keeps local time or UTC by parsing /etc/adjtime and/or /etc/default/rcS. Depending on the result, we set (or no) the rtconutc directive in /etc/chrony.conf. But now chrony is grown enough to check that by itself. Each time it is started, it will parse the correspondent value in the /etc/adjtime file. So, as you can see, the whole point of using the hwclockfile directive is to have something cleaner than playing the text processing game for the same result. Doesn't this actually require a migration path? What if the /etc/chrony and /etc/adjtime are NOT answering the same? Well, I’m not sure I’m understanding you here. The chronyd daemon will use what /etc/adjtime returns, thanks to the 'hwclockfile /etc/adjtime' directive. Can you please explain me how commit 1ce86d3 works (the Breaks of util-linux). As the hwclockfile directive can only deal with /etc/adjtime, we need to ensure that we migrated from /etc/default/rcS to /etc/adjtime. To be honest, I’m not sure that break is even needed, because this migration happened prior to Wheezy. I assume you tested all migrations for admins that already ran chrony as a different users as described in the README.Debian. Are the manual steps even needed? Shouldn't this go into a NEWS file instead of the README file? I tested a lot of use cases, but Jerome Benoit informed me he had an issue possibly related to this change, but as he uses a custom init script etc., I will have to check his atypical configuration. Line 36 of the README.Debian file ends weird now, you removed a filename but not the and in front. Indeed, will fix. You mean line 27 right? Nice to have, could you think of some autopkgtest test²? And why are the tests disabled. Unless they fail and can't be fixed, it is really recommended to run them. I’m definitely interested in autopkgtest. However I’ll need some times to dive through its meanders. I don’t known why tests have originally been disabled, but I guess it’s because they depend on the clknetsim tool which is not packaged in Debian. Also, if that tool isn’t installed on the system, the test.common script will try to download and build the tool, which is a quite invasive method. Am I wrong Joachim? I think the comments you added in commit df80cd25 in the copyright file, should the Comment field.³ Definitely, will fix. And tip to prevent the fix in commit 7245a4, use dch to write the timestamps (e.g. dch -rm) So true. I discovered this tool to late. ;-) Thanks for the reminder. You could maybe remind upstream to update their copyright years when they make changes. Indeed. Paul Thanks for the initial review, Vincent
Bug#793876: RFS: chrony/1.31.1-1
On Tue, 28 Jul 2015 14:18:54 +0200 Vincent Blut vincent.deb...@free.fr wrote: Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package chrony * Package name: chrony Version : 1.31.1-1 Upstream Author : Miroslav Lichvar mlich...@redhat.com * URL : http://chrony.tuxfamily.org * License : GPL-2 Section : net It builds those binary packages: chrony - Versatile implementation of the Network Time Protocol To access further information about this package, please visit the following URL: http://mentors.debian.net/package/chrony Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/c/chrony/chrony_1.31.1-1.dsc Changes since the last upload: * Import upstream version 1.31 and 1.31.1: - Please see /usr/share/doc/chrony/changelog.gz for release notes. * debian/chrony.conf: - Use the 'hwclockfile' directive. Avoid using text processing methods in the post install script to find out if the RTC keeps local time or UTC. (Closes: #778710) * debian/clean: - Add getdate.c * debian/control: - Move chrony from admin to net section. - Change priority from extra to optional. - Build depends on libcap-dev. (Closes: #768803) - Add ntp to the 'Replaces:' field. - Bump standards-version to 3.9.6 (no changes required). - Set myself as maintainer and Joachim as uploader. - Update Vcs-Browser URL to use cgit and https. - Build depends on pps-tools. Provides PPSAPI (RFC-2783) support. - Improve the synopsis. - Add Breaks on util-linux ( 2.20.1-5). Ensure that the 'UTC=' setting from the '/etc/default/rcS' file have been migrated to UTC/LOCAL in '/etc/adjtime'. - Depends on adduser. Needed to create _chrony system user/group. * debian/copyright: - Add myself to copyright holders. - Remove spaces from short name license (fix Lintian warning) - Filled short license field (RSA-MD) (fix Lintian warning) * debian/logrotate: - Simplify postrotate script. Thanks to Frédéric Brière fbri...@fbriere.net for reporting and diagnosing the issue. (Closes: #763542) * debian/patches: - Drop patches for issues fixed upstream. - Rename and update patch. Update the series file accordingly. * debian/postinst: - Pass the '--three-way' option to ucf. - Remove useless text processing methods as we now use the 'hwclockfile' directive. (Closes: #778711) - Create _chrony system user/group. - Update the new_file path in the ucf invocation. - Remove the MAILPASSWORD shell variable as we don’t use it. * debian/postrm: - Drop removal instruction of /etc/cron.weekly/chrony. - Remove _chrony system user/group on purge. - Don’t pass the --group option to deluser. * debian/rules: - Build with all hardening flags. - Ease the reading of configure options. - Specify _chrony as default chronyd user. This is the system user to which chronyd will drop root privileges. You'll find further information in /usr/share/doc/chrony/README.Debian. (Closes: #688971) Cheers, Vincent Aloha, So, nobody’s interested to see chrony updated ? ;-) Regards, Vincent
Re: Bug#793876: RFS: chrony/1.31.1-1
For something as one week, the current GIT version at Aliot works great on my box. (even if the option -u doent work). On 20/08/15 00:18, Vincent Blut wrote: Le mer. 19 août 2015 à 22:23, Paul Gevers elb...@debian.org a écrit : control: owner -1 ! On 19-08-15 21:29, Vincent Blut wrote: So, nobody’s interested to see chrony updated ? ;-) I will look at it soon. Paul Great, thanks Paul. Cheers, Jerome
Bug#793876: RFS: chrony/1.31.1-1
control: owner -1 ! On 19-08-15 21:29, Vincent Blut wrote: So, nobody’s interested to see chrony updated ? ;-) I will look at it soon. Paul signature.asc Description: OpenPGP digital signature
Bug#793876: RFS: chrony/1.31.1-1
Le mer. 19 août 2015 à 22:23, Paul Gevers elb...@debian.org a écrit : control: owner -1 ! On 19-08-15 21:29, Vincent Blut wrote: So, nobody’s interested to see chrony updated ? ;-) I will look at it soon. Paul Great, thanks Paul.
Bug#793876: RFS: chrony/1.31.1-1
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package chrony * Package name: chrony Version : 1.31.1-1 Upstream Author : Miroslav Lichvar mlich...@redhat.com * URL : http://chrony.tuxfamily.org * License : GPL-2 Section : net It builds those binary packages: chrony - Versatile implementation of the Network Time Protocol To access further information about this package, please visit the following URL: http://mentors.debian.net/package/chrony Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/c/chrony/chrony_1.31.1-1.dsc Changes since the last upload: * Import upstream version 1.31 and 1.31.1: - Please see /usr/share/doc/chrony/changelog.gz for release notes. * debian/chrony.conf: - Use the 'hwclockfile' directive. Avoid using text processing methods in the post install script to find out if the RTC keeps local time or UTC. (Closes: #778710) * debian/clean: - Add getdate.c * debian/control: - Move chrony from admin to net section. - Change priority from extra to optional. - Build depends on libcap-dev. (Closes: #768803) - Add ntp to the 'Replaces:' field. - Bump standards-version to 3.9.6 (no changes required). - Set myself as maintainer and Joachim as uploader. - Update Vcs-Browser URL to use cgit and https. - Build depends on pps-tools. Provides PPSAPI (RFC-2783) support. - Improve the synopsis. - Add Breaks on util-linux ( 2.20.1-5). Ensure that the 'UTC=' setting from the '/etc/default/rcS' file have been migrated to UTC/LOCAL in '/etc/adjtime'. - Depends on adduser. Needed to create _chrony system user/group. * debian/copyright: - Add myself to copyright holders. - Remove spaces from short name license (fix Lintian warning) - Filled short license field (RSA-MD) (fix Lintian warning) * debian/logrotate: - Simplify postrotate script. Thanks to Frédéric Brière fbri...@fbriere.net for reporting and diagnosing the issue. (Closes: #763542) * debian/patches: - Drop patches for issues fixed upstream. - Rename and update patch. Update the series file accordingly. * debian/postinst: - Pass the '--three-way' option to ucf. - Remove useless text processing methods as we now use the 'hwclockfile' directive. (Closes: #778711) - Create _chrony system user/group. - Update the new_file path in the ucf invocation. - Remove the MAILPASSWORD shell variable as we don’t use it. * debian/postrm: - Drop removal instruction of /etc/cron.weekly/chrony. - Remove _chrony system user/group on purge. - Don’t pass the --group option to deluser. * debian/rules: - Build with all hardening flags. - Ease the reading of configure options. - Specify _chrony as default chronyd user. This is the system user to which chronyd will drop root privileges. You'll find further information in /usr/share/doc/chrony/README.Debian. (Closes: #688971) Cheers, Vincent -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20150728121854.20773.10273.reportbug@lamella