Bug#796395: RFS: rolldice/1.14-1 ITA
Hi again Thomas,
I've uploaded a new version to mentors fixing all the problems described
above/below.
yes, mostly done I see just some issues left:
1)
* Update debian/changelog to conform to DEP5
I guess you didn't mean changelog :p
2)
About the cmake file, please answer.
I really do not like custom makefiles, specially because they hide many
troubles.
e.g. what if the user wants something like
export CC=clang in their rules file?
this just won't work :)
3) I just wrote a cmake file, and I even noticed you don't need math.h at all
(you seem to open dev/random for your random files)
4) you have some warning in the build log
gcc -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector-strong -Wformat
-Werror=format-security -g -c main.c
gcc -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector-strong -Wformat
-Werror=format-security -g -c rolldice.c
rolldice.c: In function 'get_num_sides':
cc1: warning: function may return address of local variable
[-Wreturn-local-addr]
rolldice.c:183:43: note: declared here
int *get_num_sides(char *dice_string, int temp_int, int *res_int){
^
cc1: warning: function may return address of local variable
[-Wreturn-local-addr]
rolldice.c:183:43: note: declared here
rolldice.c: In function 'get_num_drop':
cc1: warning: function may return address of local variable
[-Wreturn-local-addr]
rolldice.c:200:42: note: declared here
int *get_num_drop(char *dice_string, int temp_int, int *res_int){
^
rolldice.c: In function 'get_num_rolls':
cc1: warning: function may return address of local variable
[-Wreturn-local-addr]
rolldice.c:211:24: note: declared here
int *get_num_rolls(int temp_int, int *res_int){
^
rolldice.c: In function 'get_mutiplier':
cc1: warning: function may return address of local variable
[-Wreturn-local-addr]
rolldice.c:221:43: note: declared here
int *get_mutiplier(char *dice_string, int temp_int, int *res_int){
^
rolldice.c: In function 'get_plus_modifier':
cc1: warning: function may return address of local variable
[-Wreturn-local-addr]
rolldice.c:232:47: note: declared here
int *get_plus_modifier(char *dice_string, int temp_int, int *res_int){
^
rolldice.c: In function 'get_minus_modifier':
cc1: warning: function may return address of local variable
[-Wreturn-local-addr]
rolldice.c:243:48: note: declared here
int *get_minus_modifier(char *dice_string, int temp_int, int *res_int){
^
gcc -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector-strong -Wformat
-Werror=format-security main.o rolldice.o -g -o rolldice -Wl,-z,relro -lm
-lreadline
5)
cat CMakeLists.txt
cmake_minimum_required(VERSION 2.8)
add_executable(rolldice main.c rolldice.c)
install(TARGETS rolldice DESTINATION bin)
target_link_libraries(rolldice readline)
this is the cmake file I wrote for you.
Simple, works with clang
mkdir build
cd build
export VERBOSE=1
export CC=clang
it still needs some little tweaks:
a) find readline with cmake features (and fail if readline is not found)
b) generate the man page (trivial, but I don't want to do the work
if you don't want a cmake file)
c) install the manpage (lol)
d) think about the version.h, and maybe change it in version.h.in and generate
it
from cmake
e) instead of using sed, use cmake features to configure a file (like manpage)
I can do all of them in a couple of minutes, but they are changes that might be
good if
upstreamed :)
let me know :)
cheers,
G.
Bug#796395: RFS: rolldice/1.14-1 ITA
Hi, I've uploaded a new version to mentors fixing all the problems described above/below. Thanks, Thomas. On 22/08/15 02:40 AM, Gianfranco Costamagna wrote: Did you mean to close the bug? nope, sorry About the dep5 copyright issue, yes, I accidentally left out the header. no problem I will fix the use-flag patch as you described. ok (this shouldn't change anything, since LDFLAGS in this case are the Debian flags, and for sure they do not add libraries to link, so the risk of stripping them is 0) About the man page, the reason I didn't have it be installed by dh_manpages is the man page is edited in the Makefile, adding the version number (see make target 'man'). Should I add the version number myself and have it be installed by dh? nope, it is good that way, just I really do not like custom Makefiles :) Would you add a cmake file if I provide one to you? cheers, G. signature.asc Description: OpenPGP digital signature
Bug#796395: RFS: rolldice/1.14-1 ITA
Did you mean to close the bug? nope, sorry About the dep5 copyright issue, yes, I accidentally left out the header. no problem I will fix the use-flag patch as you described. ok (this shouldn't change anything, since LDFLAGS in this case are the Debian flags, and for sure they do not add libraries to link, so the risk of stripping them is 0) About the man page, the reason I didn't have it be installed by dh_manpages is the man page is edited in the Makefile, adding the version number (see make target 'man'). Should I add the version number myself and have it be installed by dh? nope, it is good that way, just I really do not like custom Makefiles :) Would you add a cmake file if I provide one to you? cheers, G.
Bug#796395: RFS: rolldice/1.14-1 ITA
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package rolldice * Package name: rolldice Version : 1.14-1 Upstream Author : [fill in name and email of upstream] * URL : [fill in URL of upstreams web site] * License : [fill in] Section : games It builds those binary packages: rolldice - virtual dice roller To access further information about this package, please visit the following URL: http://mentors.debian.net/package/rolldice Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/r/rolldice/rolldice_1.14-1.dsc More information about rolldice can be obtained from https://github.com/sstrickl/rolldice Changes since the last upload: rolldice (1.14-1) unstable; urgency=medium * New upstream release (Closes: #74583, #672418) * Removed patch 01_remove_strip.diff - fixed upstream * Removed patch debian-changes-1.10-5 * Don't timestamp the man page * debian/control - Bump standards-version to 3.9.6 - Removed quilt from build-depends - Added libreadline-dev to build-depends - Updated homepage - New maintainer (Closes: #784189)) - Removed article from short description * debian/rules - Remove 'dh_clean -k' in favor of 'dh_prep' - Hardened executables - Add build-arch and build-indep targets -- Thomas Ross th0m4sr...@gmail.com Thu, 20 Aug 2015 20:55:20 -0400 Regards, Thomas Ross signature.asc Description: OpenPGP digital signature
Bug#796395: RFS: rolldice/1.14-1 ITA
I have updated the watch file. The new version is on mentors. Regards, Thomas. signature.asc Description: OpenPGP digital signature
Bug#796395: RFS: rolldice/1.14-1 ITA
I have updated the copyright file to conform to dep5. The new version is on mentors. Regards, Thomas.
Bug#796395: RFS: rolldice/1.14-1 ITA
Whoops, forgot to fill in some details: Upstream Author : Stevie Strickland sstri...@cs.brown.edu * URL : https://github.com/sstrickl/rolldice * License : GPL-2 On 21/08/15 01:47 PM, Thomas Ross wrote: Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package rolldice * Package name: rolldice Version : 1.14-1 Upstream Author : [fill in name and email of upstream] * URL : [fill in URL of upstreams web site] * License : [fill in] Section : games It builds those binary packages: rolldice - virtual dice roller To access further information about this package, please visit the following URL: http://mentors.debian.net/package/rolldice Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/r/rolldice/rolldice_1.14-1.dsc More information about rolldice can be obtained from https://github.com/sstrickl/rolldice Changes since the last upload: rolldice (1.14-1) unstable; urgency=medium * New upstream release (Closes: #74583, #672418) * Removed patch 01_remove_strip.diff - fixed upstream * Removed patch debian-changes-1.10-5 * Don't timestamp the man page * debian/control - Bump standards-version to 3.9.6 - Removed quilt from build-depends - Added libreadline-dev to build-depends - Updated homepage - New maintainer (Closes: #784189)) - Removed article from short description * debian/rules - Remove 'dh_clean -k' in favor of 'dh_prep' - Hardened executables - Add build-arch and build-indep targets -- Thomas Ross th0m4sr...@gmail.com Thu, 20 Aug 2015 20:55:20 -0400 Regards, Thomas Ross signature.asc Description: OpenPGP digital signature
Bug#796395: RFS: rolldice/1.14-1 ITA
Oops, it looks like I missed the format header in the copyright file. Unfortunately I will not be able to fix this until Sunday. Regards, Thomas On Friday, 21 August 2015, Thomas Ross th0m4sr...@gmail.com wrote: I have updated the copyright file to conform to dep5. The new version is on mentors. Regards, Thomas.
Bug#796395: RFS: rolldice/1.14-1 ITA
Hi Did you mean to close the bug? About the dep5 copyright issue, yes, I accidentally left out the header. I will fix the use-flag patch as you described. About the man page, the reason I didn't have it be installed by dh_manpages is the man page is edited in the Makefile, adding the version number (see make target 'man'). Should I add the version number myself and have it be installed by dh? Regards, Thomas On Friday, 21 August 2015, Gianfranco Costamagna locutusofb...@debian.org wrote: Control: owner -1 ! Control: tags -1 moreinfo Hi Thomas, the version in mentors has no dep5 copyright. Bonus point for having a dh rules file (seems trivial) another problem regarding the use-flag patch. - $(CC) $(OBJFILES) -g -o rolldice $(LIBS) + $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) $(OBJFILES) -g -o rolldice $(LIBS) I would move LDFLAGS at the end, near LIBS, because otherwise they might be stripped by the linker (not sure, but I guess the linker might strip libraries if the previous object files in the command line are not using them) BTW do you install the manpage? I guess you might want to install by dh_manpages, the same for installdocs... I guess a dh default call might do everything the rules file does right now after that I guess it is good (note I still need to check the copyright and to build it) BTW License: GPL-2+ License: GPL-2 you need to describe the same license as above, not a different one :) (it might be fixed in the dep5 copyright that hasn't been uploaded, don't know) cheers, G.
