Bug#802298: RFS: php-htmlawed/1.1.20-2 [ITP] -- htmLawed PHP code to purify & filter HTML

[Bhuvan Krishna]

On Saturday 02 January 2016 06:30 PM, Mattia Rizzolo wrote:
> On Sat, Jan 02, 2016 at 05:14:42PM +0530, Bhuvan Krishna wrote:
>> Fixed all the above bugs and uploaded to mentors. Please have a look at
>> the source files.
>> http://mentors.debian.net/debian/pool/main/p/php-htmlawed/php-htmlawed_1.1.20-1.dsc
>
> umh, ok, but in doing this you also did other changes, the of which I
> don't like the followings:
> * you removed debian/watch  => ??? why?
Because there is no consistency of naming the upstream packages. Though
the version numbers, changelog is maintained but name of the zip file is
not consistent.
> * you added an override_dh_install, so you could run a chmod.  please
>   override dh_fixperms instead.
Fixed this by replacing dh_install with dh_fixperms
>
>




signature.asc
Description: OpenPGP digital signature

Bug#802298: RFS: php-htmlawed/1.1.20-2 [ITP] -- htmLawed PHP code to purify & filter HTML

[Bhuvan Krishna]

On Saturday 02 January 2016 04:38 PM, Mattia Rizzolo wrote:
> On Mon, Oct 19, 2015 at 12:37:22PM +0530, Bhuvan Krishna wrote:
>> http://mentors.debian.net/debian/pool/main/p/php-htmlawed/php-htmlawed_1.1.20-2.dsc
> a review, (using the -1):
>
> * you're not yet in pkg-php-pear, so I'd suggest putting yourself as
>   maintainer until then, as you did with php-mf2
> * the php dependency is just wrong, since 'php' is a metapackage with a
>   different versioning, etc.  probably using php5-common (>= 5.3.0) as
>   phpcomposer does it enough.
> * you build-depend on pkg-php-tools, but you use none of the helpers,
>   please drop the build-dep.
> * the copyright file say GPL-2+, but you point to the GPL-3 file under
>   /user/share/common-licenses, please point to the GPL-2 file instead
> * please remove line 17 on d/copyright, so you have only one blank line
>   between stanzas.
Fixed all the above bugs and uploaded to mentors. Please have a look at
the source files.
http://mentors.debian.net/debian/pool/main/p/php-htmlawed/php-htmlawed_1.1.20-1.dsc



signature.asc
Description: OpenPGP digital signature

Bug#802298: RFS: php-htmlawed/1.1.20-2 [ITP] -- htmLawed PHP code to purify & filter HTML

[Mattia Rizzolo]

On Sat, Jan 02, 2016 at 05:14:42PM +0530, Bhuvan Krishna wrote:
> Fixed all the above bugs and uploaded to mentors. Please have a look at
> the source files.
> http://mentors.debian.net/debian/pool/main/p/php-htmlawed/php-htmlawed_1.1.20-1.dsc


umh, ok, but in doing this you also did other changes, the of which I
don't like the followings:
* you removed debian/watch  => ??? why?
* you added an override_dh_install, so you could run a chmod.  please
  override dh_fixperms instead.


-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  http://mapreri.org  : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#802298: RFS: php-htmlawed/1.1.20-2 [ITP] -- htmLawed PHP code to purify & filter HTML

[Mattia Rizzolo]

On Mon, Oct 19, 2015 at 12:37:22PM +0530, Bhuvan Krishna wrote:
> http://mentors.debian.net/debian/pool/main/p/php-htmlawed/php-htmlawed_1.1.20-2.dsc

a review, (using the -1):

* you're not yet in pkg-php-pear, so I'd suggest putting yourself as
  maintainer until then, as you did with php-mf2
* the php dependency is just wrong, since 'php' is a metapackage with a
  different versioning, etc.  probably using php5-common (>= 5.3.0) as
  phpcomposer does it enough.
* you build-depend on pkg-php-tools, but you use none of the helpers,
  please drop the build-dep.
* the copyright file say GPL-2+, but you point to the GPL-3 file under
  /user/share/common-licenses, please point to the GPL-2 file instead
* please remove line 17 on d/copyright, so you have only one blank line
  between stanzas.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  http://mapreri.org  : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#802298: RFS: php-htmlawed/1.1.20-2 [ITP] -- htmLawed PHP code to purify & filter HTML

[Bhuvan Krishna]

Hi Gianfranco,

Thanks for the reply. I wrote a mail to php pear team asking them to
look into the project and if possible take it up as a php-pear project.
Hope they will responds.

Thanks again for responding.

Regards,
Bhuvan


On Monday 19 October 2015 05:00 PM, Gianfranco Costamagna wrote:
> Hi,
>
> I'm not a php savvy person, I guess you might have some luck in finding a 
> sponsor
> on the debian php team
> https://qa.debian.org/developer.php?login=pkg-php-ma...@lists.alioth.debian.org
>
> (otherwise I'll try my best to look at the package, but I'm not doing php 
> related stuff
> since two years or so)
>
> cheers,
>
> G.
>
>
>
>
> Il Lunedì 19 Ottobre 2015 9:09, Bhuvan Krishna  ha scritto:
> Package: sponsorship-requests
>   Severity: wishlist
>
>   Dear mentors,
>
>   I am looking for a sponsor for my package "php-htmlawed"
>
> * Package name: php-htmlawed
>Version : 1.1.20-2
>Upstream Author : Santosh Patnaik 
> * URL :
> http://www.bioinformatics.org/phplabware/internal_utilities/htmLawed/
> * License : LGPL-3 or GPL-2+
>Section : php
>
>   It builds those binary packages:
>
> php-htmlawed - htmLawed PHP code to purify & filter HTML
>
>   To access further information about this package, please visit the
> following URL:
>
>   http://mentors.debian.net/package/php-htmlawed
>
>
>   Alternatively, one can download the package with dget using this command:
>
> dget -x
> http://mentors.debian.net/debian/pool/main/p/php-htmlawed/php-htmlawed_1.1.20-2.dsc
>
> This package is required for building gnu-social package.
>
>
>   Changes since the last upload:
>
>   Initial release. (Closes: #802038)
>
>
>   Regards,
>Bhuvan Krishna




signature.asc
Description: OpenPGP digital signature

Bug#802298: RFS: php-htmlawed/1.1.20-2 [ITP] -- htmLawed PHP code to purify & filter HTML

[Bhuvan Krishna]

Hi Gianfranco & Mattia,

Thanks for the reply. I wrote a mail to php pear team asking them to
look into the project and if possible take it up as a php-pear project.
Hope they will responds. Thanks again for responding.

I put up Debian PHP PEAR Maintainers
 as the Maintainer.

Regards,
Bhuvan


 On Monday 19 October 2015 05:00 PM, Gianfranco Costamagna wrote:
>> Hi,
>>
>> I'm not a php savvy person, I guess you might have some luck in finding a 
>> sponsor
>> on the debian php team
>> https://qa.debian.org/developer.php?login=pkg-php-ma...@lists.alioth.debian.org
>>
>> (otherwise I'll try my best to look at the package, but I'm not doing php 
>> related stuff
>> since two years or so)
>>
>> cheers,
>>
>> G.
>>
>>
>>
>>
>> Il Lunedì 19 Ottobre 2015 9:09, Bhuvan Krishna  ha 
>> scritto:
>> Package: sponsorship-requests
>>   Severity: wishlist
>>
>>   Dear mentors,
>>
>>   I am looking for a sponsor for my package "php-htmlawed"
>>
>> * Package name: php-htmlawed
>>Version : 1.1.20-2
>>Upstream Author : Santosh Patnaik 
>> * URL :
>> http://www.bioinformatics.org/phplabware/internal_utilities/htmLawed/
>> * License : LGPL-3 or GPL-2+
>>Section : php
>>
>>   It builds those binary packages:
>>
>> php-htmlawed - htmLawed PHP code to purify & filter HTML
>>
>>   To access further information about this package, please visit the
>> following URL:
>>
>>   http://mentors.debian.net/package/php-htmlawed
>>
>>
>>   Alternatively, one can download the package with dget using this command:
>>
>> dget -x
>> http://mentors.debian.net/debian/pool/main/p/php-htmlawed/php-htmlawed_1.1.20-2.dsc
>>
>> This package is required for building gnu-social package.
>>
>>
>>   Changes since the last upload:
>>
>>   Initial release. (Closes: #802038)
>>
>>
>>   Regards,
>>Bhuvan Krishna
>




signature.asc
Description: OpenPGP digital signature

Bug#802298: RFS: php-htmlawed/1.1.20-2 [ITP] -- htmLawed PHP code to purify & filter HTML

[Bhuvan Krishna]

Package: sponsorship-requests
  Severity: wishlist

  Dear mentors,

  I am looking for a sponsor for my package "php-htmlawed"

 * Package name: php-htmlawed
   Version : 1.1.20-2
   Upstream Author : Santosh Patnaik 
 * URL :
http://www.bioinformatics.org/phplabware/internal_utilities/htmLawed/
 * License : LGPL-3 or GPL-2+
   Section : php

  It builds those binary packages:

php-htmlawed - htmLawed PHP code to purify & filter HTML

  To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/php-htmlawed


  Alternatively, one can download the package with dget using this command:

dget -x
http://mentors.debian.net/debian/pool/main/p/php-htmlawed/php-htmlawed_1.1.20-2.dsc

This package is required for building gnu-social package.


  Changes since the last upload:

  Initial release. (Closes: #802038)


  Regards,
   Bhuvan Krishna



signature.asc
Description: OpenPGP digital signature

Bug#802298: RFS: php-htmlawed/1.1.20-2 [ITP] -- htmLawed PHP code to purify & filter HTML

[Mattia Rizzolo]

On Mon, Oct 19, 2015 at 11:30:04AM +, Gianfranco Costamagna wrote:
> I'm not a php savvy person, I guess you might have some luck in finding a 
> sponsor
> on the debian php team
> https://qa.debian.org/developer.php?login=pkg-php-ma...@lists.alioth.debian.org

Note:
pkg-php-maint packages the PHP interepreter itself, you are looking for
pkg-php-pear:

https://qa.debian.org/developer.php?login=pkg-php-p...@lists.alioth.debian.org

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  http://mapreri.org  : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#802298: RFS: php-htmlawed/1.1.20-2 [ITP] -- htmLawed PHP code to purify & filter HTML

[Gianfranco Costamagna]

Hi,

I'm not a php savvy person, I guess you might have some luck in finding a 
sponsor
on the debian php team
https://qa.debian.org/developer.php?login=pkg-php-ma...@lists.alioth.debian.org

(otherwise I'll try my best to look at the package, but I'm not doing php 
related stuff
since two years or so)

cheers,

G.




Il Lunedì 19 Ottobre 2015 9:09, Bhuvan Krishna  ha scritto:
Package: sponsorship-requests
  Severity: wishlist

  Dear mentors,

  I am looking for a sponsor for my package "php-htmlawed"

* Package name: php-htmlawed
   Version : 1.1.20-2
   Upstream Author : Santosh Patnaik 
* URL :
http://www.bioinformatics.org/phplabware/internal_utilities/htmLawed/
* License : LGPL-3 or GPL-2+
   Section : php

  It builds those binary packages:

php-htmlawed - htmLawed PHP code to purify & filter HTML

  To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/php-htmlawed


  Alternatively, one can download the package with dget using this command:

dget -x
http://mentors.debian.net/debian/pool/main/p/php-htmlawed/php-htmlawed_1.1.20-2.dsc

This package is required for building gnu-social package.


  Changes since the last upload:

  Initial release. (Closes: #802038)


  Regards,
   Bhuvan Krishna