Bug#802477: RFS: django-localflavor/1.1-1 [ITP]

2015-10-23 Thread Orestis Ioannou 
Hello,

Thanks for the review..
Some updates:

In the end i intend to package this in the DPMT so here's the git link
with the up to date repo
https://anonscm.debian.org/cgit/python-modules/packages/python-django-localflavor.git/

I fixed most of the issues you mentioned plus some other things i found...
On 10/23/2015 01:26 PM, Gianfranco Costamagna wrote:

So here i have a question...

> d) copyright:
> 
> I see in setup.py
> 
> # (c) 2005 Ian Bicking and contributors; written for Paste 
> (http://pythonpaste.org)
> # Licensed under the MIT license: 
> http://www.opensource.org/licenses/mit-license.php
> # Note: you may want to copy this into your setup.py file verbatim, as
> # you can't import this from another package, when you don't know if
> # that package is installed yet.
> 
> 
> please investigate where the MIT license is applicable and where the license 
> is BSD
> 


I am not sure what to think here.. I ve found other packages with
similar citings in setup.py
http://sources.debian.net/src/python-django-compressor/1.5-3/setup.py/?hl=38#L38
http://sources.debian.net/src/cliff-tablib/1.1-1/setup.py/?hl=24#L24
http://sources.debian.net/src/python-django-formtools/1.0-1/setup.py/?hl=32#L32

but i couldn't find any particular mention in those packages copyright
files.. and i am not really sure how to proceed with this..

Cheers,
Orestis



signature.asc
Description: OpenPGP digital signature

Bug#802477: RFS: django-localflavor/1.1-1 [ITP]

2015-10-23 Thread Gianfranco Costamagna 
Control: owner -1 !
Control: tags -1 moreinfo

let's review:
a) control: "python-django-localflavor python3-django-localflavor" duplicate 
short description
b) rules: please remove lines 3-4
c) control: please add a -doc package
(you can take some bits from python-pyqtgraph package)

d) copyright:

I see in setup.py

# (c) 2005 Ian Bicking and contributors; written for Paste 
(http://pythonpaste.org)
# Licensed under the MIT license: 
http://www.opensource.org/licenses/mit-license.php
# Note: you may want to copy this into your setup.py file verbatim, as
# you can't import this from another package, when you don't know if
# that package is installed yet.


please investigate where the MIT license is applicable and where the license is 
BSD



the other stuff LGTM.

cheers,

G.


Il Martedì 20 Ottobre 2015 14:39, Orestis Ioannou  ha 
scritto:
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "django-localflavor"

* Package name: django-localflavor
   Version : 1.1-1
   Upstream Author : Django Software Foundation
* URL : https://pypi.python.org/pypi/django-localflavor
* License : BSD
   Section : python

This upload would also close a RFP bug: 737485
and help resolve an FTBFS since python-wtforms fails with the latest
django because of the localflavor dependency
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=801940  (more details
in the build log)

It builds those binary packages:

python-django-localflavor - Country-specific Django helpers
python3-django-localflavor - Country-specific Django helpers

  To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/django-localflavor


  Alternatively, one can download the package with dget using this command:

dget -x
http://mentors.debian.net/debian/pool/main/d/django-localflavor/django-localflavor_1.1-1.dsc



  Regards,
   Orestis Ioannou

Bug#802477: RFS: django-localflavor/1.1-1 [ITP]

2015-10-23 Thread Gianfranco Costamagna 
Hi,


>In the end i intend to package this in the DPMT so here's the git link
>with the up to date repo
>https://anonscm.debian.org/cgit/python-modules/packages/python-django-localflavor.git/


wonderful!
>but i couldn't find any particular mention in those packages copyright
>files.. and i am not really sure how to proceed with this..


fine for me, I guess ftpmasters will have the final decision (they are both 
permissive licenses, so I guess
the package can go in Debian anyway)

please update BSD-3 to BSD-3-clause, update the license description with 
something like this
License: BSD-3-clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
1. Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
3. Neither the name of the University nor the names of its contributors
may be used to endorse or promote products derived from this software
without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
SUCH DAMAGE.

and I guess we are fine to go.

thanks

G.

Bug#802477: RFS: django-localflavor/1.1-1 [ITP]

2015-10-23 Thread Orestis Ioannou 
Hello,
On 10/23/2015 08:11 PM, Gianfranco Costamagna wrote:
> Hi again, a new lintian warning:
> 
> P: django-localflavor source: debian-control-has-unusual-field-spacing line 3
> N: 
> N:The field on this line of debian/control has whitespace other than a
> N:single space after the colon. This is explicitly permitted in the syntax
> N:of Debian control files, but as Policy says, it is conventional to put a
> N:single space after the colon.
> N: 
> N:Refer to Debian Policy Manual section 5.1 (Syntax of control files) for
> N:details.
> N: 
> N:Severity: pedantic, Certainty: certain
> N: 
> N:Check: control-file, Type: source
> 
> please remove the spaces at the end of the file
> (well, running "wrap-and-sort" command should fix it for you)
> 
> cheers,
> 

Done and thanks again :)

Orestis



signature.asc
Description: OpenPGP digital signature

Bug#802477: RFS: django-localflavor/1.1-1 [ITP]

2015-10-23 Thread Gianfranco Costamagna 
Hi again, a new lintian warning:

P: django-localflavor source: debian-control-has-unusual-field-spacing line 3
N: 
N:The field on this line of debian/control has whitespace other than a
N:single space after the colon. This is explicitly permitted in the syntax
N:of Debian control files, but as Policy says, it is conventional to put a
N:single space after the colon.
N: 
N:Refer to Debian Policy Manual section 5.1 (Syntax of control files) for
N:details.
N: 
N:Severity: pedantic, Certainty: certain
N: 
N:Check: control-file, Type: source

please remove the spaces at the end of the file
(well, running "wrap-and-sort" command should fix it for you)

cheers,

G.

Bug#802477: RFS: django-localflavor/1.1-1 [ITP]

2015-10-20 Thread Orestis Ioannou 
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "django-localflavor"

 * Package name: django-localflavor
   Version : 1.1-1
   Upstream Author : Django Software Foundation
 * URL : https://pypi.python.org/pypi/django-localflavor
 * License : BSD
   Section : python

This upload would also close a RFP bug: 737485
and help resolve an FTBFS since python-wtforms fails with the latest
django because of the localflavor dependency
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=801940  (more details
in the build log)

 It builds those binary packages:

 python-django-localflavor - Country-specific Django helpers
 python3-django-localflavor - Country-specific Django helpers

  To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/django-localflavor


  Alternatively, one can download the package with dget using this command:

dget -x
http://mentors.debian.net/debian/pool/main/d/django-localflavor/django-localflavor_1.1-1.dsc



  Regards,
   Orestis Ioannou



signature.asc
Description: OpenPGP digital signature