Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Pilisi Gergely]

Hi,

2016-01-25 18:27 GMT+01:00 Mattia Rizzolo :

>
> So, given that those are still warnings (that would be nice to get rid
> of), and that are for sure not blockers, what would you think about
>
uploading it as it's now and work on it on a later time?
>

I think that's a good idea, we will sort it out later. The latest upload is
available on the mentors site.
Anyway this whole procedure was a really important experience, some
modification will be done on the upstream side to.
So I hope with the next release we will move forward much faster. Thank you
for being so patient with me. :)

BR,
Gergely

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Mattia Rizzolo]

On Tue, Jan 26, 2016 at 12:19:09PM +0100, Jakub Wilk wrote:
> * Pilisi Gergely , 2016-01-22, 14:55:
> >export DEB_BUILD_MAINT_OPTIONS = hardening=+all
> >export CPPFLAGS=$(shell dpkg-buildflags --get CPPFLAGS)
> >export CFLAGS=$(shell dpkg-buildflags --get CFLAGS)
> >export CXXFLAGS=$(shell dpkg-buildflags --get CXXFLAGS)
> >export LDFLAGS=$(shell dpkg-buildflags --get LDFLAGS)
> 
> Note that $(shell) constructs are not affected by variables exported in the
> same makefile.
> 
> >export CCFLAGS=$(shell dplg-buildflags --get CFLAGS)
> 
> Typo: s/dplg/dpkg/.

oh, thank you, indeed!
Your email made me try some more, and I get a better state in blhc.
I noticed that the faulty flag is pie-related.
I applied this:

--- eclipse-titan-5.4.1/debian/rules2016-01-22 13:30:30.0 +
+++ eclipse-titan-5.4.1/debian/rules2016-01-26 23:42:37.0 +
@@ -1,12 +1,9 @@
 #!/usr/bin/make -f
 export V=1
 export DH_VERBOSE=1
-export DEB_BUILD_MAINT_OPTIONS = hardening=+all
-export CPPFLAGS=$(shell dpkg-buildflags --get CPPFLAGS)
-export CFLAGS=$(shell dpkg-buildflags --get CFLAGS)
-export CXXFLAGS=$(shell dpkg-buildflags --get CXXFLAGS)
-export LDFLAGS=$(shell dpkg-buildflags --get LDFLAGS)
-export CCFLAGS=$(shell dplg-buildflags --get CFLAGS)
+
+export DEB_BUILD_OPTIONS=hardening=+all,-pie
+export CCFLAGS = $(shell DEB_BUILD_OPTIONS=hardening=+all,-pie dpkg-buildflags 
--get CFLAGS)
 
 %:
dh $@ --verbose --parallel

Which I like some more than your version (I want to remember you that
debhlper with compat 9+ exports those flags by itself, except CCFLAGS
which is non-standard)

Still, I couldn't carry this thing further.
Given that I like this more, can I upload this instead? :)

> >What is wrong with that? :(
> 
> blhc(1) is invaluable for debugging hardening issues.

Yeah, I do use it, even if usually the thing I fixed in the past were
quite easy to fix and I had ever had the need to look at its output
closer than just glancing over it.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  http://mapreri.org  : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Jakub Wilk]

* Pilisi Gergely , 2016-01-22, 14:55:

export DEB_BUILD_MAINT_OPTIONS = hardening=+all
export CPPFLAGS=$(shell dpkg-buildflags --get CPPFLAGS)
export CFLAGS=$(shell dpkg-buildflags --get CFLAGS)
export CXXFLAGS=$(shell dpkg-buildflags --get CXXFLAGS)
export LDFLAGS=$(shell dpkg-buildflags --get LDFLAGS)


Note that $(shell) constructs are not affected by variables exported in 
the same makefile.



export CCFLAGS=$(shell dplg-buildflags --get CFLAGS)


Typo: s/dplg/dpkg/.


What is wrong with that? :(


blhc(1) is invaluable for debugging hardening issues.

--
Jakub Wilk

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Mattia Rizzolo]

On Fri, Jan 22, 2016 at 02:55:38PM +0100, Pilisi Gergely wrote:
> First of all, thank you for the help. :) The new package is on the mentors
> site.

> I fixed this with exporting the build flags in the debian/rules file:
> 
> export DEB_BUILD_MAINT_OPTIONS = hardening=+all
> export CPPFLAGS=$(shell dpkg-buildflags --get CPPFLAGS)
> export CFLAGS=$(shell dpkg-buildflags --get CFLAGS)
> export CXXFLAGS=$(shell dpkg-buildflags --get CXXFLAGS)
> export LDFLAGS=$(shell dpkg-buildflags --get LDFLAGS)
> export CCFLAGS=$(shell dplg-buildflags --get CFLAGS)

oh, I see, you laso have CCFLAGS, which is kinda of non-standard (and as
such not exported.

> Now the code compiles perfectly, but I still can't see any hardening on the
> binaries.
> Lintian still throws hardening-no-fortify-functions and
> hardening-no-relro...
> 
> What is wrong with that? :(

I'm pretty lost in this :\
I think this needs a more thorough look into the build system to
understan what's wrong with it, but these days I can't really look at
it.

So, given that those are still warnings (that would be nice to get rid
of), and that are for sure not blockers, what would you think about
uploading it as it's now and work on it on a later time?

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  http://mapreri.org  : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Pilisi Gergely]

Hi,

First of all, thank you for the help. :) The new package is on the mentors
site.

2016-01-17 14:09 GMT+01:00 Mattia Rizzolo :

>
> but most importantly, I couldn't get eclipse-titan build today.
> First it failed with
>
> /usr/bin/ld: LoggerPlugin_dynamic.o: undefined reference to symbol
> 'dlclose@@GLIBC_2.2.5'
> //lib/x86_64-linux-gnu/libdl.so.2: error adding symbols: DSO missing from
> command line
> collect2: error: ld returned 1 exit status
> Makefile:307: recipe for target 'libttcn3-dynamic.so' failed
>
>
> Then, I added -ldl to LDFLAGS and retried, just to have
>
> Parallel_main.o: In function `main':
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:203: undefined reference
> to `TCov::close_file()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:208: undefined reference
> to `TTCN_Runtime::install_signal_handlers()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:209: undefined reference
> to `TTCN_Snapshot::initialize()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:210: undefined reference
> to `TTCN_Logger::initialize_logger()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:211: undefined reference
> to `TTCN_Logger::set_executable_name(char const*)'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:212: undefined reference
> to `TTCN_Logger::set_start_time()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:218: undefined reference
> to `Module_List::pre_init_modules()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:219: undefined reference
> to `TTCN_Runtime::hc_main(char const*, char const*, unsigned short)'
> Parallel_main.o: In function `TTCN_Runtime::is_hc()':
> /build/eclipse-titan-5.4.1/core/Runtime.hh:92: undefined reference to
> `TTCN_Runtime::executor_state'
> Parallel_main.o: In function `main':
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:246: undefined reference
> to `TTCN_Runtime::restore_signal_handlers()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:247: undefined reference
> to `TTCN_Logger::close_file()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:248: undefined reference
> to `TCov::close_file()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:251: undefined reference
> to `TTCN_Logger::clear_parameters()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:252: undefined reference
> to `PORT::clear_parameters()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:253: undefined reference
> to `COMPONENT::clear_component_names()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:254: undefined reference
> to `TTCN_EncDec::clear_error()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:256: undefined reference
> to `TTCN_Logger::terminate_logger()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:257: undefined reference
> to `TTCN_Snapshot::terminate()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:223: undefined reference
> to `COMPONENT::clear_component_names()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:226: undefined reference
> to `TTCN_Logger::close_file()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:227: undefined reference
> to `TCov::close_file()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:229: undefined reference
> to `TTCN_Logger::set_start_time()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:233: undefined reference
> to `TTCN_Runtime::ptc_main()'
> Parallel_main.o: In function `process_options':
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:136: undefined reference
> to `TTCN_Runtime::install_signal_handlers()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:137: undefined reference
> to `TTCN_Logger::initialize_logger()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:138: undefined reference
> to `Module_List::pre_init_modules()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:139: undefined reference
> to `Module_List::list_testcases()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:143: undefined reference
> to `TTCN_Logger::terminate_logger()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:157: undefined reference
> to `Module_List::print_version()'
> Parallel_main.o: In function `main':
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:231: undefined reference
> to `TTCN_Runtime::mtc_main()'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:235: undefined reference
> to `TTCN_error(char const*, ...)'
> /build/eclipse-titan-5.4.1/core/Parallel_main.cc:242: undefined reference
> to `TTCN_Logger::log_str(TTCN_Logger::Severity, char const*)'
> Parallel_main.o: In function `__static_initialization_and_destruction_0':
> /build/eclipse-titan-5.4.1/core/../common/version.h:94: undefined
> reference to `reffer::reffer(char const*)'
> Parallel_main.o: In function `JSON_Tokenizer::JSON_Tokenizer(bool)':
> /build/eclipse-titan-5.4.1/core/../common/JSON_Tokenizer.hh:115: undefined
> reference to `JSON_Tokenizer::init(char const*, unsigned long)'
> Parallel_main.o: In function `__static_initialization_and_destruction_0':
> 

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Mattia Rizzolo]

On Thu, Jan 14, 2016 at 02:31:25PM +0100, Pilisi Gergely wrote:
> please check the new version. I fixed a couple of things, but the remaining
> ones got me...

sorry, took some time.  My routine started again after the
winter/christmas break.. :)

A thing.  you changed the .orig.tar.gz.  Don't do that.  Once a release
has been made you can't really change it.
Those are the diffs between the old one and this:
https://paste.debian.net/366300/
Technically speaking, since that file has not yet been uploaded to
ftp-master it can still be changed, but what about other users of it?

> 2016-01-13 15:22 GMT+01:00 Mattia Rizzolo :
> > hardening-wrapper can just go away, the package builds fine anyway.
> > The canonical way to have hardening buildflags is to export
> > DEB_BUILD_MAINT_OPTIONS=hardening=+all in d/rules (instead of
> > DEB_BUILD_HARDENING).
> > Having a look at Makefile.cfg I see:
> > * CFLAGS ain't used (instead there is a CCFLAGS variable);
> > * CXXFLAGS ignores the external env.
> > You may need to patch it a bit.
> 
>  hardening-wrapper wiped out, but new lintian warning showed up:
> hardening-no-relro.
> Tried to DEB_BUILD_MAINT_OPTIONS=hardening=+all, warning still there.
> Tried to set CXXFLAGS:=$(shell dpkg-buildflags --get CXXFLAGS) and use it
> in the Makefile, same result.

In debian/rules, the line about the hardening was commented out.
That means something.

Anyway, adding debian-specific code to upstream is not that nice, other
distributions would have troubles for nothing.  CFLAGS & friends are in
the env, so there is no real need to call dpkg-buildflags that way.
Just do something like 

-CPPFLAGS := $(shell dpkg-buildflags --get CPPFLAGS)
+CPPFLAGS := $(CPPFLAGS)

or directly

CPPFLAGS += -DYY_NO_INPUT

In the diff in the tarball I see some changes from CCFLAGS to CFLAGS.
whatever, dpkg-buildflags exports/uses CFLAGS and not CCFLAGS, but you
can avoid changing upstream sources by just adding
export CCFLAGS = $(shell dplg-buildflags --get CFLAGS)
in d/rules, but YMMV, your call here.


but most importantly, I couldn't get eclipse-titan build today.
First it failed with

/usr/bin/ld: LoggerPlugin_dynamic.o: undefined reference to symbol 
'dlclose@@GLIBC_2.2.5'
//lib/x86_64-linux-gnu/libdl.so.2: error adding symbols: DSO missing from 
command line
collect2: error: ld returned 1 exit status
Makefile:307: recipe for target 'libttcn3-dynamic.so' failed


Then, I added -ldl to LDFLAGS and retried, just to have

Parallel_main.o: In function `main':
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:203: undefined reference to 
`TCov::close_file()'
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:208: undefined reference to 
`TTCN_Runtime::install_signal_handlers()'
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:209: undefined reference to 
`TTCN_Snapshot::initialize()'
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:210: undefined reference to 
`TTCN_Logger::initialize_logger()'
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:211: undefined reference to 
`TTCN_Logger::set_executable_name(char const*)'
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:212: undefined reference to 
`TTCN_Logger::set_start_time()'
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:218: undefined reference to 
`Module_List::pre_init_modules()'
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:219: undefined reference to 
`TTCN_Runtime::hc_main(char const*, char const*, unsigned short)'
Parallel_main.o: In function `TTCN_Runtime::is_hc()':
/build/eclipse-titan-5.4.1/core/Runtime.hh:92: undefined reference to 
`TTCN_Runtime::executor_state'
Parallel_main.o: In function `main':
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:246: undefined reference to 
`TTCN_Runtime::restore_signal_handlers()'
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:247: undefined reference to 
`TTCN_Logger::close_file()'
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:248: undefined reference to 
`TCov::close_file()'
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:251: undefined reference to 
`TTCN_Logger::clear_parameters()'
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:252: undefined reference to 
`PORT::clear_parameters()'
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:253: undefined reference to 
`COMPONENT::clear_component_names()'
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:254: undefined reference to 
`TTCN_EncDec::clear_error()'
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:256: undefined reference to 
`TTCN_Logger::terminate_logger()'
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:257: undefined reference to 
`TTCN_Snapshot::terminate()'
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:223: undefined reference to 
`COMPONENT::clear_component_names()'
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:226: undefined reference to 
`TTCN_Logger::close_file()'
/build/eclipse-titan-5.4.1/core/Parallel_main.cc:227: undefined reference to 
`TCov::close_file()'

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Pilisi Gergely]

Hi,

please check the new version. I fixed a couple of things, but the remaining
ones got me...

2016-01-13 15:22 GMT+01:00 Mattia Rizzolo :

> 2)
> hardening-wrapper can just go away, the package builds fine anyway.
> The canonical way to have hardening buildflags is to export
> DEB_BUILD_MAINT_OPTIONS=hardening=+all in d/rules (instead of
> DEB_BUILD_HARDENING).
> Having a look at Makefile.cfg I see:
> * CFLAGS ain't used (instead there is a CCFLAGS variable);
> * CXXFLAGS ignores the external env.
> You may need to patch it a bit.


 hardening-wrapper wiped out, but new lintian warning showed up:
hardening-no-relro.
Tried to DEB_BUILD_MAINT_OPTIONS=hardening=+all, warning still there.
Tried to set CXXFLAGS:=$(shell dpkg-buildflags --get CXXFLAGS) and use it
in the Makefile, same result.


> 4)
> there are a bunch of debug-file-with-no-debug-symbols and that
> postinst-has-useless-call-to-ldconfig that makes me itch.  I feel there
> is something weird going on, but I wouldn't know what it is.
>

Can't find out what's this. Checked the Makefile, the standard output, but
I can't see anything related to this.

>
> 5)
> do you even look at what lintian says on mentors?
> I: eclipse-titan source: wildcard-matches-nothing-in-dep5-copyright
> mctr2/editline (paragraph at line 5)
> I: eclipse-titan source: unused-file-paragraph-in-dep5-copyright paragraph
> at line 5
>
> the order of the paragraphs in d/copyright is important.  the wildcard
> in the second paragraph overrides the first.  so you need to swap them.
>

Switched the paragraphs, deleted unnecessary white spaces, etc... didn't
worked.
Checked every part of
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0 but
nothing. No more ideas.


> Furthermore I don't see a paragraph for debian/, as I can read it now
> the copyright for debian/* is of "Ericsson Telecom AB".
>

Is this a problem? I'm working at Ericcson, and I'm doing it as part of my
job. :)


>
>
>
>
> --
> regards,
> Mattia Rizzolo
>
> GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
> more about me:  http://mapreri.org  : :'  :
> Launchpad user: https://launchpad.net/~mapreri  `. `'`
> Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
>

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Pilisi Gergely]

Hi,

sorry for removing the bug from my mail, won't happen again. :)
I'm trying to reproduce this:

"About ditching hardening-wrapped in favour of just using what
dpkg-buildflags do:
whatever I use the .dsc you provided, just removed hardening-wrapper or
enable the hardening build flags using DEB_BUILD_MAINT_OPTIONS, the
build fails with

In file included from jnimw.cc:8:0:
jnimw.h:14:17: fatal error: jni.h: No such file or directory
compilation terminated.
../Makefile.genrules:87: recipe for target 'jnimw.o' failed "

This is a typical error message if the compiler can't find a valid JDK on
your system. Do you have /usr/lib/jvm/default-java on your system?
It's a symlink to the default jdk: default-java -> java-1.7.0-openjdk-amd64
I think if openjdk-7-jdk is installed then then the default-java symlink
must be there.

BR,
Gergely

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Pilisi Gergely]

The new package is done, everything is fixed, I hope. I didn't changed
anything in the source, just under the debian/ directory. Should I upload
the package as before or use the dquilt method as
https://www.debian.org/doc/manuals/maint-guide/update suggests?
If I'm right, the update method is for the change in the upstream source,
or?

2016-01-13 12:38 GMT+01:00 Pilisi Gergely :

>
>
> 2016-01-13 12:24 GMT+01:00 Mattia Rizzolo :
>
>>
>> mattia@chase ~ % apt-file search /usr/lib/jvm/default-java
>> default-jre-headless: /usr/lib/jvm/default-java
>>
>> Indeed adding it to build-deps the package builds.
>> Make sure to do your test builds inside a clean chroot.
>>
>
> Oh, just missed this dep, thank you.
>
>
>>
>> BTW, I don't see an update package on mentors (if you meant to upload
>> one).  I can't do much if I can't see what you've done till now :)
>
>
> I want to fix everything what you asked. I'm almost done, just testing the
> copyright part. If it looks good then I'll upload the new package. ;)
> Will back to you soon.
>
>

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Mattia Rizzolo]

On Wed, Jan 13, 2016 at 08:56:55AM +0100, Pilisi Gergely wrote:
> I'm trying to reproduce this:
> 
> "About ditching hardening-wrapped in favour of just using what
> dpkg-buildflags do:
> whatever I use the .dsc you provided, just removed hardening-wrapper or
> enable the hardening build flags using DEB_BUILD_MAINT_OPTIONS, the
> build fails with
> 
> In file included from jnimw.cc:8:0:
> jnimw.h:14:17: fatal error: jni.h: No such file or directory
> compilation terminated.
> ../Makefile.genrules:87: recipe for target 'jnimw.o' failed "
> 
> This is a typical error message if the compiler can't find a valid JDK on
> your system. Do you have /usr/lib/jvm/default-java on your system?
> It's a symlink to the default jdk: default-java -> java-1.7.0-openjdk-amd64
> I think if openjdk-7-jdk is installed then then the default-java symlink
> must be there.

it's not.  Inside the chroot where I build the package:
root@chase:~# ls -l /usr/lib/jvm/
total 0
lrwxrwxrwx 1 root root  20 Dec 12 23:44 java-1.7.0-openjdk-amd64 -> 
java-7-openjdk-amd64
drwxr-xr-x 7 root root 220 Jan 13 11:14 java-7-openjdk-amd64

now, if you need such things, you should build-depend on something that
provides that file.

mattia@chase ~ % apt-file search /usr/lib/jvm/default-java
default-jre-headless: /usr/lib/jvm/default-java

Indeed adding it to build-deps the package builds.
Make sure to do your test builds inside a clean chroot.

BTW, I don't see an update package on mentors (if you meant to upload
one).  I can't do much if I can't see what you've done till now :)

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  http://mapreri.org  : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Pilisi Gergely]

2016-01-13 12:24 GMT+01:00 Mattia Rizzolo :

>
> mattia@chase ~ % apt-file search /usr/lib/jvm/default-java
> default-jre-headless: /usr/lib/jvm/default-java
>
> Indeed adding it to build-deps the package builds.
> Make sure to do your test builds inside a clean chroot.
>

Oh, just missed this dep, thank you.


>
> BTW, I don't see an update package on mentors (if you meant to upload
> one).  I can't do much if I can't see what you've done till now :)


I want to fix everything what you asked. I'm almost done, just testing the
copyright part. If it looks good then I'll upload the new package. ;)
Will back to you soon.

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Gianfranco Costamagna]

Hi,
>The new package is done, everything is fixed, I hope. I didn't changed 
>anything in the source, just under the debian/ directory. Should I upload the 
>package as >before or use the dquilt method as 
>https://www.debian.org/doc/manuals/maint-guide/update suggests?
>If I'm right, the update method is for the change in the upstream source, or?


please read

http://mentors.debian.net/intro-maintainers

(TL:TR)
gbp buildpackage -S -sa
dput mentors ../filename_foo_source.changes


cheers

G.

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Mattia Rizzolo]

On Wed, Jan 13, 2016 at 02:44:25PM +0100, Pilisi Gergely wrote:
> Hi,
> 
> the new package is available on the mentors site:

ok, new iteration :)

1)
Well, I'm conviced that --verbose passed to dh is not what I had in mind
with "verbose building".
I still see

  (C++)  Object.cc
  (CC)   record.c
  (C++)  OCSV.cc
  (CC)   record_of.c
  (CC)   union.c
  (C++)  Tag.cc
  (C++)  PredefFunc.cc
  (C++)  TableConstraint.cc
  (C++)  AST.cc
  (C++)  TokenBuf.cc

that's ↑ not's verbose at all.

Here's an hint for you: this a makefile-based project.  to have GNU make
be more verbose, is enough to export V=1.  This gave me indeed a verbose
output of compilation flags, but somehow the build failed this way (??).
It's very easy to make this program fail to build, feel fragile...

2)
hardening-wrapper can just go away, the package builds fine anyway.
The canonical way to have hardening buildflags is to export
DEB_BUILD_MAINT_OPTIONS=hardening=+all in d/rules (instead of
DEB_BUILD_HARDENING).
Having a look at Makefile.cfg I see:
* CFLAGS ain't used (instead there is a CCFLAGS variable);
* CXXFLAGS ignores the external env.
You may need to patch it a bit.

3)
please fix the following lintian warnings:
W: eclipse-titan: script-with-language-extension usr/bin/ttcn3_archive.pl
I: eclipse-titan: package-contains-empty-directory usr/share/titan/etc/asciiart/
W: eclipse-titan: manpage-has-errors-from-man 
usr/share/man/man1/ttcn3_logfilter.1.gz 11: warning: macro `..' not defined
W: eclipse-titan: manpage-has-errors-from-man 
usr/share/man/man1/ttcn3_logformat.1.gz 54: a space character is not allowed in 
an escape name
W: eclipse-titan: executable-not-elf-or-script usr/bin/ttcn3_archive.pl

4)
there are a bunch of debug-file-with-no-debug-symbols and that
postinst-has-useless-call-to-ldconfig that makes me itch.  I feel there
is something weird going on, but I wouldn't know what it is.

5)
do you even look at what lintian says on mentors?
I: eclipse-titan source: wildcard-matches-nothing-in-dep5-copyright 
mctr2/editline (paragraph at line 5)
I: eclipse-titan source: unused-file-paragraph-in-dep5-copyright paragraph at 
line 5

the order of the paragraphs in d/copyright is important.  the wildcard
in the second paragraph overrides the first.  so you need to swap them.
Furthermore I don't see a paragraph for debian/, as I can read it now
the copyright for debian/* is of "Ericsson Telecom AB".




-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  http://mapreri.org  : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Pilisi Gergely]

Hi,

the new package is available on the mentors site:

https://mentors.debian.net/package/eclipse-titan

BR,
Gergely

2016-01-13 14:13 GMT+01:00 Gianfranco Costamagna <
costamagnagianfra...@yahoo.it>:

> Hi,
> >The new package is done, everything is fixed, I hope. I didn't changed
> anything in the source, just under the debian/ directory. Should I upload
> the package as >before or use the dquilt method as
> https://www.debian.org/doc/manuals/maint-guide/update suggests?
> >If I'm right, the update method is for the change in the upstream source,
> or?
>
>
> please read
>
> http://mentors.debian.net/intro-maintainers
>
> (TL:TR)
> gbp buildpackage -S -sa
> dput mentors ../filename_foo_source.changes
>
>
> cheers
>
> G.
>

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Pilisi Gergely]

Hi,

just a quick report on my progress...

2015-12-17 18:18 GMT+01:00 Mattia Rizzolo :

>
> Ok, first, a question: do you do your debian packaging in git?
>

I'm cloning form a git repository, then clean up everything which is git
related. Why do you ask? Is there a problem with that?


And, here is a review:
>
> * trailing whitespace on the changelog line.
>

FIXED


> * maybe you're happy to discover tools like `wrap-and-sort`, to wrap the
>   Build-Depends and Depends line (and sort other stuff, and removing
>   trailing whitespaces in some other files)
>

Thank you for the hint, it's a really useful tool. ;)


> * please don't cp files that way in d/rules, I find that ugly. instead,
>   use a debian/eclipse-titan.install file.  See dh_install(1) for more
>   info.  On a related note, I prefer using $(CURDIR) instead of $$(pwd)
>   + this will also make debian/eclipse-titan.dirs useless
>   + if you need to rename files dh-exec can help you a bit, if you want
>

FIXED


> * during the compilation there are several errors like
> ./TTCN3.hh:58:39: fatal error: RT1/TitanLoggerApiSimple.hh: No such
> file or directory
>   is this to be expected & ok?
>

It's expected and it's OK.


> * is there a way to have a more verbose build, showing all the command
>   line?
>

Added --verbose to debian/rules, I hope it'll help.


> * you told me that you could get it to build with hardening-wrapper,
>   well, to me it doesn't (see below) :)
>

Working on it, currently I don't know what is the reason of this. :/


> * can you enable parallel building? (see debhelper(7))
>

DONE


> * debian/copyright is totally inadequate.
>   + personally I won't be totally happy without a copyright following
> copyright-format 1.0
>   + anyway, please pick a random package from the archive and try having
> a look at what a copyright file normally looks like.
>

Will do after the hardening issue is resolved.

I move forward a little bit slow because I had a lot to do in these days
but now I can work on this almost full time, so I'll back to you soon with
all these corrections done I hope. ;)

Happy New Year
Gergely Pilisi

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Mattia Rizzolo]

note that you removed the bug from your email, I bounced your previous
email and re-added the bug to the Cc.


On Mon, Jan 11, 2016 at 12:15:14PM +0100, Pilisi Gergely wrote:
> just a quick report on my progress...

thanks for the report.
It's nice to hear from a sponsoree from time to time, otherwise we/I
might wonder what happened, and give up if too long has passed without
hearing from you :)

> 2015-12-17 18:18 GMT+01:00 Mattia Rizzolo :
> > Ok, first, a question: do you do your debian packaging in git?
> I'm cloning form a git repository, then clean up everything which is git
> related. Why do you ask? Is there a problem with that?

Not at all.  actually, I consider quite important or at least wise to
keep packaging in git.  Note that you can publish such repository and
set the URIs in Vcs-{Browser,Git} in d/control, then I'd love to do the
review from there.

> And, here is a review:
> > * is there a way to have a more verbose build, showing all the command
> >   line?
> Added --verbose to debian/rules, I hope it'll help.

If it shows more detailed info on what's going on, it'll for sure!

> I move forward a little bit slow because I had a lot to do in these days
> but now I can work on this almost full time, so I'll back to you soon with
> all these corrections done I hope. ;)

ok, please poke back once you get a building thing ;)

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  http://mapreri.org  : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Mattia Rizzolo]

control: tag -1 moreinfo

On Wed, Dec 16, 2015 at 01:45:02PM +0100, Gergely Pilisi wrote:
> I am looking for a sponsor for my package "eclipse-titan":

Ok, first, a question: do you do your debian packaging in git?

And, here is a review:

* trailing whitespace on the changelog line.
* maybe you're happy to discover tools like `wrap-and-sort`, to wrap the
  Build-Depends and Depends line (and sort other stuff, and removing
  trailing whitespaces in some other files)
* please don't cp files that way in d/rules, I find that ugly. instead,
  use a debian/eclipse-titan.install file.  See dh_install(1) for more
  info.  On a related note, I prefer using $(CURDIR) instead of $$(pwd)
  + this will also make debian/eclipse-titan.dirs useless
  + if you need to rename files dh-exec can help you a bit, if you want
* during the compilation there are several errors like
./TTCN3.hh:58:39: fatal error: RT1/TitanLoggerApiSimple.hh: No such file or 
directory
  is this to be expected & ok?
* is there a way to have a more verbose build, showing all the command
  line?
* you told me that you could get it to build with hardening-wrapper,
  well, to me it doesn't (see below) :)
* can you enable parallel building? (see debhelper(7))
* debian/copyright is totally inadequate.
  + personally I won't be totally happy without a copyright following
copyright-format 1.0
  + anyway, please pick a random package from the archive and try having
a look at what a copyright file normally looks like.


About ditching hardening-wrapped in favour of just using what
dpkg-buildflags do:
whatever I use the .dsc you provided, just removed hardening-wrapper or
enable the hardening build flags using DEB_BUILD_MAINT_OPTIONS, the
build fails with

In file included from jnimw.cc:8:0:
jnimw.h:14:17: fatal error: jni.h: No such file or directory
compilation terminated.
../Makefile.genrules:87: recipe for target 'jnimw.o' failed

So there is not much of a comparison to do.  Maybe you built the package
with an hardening-wrapper without the fix for #801597 ?
And btw, having a verbose build is kinda important to check for the
build flags, hardening, etc.


I might have other points to say, but let's go gradually, uh? :)

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  http://mapreri.org  : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Gianfranco Costamagna]

Control: forcemerge -1 794209

Control: owner -1 mat...@debian.org

as per irc request :)

cheers,

G.




Il Mercoledì 16 Dicembre 2015 14:06, Gergely Pilisi  ha 
scritto:
Package: sponsorship-requests
Severity: normal

Dear Mentors,

I am looking for a sponsor for my package "eclipse-titan":

Package name: eclipse-titan
Version : 5.4.1-1
Upstream Author : Eclipse Foundation
URL : www.eclipse.org
License : Eclipse Public License - v 1.0
Section : java

It builds this binary package:

eclipse-titan

TTCN-3 is a standardized, modular language specifically designed for testing.
Eclipse Titan offers a free and open source (FOSS) compiler both for TTCN-3 and
for ASN.1 (Abstract Syntax Notation One).

More information about eclipse-titan can be obtained from
https://github.com/eclipse/titan.core

This is the first upload so there isn’t any changelog.


Best Regards,
Gergely Pilisi



-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.2.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.

[Gergely Pilisi]

Package: sponsorship-requests
Severity: normal

Dear Mentors,

I am looking for a sponsor for my package "eclipse-titan":

Package name: eclipse-titan
Version : 5.4.1-1
Upstream Author : Eclipse Foundation
URL : www.eclipse.org
License : Eclipse Public License - v 1.0
Section : java

It builds this binary package:

eclipse-titan

TTCN-3 is a standardized, modular language specifically designed for testing.
Eclipse Titan offers a free and open source (FOSS) compiler both for TTCN-3 and
for ASN.1 (Abstract Syntax Notation One).

More information about eclipse-titan can be obtained from
https://github.com/eclipse/titan.core

This is the first upload so there isn’t any changelog.


Best Regards,
Gergely Pilisi



-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.2.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)