Bug#820539: RFS: libretro-desmume [ITP]

[Sérgio Benjamim]

Hey G.

Copyright is updated.

> debian packaging should be GPL-2+ and not GPL-3+, otherwise you might
> not be able to forward patches back in GPL-2+ mode.

Changed that.


> debian/install with an sh script inside is something that worries me 
a little

> bit (even if possible)
>
> can't you please override dh_install in rules?
> I don't like hidden scripts too much
> (instead I would prefer dh-exec)

I'm using that for all the libretro cores, and it was a tip from a 
debian dev (I don't remember who, it was months ago).



> check-all-the-things review:
> $ codespell --quiet-level=3
> $ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not 
find or open any of the paths given.'

> grep -riE 'fixme|todo|hack|xxx' .
>
> also flawfinder shows a lot of stuff.

I'm not sure what to do about this. I can't force upstream write safe 
code, I ran flawfinder and found hundred of warnings, I can't really 
make a patch to fix that.



cheers,
sergio-br2

Bug#820539: RFS: libretro-desmume [ITP]

[Gianfranco Costamagna]

control: owner -1 !
control: tags -1 moreinfo


Hi,

> https://mentors.debian.net/package/libretro-desmume


licenses are missing e.g. some Expat
desmume/src/emufile.*
desmume/src/arm_jit.h: GPL (v3 or later)
desmume/src/instruction_attributes.h: GPL (v3 or later)
desmume/src/libretro/arm_arm/arm_jit.cpp: GPL (v3 or later)

and probably many more

debian packaging should be GPL-2+ and not GPL-3+, otherwise you might
not be able to forward patches back in GPL-2+ mode.

debian/install with an sh script inside is something that worries me a little
bit (even if possible)

can't you please override dh_install in rules?
I don't like hidden scripts too much
(instead I would prefer dh-exec)


./desmume/src/utils/emufat.h://Copyright (C) 1991 Linus Torvalds 

./desmume/src/utils/emufat.h://Copyright (C) 1992-1993 Remy Card 

./desmume/src/utils/emufat.h://Copyright (C) 1993-1994 David Hudson 

./desmume/src/utils/emufat.h://Copyright (C) 1998 H. Peter Anvin 

./desmume/src/utils/emufat.h://Copyright (C) 1998-2005 Roman Hodek 

./desmume/src/utils/datetime.h:// Copyright (C) 2004-2006 Novell, Inc 
(http://www.novell.com)

missing
and probably many more

check-all-the-things review:
$ codespell --quiet-level=3
$ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open 
any of the paths given.'
grep -riE 'fixme|todo|hack|xxx' .

also flawfinder shows a lot of stuff.

I didn't check lintian and to build, I'll do as soon as the above is fixed.

G.



signature.asc
Description: OpenPGP digital signature

Bug#820539: RFS: libretro-desmume [ITP]

[Sérgio Benjamim]

Package: sponsorship-requests
Severity: wishlist

Hey dear mentors!

I'm looking for a sponsor for my package "libretro-desmume"

This is the libretro port of DeSmuME, the Nintendo DS emulator. It's a
fork of the original project to fit better with the libretro API, so
it's not possible to use the same source code of DeSmuME package.


* Package name : libretro-desmume
  Version  : 0.9.11+git20160319

  Upstream Author  : yopyop | DeSmuME team

* URL  : https://github.com/libretro/desmume
* License  : GPL-2+
  Programming Lang : C++
  Description  : Nintendo DS emulator


It builds those binary packages:

libretro-desmume - Libretro wrapper for DeSmuME
libretro-desmume-dbg - Libretro wrapper for DeSmuME debug symbols



To access further information about this package, please visit the following 
URL:

https://mentors.debian.net/package/libretro-desmume


More information about RetroArch and the libretro API can be obtained from 
http://www.libretro.com/index.php/api/

--
Sérgio Benjamim