Bug#838801: RFS: zxcvbn-c/0.20150103-1 [ITP]
control: tags -1 -moreinfo Hello Gianfranco, On Wed, Sep 28, 2016 at 02:29:42PM +, Gianfranco Costamagna wrote: > control: owner -1 ! Thank you for your interest! > > CFLAGS ?= -O2 -Wall -Wextra -Wdeclaration-after-statement > CPPFLAGS ?= -O2 -Wall -Wextra > > > this is a no-op I guess, maybe a "+=" might be better As discussed on IRC, I'd prefer to keep it this way -- these are upstream's choice of flags, and we have our own set which can be allowed to override them. They're there in case someone wants to build the library outside of Debian. > > gcc $(CFLAGS) $(LDFLAGS) -fPIC -shared -Wl,-soname,$(SONAME) -o $@ $^ > -lm > > this is wrong in many places, e.g.: > > "gcc" might be a $(CC) > with > > $(CC) ?= gcc > as example (I don't see a good reason for forcing a gcc when people might want > to try to build it with clang as example) > > LDFLAGS should be at the bottom of the ine, just before -lm, to avoid > stripping > with wl-asneeded flag (and build failures) > > > blhc: > > CXXFLAGS missing (-g -O2 -fPIE -fstack-protector-strong -Wformat > -Werror=format-security): g++ -std=c++11 -Wdate-time -D_FORTIFY_SOURCE=2 -I. > -o dictgen dict-generate.cpp > LDFLAGS missing (-fPIE -pie -Wl,-z,relro -Wl,-z,now): g++ -std=c++11 > -Wdate-time -D_FORTIFY_SOURCE=2 -I. -o dictgen dict-generate.cpp > CPPFLAGS missing (-D_FORTIFY_SOURCE=2): gcc -g -O2 > -fdebug-prefix-map=/<>=. -fPIE -fstack-protector-strong -Wformat > -Werror=format-security -I. -DUSE_DICT_FILE -c -o zxcvbn-file.o zxcvbn.c All fixed, thanks. > deb files: -rw-r--r-- root/root 568880 2016-09-25 01:14 > ./usr/lib/x86_64-linux-gnu/libzxcvbn.a > > static library? ok if you think it is useful I've pushed a new tag debian/0.20160925-1 to my git repository, and updated mentors: dget -x https://mentors.debian.net/debian/pool/main/z/zxcvbn-c/zxcvbn-c_0.20160925-1.dsc -- Sean Whitton signature.asc Description: PGP signature
Bug#838801: RFS: zxcvbn-c/0.20150103-1 [ITP]
control: owner -1 ! control: tags -1 moreinfo Hi Sean, >libzxcvbn-dev - password strength estimation library - development files >libzxcvbn0 - password strength estimation library I'm a little bit worried about the makefile :( CFLAGS ?= -O2 -Wall -Wextra -Wdeclaration-after-statement CPPFLAGS ?= -O2 -Wall -Wextra this is a no-op I guess, maybe a "+=" might be better gcc $(CFLAGS) $(LDFLAGS) -fPIC -shared -Wl,-soname,$(SONAME) -o $@ $^ -lm this is wrong in many places, e.g.: "gcc" might be a $(CC) with $(CC) ?= gcc as example (I don't see a good reason for forcing a gcc when people might want to try to build it with clang as example) LDFLAGS should be at the bottom of the ine, just before -lm, to avoid stripping with wl-asneeded flag (and build failures) blhc: CXXFLAGS missing (-g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security): g++ -std=c++11 -Wdate-time -D_FORTIFY_SOURCE=2 -I. -o dictgen dict-generate.cpp LDFLAGS missing (-fPIE -pie -Wl,-z,relro -Wl,-z,now): g++ -std=c++11 -Wdate-time -D_FORTIFY_SOURCE=2 -I. -o dictgen dict-generate.cpp CPPFLAGS missing (-D_FORTIFY_SOURCE=2): gcc -g -O2 -fdebug-prefix-map=/<>=. -fPIE -fstack-protector-strong -Wformat -Werror=format-security -I. -DUSE_DICT_FILE -c -o zxcvbn-file.o zxcvbn.c deb files: -rw-r--r-- root/root568880 2016-09-25 01:14 ./usr/lib/x86_64-linux-gnu/libzxcvbn.a static library? ok if you think it is useful other stuff is good :) thanks! G.
Bug#838801: RFS: zxcvbn-c/0.20150103-1 [ITP]
Package: sponsorship-requests Severity: wishlist Control: block 838492 by -1 Dear mentors, I am looking for a sponsor for my package "zxcvbn-c". This is a shlib dependency of a Haskell library I want to package, on the way to packaging keysafe, the latest cool project from Joey Hess: https://joeyh.name/code/keysafe/ * Package name: zxcvbn-c Version : 0.20150103-1 Upstream Author : Tony Evans * URL : https://github.com/tsyrogit/zxcvbn-c * License : BSD-3-clause Section : libs It builds those binary packages: libzxcvbn-dev - password strength estimation library - development files libzxcvbn0 - password strength estimation library Mentors information page: https://mentors.debian.net/package/zxcvbn-c Download with dget: dget -x https://mentors.debian.net/debian/pool/main/z/zxcvbn-c/zxcvbn-c_0.20150103-1.dsc Or build it with gbp: gbp clone --pristine-tar https://git.spwhitton.name/zxcvbn-c git checkout debian/0.20150103-1 git verify-tag debian/0.20150103-1 # my key is in DM keyring gbp buildpackage -- Sean Whitton signature.asc Description: PGP signature
