Bug#856910: RFS: inotify-tools/3.14-3

[Sean Whitton]

Dear Dmitry,

On Fri, Mar 10, 2017 at 07:33:29AM +0300, Dmitry Bogatov wrote:
> Thank you. It is settled. One more review, please?

32f61b4 is fine, except that f4f7bda introduced a Debian delta of more
than 3 lines.  I think this was not deliberate :)

On my system, dgit adds another commit undoing most of the changes in
f4f7bda.  Is it possible that you are working with the wrong orig.tar on
your system?  Or is your Emacs performing changes across the source
tree?  Make sure you use the orig.tar from the archive.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#856910: RFS: inotify-tools/3.14-3

[Dmitry Bogatov]

On Wed, Mar 08, 2017 at 08:46:43AM +0300, Dmitry Bogatov wrote:
> > I need help with this. If I write
> > [...]

Thank you. It is settled. One more review, please?

-- 
X-Web-Site: https://sinsekvu.github.io | Note that I process my email in batch,
Accept-Languages: eo,ru,en | at most once every 24 hours. If matter
Accept: text/plain, text/x-diff| is urgent, you have my phone number.


pgpKKnPzGor6N.pgp
Description: PGP signature

Bug#856910: RFS: inotify-tools/3.14-3

[Sean Whitton]

Hello Dmitry,

On Wed, Mar 08, 2017 at 08:46:43AM +0300, Dmitry Bogatov wrote:
> I need help with this. If I write
> 
>   embedded-javascript-library usr/share/doc/libinotifytools0-dev/jquery.js
> 
> into debian/libinotify0-dev.lintian-overrides, it does not match and lintian
> complains about unused override.

You can use wildcards ('*').

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#856910: RFS: inotify-tools/3.14-3

[Dmitry Bogatov]

control: tags -1 -moreinfo

[2017-03-06 20:46] Sean Whitton 
> - Your conversion of d/copyright has lost some information, by merging
>   the stanzas for McGovern and McCutchan.  If you use two separate
>   stanzas the conversion would not be lossy.

Fixed.

> - In your changelog you wrote that you bumped the std-ver.  It's
>   conventional to say what version you bumped it to.

Fixed.

> - The Lintian override could use a wildcard so that it only matches the
>   doxygen file, not any other javascript that might appear in a new
>   upstream release (unlikely though that is)

I need help with this. If I write

embedded-javascript-library usr/share/doc/libinotifytools0-dev/jquery.js

into debian/libinotify0-dev.lintian-overrides, it does not match and lintian
complains about unused override.

> - You've modified debian/*.install but this isn't in the changelog.

Fixed.

> - The dgit-maint-merge patch header has been updated to a better text.
>   Please consider using it: https://manpages.debian.org/dgit-maint-merge

Fixed.

> - Changes to d/rules not in changelog.

Fixed.

> - Just fyi: https://manpages.debian.org/git-deborig

Fine. Useful.

> Don't forget `dch -r` once you've addressed these.
>
> - you could install NEWS as the upstream changelog

No, thanks.

% cat NEWS

 * 19 October 2005
   inotify-tools begun.


> - you could add a doc-base registration

Fixed.

-- 
X-Web-Site: https://sinsekvu.github.io | Note that I process my email in batch,
Accept-Languages: eo,ru,en | at most once every 24 hours. If matter
Accept: text/plain, text/x-diff| is urgent, you have my phone number.


pgplVoTdqfGuj.pgp
Description: PGP signature

Bug#856910: RFS: inotify-tools/3.14-3

[Sean Whitton]

On Mon, Mar 06, 2017 at 09:05:19AM +0300, Dmitry Bogatov wrote:
> I am looking for a sponsor for my package "inotify-tools"

- you could install NEWS as the upstream changelog

- you could add a doc-base registration

This would bring you down to a single lintian tag!

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#856910: RFS: inotify-tools/3.14-3

[Sean Whitton]

control: tag -1 +moreinfo
control: owner -1 !

Dear Dmitry,

On Mon, Mar 06, 2017 at 09:05:19AM +0300, Dmitry Bogatov wrote:
> I am looking for a sponsor for my package "inotify-tools"

Thank you for your interest in adopting this package.  And great choice
for the git workflow ;)

A review of dca4111:

- Your conversion of d/copyright has lost some information, by merging
  the stanzas for McGovern and McCutchan.  If you use two separate
  stanzas the conversion would not be lossy.

- In your changelog you wrote that you bumped the std-ver.  It's
  conventional to say what version you bumped it to.

- The Lintian override could use a wildcard so that it only matches the
  doxygen file, not any other javascript that might appear in a new
  upstream release (unlikely though that is)

- You've modified debian/*.install but this isn't in the changelog.

- The dgit-maint-merge patch header has been updated to a better text.
  Please consider using it: https://manpages.debian.org/dgit-maint-merge

- Changes to d/rules not in changelog.

- Just fyi: https://manpages.debian.org/git-deborig

Don't forget `dch -r` once you've addressed these.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#856910: RFS: inotify-tools/3.14-3

[Dmitry Bogatov]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "inotify-tools"

* Package name : inotify-tools
  Version  : 3.14-3
  Upstream Author  : Radu Voicilas 
* Url  : https://github.com/rvoicilas/inotify-tools/wiki/
* Licenses : LGPL-2.1+,GPL-2.1+
  Programming Lang : C
  Section  : misc

 Inotify is a Linux kernel feature enabling user space programs to
 monitor parts of the filesystem in a efficient way. libinotifytools
 is a thin layer on top of the kernel interface which makes it easy
 to set up watches on many files at once, read events without having
 to deal with low-level I/O, and several utility functions for inotify-
 related string formatting

It builds those binary packages:

  * libinotifytools0
  * libinotifytools0-dev
  * inotify-tools

Please note, that package is maintained with dgit(1) tool using
dgit-maint-merge(7) workflow. In particular, it means that quilt
patches are squashed in source package and are not intended for
review. For more information about how to sponsor this package,
see dgit-sponsorship(7).

  Git repository: 
https://anonscm.debian.org/cgit/users/kaction-guest/inotify-tools.git
  Git branch: master
  Orig tar.gz: from tag v3.14

With /bin/sh following commands should suffice:

  $ git clone 
https://anonscm.debian.org/cgit/users/kaction-guest/inotify-tools.git 
inotify-tools
  $ cd inotify-tools
  $ git archive -o ../inotify-tools_3.14.orig.tar.xz v3.14
  $ dgit sbuild

Changes since last upload:

  * New maintainer (Closes: #856293)
  * Convert package to dgit-maint-merge workflow (patches are squashed
in uploaded source package)
  * Bump debhelper compat to 10
  * Reformat 'debian/changelog' according to DEP-5
  * Enable hardening
  * Update Vcs-* fields
  * Bump standards version (No changes needed)
  * Add lintian override concerning embedded javascript file. It is way
how doxygen works and it can not be fixed.
  * Fix segfault with cvs output when filename contains comma (Closes: #702738)

Regards,
  Dmitry Bogatov