Bug#858800: RFS: xtrs/4.9d-1 [ITA]

[G. Branden Robinson]

At 2017-03-31T18:39:23-0700, Sean Whitton wrote:
> control: owner -1 !
> 
> Hello Branden,
> 
> On Fri, Mar 31, 2017 at 07:40:51PM -0400, G. Branden Robinson wrote:
> > I've reuploaded 4.9c-4.
> 
> I can't find this on mentors...  As I said, an e-mailed debdiff would
> be fine at this point.

I accidentally uploaded to ftp-master instead, by not giving dput a
hostname argument.  I tried again; see attachment.

A debdiff *.dsc of the last NMU and this version is also attached.

> > Please find attached two files which were not dput, which you may wish
> > to peruse for QA purposes:
> 
> Thank you for these!

My pleasure!

Regards,
Branden
Successfully uploaded xtrs_4.9c-4.dsc to mentors.debian.net for mentors.
Successfully uploaded xtrs_4.9c-4.diff.gz to mentors.debian.net for mentors.
Successfully uploaded xtrs-dbgsym_4.9c-4_amd64.deb to mentors.debian.net for 
mentors.
Successfully uploaded xtrs_4.9c-4_amd64.buildinfo to mentors.debian.net for 
mentors.
Successfully uploaded xtrs_4.9c-4_amd64.deb to mentors.debian.net for mentors.
Successfully uploaded xtrs_4.9c-4_amd64.changes to mentors.debian.net for 
mentors.
diff -u xtrs-4.9c/debian/changelog xtrs-4.9c/debian/changelog
--- xtrs-4.9c/debian/changelog
+++ xtrs-4.9c/debian/changelog
@@ -1,3 +1,11 @@
+xtrs (4.9c-4) unstable; urgency=medium
+
+  * Makefile: Undefine HAVE_SIGIO.  (Closes: #511645)
+  * Update Maintainer full name and email address from the "old me" to the
+"new me".
+
+ -- G. Branden Robinson   Thu, 30 Mar 2017 09:20:32 -0400
+
 xtrs (4.9c-3.5) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -u xtrs-4.9c/debian/control xtrs-4.9c/debian/control
--- xtrs-4.9c/debian/control
+++ xtrs-4.9c/debian/control
@@ -1,7 +1,7 @@
 Source: xtrs
 Section: contrib/otherosfs
 Priority: extra
-Maintainer: Branden Robinson 
+Maintainer: G. Branden Robinson 
 Build-Depends: libncurses5-dev, libreadline-dev, libx11-dev, groff, debhelper (>= 5), po-debconf, html2text
 Standards-Version: 3.7.3
 
diff -u xtrs-4.9c/debian/patches xtrs-4.9c/debian/patches
--- xtrs-4.9c/debian/patches
+++ xtrs-4.9c/debian/patches
@@ -236,0 +237,11 @@
+--- Makefile.orig	2017-03-30 09:17:41.055300129 -0400
 Makefile	2017-03-30 09:17:48.455224512 -0400
+@@ -143,7 +143,7 @@
+ include Makefile.local
+ 
+ CFLAGS = $(DEBUG) $(ENDIAN) $(DEFAULT_ROM) $(READLINE) $(DISKDIR) $(IFLAGS) \
+-   $(APPDEFAULTS) -DKBWAIT -DHAVE_SIGIO
++   $(APPDEFAULTS) -DKBWAIT
+ LIBS = $(XLIB) $(READLINELIBS) $(EXTRALIBS)
+ 
+ ZMACFLAGS = -h
only in patch2:
unchanged:
--- xtrs-4.9c.orig/Makefile
+++ xtrs-4.9c/Makefile
@@ -143,7 +143,7 @@
 include Makefile.local
 
 CFLAGS = $(DEBUG) $(ENDIAN) $(DEFAULT_ROM) $(READLINE) $(DISKDIR) $(IFLAGS) \
-   $(APPDEFAULTS) -DKBWAIT -DHAVE_SIGIO
+   $(APPDEFAULTS) -DKBWAIT
 LIBS = $(XLIB) $(READLINELIBS) $(EXTRALIBS)
 
 ZMACFLAGS = -h


signature.asc
Description: PGP signature

Bug#858800: RFS: xtrs/4.9d-1 [ITA]

[Sean Whitton]

control: owner -1 !

Hello Branden,

On Fri, Mar 31, 2017 at 07:40:51PM -0400, G. Branden Robinson wrote:
> I've reuploaded 4.9c-4.

I can't find this on mentors...  As I said, an e-mailed debdiff would be
fine at this point.

> Please find attached two files which were not dput, which you may wish
> to peruse for QA purposes:

Thank you for these!

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#858800: RFS: xtrs/4.9d-1 [ITA]

[Sean Whitton]

Hello Branden,

On Thu, Mar 30, 2017 at 06:13:35PM -0400, G. Branden Robinson wrote:
> Yes, it was.  Either the build-dep on groff was always too strong or
> groff-base got split out at some point in the past decade (or a little
> more).
> 
> Would you like me to rebuild?  Will I be able to overwrite -4 will a
> fresher upload?

Yes, mentors will let you overwrite.  Or you could just send me an
updated debdiff, since it's tiny, and I can apply it to the current
version in the archive.  Whichever you prefer.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#858800: RFS: xtrs/4.9d-1 [ITA]

[Sean Whitton]

Dear Branden,

On Thu, Mar 30, 2017 at 09:29:25AM -0400, G. Branden Robinson wrote:
> It can.  I've uploaded xtrs 4.9c-4 with a far leaner set of changes, and
> am attaching a diff of the diff to this message.  As you can see, it's
> far leaner.
> 
> Thoughts?

Was the Build-Depends change intentional?  It's not in the changelog.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#858800: RFS: xtrs/4.9d-1 [ITA]

[G. Branden Robinson]

At 2017-03-29T12:59:12-0700, Sean Whitton wrote:
> Hello Branden,
> 
> On Tue, Mar 28, 2017 at 08:29:38PM -0400, G. Branden Robinson wrote:
> > > On Tue, Mar 28, 2017 at 05:28:25PM -0400, G. Branden Robinson wrote:
> > > > So my goals were, in this order:
> > > > 1) Get the package suitable for unstable (which it wasn't); then
> > > > 2) Get the package suitable for testing.
> >
> > It'll be suitable for testing for Buster, that's for sure.  My bad luck
> > to return during a release freeze.
> 
> Right.  But your wording ("then") suggested that (2) could be done
> exclusively of (1).

It can.  I've uploaded xtrs 4.9c-4 with a far leaner set of changes, and
am attaching a diff of the diff to this message.  As you can see, it's
far leaner.

Thoughts?

> > I'm interested in the least-effort solution (for other people) that
> > doesn't involve shipping a badly broken package in Stretch.
> 
> Well, letting it drop out of testing is technically the least-effort
> solution.

Right.  What's the next-least-effort solution?  :)

Regards,
Branden
--- xtrs_4.9c-3.5.diff	2017-03-30 09:25:15.053347227 -0400
+++ xtrs_4.9c-4.diff	2017-03-30 09:25:15.053347227 -0400
@@ -1,3 +1,14 @@
+--- xtrs-4.9c.orig/Makefile
 xtrs-4.9c/Makefile
+@@ -143,7 +143,7 @@
+ include Makefile.local
+ 
+ CFLAGS = $(DEBUG) $(ENDIAN) $(DEFAULT_ROM) $(READLINE) $(DISKDIR) $(IFLAGS) \
+-   $(APPDEFAULTS) -DKBWAIT -DHAVE_SIGIO
++   $(APPDEFAULTS) -DKBWAIT
+ LIBS = $(XLIB) $(READLINELIBS) $(EXTRALIBS)
+ 
+ ZMACFLAGS = -h
 --- xtrs-4.9c.orig/Makefile.local
 +++ xtrs-4.9c/Makefile.local
 @@ -50,7 +50,7 @@
@@ -363,7 +374,15 @@
 +vim:set ai et ts=4 sw=4 tw=80:
 --- xtrs-4.9c.orig/debian/changelog
 +++ xtrs-4.9c/debian/changelog
-@@ -0,0 +1,627 @@
+@@ -0,0 +1,635 @@
++xtrs (4.9c-4) unstable; urgency=medium
++
++  * Makefile: Undefine HAVE_SIGIO.  (Closes: #511645)
++  * Update Maintainer full name and email address from the "old me" to the
++"new me".
++
++ -- G. Branden Robinson   Thu, 30 Mar 2017 09:20:32 -0400
++
 +xtrs (4.9c-3.5) unstable; urgency=medium
 +
 +  * Non-maintainer upload.
@@ -1036,8 +1055,8 @@
 +Source: xtrs
 +Section: contrib/otherosfs
 +Priority: extra
-+Maintainer: Branden Robinson 
-+Build-Depends: libncurses5-dev, libreadline-dev, libx11-dev, groff, debhelper (>= 5), po-debconf, html2text
++Maintainer: G. Branden Robinson 
++Build-Depends: libncurses5-dev, libreadline-dev, libx11-dev, groff-base, debhelper (>= 5), po-debconf, html2text
 +Standards-Version: 3.7.3
 +
 +Package: xtrs
@@ -1132,7 +1151,7 @@
 +  command="/usr/bin/xtrs"
 --- xtrs-4.9c.orig/debian/patches
 +++ xtrs-4.9c/debian/patches
-@@ -0,0 +1,236 @@
+@@ -0,0 +1,247 @@
 +--- cassette.man~
  cassette.man
 +@@ -15,13 +15,6 @@
@@ -1369,6 +1388,17 @@
 + 
 + # If you want to debug the emulator, use the -g flag instead:
 + 
++--- Makefile.orig	2017-03-30 09:17:41.055300129 -0400
+ Makefile	2017-03-30 09:17:48.455224512 -0400
++@@ -143,7 +143,7 @@
++ include Makefile.local
++ 
++ CFLAGS = $(DEBUG) $(ENDIAN) $(DEFAULT_ROM) $(READLINE) $(DISKDIR) $(IFLAGS) \
++-   $(APPDEFAULTS) -DKBWAIT -DHAVE_SIGIO
+++   $(APPDEFAULTS) -DKBWAIT
++ LIBS = $(XLIB) $(READLINELIBS) $(EXTRALIBS)
++ 
++ ZMACFLAGS = -h
 --- xtrs-4.9c.orig/debian/po/POTFILES.in
 +++ xtrs-4.9c/debian/po/POTFILES.in
 @@ -0,0 +1 @@


signature.asc
Description: PGP signature

Bug#858800: RFS: xtrs/4.9d-1 [ITA]

[Sean Whitton]

Hello Branden,

On Tue, Mar 28, 2017 at 08:29:38PM -0400, G. Branden Robinson wrote:
> > On Tue, Mar 28, 2017 at 05:28:25PM -0400, G. Branden Robinson wrote:
> > > So my goals were, in this order:
> > > 1) Get the package suitable for unstable (which it wasn't); then
> > > 2) Get the package suitable for testing.
>
> It'll be suitable for testing for Buster, that's for sure.  My bad luck
> to return during a release freeze.

Right.  But your wording ("then") suggested that (2) could be done
exclusively of (1).

> I'm interested in the least-effort solution (for other people) that
> doesn't involve shipping a badly broken package in Stretch.

Well, letting it drop out of testing is technically the least-effort
solution.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#858800: RFS: xtrs/4.9d-1 [ITA]

[G. Branden Robinson]

On Tue, Mar 28, 2017 at 05:16:21PM -0700, Sean Whitton wrote:
> Hello Branden,
> 
> On Tue, Mar 28, 2017 at 05:28:25PM -0400, G. Branden Robinson wrote:
> > > You are very unlikely to get release team approval for this upload as it
> > > stands.  Given what you wrote in #511645, is your intention for xtrs to
> > > drop out of stretch, to be reintroduced in buster?
> > 
> > I've been making conservative (pessimistic) estimates about how fast I'd
> > be getting things done since I'm freshly back to the project after a
> > long absence.  There were and are best practices I need(ed) to get
> > caught up on.  I also couldn't be absolutely sure I'd get a sponsor
> > before the removal-from-testing date (scheduled for 11 April); I don't
> > know when I'll be able to get my new GPG key into the Debian keyring so
> > that I can upload under my own power[1], and so forth.  Finally, I don't
> > want to cause the release team any trouble.
> > 
> > So my goals were, in this order:
> > 1) Get the package suitable for unstable (which it wasn't); then
> > 2) Get the package suitable for testing.
> 
> Generally speaking, something shouldn't go into unstable unless it would
> also be suitable for testing (once deps and r-deps are also ready to
> migrate).

It'll be suitable for testing for Buster, that's for sure.  My bad luck
to return during a release freeze.

I'm interested in the least-effort solution (for other people) that
doesn't involve shipping a badly broken package in Stretch.

-- 
Regards,
Branden


signature.asc
Description: PGP signature

Bug#858800: RFS: xtrs/4.9d-1 [ITA]

[Sean Whitton]

Hello Branden,

On Tue, Mar 28, 2017 at 05:28:25PM -0400, G. Branden Robinson wrote:
> > You are very unlikely to get release team approval for this upload as it
> > stands.  Given what you wrote in #511645, is your intention for xtrs to
> > drop out of stretch, to be reintroduced in buster?
> 
> I've been making conservative (pessimistic) estimates about how fast I'd
> be getting things done since I'm freshly back to the project after a
> long absence.  There were and are best practices I need(ed) to get
> caught up on.  I also couldn't be absolutely sure I'd get a sponsor
> before the removal-from-testing date (scheduled for 11 April); I don't
> know when I'll be able to get my new GPG key into the Debian keyring so
> that I can upload under my own power[1], and so forth.  Finally, I don't
> want to cause the release team any trouble.
> 
> So my goals were, in this order:
> 1) Get the package suitable for unstable (which it wasn't); then
> 2) Get the package suitable for testing.

Generally speaking, something shouldn't go into unstable unless it would
also be suitable for testing (once deps and r-deps are also ready to
migrate).

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#858800: RFS: xtrs/4.9d-1 [ITA]

[G. Branden Robinson]

On Mon, Mar 27, 2017 at 07:11:10PM -0700, Sean Whitton wrote:
> control: tag -1 +moreinfo

Dummy response to -quiet to test Mutt/GPG configuration.

-- 
Regards,
Branden


signature.asc
Description: PGP signature

Bug#858800: RFS: xtrs/4.9d-1 [ITA]

[G. Branden Robinson]

On Mon, Mar 27, 2017 at 07:11:10PM -0700, Sean Whitton wrote:
> control: tag -1 +moreinfo
> 
> Dear Branden,
> 
> On Sun, Mar 26, 2017 at 06:45:34PM -0400, Branden Robinson wrote:
> > Changes since the last upload:
> > 
> >   * Merge new upstream release.
> > + "Deleted all SIGIO code.  The code was a kludge to begin with and it 
> > no
> >   longer worked with current X libraries and Linux kernels, causing xtrs
> >   to hang.  It was also reported to cause hangs when xtrs was compiled 
> > for
> >   Windows using Cygwin.  Thanks to Howard Pepper, Dennis Lovelady, 
> > Arumin
> >   Nueckel, Christopher Currie, and Joe Peterson for bug reports."
> >   (Closes: #511645)
> 
> Is it impossible to backport this fix to the version currently in
> stretch?

No, likely not impossible.  The crudest fix might be simply to just
#undef SIGIO in Makefile.local.

I will explore this.

> You are very unlikely to get release team approval for this upload as it
> stands.  Given what you wrote in #511645, is your intention for xtrs to
> drop out of stretch, to be reintroduced in buster?

I've been making conservative (pessimistic) estimates about how fast I'd
be getting things done since I'm freshly back to the project after a
long absence.  There were and are best practices I need(ed) to get
caught up on.  I also couldn't be absolutely sure I'd get a sponsor
before the removal-from-testing date (scheduled for 11 April); I don't
know when I'll be able to get my new GPG key into the Debian keyring so
that I can upload under my own power[1], and so forth.  Finally, I don't
want to cause the release team any trouble.

So my goals were, in this order:
1) Get the package suitable for unstable (which it wasn't); then
2) Get the package suitable for testing.

Thanks for following up!

Regards,
Branden

[1] That might take a while; my new key is not in the web of trust.

Bug#858800: RFS: xtrs/4.9d-1 [ITA]

[Sean Whitton]

control: tag -1 +moreinfo

Dear Branden,

On Sun, Mar 26, 2017 at 06:45:34PM -0400, Branden Robinson wrote:
> Changes since the last upload:
> 
>   * Merge new upstream release.
> + "Deleted all SIGIO code.  The code was a kludge to begin with and it no
>   longer worked with current X libraries and Linux kernels, causing xtrs
>   to hang.  It was also reported to cause hangs when xtrs was compiled for
>   Windows using Cygwin.  Thanks to Howard Pepper, Dennis Lovelady, Arumin
>   Nueckel, Christopher Currie, and Joe Peterson for bug reports."
>   (Closes: #511645)

Is it impossible to backport this fix to the version currently in
stretch?

You are very unlikely to get release team approval for this upload as it
stands.  Given what you wrote in #511645, is your intention for xtrs to
drop out of stretch, to be reintroduced in buster?

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#858800: RFS: xtrs/4.9d-1 [ITA]

[Branden Robinson]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I seek a sponsor for my package "xtrs".

* Package name: xtrs
  Version : 4.9d-1
  Upstream Author : Tim Mann
* URL : http://www.tim-mann.org/xtrs.html
* License : 2 different custom permissive licenses[1]
  Section : otherosfs

It builds those binary packages:

xtrs  - emulator for TRS-80 Model I/III/4/4P computers

To access further information about this package, please visit the
following URL:

https://mentors.debian.net/package/xtrs

Alternatively, one can download the package with dget using this
command:

dget -x 
https://mentors.debian.net/debian/pool/contrib/x/xtrs/xtrs_4.9d-1.dsc

Changes since the last upload:

  * Merge new upstream release.
+ "Deleted all SIGIO code.  The code was a kludge to begin with and it no
  longer worked with current X libraries and Linux kernels, causing xtrs
  to hang.  It was also reported to cause hangs when xtrs was compiled for
  Windows using Cygwin.  Thanks to Howard Pepper, Dennis Lovelady, Arumin
  Nueckel, Christopher Currie, and Joe Peterson for bug reports."
  (Closes: #511645)
  * Update README.Debian to refresh URLs and reflect developments in the
TRS-80 retrocomputing enthusiast community over the past several years.
  * Implement debian/compare-copyright script.
+ Add "check" target to debian/rules to call the script.
+ Add debian/{no-,}copyright-info.expected files.
  * Migrate former contents of debian/checklist to debian/README.source.
  * Rewrite debian/copyright using machine-readable copyright info.
  * Migrate to new (to me) quilt-based Debian source format 3.0.
+ Migrate former contents of debian/patches to debian/patch/*; dropping
  patches now merged upstream.
  * Migrate former contents of debian/README.contrib-only to Disclaimer field
of debian/copyright, and update discussion.
  * Stop shipping Tim Mann's TRS-80 FAQ document.  It's great, but strictly
speaking, it doesn't carry a license, I don't want to pester him to put
one on it, and in any event it updates much more frequently than the xtrs
software itself.  Finally, I trust people to do web searches, and
archive.org to stick around, more now than I did 19 years ago.
  * Write doc-base descriptions for the supplementary documentation in
/usr/share/doc/xtrs.
  * Add check-source target to debian/rules to aid copyright meticulousness
checking.
  * Add check-binary target to debian/rules to aid regression tesing.
  * Thanks to Christian Perrier, Hector Oron, Cyril Brulebois, and
YunQiang Su for taking care of this package during my long absence.

Regards,
Branden

[1] See attachment for gory details.  The licenses have been recognized
as DFSG-free for about 19 years.

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: xtrs
Source: http://www.tim-mann.org/xtrs.html
Disclaimer: Requires non-DFSG-free ROM images and/or operating systems
 to be useful for most purposes.
 .
 There is a freely-licensed boot ROM for Model 4P emulation provided with xtrs;
 however, this boot image can only be used to boot an operating system designed
 for the Model 4 (it is not sophisticated enough to load the BASIC interpreter
 ROM for Model III compatibility mode, provided on Model 4P TRSDOS disks as a
 file called MODELA/III).  Since most users will likely be using this emulator
 to run proprietary legacy applications for the TRS-80 computers, I do not
 regard this exception as sufficient to recategorize xtrs for inclusion in main.
 .
 It is worth keeping an eye on projects like Contiki and FUZIX; if one of them
 becomes useful under xtrs, that would be an argument for moving xtrs to main.
 + http://www.contiki-os.org/
 + https://github.com/EtchedPixels/FUZIX

License: local:Timothy-Mann-xtrs-permissive-non-copyleft
 This software may be copied, modified, and used for any purpose without fee,
 provided that (1) the above copyright notice is retained, and (2) modified
 versions are clearly marked as having been modified, with the modifier's name
 and the date included.

Files:
 cd.ccc
 mount.ccc
 pwd.ccc
 truedam.ccc
 umount.ccc
 unix.ccc
 xtrs8.lst
 xtrs8.z80
 xtrshard.lst
 xtrshard.z80
 xtrsmous.lst
 xtrsmous.z80
Copyright: 1998 Timothy Mann
License: local:Timothy-Mann-xtrs-permissive-non-copyleft

Files:
 cmd.c
 cmd.h
 hex2cmd.c
 trs_disk.c
 trs_disk.h
 trs_imp_exp.c
 trs_imp_exp.h
 trs_interrupt.c
Copyright: 1996 Timothy Mann
License: local:Timothy-Mann-xtrs-permissive-non-copyleft

Files:
 cmddump.c
 load_cmd.c
 load_cmd.h
 mkdisk.c
Copyright: 1996-98 Timothy Mann
License: