Bug#866046: closed by Gianfranco Costamagna <locutusofb...@debian.org> (Re: Bug#866046: RFS: libcgicc/3.2.18-0.1 NMU)

[Thomas Pircher]

On 2017-06-28 12:36, ow...@bugs.debian.org wrote:

#866046: RFS: libcgicc/3.2.19-0.1 NMU

It has been closed by Gianfranco Costamagna .


Hi Gianfranco,

I meant to write a short mail for this upload, but you found it 
already...

Thanks for doing the reviews!

Thomas

Bug#866046: RFS: libcgicc/3.2.18-0.1 NMU

[Gianfranco Costamagna]

control: owner -1 !
control: tags -1 moreinfo

> So, if you want I can take care of this one
lets put the review in the bug:



1) please delete the two useless patches
2) the upstream tarball is... full of useless stuff
they included a subtarball with 3.2.17 inside)

this makes the debdiff look scary, and doubled the size of the orig
tarball.

Was this intentional?
I would appreciate a new upstream fixed tarball


3) the conflict 

Conflicts: libcgicc5-dev
Replaces: libcgicc5-dev


should be dropped now, since stable already has libcgicc-dev

upgrades from oldstable to unstable should have a "stable" in the middle,
so the conflict is "useless" now (but I won't mind keeping it for another stable
release)

G.

Bug#866046: RFS: libcgicc/3.2.18-0.1 NMU

[Thomas Pircher]

On 2017-06-27 06:59, Gianfranco Costamagna wrote:

Adam Borowski wrote:


Please get an ok from the maintainer.


this is true in general, unfortunately Chrisb is inactive since one 
year or so,

and his last upload is around 5 years ago.


Hi Adam, Gianfranco,

thanks for looking into this. Apologies for not including the maintainer 
in the original mail, it wasn't intentional. Deferring the packet is 
probably a wise move to give the maintainer an opportunity to step in (I 
consider that unlikely, to be honest), should you consider going ahead 
with the review.


Should I re-upload this package with a high deferred number or can this 
be done from mentors?



BTW all of the diff, except for ~100 lines is about autotools
autogenerated stuff :)


Yes, the actual diff in the source code is much smaller than the 400 
kloc. Unfortunately this release tar ball contains a lot of 
autogenerated stuff, in addition to full a archive of the previous 
release. I considered removing some files in a patch, but that would 
have increased the total change rather than reducing it.


As far as I can see the changes in the source code since the last 
package are listed below. The latter two bugs were previously patched in 
the Debian package; these patches are now incorporated upstream, hence I 
could drop them from the Debian package.


bug #49557: XHTMLDoctype.h fails to include MStreamable.h
http://savannah.gnu.org/bugs/index.php?49557

bug #49120: cgicc should not call exit()
http://savannah.gnu.org/bugs/index.php?49120

bug #48677: Generated index.html is empty
http://savannah.gnu.org/bugs/index.php?48677

bug #46426: Pkg-config file does not provide flags for include path or 
the library itself

http://savannah.gnu.org/bugs/index.php?46426

Thanks,
Thomas

Bug#866046: RFS: libcgicc/3.2.18-0.1 NMU

[Gianfranco Costamagna]

Hello,


>While the package maintainer's is on the LowNMU list, a new upstream release
>with a 447407 line diff is not appropriate here, especially that the bug has
>been reported only 6½ days ago and is only severity:important.
>
>Please get an ok from the maintainer.

this is true in general, unfortunately Chrisb is inactive since one year or so,
and his last upload is around 5 years ago.

I have sponsored the latest major upload of this package, and everything has 
been good
so far.

My opinion is to review and eventually go in deferred/15 after a while, 
considering
that I'm ccing Chris in this email.

So, if you want I can take care of this one

BTW all of the diff, except for ~100 lines is about autotools autogenerated 
stuff :)

G.

Bug#866046: RFS: libcgicc/3.2.18-0.1 NMU

[Adam Borowski]

On Tue, Jun 27, 2017 at 12:04:26AM +0100, Thomas Pircher wrote:
> I am looking for a sponsor for my package "libcgicc"
> 
> * Package name: libcgicc
>   Version : 3.2.18-0.1

> Changes since the last upload:
> 
>   * New upstream release.
> - fixes include statement for MStreamable.h. (Closes: #865275).
> - upstream includes patches for pkgconfig file and empty index.html.
>   * Updated to Standards-Version 4.0.0 (no changes required).

While the package maintainer's is on the LowNMU list, a new upstream release
with a 447407 line diff is not appropriate here, especially that the bug has
been reported only 6½ days ago and is only severity:important.

Please get an ok from the maintainer.


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀ 
⣾⠁⢠⠒⠀⣿⡁ A dumb species has no way to open a tuna can.
⢿⡄⠘⠷⠚⠋⠀ A smart species invents a can opener.
⠈⠳⣄ A master species delegates.

Bug#866046: RFS: libcgicc/3.2.18-0.1 NMU

[Thomas Pircher]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "libcgicc"

* Package name: libcgicc
  Version : 3.2.18-0.1
  Upstream Author : Sebastien Diaz 
* URL : http://www.gnu.org/software/cgicc/
* License : GPL-2+
  Section : libs

It builds those binary packages:

libcgicc-dev - C++ class library for writing CGI applications 
(development files
libcgicc-doc - C++ class library for writing CGI applications 
(documentation)
libcgicc3  - C++ class library for writing CGI applications 
(library)


To access further information about this package, please visit the 
following URL:


https://mentors.debian.net/package/libcgicc


Alternatively, one can download the package with dget using this 
command:


dget -x 
https://mentors.debian.net/debian/pool/main/libc/libcgicc/libcgicc_3.2.18-0.1.dsc


More information about cgicc can be obtained from 
http://www.gnu.org/software/cgicc/.


Changes since the last upload:

  * New upstream release.
- fixes include statement for MStreamable.h. (Closes: #865275).
- upstream includes patches for pkgconfig file and empty index.html.
  * Updated to Standards-Version 4.0.0 (no changes required).


Regards,
 Thomas Pircher