Re: Bug#867145: RFS: fancon/0.11.13

[Andreas Moog]

On Tue, Jul 04, 2017 at 05:35:15PM +1000, Hayden Briese wrote:

I'm not a DD, so can't sponsor your package. Here are some comments:

> * Package name: fancon
>   Version : 0.11.13
>   Upstream Author : Hayden Briese (haydenbri...@gmail.com)
> * URL : https://github.com/hbriese/fancon
> * License : Apache Version 2.0
>   Section : utils

1. The package you created is a native package. This generally is only useful 
for software that are specifically targeted for Debian. In this case non-native 
would be the better choice. (See [1] for an explanation of native/non-native)

2. The files README and README.source still contain default text, either remove 
the files or fill them with useful information.

3. debian/fancon-docs.docs: This file is named wrong. Either name it just 
"docs" or "fancon.docs". The part before the ".docs" is the package name it 
applies to and you don't build a package named fancon-docs. (See "man 
dh_installdocs"). Also, the contents are wrong, the man-page has more
information about that as well.

4. debian/manpage.1: That doesn't look useful at all.

5. debian/copyright: the files under the cmake-directory have different 
copyright information, you need to record that as well.

6. debian/rules: Are all the overrides really needed? Then you should document 
why they are there and delete the non-used comments.

7. debian/control: 
   a) Carefully look at the Build-Depends again, some of the packages you 
  specified are already in build-essential so no need to specify them
  again.
   b) The current Standards version is 4.0.0
   c) Consider running "wrap-and-sort" from devscripts to make the 
  Depends/Build-Depends more readable

8. The package doesn't build:
In file included from /<>/src/Controller.hpp:4:0,
 from /<>/src/main.hpp:4,
 from /<>/src/main.cpp:1:
/<>/src/Devices.hpp:18:15: error: 'fancon::FanNV' has not been 
declared using fancon::FanNV;
/<>/src/Devices.hpp:21:15: error: 'fancon::SensorNV' has not been 
declared using fancon::SensorNV;

(Full buildlog at https://warperbbs.de/buildlogs/fancon.build)

Cheers,
  Andreas

[1] 
https://wiki.debian.org/DebianMentorsFaq#What_is_the_difference_between_a_native_Debian_package_and_a_non-native_package.3F

-- 
PGP-encrypted mails preferred
PGP Fingerprint: 74CD D9FE 5BCB FE0D 13EE 8EEA 61F3 4426 74DE 6624


signature.asc
Description: PGP signature

Bug#867145: RFS: fancon/0.11.13

[Hayden Briese]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "fancon"

* Package name: fancon
  Version : 0.11.13
  Upstream Author : Hayden Briese (haydenbri...@gmail.com)
* URL : https://github.com/hbriese/fancon
* License : Apache Version 2.0
  Section : utils

It builds those binary packages:

fancon - High performance, configurable system & NVIDIA fan control daemon

I wrote fancon as an alternative/replacement to the 'fancontrol' package.
Please keep in mind that I appreciate the work the lm-sensors team has
done on fancontrol, and wish to improve Linux fan control in part
through use of their library libsensors.

fancon provides several key improvements over fancontrol:
- Meaningful configuration - RPM & percentage speed control, not just
  PWM control as fancontrol provides (e.g. 5% or 600RPM vs 125PWM);
  note. PWM control is still supported.
- Simpler configuration - greater readability and ease of use (a serious
  issue for fancontrol, in my opinion).
- NVIDIA GPU fan control support; AMD support planned.
- Support for stopping fans completely, with guaranteed start (minimum PWM is
  almost always lower than the starting PWM meaning you can't go
  from 0RPM -> 400RPM, but instead from 0 -> 500 -> 400),
  not supported by fancontrol.
- User doesn't require knowledge detailed knowledge of each fan as
  they do with fancontrol due to 'meaningful configuration' support
  (120PWM does not result in the same RPM for even the same
  model of fan).
- No limit on the number of configuration points,
  where as fancontrol has a limit of 3.
- Support for profiles

To access further information about this package, please visit the
following URLs:

  https://mentors.debian.net/package/fancon

  https://github.com/hbriese/fancon

The package can be downloaded directly with dget:

   dget -x 
https://mentors.debian.net/debian/pool/main/f/fancon/fancon_0.11.13.dsc


Please email any feedback, and feature/package request.

Thanks,

Hayden