Bug#874305: RFS: mitlm/0.4.2-1 -- MIT Language Modeling toolkit

[Tobias Frost]

Control: close -1 

As this bug is now more than two years old since last interaction, I'm closing
it. (the link in the RFS is 404 also, so there is nothing to sponsor atm.

Feel free to reopen if there is something to be sponsored and I missed it.

-- 
tobi

Bug#874305: RFS: mitlm/0.4.2-1 -- MIT Language Modeling toolkit

[Mo Zhou]

On Sun, Sep 09, 2018 at 12:25:54PM +0200, Giulio Paci wrote:
> Hi Mo,
>    thank you for your offer and review.
> Unfortunately I do not know when I will be able to handle these issues as I
> have very limited time at the moment.
> 
> And the latest standards version is 4.2.1 .
> 
> As you can see from git, the package as not been updated since a long time. As
> soon as I can work on it again I will update the package.
> Given the long time that has passed since my last update, during the last few
> months I have also thought about orphaning, but I am still hoping to find time
> in the close future.

No problem, just take your time. And thanks for your contribution to Debian!

> 2. why is the SOVERSION bump from 0 to 1?
> --
> 
> Has upstream bumped ABI/API?
> 
> I do not remember the exact reason, but I confirm that SOVERSION has been
> bumped upstream as well.

Ok.

> The original upstream author is not active anymore, so I also act as upstream
> for this package.
> 
> Besides, I'd suggest add symbols control file for this package such
> that ABI changes can be tracked more easily. One will obtain a symbols
> list from buildlog after creating an empty .symbols file and rebuild.
> 
> I was never able to use symbols files with C++ ABI, as I always receive errors
> on architectures that are different from the one that I use to create the
> symbols file. Moreover I have also tried different approaches to track 
> symbols,
> in order to guarantee that the ABI has not changed in any platform (e.g., if
> the API changes a parameter from int64 to size_t, the change is not always
> reflected in the ABI). In the end I gave up trying to track them. When I
> described the issue upstream, in many cases some of them simply started 
> bumping
> SOVERSION at every release, just to stay on the safe side. Do you have any
> better strategy to solve these issues?

Indeed sometimes C++ symbols is a nightmare compared to that of C.
For a small C++ library one solution is to create different symbol
files for different architectures, i.e.
│
│ debian/libfoobar.symbols
│ debian/libfoobar.symbols.arm64
│ debian/libfoobar.symbols.ppc64el
│ ...
│
This can be done by abusing buildd a little bit -- e.g. uploading the
package with the amd64 symbols first, and then collect the symbol
patches from buildd for different architectures and create specific
symbol files for them. In this way the maintainer's burden won't
increase too much.
 
> Best regards,
> Giulio

Bug#874305: RFS: mitlm/0.4.2-1 -- MIT Language Modeling toolkit

[Giulio Paci]

Hi Mo,
   thank you for your offer and review.
Unfortunately I do not know when I will be able to handle these issues as I
have very limited time at the moment.

Il dom 9 set 2018, 07:46 Mo Zhou  ha scritto:

> control: owner -1 !
> control: tags -1 +moreinfo
>
> I can sponsor this package. However this package looks old and needs
> updating before the upload.
>
> 1. please have a look and fix the following lintian warnings:
> -


> And the latest standards version is 4.2.1 .
>

As you can see from git, the package as not been updated since a long time.
As soon as I can work on it again I will update the package.
Given the long time that has passed since my last update, during the last
few months I have also thought about orphaning, but I am still hoping to
find time in the close future.

2. why is the SOVERSION bump from 0 to 1?
> --
>
> Has upstream bumped ABI/API?
>

I do not remember the exact reason, but I confirm that SOVERSION has been
bumped upstream as well.
The original upstream author is not active anymore, so I also act as
upstream for this package.

Besides, I'd suggest add symbols control file for this package such
> that ABI changes can be tracked more easily. One will obtain a symbols
> list from buildlog after creating an empty .symbols file and rebuild.
>

I was never able to use symbols files with C++ ABI, as I always receive
errors on architectures that are different from the one that I use to
create the symbols file. Moreover I have also tried different approaches to
track symbols, in order to guarantee that the ABI has not changed in any
platform (e.g., if the API changes a parameter from int64 to size_t, the
change is not always reflected in the ABI). In the end I gave up trying to
track them. When I described the issue upstream, in many cases some of them
simply started bumping SOVERSION at every release, just to stay on the safe
side. Do you have any better strategy to solve these issues?

Best regards,
Giulio

Bug#874305: RFS: mitlm/0.4.2-1 -- MIT Language Modeling toolkit

[Mo Zhou]

control: owner -1 !
control: tags -1 +moreinfo

Hi Giulio,

I can sponsor this package. However this package looks old and needs
updating before the upload.

1. please have a look and fix the following lintian warnings:
-

│  W: mitlm changes: orig-tarball-missing-upstream-signature 
mitlm_0.4.2.orig.tar.xz
│  W: mitlm source: vcs-deprecated-in-debian-infrastructure vcs-git 
https://anonscm.debian.org/cgit/collab-maint/mitlm.git
│  W: mitlm source: vcs-deprecated-in-debian-infrastructure vcs-browser 
https://anonscm.debian.org/cgit/collab-maint/mitlm.git
│  W: libmitlm1: debian-changelog-has-wrong-day-of-week 2018-09-05 is a 
Wednesday
│  W: mitlm: debian-changelog-has-wrong-day-of-week 2018-09-05 is a Wednesday
│  W: libmitlm-dev: debian-changelog-has-wrong-day-of-week 2018-09-05 is a 
Wednesday

For more detailed hints about how to fix them, just run

│
│ lintian -EviI
│

after building this package. Or pass an existing *.changes file to lintian.

Particylarly, the Vcs-* fields should point to Salsa
https://salsa.debian.org/giuliopaci-guest/mitlm

And the latest standards version is 4.2.1 .

2. why is the SOVERSION bump from 0 to 1?
--

Has upstream bumped ABI/API?

Besides, I'd suggest add symbols control file for this package such
that ABI changes can be tracked more easily. One will obtain a symbols
list from buildlog after creating an empty .symbols file and rebuild.

---

The rest LGTM.

Bug#874305: RFS: mitlm/0.4.2-1 -- MIT Language Modeling toolkit

[Jakub Wilk]

I've retired from sponsoring. Sorry!

--
Jakub Wilk

Bug#874305: RFS: mitlm/0.4.2-1 -- MIT Language Modeling toolkit

[Giulio Paci]

X-Debbugs-CC: jw...@debian.org
Control: tags -1 - moreinfo

Hi Adam and Tobias,
  thank you for having a look at this.

On 15/12/2017 14:09, Adam Borowski wrote:
> On Mon, Sep 04, 2017 at 10:49:36PM +0200, Giulio Paci wrote:
>> Dear Jakub,
>>
>>   I am looking for a sponsor for an updated version of my package "mitlm"
> 
> Apparently you forgot to CC jwilk; this RFS went only to the mentors
> mailinglist -- yet, upon seeing the first line, we assumed you want your
> usual sponsor.

You are right. I am CCing him now.

>> * Package name: mitlm
>>   Version : 0.4.2
> 
> I'm afraid it fails to build:
> /<>/./configure: line 20515: AX_CXX_HEADER_TR1_UNORDERED_MAP: 
> command not found
> /<>/./configure: line 20516: syntax error near unexpected token 
> `noext,'
> /<>/./configure: line 20516: `AX_CXX_COMPILE_STDCXX_11(noext, 
> optional)'

I added the autoconf-archive missing dependency.

On 04/01/2018 11:58, Tobias Frost wrote:
> Other notes: (Note that I did NOT a complete review)
> - Are you sure you want it uploaded to experimental? Why?

Indeed I am not sure, and actually prefer to have mitlm in unstable.

We decided to upload it to experimental, because of many uncertainties about 
both upstream development and about the package development (I was new to 
packaging when we
uploaded there).

As my long term goal is to have typical "development" packages for speech 
recognition and speech synthesis in Debian, I would really like to see mitlm in 
unstable.

> - d/compat could be bumped.

Done.

> - (S-V has increased in the meantime too, when over it you might want
> to update that to the latest)

Done.

> - maybe consider switching to debhelper (and dh_autoreconf). I'm pretty
> sure that will simplify d/rules a lot. (This would be whishlist entry
> of mine, not required at all)

Considered and done. :-)

> Please fix the FTBFS (and if you want the stuff above), then remove the
> moreinfo when ready!

Done by adding the missing dependency.

Bug#874305: RFS: mitlm/0.4.2-1 -- MIT Language Modeling toolkit

[Tobias Frost]

Control: tags -1 moreinfo

I can confirm the FTBFS in a pbuilder enviroment. 

Other notes: (Note that I did NOT a complete review)
- Are you sure you want it uploaded to experimental? Why?
- d/compat could be bumped.
- (S-V has increased in the meantime too, when over it you might want
to update that to the latest)
- maybe consider switching to debhelper (and dh_autoreconf). I'm pretty
sure that will simplify d/rules a lot. (This would be whishlist entry
of mine, not required at all)

Please fix the FTBFS (and if you want the stuff above), then remove the
moreinfo when ready!

--
tobi

Bug#874305: RFS: mitlm/0.4.2-1 -- MIT Language Modeling toolkit

[Adam Borowski]

On Mon, Sep 04, 2017 at 10:49:36PM +0200, Giulio Paci wrote:
> Dear Jakub,
> 
>   I am looking for a sponsor for an updated version of my package "mitlm"

Apparently you forgot to CC jwilk; this RFS went only to the mentors
mailinglist -- yet, upon seeing the first line, we assumed you want your
usual sponsor.

> * Package name: mitlm
>   Version : 0.4.2

I'm afraid it fails to build:
/<>/./configure: line 20515: AX_CXX_HEADER_TR1_UNORDERED_MAP: 
command not found
/<>/./configure: line 20516: syntax error near unexpected token 
`noext,'
/<>/./configure: line 20516: `AX_CXX_COMPILE_STDCXX_11(noext, 
optional)'

Full log attached.


Meow!
-- 
// If you believe in so-called "intellectual property", please immediately
// cease using counterfeit alphabets.  Instead, contact the nearest temple
// of Amon, whose priests will provide you with scribal services for all
// your writing needs, for Reasonable And Non-Discriminatory prices.
sbuild (Debian sbuild) 0.73.0 (23 Dec 2016) on umbar.angband.pl

+==+
| mitlm 0.4.2-1 (amd64)Fri, 15 Dec 2017 12:58:30 + |
+==+

Package: mitlm
Version: 0.4.2-1
Source Version: 0.4.2-1
Distribution: unstable
Machine Architecture: amd64
Host Architecture: amd64
Build Architecture: amd64
Build Type: binary

I: NOTICE: Log filtering will replace 
'var/run/schroot/mount/unstable-amd64-sbuild-42572092-7fda-4143-af81-ba8882563034'
 with '<>'

+--+
| Update chroot|
+--+

Get:1 http://apt.angband.pl:3142/debian unstable InRelease [240 kB]
Get:2 http://apt.angband.pl:3142/debian unstable/main Sources.diff/Index [27.9 
kB]
Get:3 http://apt.angband.pl:3142/debian unstable/main amd64 Packages.diff/Index 
[27.9 kB]
Get:4 http://apt.angband.pl:3142/debian unstable/main Sources 
2017-12-14-0823.22.pdiff [3725 B]
Get:5 http://apt.angband.pl:3142/debian unstable/main Sources 
2017-12-14-1424.06.pdiff [15.4 kB]
Get:6 http://apt.angband.pl:3142/debian unstable/main Sources 
2017-12-14-2024.46.pdiff [17.6 kB]
Get:7 http://apt.angband.pl:3142/debian unstable/main Sources 
2017-12-15-0224.29.pdiff [17.4 kB]
Get:8 http://apt.angband.pl:3142/debian unstable/main Sources 
2017-12-15-0826.26.pdiff [10.7 kB]
Get:9 http://apt.angband.pl:3142/debian unstable/main amd64 Packages 
2017-12-14-0823.22.pdiff [4822 B]
Get:8 http://apt.angband.pl:3142/debian unstable/main Sources 
2017-12-15-0826.26.pdiff [10.7 kB]
Get:10 http://apt.angband.pl:3142/debian unstable/main amd64 Packages 
2017-12-14-1424.06.pdiff [17.8 kB]
Get:11 http://apt.angband.pl:3142/debian unstable/main amd64 Packages 
2017-12-14-2024.46.pdiff [13.7 kB]
Get:12 http://apt.angband.pl:3142/debian unstable/main amd64 Packages 
2017-12-15-0224.29.pdiff [18.1 kB]
Get:13 http://apt.angband.pl:3142/debian unstable/main amd64 Packages 
2017-12-15-0826.26.pdiff [11.1 kB]
Get:13 http://apt.angband.pl:3142/debian unstable/main amd64 Packages 
2017-12-15-0826.26.pdiff [11.1 kB]
Fetched 426 kB in 2s (174 kB/s)
Reading package lists...
Reading package lists...
Building dependency tree...
Reading state information...
Calculating upgrade...
The following packages will be upgraded:
  libxml2
1 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Need to get 730 kB of archives.
After this operation, 0 B of additional disk space will be used.
Get:1 http://apt.angband.pl:3142/debian unstable/main amd64 libxml2 amd64 
2.9.4+dfsg1-5.2 [730 kB]
debconf: delaying package configuration, since apt-utils is not installed
Fetched 730 kB in 0s (5722 kB/s)
(Reading database ... 
(Reading database ... 5%
(Reading database ... 10%
(Reading database ... 15%
(Reading database ... 20%
(Reading database ... 25%
(Reading database ... 30%
(Reading database ... 35%
(Reading database ... 40%
(Reading database ... 45%
(Reading database ... 50%
(Reading database ... 55%
(Reading database ... 60%
(Reading database ... 65%
(Reading database ... 70%
(Reading database ... 75%
(Reading database ... 80%
(Reading database ... 85%
(Reading database ... 90%
(Reading database ... 95%
(Reading database ... 100%
(Reading database ... 13687 files and directories currently installed.)
Preparing to unpack .../libxml2_2.9.4+dfsg1-5.2_amd64.deb ...
Unpacking libxml2:amd64 (2.9.4+dfsg1-5.2) over (2.9.4+dfsg1-5.1) ...
Setting up libxml2:amd64 (2.9.4+dfsg1-5.2) ...
Processing triggers for libc-bin (2.25-4) ...

+--+
| Fetch source files   |
+--+


Local sources
-

Bug#874305: RFS: mitlm/0.4.2-1 -- MIT Language Modeling toolkit

[Giulio Paci]

Package: sponsorship-requests
Severity: wishlist

Dear Jakub,

  I am looking for a sponsor for an updated version of my package "mitlm"

* Package name: mitlm
  Version : 0.4.2
  Upstream Author : Bo-June (Paul) Hsu 
* URL : https://github.com/mitlm/mitlm
* License : BSD
  Programming Lang: (C, C++, Fortran)
  Section : misc

It builds those binary packages:

 libmitlm1  - MIT Language Modeling toolkit library
 libmitlm1-dev - MIT Language Modeling toolkit development files
 mitlm - MIT Language Modeling toolkit

You can find the source of the package at:

  https://anonscm.debian.org/cgit/collab-maint/mitlm.git

Regards,
   Giulio Paci



signature.asc
Description: OpenPGP digital signature