Bug#878268: RFS: streamlink/0.9.0-1 [ITP]
Le 31/12/2017 à 02:04, Paul Wise a écrit : > On Sat, 2017-12-30 at 22:04 +0100, Alexis Murzeau wrote: > >> https://mentors.debian.net/debian/pool/main/s/streamlink/streamlink_0.9.0+dfsg.2-3.dsc > > Uploaded to NEW, thanks a lot for your contribution, it saved me from > having yet another package removed from Debian on my system :) > Thank you very much too :) The upload failed because the orig tarball was not included maybe because its -3 ? The changes since version 0.8.1-2 should be included too I guess as this one has the Closes on the ITP. -- Alexis Murzeau PGP: B7E6 0EBB 9293 7B06 BDBC 2787 E7BD 1904 F480 937F signature.asc Description: OpenPGP digital signature
Bug#878268: RFS: streamlink/0.9.0-1 [ITP]
On Sun, 2017-12-31 at 02:28 +0100, Alexis Murzeau wrote: > The upload failed because the orig tarball was not included maybe > because its -3 ? Right, I forgot to include the orig tarball manually. Done now. > The changes since version 0.8.1-2 should be included too I guess as this > one has the Closes on the ITP. Yeah, I remembered to do that one :) -- bye, pabs https://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Bug#878268: RFS: streamlink/0.9.0-1 [ITP]
On Sat, 2017-12-30 at 22:04 +0100, Alexis Murzeau wrote: > https://mentors.debian.net/debian/pool/main/s/streamlink/streamlink_0.9.0+dfsg.2-3.dsc Uploaded to NEW, thanks a lot for your contribution, it saved me from having yet another package removed from Debian on my system :) -- bye, pabs https://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Bug#878268: RFS: streamlink/0.9.0-1 [ITP]
Le 30/12/2017 à 02:35, Paul Wise a écrit : > > No, I would suggest to set the binary package version for livestreamer > only, that way you can drop the transitional package after buster > without having to keep the epoch around forever. You can set the > binary package version by passing the -v option to dpkg-gencontrol via > dh_gencontrol: > > include /usr/share/dpkg/pkg-info.mk > > override_dh_gencontrol: > dh_gencontrol -plivestreamer -- -v1.12.2+streamlink+$(DEB_VERSION) > dh_gencontrol --remaining-packages > Ok, thanks for your advice :) I uploaded streamlink version 0.9.0+dfsg.2-3: dget https://mentors.debian.net/debian/pool/main/s/streamlink/streamlink_0.9.0+dfsg.2-3.dsc Changes since last uploaded one: streamlink (0.9.0+dfsg.2-3) unstable; urgency=low * Fix livestreamer description length streamlink (0.9.0+dfsg.2-2) unstable; urgency=low * Add symlink in livestreamer transitional package * Override livestreamer package version to be greater than the one in stable * Enhance livestreamer transitional package description -- Alexis Murzeau PGP: B7E6 0EBB 9293 7B06 BDBC 2787 E7BD 1904 F480 937F signature.asc Description: OpenPGP digital signature
Bug#878268: RFS: streamlink/0.9.0-1 [ITP]
On Fri, Dec 29, 2017 at 7:54 PM, Alexis Murzeau wrote: > Yes I will do that and consider check-all-the-things to be run at each > version. Ok, great. I'm also interested in any feedback you have on the tool. > Indeed my bad. Also, the package got rejected because of a higher > version in stable for the package livestreamer. > > Does the way to handle that is to add an epoch version, so it become > 1:0.9.0~dfsg.2-2 ? No, I would suggest to set the binary package version for livestreamer only, that way you can drop the transitional package after buster without having to keep the epoch around forever. You can set the binary package version by passing the -v option to dpkg-gencontrol via dh_gencontrol: include /usr/share/dpkg/pkg-info.mk override_dh_gencontrol: dh_gencontrol -plivestreamer -- -v1.12.2+streamlink+$(DEB_VERSION) dh_gencontrol --remaining-packages -- bye, pabs https://wiki.debian.org/PaulWise
Bug#878268: RFS: streamlink/0.9.0-1 [ITP]
Le 29/12/2017 à 05:21, Paul Wise a écrit : > On Fri, Dec 29, 2017 at 9:43 AM, Alexis Murzeau wrote: > >> https://mentors.debian.net/debian/pool/main/s/streamlink/streamlink_0.9.0+dfsg.2-1.dsc > > Uploaded to NEW. > > https://ftp-master.debian.org/new.html Thanks for your support. > > For future uploads, please file an RFS bug as usual. > > Please consider working through the other issues I mentioned as you > find time. Most of what I mentioned can just be forwarded to upstream > issues, I guess they would welcome patches if you have the time > though. Yes I will do that and consider check-all-the-things to be run at each version. > >> In uploaded version, I've added a transitional package for livestreamer >> as they are compatible. > > You have not included a livestreamer symlink in /usr/bin, please > address that in your next upload. Indeed my bad. Also, the package got rejected because of a higher version in stable for the package livestreamer. Does the way to handle that is to add an epoch version, so it become 1:0.9.0~dfsg.2-2 ? > >> You mean, so that `debian/streamlink.links` and >> `debian/streamlink.manpages` can be removed ? > > Right. > -- Alexis Murzeau PGP: B7E6 0EBB 9293 7B06 BDBC 2787 E7BD 1904 F480 937F signature.asc Description: OpenPGP digital signature
Bug#878268: RFS: streamlink/0.9.0-1 [ITP]
On Fri, Dec 29, 2017 at 9:43 AM, Alexis Murzeau wrote: > https://mentors.debian.net/debian/pool/main/s/streamlink/streamlink_0.9.0+dfsg.2-1.dsc Uploaded to NEW. https://ftp-master.debian.org/new.html For future uploads, please file an RFS bug as usual. Please consider working through the other issues I mentioned as you find time. Most of what I mentioned can just be forwarded to upstream issues, I guess they would welcome patches if you have the time though. > In uploaded version, I've added a transitional package for livestreamer > as they are compatible. You have not included a livestreamer symlink in /usr/bin, please address that in your next upload. > You mean, so that `debian/streamlink.links` and > `debian/streamlink.manpages` can be removed ? Right. -- bye, pabs https://wiki.debian.org/PaulWise
Bug#878268: RFS: streamlink/0.9.0-1 [ITP]
Hi,
Le 18/12/2017 à 07:26, Paul Wise a écrit :
> On Thu, Nov 23, 2017 at 5:41 AM, Alexis Murzeau wrote:
>
>> https://mentors.debian.net/debian/pool/main/s/streamlink/streamlink_0.9.0-1.dsc
>
> Here is a review:
>
> These issues need to be resolved before upload:
>
> I think docs/_static/flattr-badge.png is probably non-free. Upstream
> stopped using a while ago so it should just get removed from their
> repository and the Debian tarball.>
> These issues would be nice to fix at some point:
>
> There has been a new Debian Policy version since your upload.
Thanks for your review.
I have uploaded a new version of the streamlink package, available with:
dget
https://mentors.debian.net/debian/pool/main/s/streamlink/streamlink_0.9.0+dfsg.2-1.dsc
I removed the flattr image and font-awesome fonts using Files-Excluded
in the copyright file.
I've also asked upstream to remove the flattr image
(https://github.com/streamlink/streamlink/pull/1395)
Here are the changes since 0.9.0-1:
* Exlude flattr-badge and font-awesome which might not be dfsg-compatible
* Bump standard version, no change required
* Remove streaming platform references in description
* Add fonts-roboto-slab to recommends
* Add transitional package livestreamer
>
> Please add some upstream metadata:
>
> https://wiki.debian.org/UpstreamMetadata
>
> Personally, I would drop the last paragraph of the description, or
> possibly just the first sentence of the last paragraph of the
> description.
Done in uploaded version. I've only removed the reference to twitch and
kept the general notice.
>
> It would be nice to have a transitional package that also contains a
> symlink to the new name for the binary (assuming that they are
> command-line compatible), so that external wrappers for livestreamer
> still work with streamlink.
In uploaded version, I've added a transitional package for livestreamer
as they are compatible.
>
> For use_debian_fonts, please note that Roboto Slab is now available in Debian.
I updated the patch comment and added a recommends dependency on
fonts-roboto-slab.
>
> Please note that python3-iso3166 is now available in Debian, so you
> can switch back to the default.
>
> Please note that python3-pycryptodome is now available in Debian, so
> you can switch back to the default.>
> I'd suggest dropping the override_dh_builddeb for Debian.
>
> It would be nice if the upstream build system would also install the
> manual pages and binary in /usr/bin, you might want to send them a
> patch.
You mean, so that `debian/streamlink.links` and
`debian/streamlink.manpages` can be removed ?
>
> Automatic checks:
>
> check-all-the-things:
>
> $ codespell --quiet-level=3 .
>
>
> $ env PERL5OPT=-m-lib=. duck
> ...
> I: debian/copyright:90: URL:
> http://www.apache.org/licenses/LICENSE-2.0: INFORMATION
> (Certainty:possible)
>The web page at http://www.apache.org/licenses/LICENSE-2.0 works,
> but is also available via https://www.apache.org/licenses/LICENSE-2.0,
> please consider switching to HTTPS urls.
>
> I: debian/copyright:102: URL: http://scripts.sil.org/OFL: INFORMATION
> (Certainty:possible)
>The web page at http://scripts.sil.org/OFL works, but is also
> available via https://scripts.sil.org/OFL, please consider switching
> to HTTPS urls.
>
> $ find . -type f \( -iname '*.ttf' -o -iname '*.otf' -o -iname '*.sfd'
> -o -iname '*.pfa' -o -iname '*.pfb' -o -iname '*.bdf' -o -iname '*.pk'
> -o -iname '*.ttc' -o -iname '*.pcf' \) -exec
> check-font-embedding-restrictions {} +
> These fonts in Debian main/contrib have embedding
> restrictions, which are not DFSG compatible:
>
> ./docs/_themes/sphinx_rtd_theme_violet/static/fonts/FontAwesome.otf: 0x0004
> ./docs/_themes/sphinx_rtd_theme_violet/static/fonts/fontawesome-webfont.ttf:
> 0x0004
>
> https://www.microsoft.com/typography/otspec/os2.htm#fst
>
> $ find . -type f \( -iname '*.ttf' -o -iname '*.otf' -o -iname
> '*.woff' -o -iname '*.sfd' -o -iname '*.pfa' -o -iname '*.pfb' -o
> -iname '*.bdf' -o -iname '*.pk' -o -iname '*.ttc' -o -iname '*.pcf' \)
> -exec fontlint {} \;
>
>
> # If you contact the owners of these keys, please point out OpenPGP
> best practices:
> # https://help.riseup.net/en/security/message-security/openpgp/best-practices
> $ find . -type f -iname '*.asc' -exec cat {} + | hot dearmor | hokey lint
> ...
> Checking user-ID- and user-attribute-related items:
> Charlie Drage :
> Self-sig hash algorithms: [SHA-1]
> ...
> Checking subkeys:
> ...
> fpr: CDEE D514 4E91 E633 6D0B 59CC 2523 80C9 D3E8 71F7
> ...
> binding sig hash algorithms: [SHA-1]
> ...
> cross-cert hash algorithms: [SHA-1]
>
> # check if these can be switched to https://
> $ grep -nHrF http: .
>
>
> $ find . -type f -iname '*.py' -exec mypy {} +
>
>
> # This command checks style. While a consistent style
> # is a good idea, people who have different style
> # preferences will want to ignore some of the output.
> # Do
Bug#878268: RFS: streamlink/0.9.0-1 [ITP]
On Thu, Nov 23, 2017 at 5:41 AM, Alexis Murzeau wrote:
> https://mentors.debian.net/debian/pool/main/s/streamlink/streamlink_0.9.0-1.dsc
Here is a review:
These issues need to be resolved before upload:
I think docs/_static/flattr-badge.png is probably non-free. Upstream
stopped using a while ago so it should just get removed from their
repository and the Debian tarball.
These issues would be nice to fix at some point:
There has been a new Debian Policy version since your upload.
Please add some upstream metadata:
https://wiki.debian.org/UpstreamMetadata
Personally, I would drop the last paragraph of the description, or
possibly just the first sentence of the last paragraph of the
description.
It would be nice to have a transitional package that also contains a
symlink to the new name for the binary (assuming that they are
command-line compatible), so that external wrappers for livestreamer
still work with streamlink.
For use_debian_fonts, please note that Roboto Slab is now available in Debian.
Please note that python3-iso3166 is now available in Debian, so you
can switch back to the default.
Please note that python3-pycryptodome is now available in Debian, so
you can switch back to the default.
I'd suggest dropping the override_dh_builddeb for Debian.
It would be nice if the upstream build system would also install the
manual pages and binary in /usr/bin, you might want to send them a
patch.
Automatic checks:
check-all-the-things:
$ codespell --quiet-level=3 .
$ env PERL5OPT=-m-lib=. duck
...
I: debian/copyright:90: URL:
http://www.apache.org/licenses/LICENSE-2.0: INFORMATION
(Certainty:possible)
The web page at http://www.apache.org/licenses/LICENSE-2.0 works,
but is also available via https://www.apache.org/licenses/LICENSE-2.0,
please consider switching to HTTPS urls.
I: debian/copyright:102: URL: http://scripts.sil.org/OFL: INFORMATION
(Certainty:possible)
The web page at http://scripts.sil.org/OFL works, but is also
available via https://scripts.sil.org/OFL, please consider switching
to HTTPS urls.
$ find . -type f \( -iname '*.ttf' -o -iname '*.otf' -o -iname '*.sfd'
-o -iname '*.pfa' -o -iname '*.pfb' -o -iname '*.bdf' -o -iname '*.pk'
-o -iname '*.ttc' -o -iname '*.pcf' \) -exec
check-font-embedding-restrictions {} +
These fonts in Debian main/contrib have embedding
restrictions, which are not DFSG compatible:
./docs/_themes/sphinx_rtd_theme_violet/static/fonts/FontAwesome.otf: 0x0004
./docs/_themes/sphinx_rtd_theme_violet/static/fonts/fontawesome-webfont.ttf:
0x0004
https://www.microsoft.com/typography/otspec/os2.htm#fst
$ find . -type f \( -iname '*.ttf' -o -iname '*.otf' -o -iname
'*.woff' -o -iname '*.sfd' -o -iname '*.pfa' -o -iname '*.pfb' -o
-iname '*.bdf' -o -iname '*.pk' -o -iname '*.ttc' -o -iname '*.pcf' \)
-exec fontlint {} \;
# If you contact the owners of these keys, please point out OpenPGP
best practices:
# https://help.riseup.net/en/security/message-security/openpgp/best-practices
$ find . -type f -iname '*.asc' -exec cat {} + | hot dearmor | hokey lint
...
Checking user-ID- and user-attribute-related items:
Charlie Drage :
Self-sig hash algorithms: [SHA-1]
...
Checking subkeys:
...
fpr: CDEE D514 4E91 E633 6D0B 59CC 2523 80C9 D3E8 71F7
...
binding sig hash algorithms: [SHA-1]
...
cross-cert hash algorithms: [SHA-1]
# check if these can be switched to https://
$ grep -nHrF http: .
$ find . -type f -iname '*.py' -exec mypy {} +
# This command checks style. While a consistent style
# is a good idea, people who have different style
# preferences will want to ignore some of the output.
# Do not bother adding non-upstreamable patches for this.
$ proselint .
# This command checks style. While a consistent style
# is a good idea, people who have different style
# preferences will want to ignore some of the output.
# Do not bother adding non-upstreamable patches for this.
$ find . -type f -iname '*.py' -exec pycodestyle --ignore W191 {} +
# This command checks style. While a consistent style
# is a good idea, people who have different style
# preferences will want to ignore some of the output.
# Do not bother adding non-upstreamable patches for this.
$ pydocstyle .
$ find . -type f -iname '*.py' -exec pyflakes {} +
$ find . -type f -iname '*.py' -exec pyflakes3 {} +
$ find . -type f -iname '*.py' -exec pylint --rcfile=/dev/null
--msg-template='{path}:{line}:{column}: [{category}:{symbol}] {obj}:
{msg}' --reports=n {} +
$ find . -type f -iname '*.py' -exec pylint3 --rcfile=/dev/null
--msg-template='{path}:{line}:{column}: [{category}:{symbol}] {obj}:
{msg}' --reports=n {} +
$ python2-bandit -r .
$ python3-bandit -r .
$ vulture .
$ find . -type d \( -iname .bzr -o -iname .git -o -iname .hg -o -iname
.svn -o -iname CVS -o -iname RCS -o -iname SCCS -o -iname _MTN -o
-iname _darcs -o -iname .pc -o -iname .cabal-sandbox -o -iname .cdv -o
-iname .metadata -o -iname CMakeFiles -o -iname _build -o
Bug#878268: RFS: streamlink/0.9.0-1 [ITP]
Control: retitle -1 RFS: streamlink/0.9.0-1 [ITP] Hi, I am looking for a sponsor for my package "streamlink" I made a new upload for the new upstream version: 0.9.0. The package is available using this dget command: dget -x https://mentors.debian.net/debian/pool/main/s/streamlink/streamlink_0.9.0-1.dsc Changes since last upload: streamlink (0.9.0-1) unstable; urgency=low * New upstream version 0.9.0 * Recommend python3-socks for socks proxy support * Drop documentation patches applied upstream streamlink (0.8.1-4) unstable; urgency=low * Use gzip format in deb files - bintray repository does not support control.tar.xz Can anyone look at it ? Thanks :) -- Alexis Murzeau PGP: B7E6 0EBB 9293 7B06 BDBC 2787 E7BD 1904 F480 937F signature.asc Description: OpenPGP digital signature
