Bug#961899: Fwd: Bug#961899: RFS: wifi-qr/0.1-1 -- WiFi Share and Connect with QR

2020-06-05 Thread Boyuan Yang 
Now I believe their's only one issue left: You marked the package to be
Architecture:any. However, I do not see any differences for your
package across difference hardware architecture. Could you explain the
reason of using Architecture:any?

If the built package would be exactly the same across all
architectures, maybe Architecture:all should be used.

After solving this problem, I believe your package should be ready for
upload.

-- 
Best,
Boyuan Yang

在 2020-06-05星期五的 09:35 +0630，Ko Ko Ye`写道：
> 
> 
> -- Forwarded message -
> From: Ko Ko Ye` 
> Date: Fri, Jun 5, 2020 at 9:32 AM
> Subject: Re: Bug#961899: RFS: wifi-qr/0.1-1 -- WiFi Share and Connect
> with QR
> To: Boyuan Yang <073p...@gmail.com>
> now its available at 
> 
> https://mentors.debian.net/package/wifi-qr
> 
> https://mentors.debian.net/debian/pool/main/w/wifi-qr/wifi-qr_0.1-1.dsc 


signature.asc
Description: This is a digitally signed message part

Bug#961899: Fwd: Bug#961899: RFS: wifi-qr/0.1-1 -- WiFi Share and Connect with QR

2020-06-04 Thread Ko Ko Ye` 
-- Forwarded message -
From: Ko Ko Ye` 
Date: Fri, Jun 5, 2020 at 9:32 AM
Subject: Re: Bug#961899: RFS: wifi-qr/0.1-1 -- WiFi Share and Connect with
QR
To: Boyuan Yang <073p...@gmail.com>


Thank so much Boyuan

On Fri, Jun 5, 2020 at 8:42 AM Boyuan Yang <073p...@gmail.com> wrote:

> Control: tags -1 +moreinfo
>
> Hi kokoye,
>
> Please find my comments below:
>
> Ko Ko Ye`  于2020年5月30日周六 下午11:57写道：
> >
> > Package: sponsorship-requests
> > Severity: wishlist
> >
> > Dear mentors,
> >
> > I am looking for a sponsor for my package "wifi-qr"
> >
> >  * Package name: wifi-qr
> >Version : 0.1-1
> >Upstream Author : kokoye2007 
> >  * URL : https://github.com/kokoye2007/wifi-qr
> >  * License : GPL-3.0+
> >  * Vcs : https://github.com/kokoye2007/wifi-qr
> >Section : utils
> >
> > It builds those binary packages:
>
> 1. Please do *not* submit duplicated RFS bugs. You submitted multiple RFS
> requests and the duplicated ones have already been closed  by the bartm bot
> as you can see in [2]. If you need to make any modifications, please use
> the
> original bug report and add more information by replying to the report
> email
> address.
>
> [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=962169;msg=7


when i make changelog with  ITP Close, have some error.
so i am test with new RFS.
now follow with #961899 

>
>
> 2. I saw your packaging repo at https://github.com/kokoye2007/wifi-qr.
> Please
> drop the /.pc directory. This directory is created internally during
> package building
> and is not supposed to appear anywhere, anytime, especially in your
> packaging repo.
> Keeping it will cause issues when building the package.
>

i am upload after function updated.
so confuse and make a patch.
now clean and fix.


>
> 3. Since you yourself is the upstream of this software, I don't quite
> get it when
> you put another patch file at
> /debian/patches/remove-duplicate-function. Apparantly
> it is not a Debian-specific patch. It is supposed to be applied
> directly onto your
> source code instead of appearing as a patch for Debian. In this case you
> might
> should act as the upstream and release a new version of your software,
> not as the
> packager applying a patch.
>

same with case 2.

>
> 4. The #DEBHELPER# placeholder should never appear in the debian/rules
> file.
> It is the placeholder to be used in the preinst/postinst/prerm/postrm
> maintenance
> scripts, not the debian/rules Makefile.
>
> 5. Even in the preinst/postinst scripts, the #DEBHELPER# placeholder should
> appear at the bottom of the scripts.
>
> 6. I highly doubt whether manually invoking update-icon-caches is useful
> at all.
> I believe it will be handled by the dpkg triggers automatically. Maybe
> you do not
> need to add any preinst/post scripts at all for this package.
>
>
Thank for very clear message.
its fix.


> I believe the 6 issues above need to be solved before having this
> package uploaded.
> Thanks!
>
>
Please kindly check for me.
now its available at

https://mentors.debian.net/package/wifi-qr

https://mentors.debian.net/debian/pool/main/w/wifi-qr/wifi-qr_0.1-1.dsc

with regards and respects

-- 
> Regards,
> Boyuan Yang
>


-- 

with regards *Ko Ko Ye`*

+95 97989 22022
+95 94500 22022
+95 9731 47907
kokoye2...@gmail.com
kokoye2...@ubuntu.com

skype: kokoye2007
jitsi: kokoye2007

http://ubuntu-mm.net
http://wiki.ubuntu.com/kokoye2007
http://wiki.ubuntu.com/MyanmarTeam http://loco.ubuntu.com/teams/ubuntu-mm


-- 

with regards *Ko Ko Ye`*

+95 97989 22022
+95 94500 22022
+95 9731 47907
kokoye2...@gmail.com
kokoye2...@ubuntu.com

skype: kokoye2007
jitsi: kokoye2007

http://ubuntu-mm.net
http://wiki.ubuntu.com/kokoye2007
http://wiki.ubuntu.com/MyanmarTeam http://loco.ubuntu.com/teams/ubuntu-mm