Bug#962091: RFS: xine-ui/0.99.12-1 [QA] -- xine video player, user interface
Hi, and thanks for the review. lør. 6. jun. 2020 kl. 11:41 skrev Adrian Bunk : > > Control: tags -1 moreinfo > > On Wed, Jun 03, 2020 at 08:04:45AM +, Håvard Flaget Aasen wrote: > >... > > Changes since the last upload: > >... > >* d/rules > > - Change to dh-sequence > >... > >* d/control > >... > > - Remove unnecessary Depends field > >... > > This was necessary, it was just broken by your debian/rules rewrite. > This RC regression can easily be reproduced with aaxine. > > For the debian/rules change, please verify that the changed package > does not contain any unexpected changes from the original one. > This means first understanding what the old debian/rules did. > I can immediately find two things that were done in the old debian/rules > but are missing in the new one. > I re added the dependency fields in d/control, dh_xine, and dh_compress targets in d/rules, which shouldn't have been removed, thanks for spotting that. I also added back dh_installchangelog, I'm still not sure if anything is actually using this symlink, but it is consistent with the previous version. > >* Add fix_spelling_error.patch > >... I've updated the .pot file and .po files as well, I believe that should fix it. > > This is a translated string, such a change breaks all translations of > this string. > > > Regards, > > Håvard > > cu > Adrian Regards, Håvard
Bug#962091: RFS: xine-ui/0.99.12-1 [QA] -- xine video player, user interface
Control: tags -1 moreinfo On Wed, Jun 03, 2020 at 08:04:45AM +, Håvard Flaget Aasen wrote: >... > Changes since the last upload: >... >* d/rules > - Change to dh-sequence >... >* d/control >... > - Remove unnecessary Depends field >... This was necessary, it was just broken by your debian/rules rewrite. This RC regression can easily be reproduced with aaxine. For the debian/rules change, please verify that the changed package does not contain any unexpected changes from the original one. This means first understanding what the old debian/rules did. I can immediately find two things that were done in the old debian/rules but are missing in the new one. >* Add fix_spelling_error.patch >... This is a translated string, such a change breaks all translations of this string. > Regards, > Håvard cu Adrian
Bug#962091: RFS: xine-ui/0.99.12-1 [QA] -- xine video player, user interface
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "xine-ui" * Package name: xine-ui Version : 0.99.12-1 Upstream Author : xine-de...@lists.sf.net * URL : https://xine-project.org/ * License : GPL-2+ * Vcs : None Section : video It builds those binary packages: xine-ui - xine video player, user interface (X11 gui) xine-console - xine video player, user interface To access further information about this package, please visit the following URL: https://mentors.debian.net/package/xine-ui Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/x/xine-ui/xine-ui_0.99.12-1.dsc Changes since the last upload: * QA upload. * New upstream release. * Orphan the package see: #881516 * Update d/watch * d/copyright: rewrite using copyright-format 1.0 and add some missing attributions * d/rules - Change to dh-sequence - Add hardening options - Fix FTCBFS, original patch by Helmut Grohne Closes: #881790 * d/control - Change to debhelper-compat - Bump debhelper to 13 - Update Standards-Version to 4.5.0 - Change to secure URI on homepage - Remove Vcs-* fields - Add Rules-Requires-Root: no - Update short description. - Remove unnecessary Depends field * Remove unused entry debian/source/include-binaries * Split xine-ui.mime into two files. * Remove whitespace from d/changelog * Add fix_macro_in_manpage.patch * Add fix_spelling_error.patch I'm unsure about the invocation of the postinst script, though the end result should be correct. Regards, Håvard
