Bug#964308: RFS: geshi/1.0.9.1-1 [ITA] -- Generic Syntax Highlighter
Hi Adrian, Thanks for looking at this. I've uploaded a new version to mentors.debian.net (#4): https://mentors.debian.net/debian/pool/main/g/geshi/geshi_1.0.9.1-1.dsc > > -Build-Depends: cdbs, debhelper (>= 9) > +Build-Depends: debhelper (>= 9), debhelper-compat (= 13) > > On the nitpick side is that debhelper-compat (= 13) is sufficient. Done. > > Slightly more serious that you should document the switch from cdbs in > the changelog. > OK, I've added a changelog entry about this. >>... >> + * debian/tests/test.php: add a simple sanity test. >>... > > Is anything running this test? > This looks like an autopkgtest without the control file. > No, I was just running it manually before. I've added a debian/tests/control file and expected output so autopkgtest can run it. > > More a question is whether the Homepage in debian/control still points > to the best place. The current URL points to an outdated location. I think http://qbnz.com/highlighter/ is still the best homepage, even though it's outdated. The other option would be the GitHub project page but that doesn't contain the documentation and examples which would be more useful to end users. I asked on their GH Issues if the homepage could be updated. -- Thanks, Nick
Bug#964308: RFS: geshi/1.0.9.1-1 [ITA] -- Generic Syntax Highlighter
Control: tags -1 moreinfo On Sun, Jul 05, 2020 at 07:15:01PM +0800, Nick Gasson wrote: >... > Changes since the last upload: Looks good, except: >... > - Update debhelper compatibility level to 13. -Build-Depends: cdbs, debhelper (>= 9) +Build-Depends: debhelper (>= 9), debhelper-compat (= 13) On the nitpick side is that debhelper-compat (= 13) is sufficient. Slightly more serious that you should document the switch from cdbs in the changelog. >... > + * debian/tests/test.php: add a simple sanity test. >... Is anything running this test? This looks like an autopkgtest without the control file. More a question is whether the Homepage in debian/control still points to the best place. The current URL points to an outdated location. > Regards, cu Adrian
Bug#964308: RFS: geshi/1.0.9.1-1 [ITA] -- Generic Syntax Highlighter
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "geshi" * Package name: geshi Version : 1.0.9.1-1 Upstream Author : Benny Baumann * URL : http://qbnz.com/highlighter/ * License : GPL-2+ * Vcs : None Section : php It builds those binary packages: php-geshi - Generic Syntax Highlighter To access further information about this package, please visit the following URL: https://mentors.debian.net/package/geshi Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/g/geshi/geshi_1.0.9.1-1.dsc Changes since the last upload: * New maintainer. (Closes: #895843). * New upstream release. * debian/control: - Update debhelper compatibility level to 13. - Bump standards version to 4.5.0. * debian/watch: - Change URL to point at GitHub releases page. - Check upstream PGP signature. * debian/docs: - Remove obsolete documentation files. * debian/patches: - Use a patch to fix #685324 instead of removing the offending file in debian/rules. - Remove remote loaded image in geshi-doc.html to avoid potential privacy breach. * debian/doc-base: register with doc-base. * debian/tests/test.php: add a simple sanity test. * debian/copyright: convert to machine-readable format. Regards, -- Nick Gasson
