Bug#969241: RFS: hydrapaper/1.12 [ITP]] -- sets desktop wallpaper on different monitors
Hello Tobias, On Mon, 2020-09-14 at 19:38 +0200, Tobias Frost wrote: > > It still has stray version 2 in the version 3 text… Look at line 17 and 29. > > New stuff I found: > d/rules: > - the dh_auto_clean override is not needed. This can be done by listing the > files to be deleted in d/clean. > - Calling dh_clean in an override for dh_*auto*_clean is not correct, you need > to match those. > --> go for d/clean and delete the override. > > Copyright review: ✔ > > Please fix the remaining issues and then ping me. Done. I've already uploaded the new version to m.d.o and updated Salsa as well. Thank you for the review! -- []'s, Francisco M Neto www.fmneto.com 3E58 1655 9A3D 5D78 9F90 CFF1 D30B 1694 D692 FBF0 signature.asc Description: This is a digitally signed message part
Bug#969241: RFS: hydrapaper/1.12 [ITP]] -- sets desktop wallpaper on different monitors
Control: tags -1 moreinfo Control: owner -1 ! Hi Francisco, On Tue, Sep 08, 2020 at 06:42:23PM -0300, Francisco M Neto wrote: (Note: I'm removing stuff from the that have been resolved, to keep it short) - new upstream version 2.0 - dep3 header of patch - extra B-D on cmake - d/watch updated - d/copytright partially fixed. - nitpicks about lintian overrides fixed. - orig tarballs shasum now matching with the on on mentors. > On Tue, 2020-09-08 at 22:01 +0200, Tobias Frost wrote: > > Control: tags -1 moreinfo > > > > Hi Francisco, > > > > d/copyright: > > - 1st files section says License: GPL3+, but License text says "Version 2" > > at > > two locations. It still has stray version 2 in the version 3 text… Look at line 17 and 29. New stuff I found: d/rules: - the dh_auto_clean override is not needed. This can be done by listing the files to be deleted in d/clean. - Calling dh_clean in an override for dh_*auto*_clean is not correct, you need to match those. --> go for d/clean and delete the override. Copyright review: ✔ Please fix the remaining issues and then ping me. -- tobi signature.asc Description: PGP signature
Re: Bug#969241: RFS: hydrapaper/1.12 [ITP]] -- sets desktop wallpaper on different monitors
Greetings! On Tue, 2020-09-08 at 22:01 +0200, Tobias Frost wrote: > Please fix those issues and then remove the moreinfo tag! > I've done all that; packaged version 2.0, fixed issues with packaging and removed the tag. Thanks. -- []'s, Francisco M Neto www.fmneto.com 3E58 1655 9A3D 5D78 9F90 CFF1 D30B 1694 D692 FBF0 signature.asc Description: This is a digitally signed message part
Bug#969241: RFS: hydrapaper/1.12 [ITP]] -- sets desktop wallpaper on different monitors
Greetings! Thanks for all the comments. That's quite a lot of needed fixes; I guess that's why mentors exists :) On Tue, 2020-09-08 at 22:01 +0200, Tobias Frost wrote: > Control: tags -1 moreinfo > > Hi Francisco, > > On Sat, 29 Aug 2020 17:16:50 -0300 Francisco M Neto wrote: > > Package: hydrapaper > > Version: 1.12-1 > > Upstream has released 2.0 in the meantime. Can you update it please? Will do. > I: hydrapaper source: quilt-patch-missing-description 010_fix-quotation-marks- > in-fstring.patch > - the patch does not have dep3 headers. Have you sent the patch upstream? I did. And I remember creating that header; I probably made some mistake when committing. > d/copyright: > - 1st files section says License: GPL3+, but License text says "Version 2" at > two locations. > - Usually it is best to have the same license for the debian/* part as > upstream. If you make the debian/* GPL3+, d/copyright can become even > shorter. > (Yes, GPL2+ includes GPL3+, but the version 2 is moot in combination) Interesting; I hadn't thought about that! > d/control: > Build Depends on cmake and meson. Does it need both? > The list on Build-Depends on the README.md is shorter than in d/control. > Please re-check your B-Ds if they are really needed. Something in the source tree made me believe I'd need both; I'll recheck that. > d/watch has some extra lines. > d/watch could be more elegant, see https://wiki.debian.org/debian/watch#Gitlab > i.e. > version=4 > https://gitlab.com/gabmus/HydraPaper/tags?sort=updated_desc > archive/@ANY_VERSION@/HydraPaper-\d\S*@ARCHIVE_EXT@ Nothing to say here; this is more elegant, I suppose I got a little paranoid with the regexps. > (Noting here that your orig source tarball is tar.xz, but upstream has no > tar.xz… How did you create the orig.xz tarball? Please stick to the upstream > provided one…) That orig tarball was generated automagically, probably when I imported the upstream source... I'm not sure why it was generated like that. I didn't see a tag when I ran lintian so I didn't notice it. > Nitpicks: > There is no need to override maintainer-manual-page. Overrides should not be > used to silence lintian, but only if lintian is wrong. > However, if you override you should provide more information in the override, > like the MR where the manpage can be found. > But ASFAIS the next release will have the manpage, so no need for action. That tag kept triggering my OCD; but I get your point - overrides should be meaningful. Thank you very much for all the comments! -- []'s, Francisco M Neto www.fmneto.com 3E58 1655 9A3D 5D78 9F90 CFF1 D30B 1694 D692 FBF0 signature.asc Description: This is a digitally signed message part
Bug#969241: RFS: hydrapaper/1.12 [ITP]] -- sets desktop wallpaper on different monitors
Control: tags -1 moreinfo Hi Francisco, On Sat, 29 Aug 2020 17:16:50 -0300 Francisco M Neto wrote: > Package: hydrapaper > Version: 1.12-1 Upstream has released 2.0 in the meantime. Can you update it please? I: hydrapaper source: quilt-patch-missing-description 010_fix-quotation-marks- in-fstring.patch - the patch does not have dep3 headers. Have you sent the patch upstream? d/copyright: - 1st files section says License: GPL3+, but License text says "Version 2" at two locations. - Usually it is best to have the same license for the debian/* part as upstream. If you make the debian/* GPL3+, d/copyright can become even shorter. (Yes, GPL2+ includes GPL3+, but the version 2 is moot in combination) d/control: Build Depends on cmake and meson. Does it need both? The list on Build-Depends on the README.md is shorter than in d/control. Please re-check your B-Ds if they are really needed. d/watch has some extra lines. d/watch could be more elegant, see https://wiki.debian.org/debian/watch#Gitlab i.e. version=4 https://gitlab.com/gabmus/HydraPaper/tags?sort=updated_desc archive/@ANY_VERSION@/HydraPaper-\d\S*@ARCHIVE_EXT@ (Noting here that your orig source tarball is tar.xz, but upstream has no tar.xz… How did you create the orig.xz tarball? Please stick to the upstream provided one…) Nitpicks: There is no need to override maintainer-manual-page. Overrides should not be used to silence lintian, but only if lintian is wrong. However, if you override you should provide more information in the override, like the MR where the manpage can be found. But ASFAIS the next release will have the manpage, so no need for action. d/control: There is a double-space in the long description before MATE Please fix those issues and then remove the moreinfo tag! -- tobi PS: There are two other packages with your name attached are marked "Need sponsor: No" on mentors.d.n. I could not find a RFS either. Is this intentional? signature.asc Description: This is a digitally signed message part
Bug#969241: RFS: hydrapaper/1.12 [ITP] -- sets desktop wallpaper on different monitors
Package: hydrapaper Version: 1.12-1 Severity: normal Dear mentors, I am looking for a sponsor for my package "hydrapaper": * Package name: hydrapaper Version : 1.12-1 Upstream Author : Gabriele Musco * URL : https://gitlab.com/gabmus/HydraPaper * License : GPL-3+ * Vcs : https://salsa.debian.org/fmneto-guest/hydrapaper Section : graphics It builds those binary packages: hydrapaper - Utility that sets background independently for each monitor To access further information about this package, please visit the following URL: https://mentors.debian.net/package/hydrapaper/ Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/h/hydrapaper/hydrapaper_1.12-1.dsc Changes since the last upload: hydrapaper (1.12-1) unstable; urgency=medium * Initial release (Closes: #969189) -- Francisco M Neto Sat, 29 Aug 2020 12:51:53 + Regards, -- Francisco M Neto -- System Information: Debian Release: bullseye/sid APT prefers testing APT policy: (800, 'testing'), (550, 'stable'), (500, 'stable- updates'), (500, 'oldstable'), (400, 'unstable'), (390, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 5.7.0-7.1-liquorix-amd64 (SMP w/12 CPU threads; PREEMPT) Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.utf8), LANGUAGE=en_US.utf8 Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages hydrapaper depends on: ii dconf-gsettings-backend [gsettings-backend] 0.36.0-1 ii gir1.2-handy-1 0.90.0-1 ii libhandy-1-0 0.90.0-1 ii python3 3.8.2-3 ii python3-gi 3.36.0-4 hydrapaper recommends no packages. hydrapaper suggests no packages. -- no debconf information -- []'s, Francisco M Neto GPG: 4096R/D692FBF0 --- Begin Message --- Package: hydrapaper Version: 1.12-1 Severity: normal Dear mentors, I am looking for a sponsor for my package "hydrapaper": * Package name: hydrapaper Version : 1.12-1 Upstream Author : Gabriele Musco * URL : https://gitlab.com/gabmus/HydraPaper * License : GPL-3+ * Vcs : https://salsa.debian.org/fmneto-guest/hydrapaper Section : graphics It builds those binary packages: hydrapaper - Utility that sets background independently for each monitor To access further information about this package, please visit the following URL: https://mentors.debian.net/package/hydrapaper/ Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/h/hydrapaper/hydrapaper_1.12-1.dsc Changes since the last upload: hydrapaper (1.12-1) unstable; urgency=medium * Initial release (Closes: #969189) -- Francisco M Neto Sat, 29 Aug 2020 12:51:53 + Regards, -- Francisco M Neto -- System Information: Debian Release: bullseye/sid APT prefers testing APT policy: (800, 'testing'), (550, 'stable'), (500, 'stable-updates'), (500, 'oldstable'), (400, 'unstable'), (390, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 5.7.0-7.1-liquorix-amd64 (SMP w/12 CPU threads; PREEMPT) Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.utf8), LANGUAGE=en_US.utf8 Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages hydrapaper depends on: ii dconf-gsettings-backend [gsettings-backend] 0.36.0-1 ii gir1.2-handy-1 0.90.0-1 ii libhandy-1-0 0.90.0-1 ii python3 3.8.2-3 ii python3-gi 3.36.0-4 hydrapaper recommends no packages. hydrapaper suggests no packages. -- no debconf information --- End Message --- signature.asc Description: This is a digitally signed message part
