Re: Overriding linda source package warnings

2006-10-10 Thread Bas Wijnen
On Mon, Oct 09, 2006 at 12:44:17PM -0500, Luis Rodrigo Gallardo Cruz wrote:
 [1] I need to override because the error could only be *fixed* by
 repackaging the .orig.tar.gz, which I don't want to do for so little a
 thing, when the problem can be adequately worked around.

While I fully agree that the workaround (plus asking upstream to fix it) is
the correct thing to do, I don't think you should use an override.  It's nice
to have warning-free packages, but that should be because they are in order,
not because you know what's wrong and don't want to hear it.  So IMO that
warning should just be there until upstream fixes the source package.

Overrides are for false positives: the check fails even though there's nothing
wrong.  (Often they also mean a bug report to lintian/linda is in order.)  In
this case there is something wrong, only the maintainer can't fix it.  But
that's no reason to suppress the warning.

Then again, looking at the warning there's something wrong with the check as
well.  That is, assuming you did remove the files in the clean target, the
hint about that suggests that they don't check what they want.  So even
without an override you may want to report a bug. :-)

Thanks,
Bas

-- 
I encourage people to send encrypted e-mail (see http://www.gnupg.org).
If you have problems reading my e-mail, use a better reader.
Please send the central message of e-mails as plain text
   in the message body, not as HTML and definitely not as MS Word.
Please do not use the MS Word format for attachments either.
For more information, see http://pcbcn10.phys.rug.nl/e-mail.html


signature.asc
Description: Digital signature


Re: Overriding linda source package warnings

2006-10-10 Thread Damyan Ivanov
Bas Wijnen -- 10.10.2006 12:09 --:
 Then again, looking at the warning there's something wrong with the check as
 well.  That is, assuming you did remove the files in the clean target, the
 hint about that suggests that they don't check what they want.  So even
 without an override you may want to report a bug. :-)

(IIUC)
The check is done on the source package - .orig.tar.gz+diff. The
problem is in the .orig.tar.gz, so clean target has no chance to
correct it.

My vote also is to leave the warning there to remind maintainer to ask
upstream for a fix.


dam
-- 
Damyan Ivanov   Modular Software Systems
[EMAIL PROTECTED]
phone +359(2)928-2611, 929-3993  fax +359(2)920-0994
mobile +359(88)856-6067 [EMAIL PROTECTED]/Gaim



signature.asc
Description: OpenPGP digital signature


Re: Overriding linda source package warnings

2006-10-10 Thread Bas Wijnen
On Tue, Oct 10, 2006 at 03:36:41PM +0300, Damyan Ivanov wrote:
 Bas Wijnen -- 10.10.2006 12:09 --:
  Then again, looking at the warning there's something wrong with the check as
  well.  That is, assuming you did remove the files in the clean target, the
  hint about that suggests that they don't check what they want.  So even
  without an override you may want to report a bug. :-)
 
 (IIUC)
 The check is done on the source package - .orig.tar.gz+diff. The
 problem is in the .orig.tar.gz, so clean target has no chance to
 correct it.

Yes, that's what I was trying to say.  The warning talks about removing the
files in the clean target.  That suggests that doing so would make the warning
go away.  Because it is about the source package, this is not the case, so the
wording of the warning is wrong.

Sorry for not making myself clear.

Thanks,
Bas

-- 
I encourage people to send encrypted e-mail (see http://www.gnupg.org).
If you have problems reading my e-mail, use a better reader.
Please send the central message of e-mails as plain text
   in the message body, not as HTML and definitely not as MS Word.
Please do not use the MS Word format for attachments either.
For more information, see http://pcbcn10.phys.rug.nl/e-mail.html


signature.asc
Description: Digital signature


Re: Overriding linda source package warnings

2006-10-10 Thread Luis Rodrigo Gallardo Cruz
On Tue, Oct 10, 2006 at 03:05:21PM +0200, Bas Wijnen wrote:
 On Tue, Oct 10, 2006 at 03:36:41PM +0300, Damyan Ivanov wrote:
  The check is done on the source package - .orig.tar.gz+diff. The
  problem is in the .orig.tar.gz, so clean target has no chance to
  correct it.
 
 Yes, that's what I was trying to say.  The warning talks about removing the
 files in the clean target.  That suggests that doing so would make the warning
 go away.  Because it is about the source package, this is not the case, so the
 wording of the warning is wrong.

Ok. I'll file a bug agains linda asking to fix it's wording. lintian's
wording is clear enough IMHO, I'll suggest they copy that one.

-- 
Rodrigo Gallardo
GPG-Fingerprint: 7C81 E60C 442E 8FBC D975  2F49 0199 8318 ADC9 BC28


signature.asc
Description: Digital signature


Overriding linda source package warnings

2006-10-09 Thread Luis Rodrigo Gallardo Cruz
I'm getting the following linda error:

linda -i ../result/keytouch_2.2.2-1_i386.changes
E: keytouch; Package contains autoconf-generated files.
 The package contains the file shown above, which is generated by
 autoconf. This may confuse the buildd's, and should be removed by the
 clean target of the package.

I know what causes it, and have corrected it, and have put an override
for lintian[1]. But I haven't found a way to override this for
linda. Files in /usr/share/linda/overrides seem to apply only to the
binary package they're contained in, and this error is produced by the
source package.

Any hints?

[1] I need to override because the error could only be *fixed* by
repackaging the .orig.tar.gz, which I don't want to do for so little a
thing, when the problem can be adequately worked around.

-- 
Rodrigo Gallardo
GPG-Fingerprint: 7C81 E60C 442E 8FBC D975  2F49 0199 8318 ADC9 BC28


signature.asc
Description: Digital signature