Re: RFR: devilspie2
On Tue, Oct 11, 2011 at 11:15:24PM +0200, Andreas Rönnquist wrote: (in this case - RFR = Request For Review - I am not sure if its a used/correct abbreviation) Correct. Could someone please check out my devilspie2 package? Yes. It is a continuation of the original Devilspie by Ross Burton, but with the major difference that the symbolic expressions of the original and their iterpreter are replaced by much simpler and easier maintainable LUA code. It is written in C, with a simple makefile as build system (My first try at a package using a Makefile, I have used cmake in the past) - and also using CDBS. This kind of comment *really* helps understanding what your package is about. I would like to see this in every RFR/RFS. I could (amongst other stuff) take some hints regarding the short/long descriptions. Both of your descriptions focus on explaining how devilspie2 does things. A user first looking at your package wants to know what your package does. Your short description explains that devilspie2 can match windows, but the use - acting on them - is only implied. Maybe your long description could give a specific use case? The information about LUA and the origin of this package are clearly useful, but I would put them to the end of the description. http://mentors.debian.net/debian/pool/main/d/devilspie2/devilspie2_0.08-1.dsc debian/docs: I think you shouldn't ship the GPL-3, because you already correctly reference /usr/share/common-licenses/GPL-3 from debian/copyright. debian/rules: Maybe you can also clean up the dh_make comments? Helmut -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20111014062654.gb15...@alf.mars
Re: RFR: devilspie2
On 14/10/11 08:26, Helmut Grohne wrote: I could (amongst other stuff) take some hints regarding the short/long descriptions. Both of your descriptions focus on explaining how devilspie2 does things. A user first looking at your package wants to know what your package does. Your short description explains that devilspie2 can match windows, but the use - acting on them - is only implied. Maybe your long description could give a specific use case? The information about LUA and the origin of this package are clearly useful, but I would put them to the end of the description. Thank you! I have updated the long description according to your comments. debian/docs: I think you shouldn't ship the GPL-3, because you already correctly reference /usr/share/common-licenses/GPL-3 from debian/copyright. fixed. debian/rules: Maybe you can also clean up the dh_make comments? done. Thank you for your review, much appreciated - I have updated the package fixing the details you have commented on. New version uploaded to mentors: http://mentors.debian.net/package/devilspie2 http://mentors.debian.net/debian/pool/main/d/devilspie2/devilspie2_0.09-1.dsc best regards /Andreas -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e986bac.3020...@gusnan.se
RFR: devilspie2
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi! (in this case - RFR = Request For Review - I am not sure if its a used/correct abbreviation) Could someone please check out my devilspie2 package? It is a continuation of the original Devilspie by Ross Burton, but with the major difference that the symbolic expressions of the original and their iterpreter are replaced by much simpler and easier maintainable LUA code. It is written in C, with a simple makefile as build system (My first try at a package using a Makefile, I have used cmake in the past) - and also using CDBS. I could (amongst other stuff) take some hints regarding the short/long descriptions. The package can be found here: http://mentors.debian.net/package/devilspie2 http://mentors.debian.net/debian/pool/main/d/devilspie2/devilspie2_0.08-1.dsc and upstream is here: http://www.gusnan.se/devilspie2/ thanks in advance, and best regards /Andreas Rönnquist gus...@gusnan.se -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJOlLHpAAoJEBlLYxqy2iiIbnwP/jXQSxtYqeDXSvtxz8GipE25 M/gsPJd5bpe3pYTpTYkwP99eRg8vhkRzirMdKa+vL10IfA2hxOydSMYqJg2UxxKs Cm78H/iWcjU+eBUZ060q1m/Dyq7GVUKG73ZWhIwVAjwVXYoaQBuYhqkthj5WRmf+ glwy2kP8VzA8bbJ2qX8SFgzXF7oT/jdPxcTEiMNyBwL7du783zgkcshSNsOBG4zC 1FDaj1M3Tjnus87CvxpszZqRM5qCW0RQTkih41GnZ8qz3462aAZuReqjG5OLfb+b RTRwzF57ezzEMFmBS7HDAgI3epliAlr7JZQDIkZghTIomiCDZKzk4181YHVjev5l Clxm4lag77VsZFBXm8Mlu1o9TCaGrJokEcMA0qCV2DwbZttve9HIwb3lHy+edcjn 7C+Y9jnjZocRh13y7GeMNA4adG36ddWMOUikAC0tgeVAtDCO4HhW6Asa+KhWZehW 7JF68Qm1u4rDI/R0X9n+CYOsT9r0U4KcwL2wPdaPTORv/dvgtlKZDbRJDP6fnqoJ W/c3yvlSCFQ2edd9RnNU8b4+uXGa7Gam3nNWYdEFzWcvQ4343EuUbFrCzsxDARWw VB8lPmvrbFazjybKDSBvewO/1K2XWHjn+NpedcLb0dUOketaaPg8uYz/D0xHEH/3 wOhSaHFOoDft7uApkisn =FLx1 -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e94b1ec.6090...@gusnan.se
