Re: RFS: Sponsor needed for pmwiki
On Thursday, August 11, 2011 08:15:24 PM, Robert Strobl wrote: Hi, I implemented your feedback. The updated version now concerns PmWiki's current upstream stable release 2.2.29. Please find the package files at: http://share.gloriabyte.de/pmwiki/ Best regards, Robert Greetings, Robert. I'd like to touch base with you concerning your Pmwiki package, and I have a couple of suggestions. I've been running PmWiki for at least 5 years or so and have been wishing for a Pmwiki package in Debian, so I'm glad to see another effort towards getting it into Debian, so your work towards this is appreciated. Right now it appears as though you're changing the group ownership of most of the pmwiki related files to being owned and writable by www-data. I have a suggestion whereby neither of these is necessary; PmWiki includes the ability to be set up as a WikiFarm[1] whereby the same installation can be used for setting up any number of wikis. Using this method, the web server does not need to be able to write to any of the pmwiki files at all, since the wiki location where web pages will be stored will differ from the pmwiki installation, so they could be owned by root:root and would only need to be readable by the www-data user. This would involve adding one file, local/farmconfig.php, which would act as the default config.php that wikis would use, until overridden by another local/config.php file in the actual wiki page storage location. [You could theoretically have debconf prompt the user for setting a default password to use in the farmconfig.php file if you wanted to, but I'm not sure it's required.] [1] http://www.pmwiki.org/wiki/PmWiki/WikiFarms One thing I note in my setup is that I have not set the $FarmPubDirUrl variable at all, which seems to be suggested in the page above under the Create the home wiki section, so I don't think that's necessary. I believe this is done to allow using the original PmWiki location as a wiki, and all the other wikis as a wikifarm, but what I've done is simply to set up every wiki as a wikifarm and leave the original PmWiki location unwritable by the web server. :-) That works fine. Adding a new wiki as a WikiFarm would need to be explained in a README, or could possibly be scripted, but might need to be run as root if you want to have the local wiki.d directory group owned and writable by www-data. I'm willing to help document that and help write the script and man page, along with example setup files, if you wish. Just let me know what I can help you with. Thanks. -- Chris -- Chris Knadle chris.kna...@coredump.us signature.asc Description: This is a digitally signed message part.
Re: RFS: Sponsor needed for pmwiki
Hello, thank you for all your feedback :) I'm currently about to move. Therefore I think that it may take some time till I will be able to bring in your ideas and publish the next release. You will hear from me soon again ;) Best regards, Robert Am 09.09.2011 um 01:59 schrieb Chris Knadle: On Thursday, August 11, 2011 08:15:24 PM, Robert Strobl wrote: Hi, I implemented your feedback. The updated version now concerns PmWiki's current upstream stable release 2.2.29. Please find the package files at: http://share.gloriabyte.de/pmwiki/ Best regards, Robert Greetings, Robert. I'd like to touch base with you concerning your Pmwiki package, and I have a couple of suggestions. I've been running PmWiki for at least 5 years or so and have been wishing for a Pmwiki package in Debian, so I'm glad to see another effort towards getting it into Debian, so your work towards this is appreciated. Right now it appears as though you're changing the group ownership of most of the pmwiki related files to being owned and writable by www-data. I have a suggestion whereby neither of these is necessary; PmWiki includes the ability to be set up as a WikiFarm[1] whereby the same installation can be used for setting up any number of wikis. Using this method, the web server does not need to be able to write to any of the pmwiki files at all, since the wiki location where web pages will be stored will differ from the pmwiki installation, so they could be owned by root:root and would only need to be readable by the www-data user. This would involve adding one file, local/farmconfig.php, which would act as the default config.php that wikis would use, until overridden by another local/config.php file in the actual wiki page storage location. [You could theoretically have debconf prompt the user for setting a default password to use in the farmconfig.php file if you wanted to, but I'm not sure it's required.] [1] http://www.pmwiki.org/wiki/PmWiki/WikiFarms One thing I note in my setup is that I have not set the $FarmPubDirUrl variable at all, which seems to be suggested in the page above under the Create the home wiki section, so I don't think that's necessary. I believe this is done to allow using the original PmWiki location as a wiki, and all the other wikis as a wikifarm, but what I've done is simply to set up every wiki as a wikifarm and leave the original PmWiki location unwritable by the web server. :-) That works fine. Adding a new wiki as a WikiFarm would need to be explained in a README, or could possibly be scripted, but might need to be run as root if you want to have the local wiki.d directory group owned and writable by www-data. I'm willing to help document that and help write the script and man page, along with example setup files, if you wish. Just let me know what I can help you with. Thanks. -- Chris -- Chris Knadle chris.kna...@coredump.us -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/5b2d3558-69ef-4d87-814b-b7f0c0eec...@student.hpi.uni-potsdam.de
Re: RFS: Sponsor needed for pmwiki
Hi, I implemented your feedback. The updated version now concerns PmWiki's current upstream stable release 2.2.29. Please find the package files at: http://share.gloriabyte.de/pmwiki/ Best regards, Robert -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/b48832ca-b2d8-467b-86d2-67baaccff...@student.hpi.uni-potsdam.de
Re: RFS: Sponsor needed for pmwiki
On 07/13/2011 08:49 PM, Robert Strobl wrote:
Hi,
I just finished updating the package. Sorry for the delay!
I hope that I could realize all your feedback as you wished :)
Please find the updated version at: http://share.gloriabyte.de/pmwiki/
Best regards,
Robert
Thanks for this.
Here are my remarks.
* In your debian/patches folder, there's Makefile.patch and
debian-changes-2.2.27-1, please merge these 2 together in a unique patch.
* In debian/control, I can see:
Vcs-Svn: svn://pmwiki.org/pmwiki/tags/latest
This seems to be the upstream SVN repository. This field isn't for this,
it is for you to point at your Debian packaging repository (best would
be to host it on alioth.debian.org, opening an account there is free).
* In debian/copyright, please use the DEP5 format. This isn't a strong
requirement by Debian, but it is for me to sponsor the package. Please
see: http://dep.debian.net/deps/dep5/
* In your debian/postinst script, you are making the assumption that
there's already apache installed, and a group www-data that is created.
That might well not be the case, considering your dependencies. So, I
would suggest to either:
- check, using getent, if the www-data user/group already exist, and
eventually create that system user (if you use adduser to create the
user, don't forget to also depend on adduser)
- document this issue in a debian/README.Debian and don't do anything at
all in your postinst (the administrator can decide)
- chown the /var/lib/pmwiki folder so that it becomes world readable
* In your debian/postrm, you are deleting /etc/pmwiki/, please don't do
that in the remove case, only in the purge one.
* Also, please setup a link like this: ln -s /usr/share/pmwiki/locale
/etc/pmwiki, so that configuration is made inside /etc/pmwiki and not in
/usr/share anymore.
* Please don't package docs/INSTALL.txt in the binary package of pmwiki,
because it doesn't fit Debian anymore. Best would be to write your own
DEBIAN.Readme to tell the administrator what to do to bring pmwiki up
and running on a Debian system and package that one instead.
* By the way, you have the following debhelper issue (shown by lintian):
W: pmwiki source: debhelper-but-no-misc-depends pmwiki
Please add ${misc:Depends} as dependency of pmwiki
* Please package a cookbook folder, so that it is possible to add
extensions in the future. Just an idea: it'd be great to have a pmwiki
plugin management system.
* On your debian/clontrol long description, you have:
You can find more information on PmWiki on http://www.pmwiki.org.
This is redundant with the Homepage field, please remove it. It would by
the way be very cool if you could find a longer short Description:
field. My proposal:
customizable and light PHP-based wiki system using file based storage
Do you think this description fits pmWiki?
Let me know what you think of the above,
Cheers,
Thomas Goirand
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4e241075.3010...@goirand.fr
Re: RFS: Sponsor needed for pmwiki
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, without having looked into the reviewed package, just one further note: On 18.07.2011 12:52, Thomas Goirand wrote: * In your debian/postinst script, you are making the assumption that there's already apache installed, and a group www-data that is created. That might well not be the case, considering your dependencies. So, I would suggest to either: - check, using getent, if the www-data user/group already exist, and eventually create that system user (if you use adduser to create the user, don't forget to also depend on adduser) Leaving your remarks on Apache untouched, I am pointing out, this is not true for www-data. www-data is among the globally project-wide assigned user ids that are known to exist on every Debian system. Please refer to policy 9.2.2 [1] which points this out for user ids from 0 to 99, www-data is 33. In Debian, this user is created by base-passwd [2] [1] http://www.debian.org/doc/debian-policy/ch-opersys.html#s9.2.2 [2] http://packages.debian.org/source/sid/base-passwd - -- with kind regards, Arno Töll IRC: daemonkeeper on Freenode/OFTC GnuPG Key-ID: 0x9D80F36D -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJOJBceAAoJEMcrUe6dgPNtEkMP/2bAda5jPN/afLyUedKQ0o/3 US+3O1vze8Yz+SNoloJ+Oyglm5kAbyOZhF5YfT0F/TO50dl3r05tj4Z5FbmVAwg6 0q1O2XMpSpSpk+SkxMqFmNVXgWzgyx6vYJ+d+p0VZb92z22QcwBakx/CefsIwmv3 i4OjMSFiZppEmm2fgld/9TNKW2mDJw5Inb64k7KPOY5utZPP6LVyLHRJrjzruje/ 4Qwewdvj6iVywhPTuLWsWVeRjVyMM78u7z4zF0qjrRGkWvC5HYxbr9gL3PTZ39rk oIt/F1gFf6TnPif9eqotmPqO6Acg4yVCFxnISVDSlPpI17tXhOqdazZUp4agYSW6 ReBK2vBoIs+Uw1mFaqCX+odTB23+aqImTu5JQ/bboz2RuM9SmHWUZmOQXn9aab3y KrlkmLHdCqUl1HUvHrhEqCWZ4bZ36TnFDXAXsQa4VSNQ2v5hHXcd9y14aS/QySRx AlrT0BiRTgSr9jZO+6ULNBFWTqDi6RigTDvCu7UJE0izVS1dDoh8+lWDGhLOuxuH OjP45WQvkjfOUTBSU3U778H5ea8HkRu+ngGwRzqci9Yb1+DJtK9t0D59NnTsJ9KO A9Y2ldI/yIKiClfzYRoHkFZ0nRdtxtiXA4KISpDUYDgA1CXKwQgsNg0q8+AZ+J55 SKEySX8BH+Q0px+UxtI5 =CJ+M -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e24171f.8030...@toell.net
Re: RFS: Sponsor needed for pmwiki
Hi Robert,
On Mon, Jul 18, 2011 at 01:35:15PM +0200, Robert Strobl wrote:
Hello Thomas,
thank you for your feedback.
Some remarks to the following points:
* In your debian/postinst script, you are making the assumption that
there's already apache installed, and a group www-data that is
created.
That might well not be the case, considering your dependencies.
www-data is a user in the default passwd file and is used by any web
server
in Debian. So it does not restrict the use of apache.
* Please don't package docs/INSTALL.txt in the binary package of
pmwiki,
because it doesn't fit Debian anymore. Best would be to write your own
DEBIAN.Readme to tell the administrator what to do to bring pmwiki up
and running on a Debian system and package that one instead.
docs/INSTALL.txt is not packaged. It is ignored in the install routine
of the Makefile. Is it probably a more common way to write a patch
that deletes it?
If make install would install docs/INSTALL.txt that may be true it'd need
fixing. Otherwise, just don't list that file in $package.docs or don't put the
entire docs folder into $package.install. No need to invent a patch for
that. A simple rm in debian/rules will do if you can't tame upstream's
logic from installing it - which I doubt is the case.
The file debian/README.Debian will be installed automatically if exists and
should contain information on why the binary package is the way it is and
how to use it. If you want to convey special information on the source put
that into debian/README.source.
* Also, please setup a link like this: ln -s /usr/share/pmwiki/locale
/etc/pmwiki, so that configuration is made inside /etc/pmwiki and
not in
/usr/share anymore.
I guess you mean ln -s /etc/pmwiki /usr/share/pmwiki/local. That is
already done in the debian/postinst script.
No, please read the above argument again. Your true config files should
reside in /etc as /usr may be read-only and shared among machines according
to FHS convention.
* By the way, you have the following debhelper issue (shown by
lintian):
W: pmwiki source: debhelper-but-no-misc-depends pmwiki
Please add ${misc:Depends} as dependency of pmwiki
Strange, my lintian shows me that the package is clean. Will check
that :)
Maybe not using unstable lintian or maybe not -I --pedantic? ;-)
--
Best regards,
Kilian
signature.asc
Description: Digital signature
Re: RFS: Sponsor needed for pmwiki
Hi, I just finished updating the package. Sorry for the delay! I hope that I could realize all your feedback as you wished :) Please find the updated version at: http://share.gloriabyte.de/pmwiki/ Best regards, Robert Am 05.07.2011 um 14:24 schrieb Thomas Goirand: On 07/04/2011 09:17 AM, Strobl, Robert wrote: I need a sponsor for: Package name: pmwiki Version:2.2.27 Upstream Author:Patrick R. Michaud License:GPL Description: PmWiki is a wiki-based system for collaborative creation and maintenance of websites. The relevant files can be found at http://share.gloriabyte.de/pmwiki/ This would close: #330117, #471816, #508725 Best regards, Robert Hi, I 100% love pmwiki. I use and abuse it. I'll review your package and sponsor it for sure. Now, I just had a look to the remarks by Arno Toll, and I agree with (most of) them. Please clean the package and let us know when it is ready. Here's few remarks on the remarks of Arno: + Instead of your dependency line apache2 | lighttpd you probably want to depend on the httpd-cgi virtual package [2] instead, and give a preference if you wish. I'd rather say: don't depend AT ALL on a web server. This is very annoying in some situations, and it's not your job to decide, but the one of the administrator. I have a situation here where I am using php5-cgi with no web server at all (because it's in a chroot), and having a dependency on a web server is *very* annoying. + Finally php-fastcgi seems wrong to me unless you actually depend on Lighttpd or any other (Fast-)CGI compatible web server. For Apache you maybe want to depend on libapache2-mod-php5 instead, since this is what most people are using for PHP when using Apache. Again, it's not your job to select a flavor for PHP. You just should depend on the largest possible choice, so maybe something like: libapache2-mod-php5 | php5-cgi would do. * You debian/copyright contains the full URL, i.e. the direct link to the origin package. Its not wrong to do so, but keep in mind you have to update this for every upload. Generally its fine enough to point to the upstream homepage there. There is also DEP-5 [6] which is perhaps the way to go for future packages. This not required though. While dep5 isn't required by Debian, it is required by *me* when I sponsor a package. So please use that format. * Your package contains GIF files. There are some discussions whether they fall into the preferred form for modification rule as they are binary data [14]. However I believe for your use case its fine to package them. Maybe someone else may comment on this. If there are some ways to generate the GIF files from some other source code, then yes, it should be done this way. Otherwise, GIF files can be considered upstream source as well. Since the GIF patent expired, GIF aren't less good than PNG or others, and it's ok to use them. * Your package is not lintian clean (this shouldn't suprise you): Yes. Please use lintian and check that you clean absolutely ALL of the issues that lintian is pointing at. Remember to use the -Ii flags when calling it, so it shows really all. Thomas Goirand (zigo)
Re: RFS: Sponsor needed for pmwiki
Yes, thank you all :) I'm currently working in your feedback and hope that I can give an update this week-end. Best regards, Robert Am 07.07.2011 um 11:10 schrieb Thomas Goirand: On 07/04/2011 09:17 AM, Strobl, Robert wrote: I need a sponsor for: Package name:pmwiki Version: 2.2.27 Upstream Author: Patrick R. Michaud License: GPL Description: PmWiki is a wiki-based system for collaborative creation and maintenance of websites. The relevant files can be found at http://share.gloriabyte.de/pmwiki/ This would close: #330117, #471816, #508725 Best regards, Robert Hi, Did you read our reply to your request in debian-mentors@? Thomas -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/81e87ff9-a729-4813-93b8-ac530d7c0...@student.hpi.uni-potsdam.de
Re: RFS: Sponsor needed for pmwiki
On 07/04/2011 09:17 AM, Strobl, Robert wrote: I need a sponsor for: Package name: pmwiki Version: 2.2.27 Upstream Author: Patrick R. Michaud License: GPL Description: PmWiki is a wiki-based system for collaborative creation and maintenance of websites. The relevant files can be found at http://share.gloriabyte.de/pmwiki/ This would close: #330117, #471816, #508725 Best regards, Robert Hi, I 100% love pmwiki. I use and abuse it. I'll review your package and sponsor it for sure. Now, I just had a look to the remarks by Arno Toll, and I agree with (most of) them. Please clean the package and let us know when it is ready. Here's few remarks on the remarks of Arno: + Instead of your dependency line apache2 | lighttpd you probably want to depend on the httpd-cgi virtual package [2] instead, and give a preference if you wish. I'd rather say: don't depend AT ALL on a web server. This is very annoying in some situations, and it's not your job to decide, but the one of the administrator. I have a situation here where I am using php5-cgi with no web server at all (because it's in a chroot), and having a dependency on a web server is *very* annoying. + Finally php-fastcgi seems wrong to me unless you actually depend on Lighttpd or any other (Fast-)CGI compatible web server. For Apache you maybe want to depend on libapache2-mod-php5 instead, since this is what most people are using for PHP when using Apache. Again, it's not your job to select a flavor for PHP. You just should depend on the largest possible choice, so maybe something like: libapache2-mod-php5 | php5-cgi would do. * You debian/copyright contains the full URL, i.e. the direct link to the origin package. Its not wrong to do so, but keep in mind you have to update this for every upload. Generally its fine enough to point to the upstream homepage there. There is also DEP-5 [6] which is perhaps the way to go for future packages. This not required though. While dep5 isn't required by Debian, it is required by *me* when I sponsor a package. So please use that format. * Your package contains GIF files. There are some discussions whether they fall into the preferred form for modification rule as they are binary data [14]. However I believe for your use case its fine to package them. Maybe someone else may comment on this. If there are some ways to generate the GIF files from some other source code, then yes, it should be done this way. Otherwise, GIF files can be considered upstream source as well. Since the GIF patent expired, GIF aren't less good than PNG or others, and it's ok to use them. * Your package is not lintian clean (this shouldn't suprise you): Yes. Please use lintian and check that you clean absolutely ALL of the issues that lintian is pointing at. Remember to use the -Ii flags when calling it, so it shows really all. Thomas Goirand (zigo) -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e13028b.6050...@debian.org
Re: RFS: Sponsor needed for pmwiki
On 07/04/2011 09:17 AM, Strobl, Robert wrote: I need a sponsor for: Package name: pmwiki Version: 2.2.27 Upstream Author: Patrick R. Michaud License: GPL Description: PmWiki is a wiki-based system for collaborative creation and maintenance of websites. The relevant files can be found at http://share.gloriabyte.de/pmwiki/ This would close: #330117, #471816, #508725 Best regards, Robert I'd add as well that there are some other issues not highlighted by Arno, maybe because he doesn't use PmWiki himself. For example, the wiki.d folder that you ship with your package is stored in /usr/share. That's wrong, because your /usr may well be mounted read only. Instead, you should put it in somewhere like /var/lib/pmwiki and symlink to it. The local folder is for customization, and will hold config files. So it should go in /etc/pmwiki. The /usr/share/pmwiki/docs should go in /usr/share/doc/pmwiki. I also believe that you should ship an index.php as per the pmwiki online doc. Cheers, Thomas -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e134c5f.6050...@goirand.fr
Re: RFS: Sponsor needed for pmwiki
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Thomas, On 05.07.2011 19:39, Thomas Goirand wrote: I'd add as well that there are some other issues not highlighted by Arno, maybe because he doesn't use PmWiki himself. Indeed I don't. Moreover I didn't verify installation paths at all, as I discovered enough issues in the packaging itself, hence I thought, before looking into the actual files and verify whether the package works, I'd like to have the packaging stuff addressed. Therefore I appreciate you did by now, as this simplifies life to Robert as I clearly admit. Thank you. - -- with kind regards, Arno Töll IRC: daemonkeeper on Freenode/OFTC GnuPG Key-ID: 0x9D80F36D -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJOE1sQAAoJEMcrUe6dgPNtf1gQAJzyqUUaqxdCHag8MMZiEjfg wR/QSOShGdFYT04fYGP4et07CFXYLuUch5sgfrJvKA7g8VmLtKwhRulbeB+Gv8Uk 2wxCoY8KW4SWUXTSCi14G4H1GId+aJyXW4WLu2qc4OE5v+CSrKeExVfDNOdXx5Dg QSJdXIXJ4zLagQ8oz6D5C+RZhxySjnmzZhA14heRA9nt1WaeEG8UTjbFDqzJd46K kwHkl9/b/VBd5wb4r7JSJMLqVTQT5ltExzOu8KdFGUZLS0N/gnU6/YqMVbY2G2JC 86wW9uuIOm1yG4g1jEQzraM2iUqv/8XYnR3HMsMMzuac6rpPlR1bxWfhgcR7ilQo KMHxkJ7wlf5/2DUcEedJlUx8Vs1aZYGkL8x0CofbdBSruGCXzu+gJFKrlTobmgTC 7G5xzuGRvzdDX4TdQGoxNgwSsYK/41wICUO2aHUQB+erAue8JTUVoeJC75PuLjFR i3Y9XPQm734hunkVe6ueoUiS1pESOaz6JGlZwscNugwFWseU+VDnlIZ1u9QBozzg k5MGmhTjb92dl8prPEPaqTVeOQ5vsQbBarDYdZr2SPGn1ogde7H7/H/Od0YmwYxD dVv3TRLSJFZgT/L1NpS1GGghQT52uuWreKUYj9sJ+YBG7RNfzn1ZC2iuLm3X3Jtn pxINTOmriP6VZYLX8ip8 =VVXl -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e135b10.2020...@toell.net
Re: RFS: Sponsor needed for pmwiki
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Robert, On 04.07.2011 03:17, Strobl, Robert wrote: I need a sponsor for: Package name: pmwiki License:GPL ^^^- its GPL-2 btw. Version: 2.2.27 here are a few notes, from me not being a developer and therefore unable to sponsor you: * The currently recommended debhelper version is 8 (see debhelper(7)). Please push in debian/compat and debian/control * Your Standards version is heavily outdated. See [1] for a list what to check, in order to verify whether your package complies with the most recent standards version which is 3.9.2. * Some notes about your dependencies: + I wonder why you depend on PHP 4. PHP 4 is not available in Debian anymore. + Moreover you depend on lighttpd (= 2.4.19) which does not exist at all. Maybe you meant 1.4.19 which would correspond to the Lighttpd version which was in Lenny. + Instead of your dependency line apache2 | lighttpd you probably want to depend on the httpd-cgi virtual package [2] instead, and give a preference if you wish. + Finally php-fastcgi seems wrong to me unless you actually depend on Lighttpd or any other (Fast-)CGI compatible web server. For Apache you maybe want to depend on libapache2-mod-php5 instead, since this is what most people are using for PHP when using Apache. * Your synopsis line is not a synopsis, see [3] for best practices. Moreover you need to provide a long description line See §3.4.2 [4] * Please add VCS links if possible [5]. If not, remove the commented out entries in debian/control. * You debian/copyright contains the full URL, i.e. the direct link to the origin package. Its not wrong to do so, but keep in mind you have to update this for every upload. Generally its fine enough to point to the upstream homepage there. There is also DEP-5 [6] which is perhaps the way to go for future packages. This not required though. * debian/docs is empty. If you don't install any docs that way, remove the file * Similarly, remove pmwiki.doc-base.EX unless you really want to ship a doc-base package (if so, you would still have to rename it of course) * Your postinst script is terribly dangerous. No you don't want chmod 777. Really. Moreover this script can be called in many different ways and you break most of them. Finally you miss the #DEBHELPER# hook. Please read [7][8][9] about maintainer script invocation. * Please remove unnecessary comments in debian/rules * Please make a compliant patch from patches/debian-changes-2.2.27-1. Its contents are not wrong, but its considered a bad style to make upstream changes like this. Please make a proper quilt patch [10][11][12] * You don't provide a watch file. Learn more about watch files on [13] * Your package contains GIF files. There are some discussions whether they fall into the preferred form for modification rule as they are binary data [14]. However I believe for your use case its fine to package them. Maybe someone else may comment on this. * Your package is not lintian clean (this shouldn't suprise you): W: pmwiki source: debhelper-but-no-misc-depends pmwiki W: pmwiki source: dh-make-template-in-source debian/pmwiki.doc-base.EX W: pmwiki source: maintainer-script-lacks-debhelper-token debian/postinst W: pmwiki source: format-3.0-but-debian-changes-patch W: pmwiki source: out-of-date-standards-version 3.8.4 (current is 3.9.2) I: pmwiki source: debian-watch-file-is-missing P: pmwiki: no-upstream-changelog E: pmwiki: description-starts-with-package-name I: pmwiki: description-synopsis-might-not-be-phrased-properly W: pmwiki: description-too-long E: pmwiki: extended-description-is-empty W: pmwiki: extra-license-file usr/share/pmwiki/docs/COPYING.txt I: pmwiki: package-contains-empty-directory usr/share/pmwiki/pub/css/ I: pmwiki: package-contains-empty-directory usr/share/pmwiki/wiki.d/ W: pmwiki: executable-not-elf-or-script usr/share/pmwiki/pmwiki.php W: pmwiki: maintainer-script-ignores-errors postinst [1] http://www.debian.org/doc/packaging-manuals/upgrading-checklist.txt [2] http://www.debian.org/doc/packaging-manuals/virtual-package-names-list.txt [3] http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-synopsis [4] http://www.debian.org/doc/debian-policy/ch-binary.html#s-extendeddesc [5] http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-vcs [6] http://dep.debian.net/deps/dep5/ [7] http://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-mscriptsinstact [8] http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-debian-maint-scripts [9] http://wiki.debian.org/MaintainerScripts [10] http://wiki.debian.org/UsingQuilt [11] http://dep.debian.net/deps/dep3/ [12] http://www.debian.org/doc/manuals/maint-guide/modify.en.html [13] http://www.debian.org/doc/debian-policy/ch-source.html#s-debianwatch and uscan(1) [14]
RFS: Sponsor needed for pmwiki
I need a sponsor for: Package name: pmwiki Version:2.2.27 Upstream Author:Patrick R. Michaud License:GPL Description:PmWiki is a wiki-based system for collaborative creation and maintenance of websites. The relevant files can be found at http://share.gloriabyte.de/pmwiki/ This would close: #330117, #471816, #508725 Best regards, Robert -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/36fb658b-a720-402e-9f4c-24629e36a...@student.hpi.uni-potsdam.de
