Bug#1014131: RFS: ario/1.6.1-1 -- GTK+ client for the Music Player Daemon (MPD)
Control: tags -1 moreinfo Please untag moreinfo when you are done and have uploaded a new version.
Bug#1014131: RFS: ario/1.6.1-1 -- GTK+ client for the Music Player Daemon (MPD)
Please always answer to the bug address as well. Typo in d/changelog: updstream. Please comment on the d/watch change and the debhelper update as well. I have already given the hint that install-sh's license is called X11. You are missing the rest of the conditions: # The above copyright notice and this permission notice shall be included in # all copies or substantial portions of the Software. # # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR # IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, # FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE # X CONSORTIUM BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN # AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNEC- # TION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. # # Except as contained in this notice, the name of the X Consortium shall not # be used in advertising or otherwise to promote the sale, use or other deal- # ings in this Software without prior written authorization from the X Consor- # tium. Am 01.07.22 um 18:22 schrieb Marc Pavot: Hi Bastian I have uploaded a new version of ario package, could you check it? It fixes the different points you have mentioned. I am not 100% sure that the copyright file is now following all good practices as it is the first time I create one so don't hesitate to highlight any mistake. Have a nice day Marc Le ven. 1 juil. 2022 à 17:15, Bastian Germann mailto:b...@debian.org>> a écrit : On Fri, 1 Jul 2022 12:05:20 +0200 Marc Pavot mailto:marc.pa...@gmail.com>> wrote: > I have uploaded a new version with a copyright file following the > recommended format. I hope it's good now. d/changelog: What happened to the changelog entries since 1.4-1? Please also include the 1.6-1.1 entry. d/copyright: Missing Copyright statements: Copyright (C) 2009 Samuel CUELLA mailto:samuel.cue...@supinfo.com>> Copyright (c) 2007-2010 Rosetta Contributors and Canonical Ltd Copyright (C) 2002-2005 - Paolo Maggi Copyright (C) 1994 X Consortium Missing license: Please also include install-sh's X11 license.
Bug#1014131: RFS: ario/1.6.1-1 -- GTK+ client for the Music Player Daemon (MPD)
On Fri, 1 Jul 2022 12:05:20 +0200 Marc Pavot wrote: I have uploaded a new version with a copyright file following the recommended format. I hope it's good now. d/changelog: What happened to the changelog entries since 1.4-1? Please also include the 1.6-1.1 entry. d/copyright: Missing Copyright statements: Copyright (C) 2009 Samuel CUELLA Copyright (c) 2007-2010 Rosetta Contributors and Canonical Ltd Copyright (C) 2002-2005 - Paolo Maggi Copyright (C) 1994 X Consortium Missing license: Please also include install-sh's X11 license.
Bug#1014131: RFS: ario/1.6.1-1 -- GTK+ client for the Music Player Daemon (MPD)
Thank you Bastian! I have uploaded a new version with a copyright file following the recommended format. I hope it's good now. Marc
Bug#1014131: RFS: ario/1.6.1-1 -- GTK+ client for the Music Player Daemon (MPD)
Hi Marc, I can imagine sponsoring this if you convert d/copyright to https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Cheers, Bastian
Bug#1014131: RFS: ario/1.6.1-1 -- GTK+ client for the Music Player Daemon (MPD)
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "ario": * Package name: ario Version : 1.6.1-1 Upstream Author : Marc Pavot * URL : https://github.com/mpavot/ario * License : GPL * Vcs : ? Section : sound The source builds the following binary packages: ario - GTK+ client for the Music Player Daemon (MPD) ario-common - GTK+ client for the Music Player Daemon (MPD) (Common files) To access further information about this package, please visit the following URL: https://mentors.debian.net/package/ario/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/a/ario/ario_1.6.1-1.dsc Changes since the last upload: ario (1.6.1-1) unstable; urgency=medium . * New updstream release * Remove dependency on dbus-glib (Closes: #955872) * Make build reproducible (Closes: 828876) Regards, -- Marc Pavot
Re: RFS: ario
Hi, Well it should be tag in source package and not in description, I moved it this way and uploaded package. Thanks for your upload but I received this mail from Joerg Jaspert: Hi Maintainer, rejected, two things. First, an easy to fix Lintian E: E: ario: description-synopsis-is-duplicated And second - you missed the BSD-like license for the libmpdclient* I uploaded ario_0.2-4 which should fix this 2 problems. Marc
Re: RFS: ario
Michal Čihař wrote: I just noticed one more thing - as we now have Homepage field support in dpkg, please use it instead of URL pseudo tag (some tools will complain about Homepage for now, but you can ignore it). Is this field really available at the time of writing? (I'm just aware of #433469 which is not closed as I am writing this). And: If it is, then is it (properly) supported by packages.debian.org? Gruß Patrick -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: ario
Hi On Tue, 18 Sep 2007 10:30:32 +0200 Patrick Schoenfeld [EMAIL PROTECTED] wrote: Is this field really available at the time of writing? (I'm just aware of #433469 which is not closed as I am writing this). It has been added as of dpkg 1.14.6 (at least according to its changelog). And: If it is, then is it (properly) supported by packages.debian.org? I have no idea, but I don't see reason not to use it. I hope that other tools will catch up sooner or later. -- Michal Čihař | http://cihar.com | http://blog.cihar.com signature.asc Description: PGP signature
Re: RFS: ario
On Thu, 13 Sep 2007 19:19:55 +0200 Marc Pavot [EMAIL PROTECTED] wrote: Hi, As mentioned by other reply, simple rm in clean target should do it. Ok that's what I had done for ario_0.2-2. I just noticed one more thing - as we now have Homepage field support in dpkg, please use it instead of URL pseudo tag (some tools will complain about Homepage for now, but you can ignore it). done. I have uploaded ario_0.2-3 whith this modification. Well it should be tag in source package and not in description, I moved it this way and uploaded package. -- Michal Čihař | http://cihar.com | http://blog.cihar.com signature.asc Description: PGP signature
Re: RFS: ario
Hi, As mentioned by other reply, simple rm in clean target should do it. Ok that's what I had done for ario_0.2-2. I just noticed one more thing - as we now have Homepage field support in dpkg, please use it instead of URL pseudo tag (some tools will complain about Homepage for now, but you can ignore it). done. I have uploaded ario_0.2-3 whith this modification. Marc
Re: RFS: ario
Hi, Please merge changelog entries, it looks a bit strange to have -0 as initial upload, as initial version in archive should be -1. done. W: ario source: configure-generated-file-in-source config.log W: ario: binary-without-manpage usr/bin/ario I: ario: desktop-entry-contains-encoding-key ./usr/share/applications/ario.desktop:2 Encoding W: ario: desktop-entry-invalid-category Application ./usr/share/applications/ario.desktop W: ario: menu-item-uses-apps-section /usr/share/menu/ario:5 I have fixed all this warnings (but I'm not really sure of solution for the first one). I have uploaded ario_0.2-2, can you please check it again? Thanks for your help. Marc
Re: RFS: ario
On 9/13/07, Marc Pavot [EMAIL PROTECTED] wrote: W: ario source: configure-generated-file-in-source config.log I have fixed all this warnings (but I'm not really sure of solution for the first one). A simple 'rm config.log' in the clean rule of debian/rules should do it. -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: ario
Hi On Wed, 12 Sep 2007 19:32:08 +0200 Marc Pavot [EMAIL PROTECTED] wrote: W: ario source: configure-generated-file-in-source config.log W: ario: binary-without-manpage usr/bin/ario I: ario: desktop-entry-contains-encoding-key ./usr/share/applications/ario.desktop:2 Encoding W: ario: desktop-entry-invalid-category Application ./usr/share/applications/ario.desktop W: ario: menu-item-uses-apps-section /usr/share/menu/ario:5 I have fixed all this warnings (but I'm not really sure of solution for the first one). As mentioned by other reply, simple rm in clean target should do it. I have uploaded ario_0.2-2, can you please check it again? I just noticed one more thing - as we now have Homepage field support in dpkg, please use it instead of URL pseudo tag (some tools will complain about Homepage for now, but you can ignore it). PS: No need to CC me on reply. -- Michal Čihař | http://cihar.com | http://blog.cihar.com signature.asc Description: PGP signature
Re: RFS: ario
Hi Please fix following issues: =20 - you should close ITP in changelog done. - any good reason for being Architecture: i386 and not all? It's a mistake, I changed the Architecture to 'any'. - fix copyright file - add more license information and link to full license (see [1] for example) done. - remove comments from template at the end and really check file licenses. at least src/libmpdclient.[ch] are under different license done. - I think that debian/dirs is useless removed. - there is no point of including empty README and NEWS as documentation removed. - consider using system libmpd instead of bundled src/libmpdclient.[ch] libmp is different from libmpdclient. libmpd is a higler level library based on libmpdclient but Ario doesn't use libmpd. - after installing I do not see application icon in menu (I didn't investigate this) fixed. Anw why is tarball different from the one on upstream web site? d15024564458d171771cb4c9d99a9466 ario_0.2.orig.tar.gz 6696f96db91fd02f2dc021b0384cdbf8 ario-0.2.tar.gz fixed. I have uploaded a new package (ario_0.2-1). Can you please check it? Thanks a lot for your remarks. Marc
Re: RFS: ario
Hi On Tue, 11 Sep 2007 22:22:03 +0200 Marc Pavot [EMAIL PROTECTED] wrote: - consider using system libmpd instead of bundled src/libmpdclient.[ch] libmp is different from libmpdclient. libmpd is a higler level library based on libmpdclient but Ario doesn't use libmpd. It provides libmpdclient.h and there are no problems to make code use it. I did such switch in mpdscribble, but it's your choice whether to use it. I have uploaded a new package (ario_0.2-1). Can you please check it? Please merge changelog entries, it looks a bit strange to have -0 as initial upload, as initial version in archive should be -1. Now lintian complains about some problems (run with -i to get more verbose details about each problem): $ lintian -I ../ario_0.2-1_i386.changes W: ario source: configure-generated-file-in-source config.log W: ario: binary-without-manpage usr/bin/ario I: ario: desktop-entry-contains-encoding-key ./usr/share/applications/ario.desktop:2 Encoding W: ario: desktop-entry-invalid-category Application ./usr/share/applications/ario.desktop W: ario: menu-item-uses-apps-section /usr/share/menu/ario:5 The first issue comes from fact, that I built package several times. Clean target does not seem to remove everything and config.log is then added to to diff, because it is new file. For menu changes (last issue) see http://lists.debian.org/debian-devel-announce/2007/07/msg0.html -- Michal Čihař | http://cihar.com | http://blog.cihar.com signature.asc Description: PGP signature
Re: RFS: ario
Michal Čihař wrote: Hi On Tue, 11 Sep 2007 22:22:03 +0200 Marc Pavot [EMAIL PROTECTED] wrote: - consider using system libmpd instead of bundled src/libmpdclient.[ch] libmp is different from libmpdclient. libmpd is a higler level library based on libmpdclient but Ario doesn't use libmpd. It provides libmpdclient.h and there are no problems to make code use it. I did such switch in mpdscribble, but it's your choice whether to use it. I can't seem to find it right now, but somewhere it is written that binary packages should not link with package provided libraries, but use the system one. This is done because then it is easier to correct bugs related to the original library (no need to search for packages that link with hidden copies). -- Felipe Sateler -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
RFS: ario
Dear mentors, I am looking for a sponsor for my package ario. * Package name: ario Version : 0.2-0 Upstream Author : Marc Pavot [EMAIL PROTECTED] * URL : http://ario-player.sourceforge.net/ * License : GPL Section : sound It builds these binary packages: ario - A complete GTK2 client for MPD Ario is a complete GTK2 client for MPD (Music Player Daemon). The interface used to browse the library is inspired by Rhythmbox but Ario aims to be much lighter and faster. The package appears to be lintian clean. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/a/ario - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/a/ario/ario_0.2-0.dsc I would be glad if someone uploaded this package for me. Kind regards Marc Pavot
Re: RFS: ario
Hi On Sun, 9 Sep 2007 23:35:40 +0200 Marc Pavot [EMAIL PROTECTED] wrote: I am looking for a sponsor for my package ario. [...] I would be glad if someone uploaded this package for me. Please fix following issues: - you should close ITP in changelog - any good reason for being Architecture: i386 and not all? - fix copyright file - add more license information and link to full license (see [1] for example) - remove comments from template at the end and really check file licenses. at least src/libmpdclient.[ch] are under different license - I think that debian/dirs is useless - there is no point of including empty README and NEWS as documentation - consider using system libmpd instead of bundled src/libmpdclient.[ch] - after installing I do not see application icon in menu (I didn't investigate this) [1]:http://viewsvn.cihar.com/viewvc.cgi/debian-gmobilemedia/trunk/debian/copyright?view=markup -- Michal Čihař | http://cihar.com | http://blog.cihar.com signature.asc Description: PGP signature
Re: RFS: ario
Hi On Mon, 10 Sep 2007 10:27:08 +0900 Michal Čihař [EMAIL PROTECTED] wrote: On Sun, 9 Sep 2007 23:35:40 +0200 Marc Pavot [EMAIL PROTECTED] wrote: I am looking for a sponsor for my package ario. [...] I would be glad if someone uploaded this package for me. Please fix following issues: - you should close ITP in changelog - any good reason for being Architecture: i386 and not all? - fix copyright file - add more license information and link to full license (see [1] for example) - remove comments from template at the end and really check file licenses. at least src/libmpdclient.[ch] are under different license - I think that debian/dirs is useless - there is no point of including empty README and NEWS as documentation - consider using system libmpd instead of bundled src/libmpdclient.[ch] - after installing I do not see application icon in menu (I didn't investigate this) Anw why is tarball different from the one on upstream web site? d15024564458d171771cb4c9d99a9466 ario_0.2.orig.tar.gz 6696f96db91fd02f2dc021b0384cdbf8 ario-0.2.tar.gz After you fix these issues, I can upload package for you. -- Michal Čihař | http://cihar.com | http://blog.cihar.com signature.asc Description: PGP signature
Re: RFS: ario
On Mon, Sep 10, 2007 at 10:27:08AM +0900, Michal Čihař wrote: Hi On Sun, 9 Sep 2007 23:35:40 +0200 Marc Pavot [EMAIL PROTECTED] wrote: I am looking for a sponsor for my package ario. [...] I would be glad if someone uploaded this package for me. Please fix following issues: - there is no point of including empty README and NEWS as documentation But actually debhelper makes an exception and doesn't include empty docs in the binary package. I forget who/when/where this was pointed out to me, but the maintainer wanted their source package to DWTW even if upstream filled in the originally-empty docs files. Also you specify -pario to all the debhelper calls, but they all act by default on the first binary package anyway. Justin
Re: RFS: ario
Hi On Sun, 9 Sep 2007 23:10:58 -0400 Justin Pryzby [EMAIL PROTECTED] wrote: On Mon, Sep 10, 2007 at 10:27:08AM +0900, Michal Čihař wrote: Hi On Sun, 9 Sep 2007 23:35:40 +0200 Marc Pavot [EMAIL PROTECTED] wrote: I am looking for a sponsor for my package ario. [...] I would be glad if someone uploaded this package for me. Please fix following issues: - there is no point of including empty README and NEWS as documentation But actually debhelper makes an exception and doesn't include empty docs in the binary package. I forget who/when/where this was pointed out to me, but the maintainer wanted their source package to DWTW even if upstream filled in the originally-empty docs files. I know they won't end up in resulting package, but I still do not see reason for listing them as documentation. Also you specify -pario to all the debhelper calls, but they all act by default on the first binary package anyway. I also noticed this, but it seems to come from cdbs... -- Michal Čihař | http://cihar.com | http://blog.cihar.com signature.asc Description: PGP signature
