RFS: deejayd (updated package)
Dear mentors, I am looking for a sponsor for the new version 0.10.0-2 of my package deejayd. deejayd is a Network controllable media player daemon that supports multiple panes media library browsing, video playback, among other features. It is a python package. The package appears to be lintian clean. The upload would fix these bugs: 587326 which renders package unusable, and 575118. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/d/deejayd - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/d/deejayd/deejayd_0.10.0-2.dsc I would be glad if someone uploaded this package for me. Kind regards Alex -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/aanlktimuhhvm7fksiea4ji5n45yafo4tgdoyfulgu...@mail.gmail.com
RFS: deejayd (updated package)
Dear mentors, I am looking for a sponsor for the new version 0.10.0-1 of my package deejayd. It builds these binary packages: deejayd- Network controllable media player daemon deejayd-client - Client library and command line tool to access the deejayd server deejayd-gstreamer - Deejayd GStreamer backend deejayd-webui - Web interface for deejayd deejayd-webui-extension - Deejayd web user interface Iceweasel extension deejayd-xine - Deejayd XINE backend The package appears to be lintian clean. The upload would fix these bugs: 575118 The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/d/deejayd - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/d/deejayd/deejayd_0.10.0-1.dsc I would be glad if someone uploaded this package for me and to address any issues you would find with the package. Kind regards Alexandre Rossi -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/w2q9b01ce9b1004061027q3fc0eca9k1115d6c2d7453...@mail.gmail.com
Re: RFS: deejayd (updated package)
Hi, Thanks a lot for the comments. I'll upload an updated version once I have implemented something to ensure the X server is ready in debian/deejayd.deejayd-xserver.init do_start() (and something better than sleep 2). Thanks for all the clarifications. I just finally uploaded a new version 0.8.3-2 that fixes all this plus the wait for X to be ready thing I wanted to address. As a reminder, major items of the changelog : - New upstream version, - fixes the build with python 2.6 (change of install locations), - handles pyinotify = 0.8 API changes, - closes #535374 (bashism in debian/rules), - eases the connection with Xorg (this is a daemon running with its own privileges, so connection to Xorg is tricky). Comments and/or upload very welcomed. Thanks, Alex -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: deejayd (updated package)
Alexandre Rossi wrote: And the script doesn't correctly handle the case where the default file has been removed (it expects the vars to be always defined). The Xsession script doesn't handle an unset DEEJAYD_DISPLAYNAME and DEEJAYD_XAUTHORITY vars either. [ -r ] is evaluated to true. [ -r ] behaves correctly both with bash and sh on my lenny box. Not sure I understand what to do here. What I meant was that: $ foo=/foo/bar; [ -r $foo ] echo hello world $ unset foo; [ -r $foo ] echo hello world hello world $ unset foo; [ -r $foo ] echo hello world nothing Thanks a lot for the comments. I'll upload an updated version once I have implemented something to ensure the X server is ready in debian/deejayd.deejayd-xserver.init do_start() (and something better than sleep 2). Okay Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: deejayd (updated package)
In h49gnk$6n...@ger.gmane.org, Raphael Geissert wrote: Alexandre Rossi wrote: And the script doesn't correctly handle the case where the default file has been removed (it expects the vars to be always defined). The Xsession script doesn't handle an unset DEEJAYD_DISPLAYNAME and DEEJAYD_XAUTHORITY vars either. [ -r ] is evaluated to true. [ -r ] behaves correctly both with bash and sh on my lenny box. Not sure I understand what to do here. What I meant was that: $ foo=/foo/bar; [ -r $foo ] echo hello world Looks normal, assuming /foor/bar doesn't exist on your system. $ unset foo; [ -r $foo ] echo hello world hello world $ unset foo; [ -r $foo ] echo hello world nothing Both these are required behavior by SUSv2. In the first, you are passing 2 arguments to the '[' command, after removing the trailing ']' only one argument remains. In that case the '[' (or test) command is required to return 0 (succeed) if the argument is non-empty and return non-0 (fail) if the argument is empty. -- Boyd Stephen Smith Jr. ,= ,-_-. =. b...@iguanasuicide.net ((_/)o o(\_)) ICQ: 514984 YM/AIM: DaTwinkDaddy `-'(. .)`-' http://iguanasuicide.net/\_/ signature.asc Description: This is a digitally signed message part.
Re: RFS: deejayd (updated package)
On 2009-07-23 20:56 +0200, Boyd Stephen Smith Jr. wrote: In h49gnk$6n...@ger.gmane.org, Raphael Geissert wrote: Alexandre Rossi wrote: And the script doesn't correctly handle the case where the default file has been removed (it expects the vars to be always defined). The Xsession script doesn't handle an unset DEEJAYD_DISPLAYNAME and DEEJAYD_XAUTHORITY vars either. [ -r ] is evaluated to true. [ -r ] behaves correctly both with bash and sh on my lenny box. Not sure I understand what to do here. What I meant was that: $ foo=/foo/bar; [ -r $foo ] echo hello world Looks normal, assuming /foor/bar doesn't exist on your system. $ unset foo; [ -r $foo ] echo hello world hello world $ unset foo; [ -r $foo ] echo hello world nothing Both these are required behavior by SUSv2. In the first, you are passing 2 arguments to the '[' command, after removing the trailing ']' only one argument remains. In that case the '[' (or test) command is required to return 0 (succeed) if the argument is non-empty and return non-0 (fail) if the argument is empty. Raphael surely knows this; what he wanted to say is that the behavior of [ -r $foo ] if foo is unset is probably not intended and therefore [ -r $foo ] should be used. Sven pgpbZsY6fg2ud.pgp Description: PGP signature
Re: RFS: deejayd (updated package)
Hi, Whenever that happens you should report them. I just did it: #536405 Thanks and noted. To sum up the changelog, this new version : - is a new upstream version that fixes a lot, - fixes the build with python 2.6 (change of install locations), Which fixes an ubuntu bug but you are not closing it. The syntax is LP: # Bug references added. debian/50...: tmpauthfile=`mktemp -p /tmp deejayd-reuse.XX` why do you specify a directory instead of letting mktemp find one on its own? debian/deejayd?deejayd-xserver.init if [ -z `hostname --version 21 | grep GNU` ]; then if ! hostname --version 21 | grep -q GNU; then xserverauthfile=`mktemp -p /tmp serverauth.XX` same as above Cut and paste from /usr/bin/startx, fixed. And the script doesn't correctly handle the case where the default file has been removed (it expects the vars to be always defined). The Xsession script doesn't handle an unset DEEJAYD_DISPLAYNAME and DEEJAYD_XAUTHORITY vars either. [ -r ] is evaluated to true. [ -r ] behaves correctly both with bash and sh on my lenny box. Not sure I understand what to do here. Anyway, I added default values for required variables. And: $ checkbashisms -x debian/50deejayd_steal-session script debian/50deejayd_steal-session does not appear to have a #! interpreter line; you may get strange results possible bashism in debian/50deejayd_steal-session line 7 (should be 'b = a'): if [ $DEEJAYD_XSERVER_METHOD == reuse ]; then Fixed. Thanks a lot for the comments. I'll upload an updated version once I have implemented something to ensure the X server is ready in debian/deejayd.deejayd-xserver.init do_start() (and something better than sleep 2). Alex -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: deejayd (updated package)
[Sending you a copy in case you are not subscribed] Hi, Alexandre Rossi wrote: Dear mentors, I am looking for a sponsor for the new version 0.8.3-1 of my package deejayd. [...] The package appears to be lintian clean. The informational messages can be ignored because both debhelper and python are needed to run the clean target. $ lintian -IE --pedantic deejayd_0.8.2-1.dsc I: deejayd source: build-depends-without-arch-dep debhelper I: deejayd source: build-depends-without-arch-dep python Whenever that happens you should report them. I just did it: #536405 To sum up the changelog, this new version : - is a new upstream version that fixes a lot, - fixes the build with python 2.6 (change of install locations), Which fixes an ubuntu bug but you are not closing it. The syntax is LP: # - handles pyinotify = 0.8 API changes, - closes #535374 (bashism in debian/rules) which is not in the changelog because it has been fixed a while ago, - eases the connection with Xorg (this is a daemon running with its own privileges, so connection to Xorg is tricky). debian/50...: tmpauthfile=`mktemp -p /tmp deejayd-reuse.XX` why do you specify a directory instead of letting mktemp find one on its own? debian/deejayd?deejayd-xserver.init if [ -z `hostname --version 21 | grep GNU` ]; then if ! hostname --version 21 | grep -q GNU; then xserverauthfile=`mktemp -p /tmp serverauth.XX` same as above And the script doesn't correctly handle the case where the default file has been removed (it expects the vars to be always defined). The Xsession script doesn't handle an unset DEEJAYD_DISPLAYNAME and DEEJAYD_XAUTHORITY vars either. [ -r ] is evaluated to true. And: $ checkbashisms -x debian/50deejayd_steal-session script debian/50deejayd_steal-session does not appear to have a #! interpreter line; you may get strange results possible bashism in debian/50deejayd_steal-session line 7 (should be 'b = a'): if [ $DEEJAYD_XSERVER_METHOD == reuse ]; then I've added a new rule to force the check of files in /etc/Xsession.d to the script I use on my archive-wide runs. There are probably other issues, but that's my review for now. Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
RFS: deejayd (updated package)
Dear mentors, I am looking for a sponsor for the new version 0.8.3-1 of my package deejayd. It builds these binary packages: deejayd- Network controllable media player daemon deejayd-client - Client library and command line tool to access the deejayd server deejayd-gstreamer - Deejayd GStreamer backend deejayd-webui - Web interface for deejayd deejayd-webui-extension - Deejayd web user interface Iceweasel extension deejayd-xine - Deejayd XINE backend The package appears to be lintian clean. The informational messages can be ignored because both debhelper and python are needed to run the clean target. $ lintian -IE --pedantic deejayd_0.8.2-1.dsc I: deejayd source: build-depends-without-arch-dep debhelper I: deejayd source: build-depends-without-arch-dep python To sum up the changelog, this new version : - is a new upstream version that fixes a lot, - fixes the build with python 2.6 (change of install locations), - handles pyinotify = 0.8 API changes, - closes #535374 (bashism in debian/rules) which is not in the changelog because it has been fixed a while ago, - eases the connection with Xorg (this is a daemon running with its own privileges, so connection to Xorg is tricky). The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/d/deejayd - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/d/deejayd/deejayd_0.8.3-1.dsc I would be glad if someone uploaded this package for me. Cheers, Alex -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
