Re: RFS: evolution-tray

2011-08-06 Thread Kilian Krause
Hi Max,

On Fri, Jul 15, 2011 at 09:56:37AM +0600, Max Tsepkov wrote:
 Thanks to people from debian-devel the package is now ready and lintian
 clean.
 Therefore, I'm reposting the RFS.
 * Package name: evolution-tray
 http://mentors.debian.net/debian/pool/main/e/evolution-tray/evolution-tray_0.0.7-1.dsc
 
 I would be glad if someone uploaded this package for me.

Thanks for your work. Reviewing your package I find:

1.) You're using dh 7 style for debian/rules but scripting the binary target
yourself. Why? You don't seem to put any options and even if so, you
could still add the override_.. targets.

2.) You include autotools-dev in Build-Depends, but don't add the call to dh
in debian/rules.

3.) You put depends for your binary package even though using
shlibs:Depends. Why aren't they properly detected by the automatic of
dh_shlibdeps?

4.) src/tray.c still has the old FSF-address. Upstream should correct this.

5.) You build-depends on debhelper (= 8.0.0) which will block backporting.
Depending on = 8 or = 8.0 would be preferred.

6.) The template header in debian/rules can be removed

7.) debian/watch is missing.

8.) lintian moans about:
E: evolution-tray: non-empty-dependency_libs-in-la-file
usr/lib/evolution/2.32/plugins/liborg-gnome-evolution-tray.la

I don't see why the *.la file is needed at all. Can you explain?

Apart from that good to go even though I'm wondering if it'd not be easier
to try and find a way to make this code be included upstream in evolution
itself.

-- 
Best regards,
Kilian


signature.asc
Description: Digital signature


Re: RFS: evolution-tray

2011-07-14 Thread Arno Töll
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 14.07.2011 13:55, Max Tsepkov wrote:
 I am looking for a sponsor for my package evolution-tray.

For reference, there is also an ongoing discussion on debian-devel
regarding the package. See the corresponding thread on [1].

[1] http://lists.debian.org/debian-devel/2011/07/msg00198.html

- -- 
with kind regards,
Arno Töll
IRC: daemonkeeper on Freenode/OFTC
GnuPG Key-ID: 0x9D80F36D
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOHuZEAAoJEMcrUe6dgPNtpLMP/2SWnFhe+ZB+O/1Uocn9FjOY
gOqLXChydMws8Fl7le4uLavQW9LFOqWq6M41zhXNBQX/d+kI/OlECypACBSmdjyL
lrdfJtyWuM/Rawyf+wpxHTmKZBSA2ebBajqG6EJAioTZG+YplBX8k+GtJdilqlXa
lkVF97W/KEM8HRbnOevUaedKkyij0bSmA6wRNAHUVpTaArYKm8TeJRMF+pw/s5FU
ssnu0jyZoAStVIp8+mdWMF6ImEUEpZcc+Tn8zEfRkSrPMj6//uHzefz5OhuSoMIY
y8iIoIiiBWrJny1tIZDUp4qY35osBqHz4pZEjH8khQmB1beZG2oKpcqHAjoDYc/1
cFNFFMcVlle1Nam207PWgspaukuN+f1gdRxVdRgBVYfKaaYwOIoSg+BkP4uCkqSu
fIEJxD5d0Y/S7fdLbi18KbJ90Fs8FWynr0zx2x+8jGH1FIvGQyP/BqK3IhJ8Kdbi
Z9HFOiJNReXd10/po68yEHZSMMhpQzCFRsupVDUvnS7/WDEcGSxVogxR9mA6LQSF
uIpmQgKXgrFhZhxh+f45ma7uXkT7nCmD4bPkVX31xmUanU5JnQkonAV3Jfh8203C
SSr0oYq22IRqzG9su5W9FFcNjcwROibLSRCBItAJ+j7L8ZH0pqlfdlBNvIonDYOa
razusD8vvAle7NsuiJ/F
=oaxW
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4e1ee644.7070...@toell.net



Re: RFS: evolution-tray

2011-07-14 Thread Max Tsepkov
Thanks to people from debian-devel the package is now ready and lintian
clean.
Therefore, I'm reposting the RFS.


Dear mentors,

I am looking for a sponsor for my package evolution-tray.

* Package name: evolution-tray
  Version : 0.0.7-1
  Upstream Author : Lucian Langa  lucila...@gnome.org
* URL : http://gnome.eu.org/evo/index.php/Evolution_Tray
* License : GPL2
  Section : gnome

It builds these binary packages:
evolution-tray - Plugin for Evolution to put it in notification area

The package appears to be lintian clean.

The upload would fix these bugs: 633795

The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/e/evolution-tray
- Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- dget
http://mentors.debian.net/debian/pool/main/e/evolution-tray/evolution-tray_0.0.7-1.dsc

I would be glad if someone uploaded this package for me.

Kind regards
Max Tsepkov


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/1310702197.16382.42.camel@sewers