Re: RFS: fslint (updated package)
Hi, Maximiliano Curia wrote: Hola Pádraig Brady! El 23/07/2009 a las 16:53 escribiste: [...] A few comments: - Standards-Version are a bit old 3.8.0, while 3.8.2 is the current one, please check that in furter uploads. - Concerning bugs: * #511805, should have been answered and closed. findutils is an essential package, there is no need to declare essential packages as dependecies, you added the dependency, and the bug will be closed in this upload, there is no harm in this but it's not the best solution. * You closed a few debian bugs in a version that never hit Debian repositories, that requires some manual tweaking to process the correct part of the changelog, please avoid it. That's ok, it was me who forgot to include the changelog entries when uploading it. * You package version is 2.40-2, which would not include the original source in the upload, and requires some manual tweaking to do so, please avoid that. This shouldn't be discouraged either. - You need to keep in contact with your mentors, that will accelerate your uploads, once you gain their trust you might prefer to advocate as a debian maintainer, so you can upload your own packages, it might be educational to have a new mentor in every upload, but it's quite inefficient (you are encouraged to ask for help, though). He actually sent me a copy of his RFS and I was going to take a look at it and require him to do proper cleanup this time (on the BTS and the package itself). I can't get 2.28 into debian because the mentor process sucks., that's not it. I'm uploading your package, please consider the previous comments in further changes. Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: fslint (updated package)
Hola Raphael Geissert! El 25/07/2009 a las 11:37 escribiste: * You closed a few debian bugs in a version that never hit Debian repositories, that requires some manual tweaking to process the correct part of the changelog, please avoid it. That's ok, it was me who forgot to include the changelog entries when uploading it. You mean that the bugs were closed with the 2.28-1 upload? In that case, it might be good to close them through the bts commands? * You package version is 2.40-2, which would not include the original source in the upload, and requires some manual tweaking to do so, please avoid that. This shouldn't be discouraged either. Just to clarify, I personally find debian/changelog entries of versions that never hit debian repositories (which are the cause for the previous two points) useless, an error prone situation and bothering for the users. -- La duración de un minuto depende de que lado del baño estés. -- Ley de la Relatividad (Burke) Saludos /\/\ /\ `/ -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: fslint (updated package)
Hola Pádraig Brady! El 23/07/2009 a las 16:53 escribiste: I am looking for a sponsor for the new version 2.40-2 of my package fslint. It builds these binary packages: fslint - A utility to fix problems with filesystems' data, like duplicate The package appears to be lintian clean. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/f/fslint - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/f/fslint/fslint_2.40-2.dsc I would be glad if someone uploaded this package for me. A few comments: - Standards-Version are a bit old 3.8.0, while 3.8.2 is the current one, please check that in furter uploads. - Concerning bugs: * #511805, should have been answered and closed. findutils is an essential package, there is no need to declare essential packages as dependecies, you added the dependency, and the bug will be closed in this upload, there is no harm in this but it's not the best solution. * You closed a few debian bugs in a version that never hit Debian repositories, that requires some manual tweaking to process the correct part of the changelog, please avoid it. * You package version is 2.40-2, which would not include the original source in the upload, and requires some manual tweaking to do so, please avoid that. - You need to keep in contact with your mentors, that will accelerate your uploads, once you gain their trust you might prefer to advocate as a debian maintainer, so you can upload your own packages, it might be educational to have a new mentor in every upload, but it's quite inefficient (you are encouraged to ask for help, though). I can't get 2.28 into debian because the mentor process sucks., that's not it. I'm uploading your package, please consider the previous comments in further changes. -- : You are in a dark room with a compiler, emacs, an internet connection, : and a thermos of coffee. : Your move ? Saludos /\/\ /\ `/ -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
RFS: fslint (updated package)
Dear mentors, I am looking for a sponsor for the new version 2.40-2 of my package fslint. It builds these binary packages: fslint - A utility to fix problems with filesystems' data, like duplicate The package appears to be lintian clean. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/f/fslint - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/f/fslint/fslint_2.40-2.dsc I would be glad if someone uploaded this package for me. cheers, Pádraig Brady -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: fslint (updated package)
On 5/22/08, Pádraig Brady [EMAIL PROTECTED] wrote: I've uploaded fslint-2.26-2 to mentors addressing some of your concerns. I'll address the rest in the next release. Sponsored. One other minor thing I noticed is that you upload an identical manpage for fslint as for fslint-gui. While it's great that you have a manpage for fslint (I think all packages should do this), you should use a symlink to the fslint-gui manpage instead of shipping the unnecessary file. Debhelper's dh_link can help you there. Cameron -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: fslint (updated package)
On Thu, 2008-05-22 at 10:24 -0700, Cameron Dale wrote: On 5/22/08, Neil Williams [EMAIL PROTECTED] wrote: On Wed, 2008-05-21 at 21:20 -0700, Cameron Dale wrote: Unless you released 2.25-1 somewhere else, merge the unreleased 2.25-1 and 2.26-1 changelog entries into one 2.26-1, otherwise the bugs probably won't get closed automatically. Wrong - all the sponsor has to do is use '-v2.25-0 -sa'. dpkg-genchanges collates all Closes: entries in whichever versions the maintainer chooses to include by using the -v option. All bugs listed in the .changes file will be closed by that upload. Thanks for the tip. FWIW though, you have to explicitly specify a version that actually exists in the changelog or you get a .changes file that lists ALL the changelog entries (and closes all bugs ever listed). True - I was expecting 2.25-0 to be before the first changelog entry. Adapt the command as necessary. It's probably a bug in dpkg-dev that it behaves this way, given what the manpage says. Not sure, because you do need to specify a version *prior* to the first one you want listed so if there are no other changelog entries, you do need to specify a -0 or whatever. -- Neil Williams [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part
Re: RFS: fslint (updated package)
On Wed, 2008-05-21 at 21:20 -0700, Cameron Dale wrote: Hi Pádraig, Some more comments: Unless you released 2.25-1 somewhere else, merge the unreleased 2.25-1 and 2.26-1 changelog entries into one 2.26-1, otherwise the bugs probably won't get closed automatically. Wrong - all the sponsor has to do is use '-v2.25-0 -sa'. dpkg-genchanges collates all Closes: entries in whichever versions the maintainer chooses to include by using the -v option. All bugs listed in the .changes file will be closed by that upload. '-sa' might not be essential in this specific case but as the other changes will need a new upload to mentors, the actual version will be 2.26-2 and then '-sa' will be needed. http://people.debian.org/~codehelp/#increment (And don't blame me if Adblock Plus breaks the page - use a sane ad blocker, like the one in epiphany-browser.) Not required, but the use of the many install commands in the rules file should, in my opinion, be made more understandable by using debhelper's dh_install command and a separate fslint.install file. dh_install is preferred because if anyone needs to customise the build using DEB_BUILD_OPTIONS, dh_install will use those options, install will not. This means that a customised build has to patch debian/rules instead of just setting an environment variable. -- Neil Williams [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: fslint (updated package)
Cameron Dale wrote: Hi Pádraig, I might be able to sponsor this, but I have some concerns below. On 5/20/08, Pádraig Brady [EMAIL PROTECTED] wrote: Dear mentors, I am looking for a sponsor for the new version 2.26-1 of my package fslint. It builds these binary packages: fslint - A utility to fix problems with filesystems' data, like duplicate The package appears to be lintian clean. Upgrade your lintian and fix these problems: N: Processing source package fslint (version 2.26-1) ... W: fslint source: out-of-date-standards-version 3.7.2 (current is 3.7.3) ok I: fslint: desktop-entry-contains-encoding-key /usr/share/applications/fslint.desktop:8 Encoding N: N: The Encoding key is now deprecated by the FreeDesktop standard and all I can't change this without a patch to my release Will fix in next release if that's OK. W: fslint: description-contains-homepage N: N: The extended description contains a Homepage: pseudo-header N: following the old Developer's Reference recommendation. As of 1.14.6, N: dpkg now supports Homepage: as a regular field in debian/control. This N: header should be moved from the extended description to the fields for N: the relevant source or binary packages. ok Some more comments: Unless you released 2.25-1 somewhere else, merge the unreleased 2.25-1 and 2.26-1 changelog entries into one 2.26-1, otherwise the bugs probably won't get closed automatically. Neil commented why this is not necessary The changelog entry for 2.22-2 disappeared, add it back in. ok Not required, but the use of the many install commands in the rules file should, in my opinion, be made more understandable by using debhelper's dh_install command and a separate fslint.install file. Also not required, but the use of perl to set the location of the installed files in the fslint-gui program should be replaced by a patch, using quilt (preferably) or dpatch, so that it is more clear exactly what is being changed from upstream. I'll fix those up in fslint-2.28 (comming soon). thanks, Pádraig. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: fslint (updated package)
On 5/22/08, Neil Williams [EMAIL PROTECTED] wrote: On Wed, 2008-05-21 at 21:20 -0700, Cameron Dale wrote: Unless you released 2.25-1 somewhere else, merge the unreleased 2.25-1 and 2.26-1 changelog entries into one 2.26-1, otherwise the bugs probably won't get closed automatically. Wrong - all the sponsor has to do is use '-v2.25-0 -sa'. dpkg-genchanges collates all Closes: entries in whichever versions the maintainer chooses to include by using the -v option. All bugs listed in the .changes file will be closed by that upload. Thanks for the tip. FWIW though, you have to explicitly specify a version that actually exists in the changelog or you get a .changes file that lists ALL the changelog entries (and closes all bugs ever listed). It's probably a bug in dpkg-dev that it behaves this way, given what the manpage says. Cameron -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: fslint (updated package)
Pádraig Brady wrote: Cameron Dale wrote: Hi Pádraig, I might be able to sponsor this, but I have some concerns below. I've uploaded fslint-2.26-2 to mentors addressing some of your concerns. I'll address the rest in the next release. thanks, Pádraig. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: fslint (updated package)
Hi Pádraig, I might be able to sponsor this, but I have some concerns below. On 5/20/08, Pádraig Brady [EMAIL PROTECTED] wrote: Dear mentors, I am looking for a sponsor for the new version 2.26-1 of my package fslint. It builds these binary packages: fslint - A utility to fix problems with filesystems' data, like duplicate The package appears to be lintian clean. Upgrade your lintian and fix these problems: N: Processing source package fslint (version 2.26-1) ... W: fslint source: out-of-date-standards-version 3.7.2 (current is 3.7.3) N: N: The source package refers to a 'Standards-Version' that is starting to N: get out of date, compared to current Policy. You can safely ignore N: this warning, but please consider updating the package to current N: Policy. N: N: N: Processing binary package fslint (version 2.26-1) ... I: fslint: desktop-entry-contains-encoding-key /usr/share/applications/fslint.desktop:8 Encoding N: N: The Encoding key is now deprecated by the FreeDesktop standard and all N: strings are required to be encoded in UTF-8. This desktop entry N: explicitly specifies an Encoding of UTF-8, which is harmless but no N: longer necessary. N: N: Refer to N: http://standards.freedesktop.org/desktop-entry-spec/1.0/apc.html for N: details. N: W: fslint: description-contains-homepage N: N: The extended description contains a Homepage: pseudo-header N: following the old Developer's Reference recommendation. As of 1.14.6, N: dpkg now supports Homepage: as a regular field in debian/control. This N: header should be moved from the extended description to the fields for N: the relevant source or binary packages. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/f/fslint - Source repository: deb-src http://mentors.debian.net/debian unstable main con - dget http://mentors.debian.net/debian/pool/main/f/fslint/fslint_2.26-1.dsc Some more comments: Unless you released 2.25-1 somewhere else, merge the unreleased 2.25-1 and 2.26-1 changelog entries into one 2.26-1, otherwise the bugs probably won't get closed automatically. The changelog entry for 2.22-2 disappeared, add it back in. Not required, but the use of the many install commands in the rules file should, in my opinion, be made more understandable by using debhelper's dh_install command and a separate fslint.install file. Also not required, but the use of perl to set the location of the installed files in the fslint-gui program should be replaced by a patch, using quilt (preferably) or dpatch, so that it is more clear exactly what is being changed from upstream. Other than these minor problems, it looked good. Cameron -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
RFS: fslint (updated package)
Dear mentors, I am looking for a sponsor for the new version 2.26-1 of my package fslint. It builds these binary packages: fslint - A utility to fix problems with filesystems' data, like duplicate The package appears to be lintian clean. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/f/fslint - Source repository: deb-src http://mentors.debian.net/debian unstable main con - dget http://mentors.debian.net/debian/pool/main/f/fslint/fslint_2.26-1.dsc I would be glad if someone uploaded this package for me. cheers, Pádraig Brady -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: fslint (updated package)
Pádraig Brady wrote: Dear mentors, I am looking for a sponsor for the new version 2.20-1 of my package fslint. It builds these binary packages: fslint - A utility to fix problems with filesystems' data, like duplicate files The package is lintian clean. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/f/fslint - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/f/fslint/fslint_2.20-1.dsc Pretty please, with sugar on top? It fixes bugs 37, 380208, 397046, 413907 cheers, Pádraig. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
RFS: fslint (updated package)
Dear mentors, I am looking for a sponsor for the new version 2.20-1 of my package fslint. It builds these binary packages: fslint - A utility to fix problems with filesystems' data, like duplicate files The package is lintian clean. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/f/fslint - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/f/fslint/fslint_2.20-1.dsc I would be glad if someone uploaded this package for me. Kind regards Pádraig Brady -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
