Re: RFS: lebiniou, lebiniou-data (3rd try) (new upstream version)
http://pkg-fonts.debian.org/review/ correct link: http://pkg-fonts.alioth.debian.org/review/ --- Have a nice day. Joachim (Germany) -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110807111546.5e26b...@jupiter.home
Re: RFS: lebiniou, lebiniou-data (3rd try) (new upstream version)
On Sat, Jul 30, 2011 at 12:28:57AM +0200, Kilian Krause wrote: Regarding fonts/FreeMono.ttf I'm not sure whether that one needs to be removed from the source tarball too. It would be a GPL violation to not remove it. There are quite a few such packages in the archive already, we should not add more. If anyone wants to file some RC bugs on these packages, check out these two links: http://wiki.debian.org/Fonts#license-violation http://pkg-fonts.debian.org/review/ -- bye, pabs http://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Re: RFS: lebiniou, lebiniou-data (3rd try) (new upstream version)
Hi Olivier, On Fri, 2011-07-29 at 17:09 +0200, Olivier Girondel wrote: I am looking for a sponsor for my packages lebiniou and lebiniou-data. http://mentors.debian.net/debian/pool/main/l/lebiniou/lebiniou_3.9-1.dsc http://mentors.debian.net/debian/pool/main/l/lebiniou-data/lebiniou-data_3.9-1.dsc I would be glad if someone uploaded these packages for me. Sorry for taking so long to review. Built, signed, uploaded now. Thanks! -- Best regards, Kilian signature.asc Description: This is a digitally signed message part
Re: RFS: lebiniou, lebiniou-data (3rd try) (new upstream version)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Arno, On 07/30/2011 09:42 PM, Arno Töll wrote: Hi Oliver, On 30.07.2011 21:20, Olivier Girondel wrote: 2. OSS as default audio driver upstream (and thus Debian patch) lebiniou also builds on FreeBSD and NetBSD, and for these systems only OSS is available That's perfectly fine, but please note Debian also supports kFreeBSD which builds a GNU user land around the FreeBSD kernel. Your patch effectively breaks such systems, as there is no Alsa available as you said yourself. Nonetheless I agree with you, that defaulting to ALSA is a good idea for Linux. Thank you for pointing this out ! The default input plugin is now figured out at build time, depending on the target OS New package has been uploaded Best regards, - -- Olivier -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk41OlUACgkQpqVXaJzJYNLyfgCdFdXesG7gTxJ7RYteJWQDTgTu 6LsAn3aKY1zV/UzGjNJDlR+dZ8myx9ix =t/RP -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e353a56.3060...@biniou.info
Re: RFS: lebiniou, lebiniou-data (3rd try) (new upstream version)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Kilian, Thanks for reviewing the packages; On 07/30/2011 12:28 AM, Kilian Krause wrote: what's the reason to have: 1. dh-autoreconf (none of the patches requires this) There is a dependency on the ttf-freefont package; The patch path-to-freemono-font.diff removes the fonts/ directory from the build: it modifies configure.ac and the top-level Makefile.am (and sets the correct path to /usr/share/fonts/truetype/freefont/) dh-autoreconf is therefore needed, otherwise the package will end up containing a copy of FreeMono.ttf, and lintian will complain with a: W: lebiniou: duplicate-font-file usr/share/lebiniou/fonts/FreeMono.ttf also in ttf-freefont 2. OSS as default audio driver upstream (and thus Debian patch) lebiniou also builds on FreeBSD and NetBSD, and for these systems only OSS is available 3. extra -O3 when -O2 is already set as the Debian default? Some optimizations (eg. -finline-functions, -funswitch-loops, - -fpredictive-commoning) are set by -O3 4. a different lebiniou tarball than the one from your upstream website The tarballs have possibly gone out-of-sync, I just re-uploaded them. (the .orig.tar.gz is a symbolic link to the .tar.gz generated by 'make dist') Regarding fonts/FreeMono.ttf I'm not sure whether that one needs to be removed from the source tarball too. The previous suggestions I received were to remove it from the tarball and add a dependency on ttf-freefont 1. The public domain license is not printed verbatim in debian/copyright. Needs to be added. The copyright has been set to Public Domain and the license to CC0, included in the 'copyright' file (I hope the text/formating is ok) 2. Won't built for me with pdebuild -- --twice due to: Making all in sequences make[2]: Entering directory `/tmp/buildd/lebiniou-data-3.9/sequences' ./make-tar.sh /bin/bash: ./make-tar.sh: No such file or directory make[2]: *** [sequences.tar.gz] Error 127 This is now fixed Thanks for your work. Please fix these and ping me when you have updated this. New packages have been uploaded to m.d.n Thanks again for your time Best regards, - -- Olivier -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk40WYcACgkQpqVXaJzJYNKuMwCfaqejgKQSZ+dv3wfSdK4UAcTp d30AnAumvZ5a6OCJ2BcPw9DUxz5hVaQO =fieL -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e345993.2010...@biniou.info
Re: RFS: lebiniou, lebiniou-data (3rd try) (new upstream version)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Oliver, On 30.07.2011 21:20, Olivier Girondel wrote: 2. OSS as default audio driver upstream (and thus Debian patch) lebiniou also builds on FreeBSD and NetBSD, and for these systems only OSS is available That's perfectly fine, but please note Debian also supports kFreeBSD which builds a GNU user land around the FreeBSD kernel. Your patch effectively breaks such systems, as there is no Alsa available as you said yourself. Nonetheless I agree with you, that defaulting to ALSA is a good idea for Linux. Is there some conditional to override this compiled in choice upon build time? If so, you might consider making use of it, to make your package build on kFreeBSD with different defaults than Linux. For autotools based build systems, you could make use of dpkg-architecture plus conditional branching around it and pass host architecture dependent flags to its configure script. Alternatively you could do the same branching based on compiler preprocessor flags. - -- with kind regards, Arno Töll IRC: daemonkeeper on Freenode/OFTC GnuPG Key-ID: 0x9D80F36D -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJONF6NAAoJEMcrUe6dgPNtxdgQAIgYutl/M9QMfGaSmpC8Odxv fr284zDxlExblXIAYyfNuEg/cwNnoZzRP4FAcHijdkG0YCFZRQi3mmQgvRJbvpRm zw69rr326PDHxEP3L8u3TSI2mVQIXPsvrmua8XpNCH86Yk3oFeXWeVS0kDSJJACm VZdFm3hz2RUwlmz1WyzY9rWHD1HTgzq8GYiLTct+MqomLuifuV0UngNlu8G7WkKm iVrqScsRl3RGubYwoKgub8QqWZeaTbBe4VC1dyW78XL0/h0goj1jKobWgux4ZuhM a6w3p3IhqFpcB80UzzWMow/5kIkMoM7fIKIcCDgKEGzZLPsDn9uniCWdNT8s9CDo 9EVouyobXodKFTDtHhUR/Y7gghd/hkg+mBv9O5jZ+QUi5Zla0UeFLSTMnsVct7K9 NxsbjaYyU7e7Vl1JGK1fBMFn62g85ZOwslfyIVNEjQACbRG5ZcOYNWkn2LY1Rs+o UsHtkvT/eqRAPL4UVbB3KDKEi8ZFHNgbFNgZQm+1C+aTGCMdE52/M//25UanBO59 K03DVLmjy19w9YFqi/GINmKjVHoCjYeinYFutAJ3wNk1Xqft3C4HVUh2BYflklvj 4vdxLa+qoWsk1Li288NzUwOT5r84kOkVq/KY3Ymfp9kXmS0JzdvTb3kugXVlzPFh OUuQBUR48C0y8zI+cwXO =x8ug -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e345e8d.5070...@toell.net
RFS: lebiniou, lebiniou-data (3rd try) (new upstream version)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dear mentors, I am looking for a sponsor for my packages lebiniou and lebiniou-data. Package name: lebiniou, lebiniou-data Version : 3.9-1 Upstream Author : Olivier Girondel oliv...@biniou.info URL : http://biniou.net License : GPLv2 Section : graphics They build these binary packages: lebiniou - displays images that evolve with sound lebiniou-data - Datafiles for Le Biniou The packages appear to be lintian (--pedantic) clean. The upload would fix these bugs: 610042, 620899 My motivation for maintaining these packages is: I'm upstream for this software, which has more than fifteen years of existence running on GNU/Linux-based systems (esp. Debian), and *BSD. It's been appreciated and used as a VJing tool, and I think packaging it will make the procedures smoother for users as well as broadening its audience. The packages can be found on mentors.debian.net: - - URL: http://mentors.debian.net/debian/pool/main/l/lebiniou - - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - - dget http://mentors.debian.net/debian/pool/main/l/lebiniou/lebiniou_3.9-1.dsc and - - URL: http://mentors.debian.net/debian/pool/main/l/lebiniou-data - - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - - dget http://mentors.debian.net/debian/pool/main/l/lebiniou-data/lebiniou-data_3.9-1.dsc I would be glad if someone uploaded these packages for me. Kind regards, Olivier Girondel -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk4yzTEACgkQpqVXaJzJYNLgwQCfUZ8uly2+4yjvlF77Fzb5IoaD eEQAoIeHMs7iWpDKQwFRyjtRw6M0LOX5 =ZU+S -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e32cd31.50...@biniou.info
Re: RFS: lebiniou, lebiniou-data (3rd try) (new upstream version)
Hi Olivier, On Fri, Jul 29, 2011 at 05:09:37PM +0200, Olivier Girondel wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dear mentors, I am looking for a sponsor for my packages lebiniou and lebiniou-data. Package name: lebiniou, lebiniou-data Version : 3.9-1 Upstream Author : Olivier Girondel oliv...@biniou.info URL : http://biniou.net License : GPLv2 Section : graphics They build these binary packages: lebiniou - displays images that evolve with sound lebiniou-data - Datafiles for Le Biniou The packages appear to be lintian (--pedantic) clean. The upload would fix these bugs: 610042, 620899 My motivation for maintaining these packages is: I'm upstream for this software, which has more than fifteen years of existence running on GNU/Linux-based systems (esp. Debian), and *BSD. It's been appreciated and used as a VJing tool, and I think packaging it will make the procedures smoother for users as well as broadening its audience. The packages can be found on mentors.debian.net: - - URL: http://mentors.debian.net/debian/pool/main/l/lebiniou - - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - - dget http://mentors.debian.net/debian/pool/main/l/lebiniou/lebiniou_3.9-1.dsc what's the reason to have: 1. dh-autoreconf (none of the patches requires this) 2. OSS as default audio driver upstream (and thus Debian patch) 3. extra -O3 when -O2 is already set as the Debian default? 4. a different lebiniou tarball than the one from your upstream website Regarding fonts/FreeMono.ttf I'm not sure whether that one needs to be removed from the source tarball too. and - - URL: http://mentors.debian.net/debian/pool/main/l/lebiniou-data - - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - - dget http://mentors.debian.net/debian/pool/main/l/lebiniou-data/lebiniou-data_3.9-1.dsc 1. The public domain license is not printed verbatim in debian/copyright. Needs to be added. 2. Won't built for me with pdebuild -- --twice due to: Making all in sequences make[2]: Entering directory `/tmp/buildd/lebiniou-data-3.9/sequences' ./make-tar.sh /bin/bash: ./make-tar.sh: No such file or directory make[2]: *** [sequences.tar.gz] Error 127 Thanks for your work. Please fix these and ping me when you have updated this. -- Best regards, Kilian signature.asc Description: Digital signature
RFS: lebiniou, lebiniou-data (new 3.9 upstream version, debian packages updated)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/05/2011 07:24 PM, Olivier Girondel wrote: Dear mentors, I am looking for a sponsor for my packages lebiniou and lebiniou-data. Package name: lebiniou, lebiniou-data Version : 3.9-1 Upstream Author : Olivier Girondel oliv...@biniou.info URL : http://biniou.net License : GPLv2 Section : graphics They build these binary packages: lebiniou - displays images that evolve with sound lebiniou-data - Datafiles for Le Biniou The packages appear to be lintian clean. The upload would fix these bugs: 610042, 620899 My motivation for maintaining these packages is: I'm upstream for this software, which has more than fifteen years of existence running on GNU/Linux-based systems (esp. Debian), and *BSD. It's been appreciated and used as a VJing tool, and I think packaging it will make the procedures smoother for users as well as broadening its audience. The packages can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/l/lebiniou - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/l/lebiniou/lebiniou_3.8-1.dsc and - URL: http://mentors.debian.net/debian/pool/main/l/lebiniou-data - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/l/lebiniou-data/lebiniou-data_3.8-1.dsc I would be glad if someone uploaded these packages for me. Kind regards Olivier Girondel -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk4neK0ACgkQpqVXaJzJYNKMKACfTTEAg7bQusS5/Z6nXz3hEAwR 9I4AnjOmAuOKNvBo71wSDDWJY/tTKiSg =RpxP -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e2778ad.2070...@biniou.info
Re: RFS: lebiniou, lebiniou-data
On Wed, Jul 6, 2011 at 6:23 PM, Olivier Girondel wrote: I included the FreeMono.sfd, COPYING and README files from the freefont package in the source tarball. I don't think that was needed. Really you only need them in any non-Debian binary packages that you make (for Windows/MacOS etc). Even there it is probably better to use the native fonts of the platform than GNU FreeFont. However, the Debian package now depends on ttf-freefont, and the option to remove the fonts/ directory has been moved from the Makefile to debian/patches, as suggested. Ok. -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caktje6giemfdjcjxk0iznquof3pzk2y63nve1x1-s+emrvz...@mail.gmail.com
Re: RFS: lebiniou, lebiniou-data
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/29/2011 05:12 PM, David Banks wrote: wrt to debian/copyright file there are a few issues: * You might consider using DEP-5 as a best practice, this is up to you. This has been fixed, but I'm not sure what exactly the content of the Format: field should be. * You should probably mention the original author and license of src/pnglite.[ch] in the copyright file. Also fixed. * You should mention the copyright on fonts/FreeMono.ttf and preferably ship the source if possible. Alternatively, repack and exclude it. (About the latter, I see that in Makefile.am you use --enable-debian to disable installing the fonts. I would say as a matter of style you should keep all debian-specific tweaks inside the 'debian' directory. Arguably it's better to patch the Makefile than to put this option in. Regardless of where you put the option, though, everything in the _source_ package needs a copyright statement.) I included the FreeMono.sfd, COPYING and README files from the freefont package in the source tarball. However, the Debian package now depends on ttf-freefont, and the option to remove the fonts/ directory has been moved from the Makefile to debian/patches, as suggested. * Manpage is lebiniou.6, but I'm not sure if Le Biniou would be called a game, though you can see it as one. I'd be comfortable with it under section 1. Moved back to section 1. * The program didn't seem to detect audio from Rhythmbox out of the box, presumably as it was trying to use the alsa plugin where rhythmbox uses pulseaudio. Maybe consider adding a note to the manual about how to switch the audio plugin, for new users. The manual has been updated. I uploaded the new packages to mentors.debian.net. Thanks, - -- Olivier -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk4Ui+4ACgkQpqVXaJzJYNKH7wCfXiZ45Zo/yJ5qbQu/oU3RIDpR +uQAnjrCQ0bCxyMdgBJkytd6j5EwTQxP =tBIQ -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e148bee.9050...@biniou.info
Re: RFS: lebiniou, lebiniou-data
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Oliver, On 06.07.2011 18:23, Olivier Girondel wrote: This has been fixed, but I'm not sure what exactly the content of the Format: field should be. please see [1] and that thread in general. Some people have different understandings what to put there. The thread I am referring to addresses most if not all concerns with it. [1] http://lists.debian.org/debian-mentors/2011/05/msg00529.html - -- with kind regards, Arno Töll IRC: daemonkeeper on Freenode/OFTC GnuPG Key-ID: 0x9D80F36D -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJOFJV/AAoJEMcrUe6dgPNt32AP/A5aKWbRmDV/QhDlE9rV0DxF MYOGfotMvDlK6usM0QpQjl86E+hG6jZ/8TWjPS1M2pkjVvkw2kyu2JWfaMSwYUgB c0g0694yf2qKAa+tiKZ/jvUhih6wDmkrEMqcWKAh/r8XFkibm4vIO9Mm4QDCc+jP qTXKcmkbIVXraJ88QHZiohaLCgcZ4eMJf/Exxr8yt+4zuLbBYi6fRdW195BSsiCk vJwiuX+k9ZzQOUnfm4E9Z/rAciAW/a/xqnU0Yw+4c0AfX96iDZe778LF/zQqPQ3v Jxz2bbukJ/UwXwm61KF962EhyIqFFfrDg8zKEvXRKz3NKaWyIVomKBMqIhgE+eOB GIPI9x0o0XWr1RPgaZ2iCb7Vsn4mRX7PFlEcdyePPfcZW50tOZmzOLGrQ3ajw1Qh Y742A8j1PRP0Xp0YLDnhXwTOmlOw7wIZl/YItfhj9NfwwyWuzD+WgFZA+Jh+a3pu btaXdhrogo1vvQDYd78La8ivBC4m/mqJfL2TU1OVY46m8R3Uh9rELtH/7Ii+t0yI 9gQnHQQ+DpKIqLGlHBc+5RhYwUp2tnPAIYHR1lDD0hmsbVoPqyT+wYpAi7bb0fGP ffWlbZiPWwtgVe9CmSG6BlRuXBQMka6mEAdDVvyAgdiTdDmRV0V1bLdCKQOG/rvj 4GW5X3gAtNc0KUgzrCFd =8fKi -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e149580.4010...@toell.net
Re: RFS: lebiniou, lebiniou-data
- The dependency against lebiniou-data is not versioned. That means
that lebiniou is meant to be usable with any version of
lebiniou-data. In such a case I think you need to specify exactly
one version. With a single source package, you could depend on
lebinou-data (= ${source:Version}).
${binary:Version} sounds even better to me for this usecase.
If I understand it correctly, ${source:Version} will allow binNMUs of
the Arch:any package without having to provide a binNMU of the
Arch:all package (which is impossible).
Or am I missing something ?
--
Etienne Millon
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110630063054.ga4...@john.ssi.corp
Re: RFS: lebiniou, lebiniou-data
Etienne,
On Thu, Jun 30, 2011 at 08:30:54AM +0200, Etienne Millon wrote:
- The dependency against lebiniou-data is not versioned. That means
that lebiniou is meant to be usable with any version of
lebiniou-data. In such a case I think you need to specify exactly
one version. With a single source package, you could depend on
lebinou-data (= ${source:Version}).
${binary:Version} sounds even better to me for this usecase.
If I understand it correctly, ${source:Version} will allow binNMUs of
the Arch:any package without having to provide a binNMU of the
Arch:all package (which is impossible).
Or am I missing something ?
No, you got it exactly right. I just had them two mixed up. Sorry.
--
Cheers,
Kilian
signature.asc
Description: Digital signature
Re: RFS: lebiniou, lebiniou-data
Hi Olivier, [CCing my response to the list, hope you don't mind] On 30 June 2011 03:43, Olivier Girondel olivier.giron...@gmail.com wrote: [wrt fonts] Yes, I already got a remark from Paul Wise about this, but I'm not sure what to do, regarding the source of FreeMono.ttf FreeMono.ttf comes from http://savannah.gnu.org/projects/freefont/ but I'm not sure about what the source files are, any hints would be welcomed At a quick glance, the source would appear to be the SFD files. Here's one from the CVS: http://cvs.savannah.gnu.org/viewvc/*checkout*/freefont/sfd/FreeMono.sfd?revision=1.226root=freefont * In lebiniou-data, I'm loving the images! Many of them are homemade, but some of them look like they might be copyrighted. All these images need license statements in debian/copyright. I'm guessing it won't be practical to dig up these for some of them, so if I were you I would just strip out the potentially problematic ones and only leave the ones you are sure about. Would you please tell me which images could be, in your opinion, copyrighted ? I tried my best to remove those that would be problematic; all the rest is eather home-made or under a Creative Commons license Cool - The CC licensed images need to be stated in debian/copyright. If you're sure they are homemade or CC, that's fine. The ones which immediately stuck as being potentially non-free were: * UNIX live free or die plate * Eye in the pyramid logo * Possibly the Cthulhu hazard sign (which I love) * Matrix code (this could be generated, though) If these have attributions, though, that's no problem. As far as I was tought, section 6 was for games, and everything related, that does not fit within sections 1..3. lebiniou, IMHO, is not a general command one would include, for example, in a shell script Back to the origins, yes, it was a .1, but I decided to go to .6 since this is not a (usefull) command. Arguments on this are welcomed :) FHS says, man1: Most program documentation that a user will need to use is located here. man6: This chapter documents games, demos, and generally trivial programs. Different people have various notions about how essential this is. Personally I'd leave it in section 1 unless the package's section is also set to 'games'. Which I wouldn't recommend ;) * I would prefer to have sequences.tar.gz installed unpacked, as it's very small. No big deal though. Do you mean, shipping it as a plain .tar ? Doable. Ah, when I wrote that I meant to have the entire tree unpacked under /usr/share/doc/lebinou/examples/sequences or similar. However, after posting my message I looked at the manual and you describe unpacking that tarball to your home directory, so I figured your motivation was that unpacking a tarball is easier for users than 'cp -a' or whatever. So leave it as it is. * The program didn't seem to detect audio from Rhythmbox out of the box, presumably as it was trying to use the alsa plugin where rhythmbox uses pulseaudio. Maybe consider adding a note to the manual about how to switch the audio plugin, for new users. This is one of the main problems regarding linux distros[1], I chose to make ALSA a default, since some people are reluctant using PulseAudio, I'll try my best finding a way to document this, (if you have any hint on this, I'd be happy to get it) [1] Not to mention that lebiniou is also supposed to run under *BSDs ;) I think just an instruction Pulseaudio users: use -i pulseaudio should be OK, plus instructions on how to set that more permanently. Cheers, -- David Banks amoe...@gmail.com -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e0c3fb3.7050...@gmail.com
Re: RFS: lebiniou, lebiniou-data
On Thu, Jun 30, 2011 at 10:19 AM, David Banks amoe...@gmail.com wrote: On 30 June 2011 03:43, Olivier Girondel olivier.giron...@gmail.com wrote: [wrt fonts] Yes, I already got a remark from Paul Wise about this, but I'm not sure what to do, regarding the source of FreeMono.ttf FreeMono.ttf comes from http://savannah.gnu.org/projects/freefont/ but I'm not sure about what the source files are, any hints would be welcomed At a quick glance, the source would appear to be the SFD files. Here's one from the CVS: http://cvs.savannah.gnu.org/viewvc/*checkout*/freefont/sfd/FreeMono.sfd?revision=1.226root=freefont The best way to deal with this is to not ship any fonts in the source package and use the default system font for rendering text. Unless you forked FreeMono, this should be acceptable to you. If you are also targeting platforms without robust repository and dependency systems, you can embed a copy of the font in the binary package for those systems and place a copy of the FreeFont source tarball alongside your binary packages. You can find source tarballs and pre-compiled TTF files for FreeFont here: http://ftp.gnu.org/gnu/freefont/ If you need to use a specific font, then depend on it. If you need to find the filename of a specific font, then use fontconfig. If you don't want to do that then add a build-time configuration parameter, in Debian for example that could point at the path to FreeMono.ttf in ttf-freefont. If you don't want to do that then add a symlink to the path to FreeMono.ttf in ttf-freefont from the path the program expects FreeMono.ttf to be at. -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/BANLkTi=3qo55r814j-kzaesj37z3ne3...@mail.gmail.com
Re: RFS: lebiniou, lebiniou-data
Hi Olivier, On 05/04/11 18:24, Olivier Girondel wrote: Dear mentors, I am looking for a sponsor for my packages lebiniou and lebiniou-data. Sadly I am not a DD, but I am responding to Michael's request for non-DDs to review packages. (http://lists.debian.org/debian-mentors/2011/06/msg00388.html) Technical quality of the package is overall very good. Not to mention the program itself is very impressive, I'll definitely be using it in the future. wrt to debian/copyright file there are a few issues: * You might consider using DEP-5 as a best practice, this is up to you. * You should probably mention the original author and license of src/pnglite.[ch] in the copyright file. * You should mention the copyright on fonts/FreeMono.ttf and preferably ship the source if possible. Alternatively, repack and exclude it. (About the latter, I see that in Makefile.am you use --enable-debian to disable installing the fonts. I would say as a matter of style you should keep all debian-specific tweaks inside the 'debian' directory. Arguably it's better to patch the Makefile than to put this option in. Regardless of where you put the option, though, everything in the _source_ package needs a copyright statement.) * In lebiniou-data, I'm loving the images! Many of them are homemade, but some of them look like they might be copyrighted. All these images need license statements in debian/copyright. I'm guessing it won't be practical to dig up these for some of them, so if I were you I would just strip out the potentially problematic ones and only leave the ones you are sure about. * Manpage is lebiniou.6, but I'm not sure if Le Biniou would be called a game, though you can see it as one. I'd be comfortable with it under section 1. * A few natural language nit picks about the description: When you run Le Biniou it gives a revolutionary rendering of the sound you are playing. I don't disagree that it's revolutionary ;) but evolutionary might fit better with the short package description. chose your own series of pictures You probably mean 'choose' discover a multidimensional –spatial and chromatic– way Dash separation normally looks like - . You want a space before 'spatial' and a space after 'chromatic'. comprehending musics and sounds 'Musics' is actually a valid plural but that's quite a strange academic usage, I'm guessing you meant just 'music'. * I would prefer to have sequences.tar.gz installed unpacked, as it's very small. No big deal though. * The program didn't seem to detect audio from Rhythmbox out of the box, presumably as it was trying to use the alsa plugin where rhythmbox uses pulseaudio. Maybe consider adding a note to the manual about how to switch the audio plugin, for new users. Nice work! One step closer. ;) Cheers, David -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/iuffc7$3si$1...@dough.gmane.org
Re: RFS: lebiniou, lebiniou-data
Hello,
A few extra remarks from a non-DD :
debian/control
--
- The VCS-* fields should be relative to the debian packaging, not
the upstream repository. From what I've seen, this source package
has been generated from the upstream debian/ subdirectory. This
is misleading because you can't easily export a tarball and use it
as a .orig file.
As you are the upstream author, I suggest that you use a single
source package to build these two binary packages (one .dsc, two
.debs). That should ease maintenance, including the following
point.
- The dependency against lebiniou-data is not versioned. That means
that lebiniou is meant to be usable with any version of
lebiniou-data. In such a case I think you need to specify exactly
one version. With a single source package, you could depend on
lebinou-data (= ${source:Version}).
Hope that helps,
--
Etienne Millon
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110629155449.gb21...@john.ssi.corp
Re: RFS: lebiniou, lebiniou-data
Hi,
On Wed, Jun 29, 2011 at 05:54:49PM +0200, Etienne Millon wrote:
A few extra remarks from a non-DD :
debian/control
--
- The VCS-* fields should be relative to the debian packaging, not
the upstream repository. From what I've seen, this source package
has been generated from the upstream debian/ subdirectory. This
is misleading because you can't easily export a tarball and use it
as a .orig file.
Thanks for pointing this out. The problem generally is that updating the
debian package otherwise would demand for a new upstream release if this is
not split apart. That's usually not what you want.
Therefore please only make a Debian-native (upstream=Debian, version without
-number suffix) package for stuff that is exclusively targetted at Debian
and can receive new releases anytime the Debian version asks for it.
As you are the upstream author, I suggest that you use a single
source package to build these two binary packages (one .dsc, two
.debs). That should ease maintenance, including the following
point.
Sounds good to me.
- The dependency against lebiniou-data is not versioned. That means
that lebiniou is meant to be usable with any version of
lebiniou-data. In such a case I think you need to specify exactly
one version. With a single source package, you could depend on
lebinou-data (= ${source:Version}).
${binary:Version} sounds even better to me for this usecase.
--
Best regards,
Kilian
signature.asc
Description: Digital signature
Re: RFS: lebiniou, lebiniou-data
Hi,
On Wed, Jun 29, 2011 at 05:54:49PM +0200, Etienne Millon wrote:
debian/control
--
- The VCS-* fields should be relative to the debian packaging, not
the upstream repository. From what I've seen, this source package
has been generated from the upstream debian/ subdirectory. This
is misleading because you can't easily export a tarball and use it
as a .orig file.
As you are the upstream author, I suggest that you use a single
source package to build these two binary packages (one .dsc, two
.debs). That should ease maintenance, including the following
point.
- The dependency against lebiniou-data is not versioned. That means
that lebiniou is meant to be usable with any version of
lebiniou-data. In such a case I think you need to specify exactly
one version. With a single source package, you could depend on
lebinou-data (= ${source:Version}).
Also, debhelper is 7. Bump to 8 under: debia/compat , debian/control
Regards,
--
Elías Alejandro
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110629164011.GA2308@debianero
RFS: lebiniou, lebiniou-data
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dear mentors, I am looking for a sponsor for my packages lebiniou and lebiniou-data. Package name: lebiniou, lebiniou-data Version : 3.8-1 Upstream Author : Olivier Girondel oliv...@biniou.info URL : http://biniou.net License : GPLv2 Section : graphics They build these binary packages: lebiniou - displays images that evolve with sound lebiniou-data - Datafiles for Le Biniou The packages appear to be lintian clean. The upload would fix these bugs: 610042, 620899 My motivation for maintaining these packages is: I'm upstream for this software, which has more than fifteen years of existence running on GNU/Linux-based systems (esp. Debian), and *BSD. It's been appreciated and used as a VJing tool, and I think packaging it will make the procedures smoother for users as well as broadening its audience. The packages can be found on mentors.debian.net: - - URL: http://mentors.debian.net/debian/pool/main/l/lebiniou - - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - - dget http://mentors.debian.net/debian/pool/main/l/lebiniou/lebiniou_3.8-1.dsc and - - URL: http://mentors.debian.net/debian/pool/main/l/lebiniou-data - - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - - dget http://mentors.debian.net/debian/pool/main/l/lebiniou-data/lebiniou-data_3.8-1.dsc I would be glad if someone uploaded these packages for me. Kind regards Olivier Girondel -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk2bUDEACgkQpqVXaJzJYNL5XQCfQy915dKNh6koVhWSIbV5oi+B qQEAn1sDqt3bgSaSUWdG3oa9KhVQFBnz =PpzO -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4d9b5031.8090...@biniou.info
