Re: RFS: lebiniou, lebiniou-data (3rd try) (new upstream version)

2011-08-07 Thread Joachim Wiedorn
 http://pkg-fonts.debian.org/review/

correct link:
http://pkg-fonts.alioth.debian.org/review/

---
Have a nice day.
Joachim (Germany)


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110807111546.5e26b...@jupiter.home



Re: RFS: lebiniou, lebiniou-data (3rd try) (new upstream version)

2011-08-06 Thread Paul Wise
On Sat, Jul 30, 2011 at 12:28:57AM +0200, Kilian Krause wrote:

 Regarding fonts/FreeMono.ttf I'm not sure whether that one needs to be
 removed from the source tarball too.

It would be a GPL violation to not remove it. There are quite a few such
packages in the archive already, we should not add more. If anyone wants
to file some RC bugs on these packages, check out these two links: 

http://wiki.debian.org/Fonts#license-violation
http://pkg-fonts.debian.org/review/

-- 
bye,
pabs

http://wiki.debian.org/PaulWise



signature.asc
Description: This is a digitally signed message part


Re: RFS: lebiniou, lebiniou-data (3rd try) (new upstream version)

2011-08-05 Thread Kilian Krause
Hi Olivier,

On Fri, 2011-07-29 at 17:09 +0200, Olivier Girondel wrote:
 I am looking for a sponsor for my packages lebiniou and
 lebiniou-data.
 http://mentors.debian.net/debian/pool/main/l/lebiniou/lebiniou_3.9-1.dsc
 http://mentors.debian.net/debian/pool/main/l/lebiniou-data/lebiniou-data_3.9-1.dsc
 
 I would be glad if someone uploaded these packages for me.

Sorry for taking so long to review.

Built, signed, uploaded now.

Thanks!

-- 
Best regards,
Kilian


signature.asc
Description: This is a digitally signed message part


Re: RFS: lebiniou, lebiniou-data (3rd try) (new upstream version)

2011-07-31 Thread Olivier Girondel
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi Arno,

On 07/30/2011 09:42 PM, Arno Töll wrote:
 Hi Oliver,
 
 On 30.07.2011 21:20, Olivier Girondel wrote:
 2. OSS as default audio driver upstream (and thus Debian patch)
 
 lebiniou also builds on FreeBSD and NetBSD, and for these systems only
 OSS is available
 
 
 That's perfectly fine, but please note Debian also supports kFreeBSD
 which builds a GNU user land around the FreeBSD kernel. Your patch
 effectively breaks such systems, as there is no Alsa available as you
 said yourself. Nonetheless I agree with you, that defaulting to ALSA is
 a good idea for Linux.

Thank you for pointing this out !

The default input plugin is now figured out at build time, depending
on the target OS

New package has been uploaded

Best regards,

- --
Olivier
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk41OlUACgkQpqVXaJzJYNLyfgCdFdXesG7gTxJ7RYteJWQDTgTu
6LsAn3aKY1zV/UzGjNJDlR+dZ8myx9ix
=t/RP
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4e353a56.3060...@biniou.info



Re: RFS: lebiniou, lebiniou-data (3rd try) (new upstream version)

2011-07-30 Thread Olivier Girondel
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi Kilian,

Thanks for reviewing the packages;

On 07/30/2011 12:28 AM, Kilian Krause wrote:
 what's the reason to have:
 
 1. dh-autoreconf (none of the patches requires this)

There is a dependency on the ttf-freefont package;

The patch path-to-freemono-font.diff removes the fonts/ directory from
the build: it modifies configure.ac and the top-level Makefile.am
(and sets the correct path to /usr/share/fonts/truetype/freefont/)

dh-autoreconf is therefore needed, otherwise the package will end up
containing a copy of FreeMono.ttf, and lintian will complain with a:
W: lebiniou: duplicate-font-file usr/share/lebiniou/fonts/FreeMono.ttf
also in ttf-freefont

 2. OSS as default audio driver upstream (and thus Debian patch)

lebiniou also builds on FreeBSD and NetBSD, and for these systems only
OSS is available

 3. extra -O3 when -O2 is already set as the Debian default?

Some optimizations (eg. -finline-functions, -funswitch-loops,
- -fpredictive-commoning) are set by -O3

 4. a different lebiniou tarball than the one from your upstream website

The tarballs have possibly gone out-of-sync, I just re-uploaded them.
(the .orig.tar.gz is a symbolic link to the .tar.gz generated by 'make
dist')

 Regarding fonts/FreeMono.ttf I'm not sure whether that one needs to be
 removed from the source tarball too.

The previous suggestions I received were to remove it from the tarball
and add a dependency on ttf-freefont

 1. The public domain license is not printed verbatim in debian/copyright.
Needs to be added.

The copyright has been set to Public Domain and the license to CC0,
included in the 'copyright' file (I hope the text/formating is ok)

 2. Won't built for me with pdebuild -- --twice due to:
 Making all in sequences
 make[2]: Entering directory `/tmp/buildd/lebiniou-data-3.9/sequences'
 ./make-tar.sh
 /bin/bash: ./make-tar.sh: No such file or directory
 make[2]: *** [sequences.tar.gz] Error 127

This is now fixed

 Thanks for your work. Please fix these and ping me when you have updated
 this.

New packages have been uploaded to m.d.n

Thanks again for your time
Best regards,

- --
Olivier
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk40WYcACgkQpqVXaJzJYNKuMwCfaqejgKQSZ+dv3wfSdK4UAcTp
d30AnAumvZ5a6OCJ2BcPw9DUxz5hVaQO
=fieL
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4e345993.2010...@biniou.info



Re: RFS: lebiniou, lebiniou-data (3rd try) (new upstream version)

2011-07-30 Thread Arno Töll
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi Oliver,

On 30.07.2011 21:20, Olivier Girondel wrote:
 2. OSS as default audio driver upstream (and thus Debian patch)
 
 lebiniou also builds on FreeBSD and NetBSD, and for these systems only
 OSS is available
 

That's perfectly fine, but please note Debian also supports kFreeBSD
which builds a GNU user land around the FreeBSD kernel. Your patch
effectively breaks such systems, as there is no Alsa available as you
said yourself. Nonetheless I agree with you, that defaulting to ALSA is
a good idea for Linux.

Is there some conditional to override this compiled in choice upon build
time? If so, you might consider making use of it, to make your package
build on kFreeBSD with different defaults than Linux.

For autotools based build systems, you could make use of
dpkg-architecture plus conditional branching around it and pass host
architecture dependent flags to its configure script.

Alternatively you could do the same branching based on compiler
preprocessor flags.

- -- 
with kind regards,
Arno Töll
IRC: daemonkeeper on Freenode/OFTC
GnuPG Key-ID: 0x9D80F36D
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJONF6NAAoJEMcrUe6dgPNtxdgQAIgYutl/M9QMfGaSmpC8Odxv
fr284zDxlExblXIAYyfNuEg/cwNnoZzRP4FAcHijdkG0YCFZRQi3mmQgvRJbvpRm
zw69rr326PDHxEP3L8u3TSI2mVQIXPsvrmua8XpNCH86Yk3oFeXWeVS0kDSJJACm
VZdFm3hz2RUwlmz1WyzY9rWHD1HTgzq8GYiLTct+MqomLuifuV0UngNlu8G7WkKm
iVrqScsRl3RGubYwoKgub8QqWZeaTbBe4VC1dyW78XL0/h0goj1jKobWgux4ZuhM
a6w3p3IhqFpcB80UzzWMow/5kIkMoM7fIKIcCDgKEGzZLPsDn9uniCWdNT8s9CDo
9EVouyobXodKFTDtHhUR/Y7gghd/hkg+mBv9O5jZ+QUi5Zla0UeFLSTMnsVct7K9
NxsbjaYyU7e7Vl1JGK1fBMFn62g85ZOwslfyIVNEjQACbRG5ZcOYNWkn2LY1Rs+o
UsHtkvT/eqRAPL4UVbB3KDKEi8ZFHNgbFNgZQm+1C+aTGCMdE52/M//25UanBO59
K03DVLmjy19w9YFqi/GINmKjVHoCjYeinYFutAJ3wNk1Xqft3C4HVUh2BYflklvj
4vdxLa+qoWsk1Li288NzUwOT5r84kOkVq/KY3Ymfp9kXmS0JzdvTb3kugXVlzPFh
OUuQBUR48C0y8zI+cwXO
=x8ug
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4e345e8d.5070...@toell.net



RFS: lebiniou, lebiniou-data (3rd try) (new upstream version)

2011-07-29 Thread Olivier Girondel
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Dear mentors,

I am looking for a sponsor for my packages lebiniou and
lebiniou-data.

 Package name: lebiniou, lebiniou-data
 Version : 3.9-1
 Upstream Author : Olivier Girondel oliv...@biniou.info
 URL : http://biniou.net
 License : GPLv2
 Section : graphics

They build these binary packages:

lebiniou  - displays images that evolve with sound
lebiniou-data - Datafiles for Le Biniou

The packages appear to be lintian (--pedantic) clean.

The upload would fix these bugs: 610042, 620899

My motivation for maintaining these packages is: I'm upstream for this
software, which has more than fifteen years of existence running on
GNU/Linux-based systems (esp. Debian), and *BSD. It's been appreciated
and used as a VJing tool, and I think packaging it will make the
procedures smoother for users as well as broadening its audience.

The packages can be found on mentors.debian.net:

- - URL: http://mentors.debian.net/debian/pool/main/l/lebiniou
- - Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- - dget
http://mentors.debian.net/debian/pool/main/l/lebiniou/lebiniou_3.9-1.dsc

and
- - URL: http://mentors.debian.net/debian/pool/main/l/lebiniou-data
- - Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- - dget
http://mentors.debian.net/debian/pool/main/l/lebiniou-data/lebiniou-data_3.9-1.dsc

I would be glad if someone uploaded these packages for me.

Kind regards,

  Olivier Girondel
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk4yzTEACgkQpqVXaJzJYNLgwQCfUZ8uly2+4yjvlF77Fzb5IoaD
eEQAoIeHMs7iWpDKQwFRyjtRw6M0LOX5
=ZU+S
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4e32cd31.50...@biniou.info



Re: RFS: lebiniou, lebiniou-data (3rd try) (new upstream version)

2011-07-29 Thread Kilian Krause
Hi Olivier,

On Fri, Jul 29, 2011 at 05:09:37PM +0200, Olivier Girondel wrote:
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1
 
 Dear mentors,
 
 I am looking for a sponsor for my packages lebiniou and
 lebiniou-data.
 
  Package name: lebiniou, lebiniou-data
  Version : 3.9-1
  Upstream Author : Olivier Girondel oliv...@biniou.info
  URL : http://biniou.net
  License : GPLv2
  Section : graphics
 
 They build these binary packages:
 
 lebiniou  - displays images that evolve with sound
 lebiniou-data - Datafiles for Le Biniou
 
 The packages appear to be lintian (--pedantic) clean.
 
 The upload would fix these bugs: 610042, 620899
 
 My motivation for maintaining these packages is: I'm upstream for this
 software, which has more than fifteen years of existence running on
 GNU/Linux-based systems (esp. Debian), and *BSD. It's been appreciated
 and used as a VJing tool, and I think packaging it will make the
 procedures smoother for users as well as broadening its audience.
 
 The packages can be found on mentors.debian.net:
 
 - - URL: http://mentors.debian.net/debian/pool/main/l/lebiniou
 - - Source repository: deb-src http://mentors.debian.net/debian unstable
 main contrib non-free
 - - dget
 http://mentors.debian.net/debian/pool/main/l/lebiniou/lebiniou_3.9-1.dsc

what's the reason to have:

1. dh-autoreconf (none of the patches requires this)
2. OSS as default audio driver upstream (and thus Debian patch)
3. extra -O3 when -O2 is already set as the Debian default?
4. a different lebiniou tarball than the one from your upstream website

Regarding fonts/FreeMono.ttf I'm not sure whether that one needs to be
removed from the source tarball too.

 and
 - - URL: http://mentors.debian.net/debian/pool/main/l/lebiniou-data
 - - Source repository: deb-src http://mentors.debian.net/debian unstable
 main contrib non-free
 - - dget
 http://mentors.debian.net/debian/pool/main/l/lebiniou-data/lebiniou-data_3.9-1.dsc

1. The public domain license is not printed verbatim in debian/copyright.
   Needs to be added.
2. Won't built for me with pdebuild -- --twice due to:
Making all in sequences
make[2]: Entering directory `/tmp/buildd/lebiniou-data-3.9/sequences'
./make-tar.sh
/bin/bash: ./make-tar.sh: No such file or directory
make[2]: *** [sequences.tar.gz] Error 127


Thanks for your work. Please fix these and ping me when you have updated
this.

-- 
Best regards,
Kilian


signature.asc
Description: Digital signature