Re: RFS: libx86 (adopted package)
Il giorno Sat, 9 Feb 2008 12:40:31 +0530 Kapil Hari Paranjape [EMAIL PROTECTED] ha scritto: Hello, On Sat, 09 Feb 2008, Kapil Hari Paranjape wrote: I have not yet done the rest of my review so you may want to wait a while before uploading a new version to mentors. Since you are adding quilt, it is probably a good idea to modify/add the Makefile in a quilt patch. Ooops, I must have missed that, sorry. (I usually leave only debian/ into the .diff.gz). Probably it was done by the previous maintainer, and I just didn't notice it. It has been fixed now :) Once you take a decision on this and the name change please upload your file to mentors and I will upload it. Sure, done. I decided to use your suggestion as the version number, with revision number 1 (i.e. 0.99.ds1-2), because it's the first release with the repackaged source. And, IMHO, it's better than the +ds thing. Here you are: http://mentors.debian.net/debian/pool/main/l/libx86/libx86_0.99.ds1-1.dsc Thanks for reviewing this package. Kindly, David -- . ''`. Debian maintainer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 | http://snipr.com/qa_page `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: libx86 (adopted package)
David Paleino scrisse: I decided to use your suggestion as the version number, with revision number 1 (i.e. 0.99.ds1-2), because it's the first release with the repackaged source. And, IMHO, it's better than the +ds thing. I'd say that this isn't a great idea. If in the future upstream release a micro revision, eg 0.99.1, you'll be in trouble as 0.99.1 isn't greater than your 0.99.ds1. Please compare these: dpkg --compare-versions 0.99.1 gt 0.99.ds1 echo OK dpkg --compare-versions 0.99.1 gt 0.99+ds1 echo OK Kindly, David Cheers, Luca -- .''`. ** Debian GNU/Linux ** | Luca Bruno : :' : The Universal O.S.| lucab (AT) debian.org `. `'` | GPG Key ID: 3BFB9FB3 `- http://www.debian.org | Debian GNU/Linux Developer pgpJGLqfJNeOM.pgp Description: PGP signature
Re: RFS: libx86 (adopted package)
Il giorno Sat, 9 Feb 2008 10:45:48 +0100 Luca Bruno [EMAIL PROTECTED] ha scritto: David Paleino scrisse: I decided to use your suggestion as the version number, with revision number 1 (i.e. 0.99.ds1-2), because it's the first release with the repackaged source. And, IMHO, it's better than the +ds thing. I'd say that this isn't a great idea. If in the future upstream release a micro revision, eg 0.99.1, you'll be in trouble as 0.99.1 isn't greater than your 0.99.ds1. Please compare these: dpkg --compare-versions 0.99.1 gt 0.99.ds1 echo OK dpkg --compare-versions 0.99.1 gt 0.99+ds1 echo OK You're right. Thanks for noticing this :) http://mentors.debian.net/debian/pool/main/l/libx86/libx86_0.99+ds1-1.dsc Ciao, David -- . ''`. Debian maintainer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 | http://snipr.com/qa_page `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: libx86 (adopted package)
Hello, On Sat, 09 Feb 2008, David Paleino wrote: You're right. Thanks for noticing this :) http://mentors.debian.net/debian/pool/main/l/libx86/libx86_0.99+ds1-1.dsc Looks like there is convergence! I'm currently away from my build machine. I'll upload as soon as I get there. Regards, Kapil. -- signature.asc Description: Digital signature
[uploaded] RFS: libx86 (adopted package)
Hello, On Wed, 06 Feb 2008, David Paleino wrote: I am looking for a sponsor for the new version 0.99-2+ds1 of the package libx86, which I want to adopt. On Sat, 09 Feb 2008, David Paleino wrote: http://mentors.debian.net/debian/pool/main/l/libx86/libx86_0.99+ds1-1.dsc Uploaded. Thanks for your work on this package. Please check http://buildd.debian.org/libx86 for further information on the results of buildd's. Regards, Kapil. -- signature.asc Description: Digital signature
Re: [uploaded] RFS: libx86 (adopted package)
Il giorno Sat, 9 Feb 2008 22:45:23 +0530 Kapil Hari Paranjape [EMAIL PROTECTED] ha scritto: Uploaded. Thanks for your work on this package. Thank you for reviewing and uploading it. Kindly, David -- . ''`. Debian maintainer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 | http://snipr.com/qa_page `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: libx86 (adopted package)
Il giorno Fri, 8 Feb 2008 08:38:43 +0530 Kapil Hari Paranjape [EMAIL PROTECTED] ha scritto: Good work. I will examine your package tonight (about 12 hours from now) and tell convey any further suggestions. Thank you, Meanwhile, could you explain the logic behind the version number 0.99-2+ds1. (I suppose one could also look up policy on this but I'm being lazy!) Well. 0.99-2 because the archive already has 0.99-1. The +ds1 part means that it has been repackaged (Debian Source), and 1... well, I didn't like 0.99-2+ds ;) I've looked the Policy, but probably I missed it, and it doesn't explain what version number to use in case of a repackaged source. I've seen lots of versions (results taken from apt-cache dumpavail with some grepping): 0.5.2.1.ds-1.1 4.57~ds.1-1 2.3.0+ds1-1 I think I shouldn't use dfsg either, because it's not been repackaged because of non-free things or the like :) Kindly, David -- . ''`. Debian maintainer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 | http://snipr.com/qa_page `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: libx86 (adopted package)
On Fri, 08 Feb 2008 09:38:15 +0100, David Paleino wrote: Meanwhile, could you explain the logic behind the version number 0.99-2+ds1. (I suppose one could also look up policy on this but I'm being lazy!) Well. 0.99-2 because the archive already has 0.99-1. The +ds1 part means that it has been repackaged (Debian Source), and 1... well, I didn't like 0.99-2+ds ;) If you look at the examples ... 0.5.2.1.ds-1.1 4.57~ds.1-1 2.3.0+ds1-1 ... you see that the [.+~]ds[1] is part of the upstream version and not of the Debian revision (before the - and not after it). So I suggest you use e.g. 0.99+ds-1 for your package. Cheers, gregor -- .''`. http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4 : :' : debian: the universal operating system - http://www.debian.org/ `. `' member of https://www.vibe.at/ | how to reply: http://got.to/quote/ `-NP: Van Morrison signature.asc Description: Digital signature
Re: RFS: libx86 (adopted package)
Il giorno Fri, 8 Feb 2008 09:38:15 +0100 David Paleino [EMAIL PROTECTED] ha scritto: ... Well. 0.99-2 because the archive already has 0.99-1. The +ds1 part means that it has been repackaged (Debian Source), and 1... well, I didn't like 0.99-2+ds ;) ... 0.5.2.1.ds-1.1 4.57~ds.1-1 2.3.0+ds1-1 Now, after some reasoning, I believe that I should use something like 0.99+ds-1, (or 0.99~ds-1, but it results to be lesser than 0.99-1). Any suggestion on what versioning scheme to adopt? (obviously not 0.99~ds-1, since it wouldn't supersede the version in the archive) Kindly, David -- . ''`. Debian maintainer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 | http://snipr.com/qa_page `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: libx86 (adopted package)
Il giorno Fri, 8 Feb 2008 13:44:23 +0100 gregor herrmann [EMAIL PROTECTED] ha scritto: ... So I suggest you use e.g. 0.99+ds-1 for your package. Thank you. A new package is available on m.d.n: http://mentors.debian.net/debian/pool/main/l/libx86/libx86_0.99+ds-1.dsc Kindly, David -- . ''`. Debian maintainer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 | http://snipr.com/qa_page `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: libx86 (adopted package)
Hello, Sorry for the delay in responding. I had less free time than I thought. gregor herrmann [EMAIL PROTECTED] ha scritto: So I suggest you use e.g. 0.99+ds-1 for your package. On Fri, 08 Feb 2008, David Paleino wrote: Now, after some reasoning, I believe that I should use something like 0.99+ds-1, (or 0.99~ds-1, but it results to be lesser than 0.99-1). I understand the ds part. Is there some reason why 0.99.ds1-2 was left out of the choices? This seems to be the practice for packages like sysvinit for example. The .tar.gz would then be named libx86_0.99.ds1.orig.tar.gz which is fine since it is the source which is being re-packaged by Debian. I have not yet done the rest of my review so you may want to wait a while before uploading a new version to mentors. Regards, Kapil. -- signature.asc Description: Digital signature
Re: RFS: libx86 (adopted package)
Hello, On Sat, 09 Feb 2008, Kapil Hari Paranjape wrote: I have not yet done the rest of my review so you may want to wait a while before uploading a new version to mentors. Since you are adding quilt, it is probably a good idea to modify/add the Makefile in a quilt patch. Once you take a decision on this and the name change please upload your file to mentors and I will upload it. Regards, Kapil. -- signature.asc Description: Digital signature
Re: RFS: libx86 (adopted package)
Il giorno Thu, 7 Feb 2008 08:18:44 +0530 Kapil Hari Paranjape [EMAIL PROTECTED] ha scritto: Some remarks: 1. The Ubuntu package seems to have some additional patches are these relevant to Debian? I've merged the Ubuntu patch, and mentioned it in debian/changelog: http://mentors.debian.net/debian/pool/main/l/libx86/libx86_0.99-2+ds1.dsc 2. You should perhaps request upstream author to maintain a clean tarball. I've done it, and also asked if he wants to co-maintain the package (or take it back), so as to reduce the delta between Debian and Ubuntu :) Kindly, David -- . ''`. Debian maintainer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 | http://snipr.com/qa_page `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: libx86 (adopted package)
Hello, On Thu, 07 Feb 2008, David Paleino wrote: I've merged the Ubuntu patch, and mentioned it in debian/changelog: http://mentors.debian.net/debian/pool/main/l/libx86/libx86_0.99-2+ds1.dsc 2. You should perhaps request upstream author to maintain a clean tarball. I've done it, and also asked if he wants to co-maintain the package (or take it back), so as to reduce the delta between Debian and Ubuntu :) Good work. I will examine your package tonight (about 12 hours from now) and tell convey any further suggestions. Meanwhile, could you explain the logic behind the version number 0.99-2+ds1. (I suppose one could also look up policy on this but I'm being lazy!) Regards, Kapil. -- signature.asc Description: Digital signature
RFS: libx86 (adopted package)
Dear mentors, I am looking for a sponsor for the new version 0.99-2+ds1 of the package libx86, which I want to adopt. It builds these binary packages: libx86-1 - x86 real-mode library libx86-dbg - x86 real-mode library - debugging symbols libx86-dev - x86 real-mode library - development files Wrt the previous version, this one has the -dbg package added. Moreover, the source has been repackaged because the upstream tarball contained debian/ and precompiled binaries (which created problems during dpkg-source's diffs) The package is lintian (from unstable) clean. The upload would fix the ITA bug #459900 The package can be found on mentors.debian.net: - dget http://mentors.debian.net/debian/pool/main/l/libx86/libx86_0.99-2+ds1.dsc The package is also maintained under collab-maint: - http://svn.debian.org/wsvn/collab-maint/deb-maint/libx86/trunk/?rev=0sc=0 - svn://svn.debian.org/svn/collab-maint/deb-maint/libx86/trunk/ I would be glad if someone uploaded this package for me. Kind regards David Paleino -- . ''`. Debian maintainer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 | http://snipr.com/qa_page `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: libx86 (adopted package)
Hello, On Wed, 06 Feb 2008, David Paleino wrote: I am looking for a sponsor for the new version 0.99-2+ds1 of the package libx86, which I want to adopt. Thanks for this work. This package is quite important for people with laptops! Some remarks: 1. The Ubuntu package seems to have some additional patches are these relevant to Debian? 2. You should perhaps request upstream author to maintain a clean tarball. Regards, Kapil. -- signature.asc Description: Digital signature
Re: RFS: libx86 (adopted package)
Il giorno Thu, 7 Feb 2008 08:18:44 +0530 Kapil Hari Paranjape [EMAIL PROTECTED] ha scritto: Hello, Hi, On Wed, 06 Feb 2008, David Paleino wrote: I am looking for a sponsor for the new version 0.99-2+ds1 of the package libx86, which I want to adopt. Thanks for this work. This package is quite important for people with laptops! I _do_ have a laptop ;) Some remarks: 1. The Ubuntu package seems to have some additional patches are these relevant to Debian? Yes, they are, I'll add them to the Debian package. Thanks for the pointer! 2. You should perhaps request upstream author to maintain a clean tarball. Well, the package was orphaned because the maintainer seemed MIA. I did not contact him because also the website seemed outdated. Now I see that the Ubuntu changelog is dated Mon, 24 Sep 2007 01:15:59 +0100 (from the same Debian maintainer), thus now I believe that he disregarded the Debian package in favour of Ubuntu's one. I'll write him :) Thank you for your suggestions, David P.S.: please do not CC me, I'm subscribed ;) -- . ''`. Debian maintainer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 | http://snipr.com/qa_page `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
