Bug#988431: RFS: open-invaders/0.3-6 [QA] -- Space Invaders clone

[Hugo Torres]

debian/tests/control has been removed because it does not provide any
useful tests, avoiding errors with autopkgtest.


--
Hugo Torres de Lima
GPG: 4AF1 1173 DCAD 0380 CC43 A5C6 365C 8CEF 4233 E3D8

Sent with ProtonMail Secure Email.

‐‐‐ Original Message ‐‐‐
On Sunday, May 16, 2021 10:46 AM, Adam Borowski  wrote:

> On Wed, May 12, 2021 at 06:38:28PM -0300, Hugo Torres wrote:
> 

> > -   Package name : open-invaders
> > Version : 0.3-6
> > 

> 

> > Changes since the last upload:
> > open-invaders (0.3-6) experimental; urgency=medium
> > .
> > 

> > -   QA upload.
> > -   debian/control:
> > -   Added 'Rules-Requires-Root: no' to source stanza.
> > -   Added Vcs-* URLs to salsa.debian.org.
> > -   Bumped DH level format to 13.
> > -   Bumped Standards-Version to 4.5.1.
> > -   Updated homepage.
> > -   debian/copyright: Updated for format 1.0.
> > -   debian/lintian-overrides: Created for false positive.
> > -   debian/debian/open-invaders-data.docs renamed for open-invaders.docs.
> > -   debian/open-invaders.desktop: Added Keywords.
> > -   debian/patches/doc_directory_commented.patch: Created.
> > -   debian/patches/fix_ftbfs_gcc45.patch: Added header.
> > -   debian/patches/fix_pmask_amd64.patch: Added header.
> > -   debian/patches/format_security.patch: Added date in header.
> > -   debian/rules: Added the DEB_BUILD_MAINT_OPTIONS, 
> > DEB_CXXFLAGS_MAINT_APPEND,
> > DEB_CFLAGS_MAINT_APPEND and DEB_LDFLAGS_MAINT_APPEND variable
> > to improve the GCC hardening.
> > 

> > -   debian/salsa-ci.yml: Added to provide CI tests for Salsa.
> > -   debian/tests/control: Created for basic CI testing.
> > -   debian/upstream/metadata: Created.
> > -   debian/watch:
> > -   Bumped to version 4.
> > -   Updated the source address.
> 

> Alas, the autopkgtest fails -- and is bogus.
> 

> autopkgtest [15:02:01]: test command1: xvfb-run -a open-invaders &
> autopkgtest [15:02:01]: test command1: [---
> /usr/share
> ALSA lib confmisc.c:767:(parse_card) cannot find card '0'
> ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_card_driver 
> returned error: No such file or directory
> ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
> ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_concat returned 
> error: No such file or directory
> ALSA lib confmisc.c:1246:(snd_func_refer) error evaluating name
> ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_refer returned 
> error: No such file or directory
> ALSA lib conf.c:5233:(snd_config_expand) Evaluate error: No such file or 
> directory
> ALSA lib pcm.c:2660:(snd_pcm_open_noupdate) Unknown PCM default
> autopkgtest [15:02:01]: test command1: ---]
> autopkgtest [15:02:01]: test command1: - - - - - - - - - - results - - - - - 
> - - - - -
> command1 FAIL stderr: ALSA lib confmisc.c:767:(parse_card) cannot find card 
> '0'
> autopkgtest [15:02:01]: test command1: - - - - - - - - - - stderr - - - - - - 
> - - - -
> ALSA lib confmisc.c:767:(parse_card) cannot find card '0'
> ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_card_driver 
> returned error: No such file or directory
> ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
> ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_concat returned 
> error: No such file or directory
> ALSA lib confmisc.c:1246:(snd_func_refer) error evaluating name
> ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_refer returned 
> error: No such file or directory
> ALSA lib conf.c:5233:(snd_config_expand) Evaluate error: No such file or 
> directory
> ALSA lib pcm.c:2660:(snd_pcm_open_noupdate) Unknown PCM default
> autopkgtest [15:02:01]:  summary
> command1 FAIL stderr: ALSA lib confmisc.c:767:(parse_card) cannot find card 
> '0'
> 

> But that failure happened only due to luck. The '&' at the end stops
> most of errors from causing a failure, even "Test-Command: false &"
> succeeds.
> 

> Meow!
> 

> --
> ⢀⣴⠾⠻⢶⣦⠀ The oldest dated printed book includes the following license grant:
> ⣾⠁⢠⠒⠀⣿⡁ Reverently made for universal free distribution by Wang Jie
> ⢿⡄⠘⠷⠚⠋⠀ on behalf of his two parents on the 15th of the 4th moon of
> ⠈⠳⣄ the 9th year of Xiantong [11 May 868].



signature.asc
Description: OpenPGP digital signature

Bug#988431: RFS: open-invaders/0.3-6 [QA] -- Space Invaders clone

[Adam Borowski]

On Wed, May 12, 2021 at 06:38:28PM -0300, Hugo Torres wrote:
>  * Package name: open-invaders
>Version : 0.3-6

> Changes since the last upload:
> 
>  open-invaders (0.3-6) experimental; urgency=medium
>  .
>* QA upload.
>* debian/control:
>- Added 'Rules-Requires-Root: no' to source stanza.
>- Added Vcs-* URLs to salsa.debian.org.
>- Bumped DH level format to 13.
>- Bumped Standards-Version to 4.5.1.
>- Updated homepage.
>* debian/copyright: Updated for format 1.0.
>* debian/lintian-overrides: Created for false positive.
>* debian/debian/open-invaders-data.docs renamed for open-invaders.docs.
>* debian/open-invaders.desktop: Added Keywords.
>* debian/patches/doc_directory_commented.patch: Created.
>* debian/patches/fix_ftbfs_gcc45.patch: Added header.
>* debian/patches/fix_pmask_amd64.patch: Added header.
>* debian/patches/format_security.patch: Added date in header.
>* debian/rules: Added the DEB_BUILD_MAINT_OPTIONS, 
> DEB_CXXFLAGS_MAINT_APPEND,
>DEB_CFLAGS_MAINT_APPEND and DEB_LDFLAGS_MAINT_APPEND 
> variable
>to improve the GCC hardening.
>* debian/salsa-ci.yml: Added to provide CI tests for Salsa.
>* debian/tests/control: Created for basic CI testing.
>* debian/upstream/metadata: Created.
>* debian/watch:
>- Bumped to version 4.
>- Updated the source address.

Alas, the autopkgtest fails -- and is bogus.

autopkgtest [15:02:01]: test command1: xvfb-run -a open-invaders &
autopkgtest [15:02:01]: test command1: [---
/usr/share
ALSA lib confmisc.c:767:(parse_card) cannot find card '0'
ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_card_driver 
returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_concat returned 
error: No such file or directory
ALSA lib confmisc.c:1246:(snd_func_refer) error evaluating name
ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_refer returned 
error: No such file or directory
ALSA lib conf.c:5233:(snd_config_expand) Evaluate error: No such file or 
directory
ALSA lib pcm.c:2660:(snd_pcm_open_noupdate) Unknown PCM default
autopkgtest [15:02:01]: test command1: ---]
autopkgtest [15:02:01]: test command1:  - - - - - - - - - - results - - - - - - 
- - - -
command1 FAIL stderr: ALSA lib confmisc.c:767:(parse_card) cannot 
find card '0'
autopkgtest [15:02:01]: test command1:  - - - - - - - - - - stderr - - - - - - 
- - - -
ALSA lib confmisc.c:767:(parse_card) cannot find card '0'
ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_card_driver 
returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_concat returned 
error: No such file or directory
ALSA lib confmisc.c:1246:(snd_func_refer) error evaluating name
ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_refer returned 
error: No such file or directory
ALSA lib conf.c:5233:(snd_config_expand) Evaluate error: No such file or 
directory
ALSA lib pcm.c:2660:(snd_pcm_open_noupdate) Unknown PCM default
autopkgtest [15:02:01]:  summary
command1 FAIL stderr: ALSA lib confmisc.c:767:(parse_card) cannot 
find card '0'

But that failure happened only due to luck.  The '&' at the end stops
most of errors from causing a failure, even "Test-Command: false &"
succeeds.


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀ The oldest dated printed book includes the following license grant:
⣾⠁⢠⠒⠀⣿⡁   Reverently made for universal free distribution by Wang Jie
⢿⡄⠘⠷⠚⠋⠀   on behalf of his two parents on the 15th of the 4th moon of
⠈⠳⣄   the 9th year of Xiantong [11 May 868].

Bug#988431: RFS: open-invaders/0.3-6 [QA] -- Space Invaders clone

[Hugo Torres]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "open-invaders":

 * Package name: open-invaders
   Version : 0.3-6
   Upstream Author : Darryl LeCount 
 * URL : https://sourceforge.net/projects/open-invaders
 * License : GPL-2+
 * Vcs : https://salsa.debian.org/debian/open-invaders
   Section : games

It builds those binary packages:

  open-invaders - Space Invaders clone
  open-invaders-data - Space Invaders clone (data package)

To access further information about this package, please visit the following 
URL:

  https://mentors.debian.net/package/open-invaders/

Alternatively, one can download the package with dget using this command:

  dget -x 
https://mentors.debian.net/debian/pool/main/o/open-invaders/open-invaders_0.3-6.dsc

Changes since the last upload:

 open-invaders (0.3-6) experimental; urgency=medium
 .
   * QA upload.
   * debian/control:
   - Added 'Rules-Requires-Root: no' to source stanza.
   - Added Vcs-* URLs to salsa.debian.org.
   - Bumped DH level format to 13.
   - Bumped Standards-Version to 4.5.1.
   - Updated homepage.
   * debian/copyright: Updated for format 1.0.
   * debian/lintian-overrides: Created for false positive.
   * debian/debian/open-invaders-data.docs renamed for open-invaders.docs.
   * debian/open-invaders.desktop: Added Keywords.
   * debian/patches/doc_directory_commented.patch: Created.
   * debian/patches/fix_ftbfs_gcc45.patch: Added header.
   * debian/patches/fix_pmask_amd64.patch: Added header.
   * debian/patches/format_security.patch: Added date in header.
   * debian/rules: Added the DEB_BUILD_MAINT_OPTIONS, DEB_CXXFLAGS_MAINT_APPEND,
   DEB_CFLAGS_MAINT_APPEND and DEB_LDFLAGS_MAINT_APPEND variable
   to improve the GCC hardening.
   * debian/salsa-ci.yml: Added to provide CI tests for Salsa.
   * debian/tests/control: Created for basic CI testing.
   * debian/upstream/metadata: Created.
   * debian/watch:
   - Bumped to version 4.
   - Updated the source address.

Regards,
--
  Hugo Torres de Lima

Bug#834268: marked as done (RFS: open-invaders/0.3-5 [ITA])

[Debian Bug Tracking System]

Your message dated Wed, 28 Sep 2016 04:26:17 +
with message-id <e1bp6rl-0001bm...@quantz.debian.org>
and subject line closing RFS: open-invaders/0.3-5 [ITA]
has caused the Debian Bug report #834268,
regarding RFS: open-invaders/0.3-5 [ITA]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
834268: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=834268
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: sponsorship-requests
Severity: normal

Dear mentors,
  
I am looking for a sponsor for my package "open-invaders"
  
   * Package name: open-invaders
 Version : 0.3-5
 Upstream Author : Darryl LeCount <dar...@jamyskis.net>
   * URL : http://www.jamyskis.net/invaders.php
   * License : GPLv2
 Section : games
  
It builds those binary packages:

  open-invaders - Space Invaders clone
  open-invaders-data - Space Invaders clone (data package)
 
To access further information about this package, please visit the
following URL:
   
  https://mentors.debian.net/package/open-invaders

Alternatively, one can download the package with dget using this command:

 dget -x  
https://mentors.debian.net/debian/pool/main/o/open-invaders/open-invaders_0.3-5.dsc

More information about open-invaders has been able to be obtained from
the URL mentioned above, but apparently this website is down since
some time and is misused in the meantime.

Changes since the last upload:  Fixed Type-Incompatibility g++-old and
g++-new, taking over Maintainership after the package has been orphaned.
 
Regards,
Hanno 'Rince' Wagner
-- 
|  Hanno Wagner  | Member of the HTML Writers Guild  | Rince@IRC  |
| Eine gewerbliche Nutzung meiner Email-Adressen ist nicht gestattet! |
| 74 a3 53 cc 0b 19 - we did it!  |Generation @   |

#"Eine Zensur findet nicht statt..."   "... ausser wenn sie doch stattfindet."
#   -- Vorgeschlagene Aenderung des Grundgesetzes
--- End Message ---
--- Begin Message ---
Package open-invaders has been removed from mentors.--- End Message ---

Bug#834268: RFS: open-invaders/0.3-5 [NMU] [ITA]

[Adam Borowski]

On Wed, Aug 17, 2016 at 10:59:46PM +0200, Hanno 'Rince' Wagner wrote:
> I am packaging open-invaders, a clone of space invaders. I was able to
> "port" it (with a lot of help from friends) to gcc-6, but I have a
> problem with the used libraries.
> 
> I am able to successfully compile and package open-invaders. But when
> I want to start it, the initialization of allegro4 seems to fail:
> 
> [~]$ open-invaders 
> /usr/share
> Segmentation fault
> 
> 
> I used gdb and found that open-invaders crashed while initializing
> allegro:
> 
> (gdb) run
> Starting program: /usr/share/open-invaders/open-invaders 
> [Thread debugging using libthread_db enabled]
> Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
> /usr/share
> [New Thread 0x7433a700 (LWP 7044)]
> [Thread 0x7433a700 (LWP 7044) exited]
> 
> Thread 1 "open-invaders" received signal SIGSEGV, Segmentation fault.
> 0x77704cc7 in install_timer () from 
> /usr/lib/x86_64-linux-gnu/liballeg.so.4.4
> (gdb) bt
> #0  0x77704cc7 in install_timer () from 
> /usr/lib/x86_64-linux-gnu/liballeg.so.4.4
> #1  0xfbd5 in initialise_game () at init.cc:521
> #2  0x74f4 in main (argc=1, argv=0x7fffe668) at main.cc:81
> (gdb) 

My splat is different:

[~]$ open-invaders
/usr/share
Allegro initialised...
Loading graphics...
Fatal error: Could not load file ship.pcx
Fatal error: Could not load file invader_top.pcx
Aborted (core dumped)

#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:58
#1  0x7f679d2c740a in __GI_abort () at abort.c:89
#2  0x7f679df90101 in ?? () from /usr/lib/x86_64-linux-gnu/liballeg.so.4.4
#3  
#4  0x7f679def975e in blit () from /usr/lib/x86_64-linux-gnu/liballeg.so.4.4
#5  0x565519e152db in load_data_files () at init.cc:92
#6  0x565519e0f8af in define_sprites () at graphics.cc:317
#7  0x565519e08377 in main (argc=1, argv=0x7ffdfb9aba98) at main.cc:89

Curiously, when you start the game from the directory you have unpacked the
sources to, it does work.  As if, it tried to load sprites from the current
dir.  Could that be?

.--[ src/init.cc lines 619..642 ]
BITMAP *oi_load_graphic(std::string filename, std::string defsymbol)
{
BITMAP *loaded_graphic;
ostringstream filenamebuffer;

filenamebuffer << "./data/" << filename;

loaded_graphic=load_bitmap(filenamebuffer.str().c_str(),NULL);

#ifdef ALLEGRO_LINUX
if(!loaded_graphic)
{
loaded_graphic=load_bitmap(defsymbol.c_str(), NULL);
}
#endif  
 
if(!loaded_graphic)
{
cout << "Fatal error: Could not load file " << filename << "\n";
return NULL;
}
 
return loaded_graphic;
}
`

and the part that dies is:
.--[ src/init.cc lines 81..93 ]
  switch(aliens)
  {
  case 0: 
alienbuffer=oi_load_graphic("invader_top.pcx",GFX_ALIEN_TOP); break;
  case 1: 
alienbuffer=oi_load_graphic("invader_middle.pcx",GFX_ALIEN_MIDDLE); break;
  case 2: 
alienbuffer=oi_load_graphic("invader_bottom.pcx",GFX_ALIEN_BOTTOM); break;
  case 3: 
alienbuffer=oi_load_graphic("invader_bottom.pcx",GFX_ALIEN_BOTTOM); break;
  }
 
  for(int animframes=0; animframes<3; animframes++)
  {
  alien[aliens][animframes]=create_bitmap(64,64);
splat here--> 
blit(alienbuffer,alien[aliens][animframes],animframes*64,0,0,0,64,64);
  }
`

Thus:
1.  please make the part that says "Fatal" indeed fatal; returning NULL does
nothing good if the return value never gets checked.  It'd be good to die
immediately, gracefully restoring the screen resolution.  At least XFCE and
Gnome 2[1] completely lose your screen setup in this case, I guess most if
not all of other window managers fail in similar ways.  I need to manually
restore the resolution, turn on the other monitor, set the correct one as
primary, re-configure their layout, etc.  Not nice.

2. you install everything (sprites and sounds) to /usr/share/open-invaders/
rather than ./data/, please make the code use packaged paths.


Meow!

[1]. I'm too lazy to check how others handle such failures these days.
-- 
Second "wet cat laying down on a powered-on box-less SoC on the desk" close
shave in a week.  Protect your ARMs, folks!

Re: Bug#834268: RFS: open-invaders/0.3-5 [NMU] [ITA]

[James Cowgill]

Hi,

On 17/08/16 21:59, Hanno 'Rince' Wagner wrote:
> I am packaging open-invaders, a clone of space invaders. I was able to
> "port" it (with a lot of help from friends) to gcc-6, but I have a
> problem with the used libraries.
> 
> I am able to successfully compile and package open-invaders. But when
> I want to start it, the initialization of allegro4 seems to fail:
> 
> [~]$ open-invaders 
> /usr/share
> Segmentation fault

I cannot reproduce this. Your package on mentors runs fine for me.

> I used gdb and found that open-invaders crashed while initializing
> allegro:
[...]
> Thread 1 "open-invaders" received signal SIGSEGV, Segmentation fault.
> 0x77704cc7 in install_timer () from 
> /usr/lib/x86_64-linux-gnu/liballeg.so.4.4
> (gdb) bt
> #0  0x77704cc7 in install_timer () from 
> /usr/lib/x86_64-linux-gnu/liballeg.so.4.4
> #1  0xfbd5 in initialise_game () at init.cc:521
> #2  0x74f4 in main (argc=1, argv=0x7fffe668) at main.cc:81
> (gdb) 

Install liballeggl4.4-dbgsym from the debug repository [1] and then use
'bt full' to get a full backtrace which should have much more
information about the segfault.

Also, do other allegro4 games work for you?
$ apt-cache rdepends liballegro4.4

[1] https://wiki.debian.org/AutomaticDebugPackages

Thanks,
James



signature.asc
Description: OpenPGP digital signature

Bug#834268: RFS: open-invaders/0.3-5 [NMU] [ITA]

[Adam Borowski]

On Sat, Aug 13, 2016 at 11:33:05PM +0200, Hanno 'Rince' Wagner wrote:
> I am looking for a sponsor for my package "open-invaders"
>   
>* Package name: open-invaders
>  Version : 0.3-5
> 
>  dget -x  
> https://mentors.debian.net/debian/pool/main/o/open-invaders/open-invaders_0.3-5.dsc

> Changes since the last upload:Fixed Type-Incompatibility g++-old and
> g++-new, taking over Maintainership after the package has been orphaned.

This is an ITA rather than a NMU.  Also, as 0.3-4.2 didn't happen, please
merge the two changelog entries, preferably to:
,--
open-invaders (0.3-5) unstable; urgency=low

  * New maintainer (Closes: #826461)
  * clean declaration and casts (Closes: #811654)

 -- Hanno 'Rince' Wagner   Sat, 13 Aug 2016 18:12:33 +0100
`


Alas, there's one "small" detail:

[~]$ open-invaders 
/usr/share
Allegro initialised...
Loading graphics...
Fatal error: Could not load file ship.pcx
Fatal error: Could not load file invader_top.pcx
Aborted (core dumped)

... and it leaves me with a bad screen resolution.


-- 
An imaginary friend squared is a real enemy.

Re: RFS: open-invaders

[Siegfried-Angel]

Hi,

Thanks for looking at it Alexander, and sorry that I did not answer
before but I wasn't subscribed to this list and so did not see your
reply before.

I fixed everything you said (it's online on mentors.deban.net [1])
except point 3, that one about the architecture independent stuff. You
mean that the data should be in a separate binary package
(open-invaders-data)?

If so, could you appoint me to a tutorial on how to do that? (I looked
at the contents of the Debian New Maintainer's Guide but it doesn't
look like there's anything related to that). Also, currently the game
is only building on i386 (upstream author promised to fix that, but it
may still need some time), so is this necessary now?

[1] http://mentors.debian.net/debian/pool/main/o/open-invaders/

Thanks again,

Siegfried-Angel Gevatter Pujals (RainCT)


On 18 Jul, 17:20, Alexander Schmehl [EMAIL PROTECTED] wrote:
 Hi!

 * Siegfried-Angel [EMAIL PROTECTED] [070705 22:18]:

  * Package name: open-invaders
   Version   : 0.2-1
   Upstream Author : Darryl LeCount
  * URL   :http://www.jamyskis.net/invaders.php
  * License   : GPLv2
   Section   : games

 Problems with your package:

 - Binary is installed to /usr/bin/open-invaders, but should be
   /usr/games
 - Data ist installed to /usr/share/open-invaders/, but should be
   /usr/share/games/open-invaders/
 - You install 3.1 MB of arch independent stuff which should go in a
   sepperate arch:all package
 - Your package contains /usr/include/
 - In your debian/rules you should replace -$(MAKE) distclean with [ ! -f
   Makefile ] || $(MAKE) distclean (as lintian would have told you)

 Rest seemst fine.  If you fix those, I'll upload your package.

 Yours sincerely,
   Alexander


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Re: RFS: open-invaders

[Justin Pryzby]

On Tue, Jul 31, 2007 at 03:33:40PM +0200, Siegfried-Angel wrote:
 Hi,
 
 Thanks for looking at it Alexander, and sorry that I did not answer
 before but I wasn't subscribed to this list and so did not see your
 reply before.
 
 I fixed everything you said (it's online on mentors.deban.net [1])
 except point 3, that one about the architecture independent stuff. You
 mean that the data should be in a separate binary package
 (open-invaders-data)?
 
 If so, could you appoint me to a tutorial on how to do that? (I looked
 at the contents of the Debian New Maintainer's Guide but it doesn't
 look like there's anything related to that). Also, currently the game
 is only building on i386 (upstream author promised to fix that, but it
 may still need some time), so is this necessary now?
Maybe this will help?
http://lists.debian.org/debian-mentors/2005/11/msg00042.html

Or check some multiple-binary packages [0], or just the
./debian/control output of dh_make m.

The architecture problems are kind of disappointing..

Justin

[0] Ones for which there are multiple Binary packages listed for the
given source Package in apt-cache showsrc output.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Re: RFS: open-invaders

[Alexander Schmehl]

Hi!

* Siegfried-Angel [EMAIL PROTECTED] [070731 15:33]:

 I fixed everything you said (it's online on mentors.deban.net [1])
 except point 3, that one about the architecture independent stuff. You
 mean that the data should be in a separate binary package
 (open-invaders-data)?

Yes... Debian is shipped with 11 different architectures (even more if
you count the inofficial / upcoming architectures, too).

Now let's do a small estimation:  3MB architecture independent Stuff, 11
architectures, that are 30MB wasted disc space.  500 Mirrors... you just
wasted 15 GB Traffic ;)


 If so, could you appoint me to a tutorial on how to do that? (I looked
 at the contents of the Debian New Maintainer's Guide but it doesn't
 look like there's anything related to that).

Uhm... actually I'm not sure of an howto... will put it on my todo-List
to create one ;)

But actually it's quite simple: First you need to add a description for
the -data Package to debian/control and set proper package
relationships, than you tweak your debian/rules so that the arch
independent stuff is installed to the -data package.

Easiest might be you take a look at the ppracer package as example:
http://svn.debian.org/wsvn/pkg-games/packages/trunk/ppracer/debian/control?op=filerev=0sc=0
http://svn.debian.org/wsvn/pkg-games/packages/trunk/ppracer/debian/rules?op=filerev=0sc=0

That package builds two additional arch independent packages, and has
(hopefully) an easy to understand rules, but feel free to ask questions
:)


 Also, currently the game is only building on i386 (upstream author
 promised to fix that, but it may still need some time), so is this
 necessary now?

Oh, good point.  Missed that... would sponsor your package, but your
current approach doesn't work.

Did you test your game?  It doesn't find it's data files, now that you
just moved them away.

So, your new todo list:
 - Use some proper ./configure-flags instead of moving files around
   (Hint: Either take a look at ./configure --help or play with relative
   path to parent directories for mandir and docdir, and use an absolute
   path for bindir.)
 - You need to review your debian/dirs
   (Removing directories manually in debian/rules, after you added them
   do debian/dirs doesn't sound very logic; perhaps you just remove
   debian/dirs complelty)
 - BTW:  Did you asked upstream, why his makefile installs the header
   files?  Seems so wrong to me, perhaps it's just some kind of bug?


Yours sincerely,
  Alexander


signature.asc
Description: Digital signature

Re: RFS: open-invaders

[Alexander Schmehl]

Hi!

* Siegfried-Angel [EMAIL PROTECTED] [070705 22:18]:

 * Package name: open-invaders
  Version   : 0.2-1
  Upstream Author : Darryl LeCount
 * URL   : http://www.jamyskis.net/invaders.php
 * License   : GPLv2
  Section   : games

Problems with your package:

- Binary is installed to /usr/bin/open-invaders, but should be
  /usr/games
- Data ist installed to /usr/share/open-invaders/, but should be
  /usr/share/games/open-invaders/
- You install 3.1 MB of arch independent stuff which should go in a
  sepperate arch:all package
- Your package contains /usr/include/
- In your debian/rules you should replace -$(MAKE) distclean with [ ! -f
  Makefile ] || $(MAKE) distclean (as lintian would have told you)

Rest seemst fine.  If you fix those, I'll upload your package.


Yours sincerely,
  Alexander

-- 
http://learn.to/quote/
http://www.catb.org/~esr/faqs/smart-questions.html


signature.asc
Description: Digital signature

RFS: open-invaders

[Siegfried-Angel]

Dear mentors,

I am looking for a sponsor for my package open-invaders.

* Package name: open-invaders
 Version   : 0.2-1
 Upstream Author : Darryl LeCount
* URL   : http://www.jamyskis.net/invaders.php
* License   : GPLv2
 Section   : games

It builds these binary packages:
open-invaders - Space Invaders clone

The package appears to be lintian clean.

The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/o/open-invaders
- Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- dget 
http://mentors.debian.net/debian/pool/main/o/open-invaders/open-invaders_0.2-1.dsc

I would be glad if someone uploaded this package for me.

Kind regards
Siegfried-Angel Gevatter Pujals (RainCT)


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Re: RFS: open-invaders

[Joseph Nahmias]

On Thu, Jul 05, 2007 at 10:18:29PM +0200, Siegfried-Angel wrote:
 Dear mentors,
 
 I am looking for a sponsor for my package open-invaders.
 
 * Package name: open-invaders
  Version   : 0.2-1
  Upstream Author : Darryl LeCount
 * URL   : http://www.jamyskis.net/invaders.php
 * License   : GPLv2
  Section   : games
 
 It builds these binary packages:
 open-invaders - Space Invaders clone
[snip]

A few questions just from the RFS notice:

Is this a new package?  If so, there should be an ITP which is closed in
the changelog.  If there isn't one, please create one and ensure the bug
is closed in the changelog.

--Joe


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]