Re: RFS: python-mplayer

2012-01-02 Thread Jakub Wilk

* Olivier Schwander olivier.schwan...@chadok.info, 2011-12-30, 17:28:
I'd recommend using the upstream name (mplayer.py) for the source 
package name.


The upstream author seems to change the name of the project nearly at 
each release but, ok, I'll try to stick to it.


Actually it seems I can't commit a rename of the project directory in 
the repository ? I get Authorization failed.


That's weird. I did the rename for you (r19840).


The module doesn't handle filenames with special characters correctly:
|  mplayer.Player('eggsham.avi')
| Traceback (most recent call last):
|   File stdin, line 1, in module
|   File /usr/lib/python2.7/dist-packages/mplayer/core.py, line 102, in 
__init__
| self.args = args
|   File /usr/lib/python2.7/dist-packages/mplayer/core.py, line 142, in args
| args = shlex.split(args)
|   File /usr/lib/python2.7/shlex.py, line 279, in split
| return list(lex)
|   File /usr/lib/python2.7/shlex.py, line 269, in next
| token = self.get_token()
|   File /usr/lib/python2.7/shlex.py, line 96, in get_token
| raw = self.read_token()
|   File /usr/lib/python2.7/shlex.py, line 172, in read_token
| raise ValueError, No closing quotation
| ValueError: No closing quotation


It works well for me. What are your python and mplayer version ?


$ dpkg-query -W python2.7 mplayer
mplayer 2:1.0~rc4.dfsg1+svn33713-5
python2.7   2.7.2-9

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120102224308.ga4...@jwilk.net



Re: RFS: python-mplayer

2011-12-30 Thread Olivier Schwander
Le 18 Dec 2011 23:12, Jakub Wilk a écrit:
 (I don't intend to sponsor this package.)
 
 I'd recommend using the upstream name (mplayer.py) for the source
 package name.

The upstream author seems to change the name of the project nearly at
each release but, ok, I'll try to stick to it.

Actually it seems I can't commit a rename of the project directory in
the repository ? I get Authorization failed.

 Unless there's a compelling reason not do so, I'd merge both
 changelog entries into one.

Ok.

 What is the debian/python-module-stampdir directory for?

It seems to have been auto-generated by some tools and added by mistake
to the repository. Removed.

 Why Priority: extra?

Changed to optional.

 It should be mplayer (= 1.0~rc3) rather than mplayer (= 1.0rc3).

Ok.

 Architecture should be all, not any.

Ok.

 ${shlibs:Depends} can be removed from Depends, it's unused.

Removed.

 The module doesn't handle filenames with special characters correctly:
 |  mplayer.Player('eggsham.avi')
 | Traceback (most recent call last):
 |   File stdin, line 1, in module
 |   File /usr/lib/python2.7/dist-packages/mplayer/core.py, line 102, in 
 __init__
 | self.args = args
 |   File /usr/lib/python2.7/dist-packages/mplayer/core.py, line 142, in args
 | args = shlex.split(args)
 |   File /usr/lib/python2.7/shlex.py, line 279, in split
 | return list(lex)
 |   File /usr/lib/python2.7/shlex.py, line 269, in next
 | token = self.get_token()
 |   File /usr/lib/python2.7/shlex.py, line 96, in get_token
 | raw = self.read_token()
 |   File /usr/lib/python2.7/shlex.py, line 172, in read_token
 | raise ValueError, No closing quotation
 | ValueError: No closing quotation

It works well for me. What are your python and mplayer version ?

 It looks like upstream supports also Python 3.X. Please consider
 supporting it in Debian, too (in a separate binary package,
 python3-mplayer).

Ok, I'll have a look to that.

 The comment at the top of debian/rules doesn't make sense.

Ok.

Thank you very much for your comments. I just committed the updates to
the repository.

Best,

Olivier



-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20111230162839.ga3...@bugaga.lan



RFS: python-mplayer

2011-12-18 Thread Olivier Schwander
Dear mentors and Python modules team,

I am looking for sponsorship and reviews for my package
python-mplayer.

 * Package name: python-mplayer
   Version : 0.7.0-1
   Upstream Author : Darwin M. Bautista
 * URL : http://code.google.com/p/python-mplayer/
 * License : LGPL-3.0
   Section : python

It builds those binary packages:

python-mplayer - Lightweight and dynamic MPlayer wrapper with a Pythonic
API

To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/python-mplayer

Alternatively, one can download the package with dget using this
command:

  dget -x
  
http://mentors.debian.net/debian/pool/main/p/python-mplayer/python-mplayer_0.7.0-1.dsc

The package is also available from the DPMT repository:

  svn://svn.debian.org/python-modules/packages/python-mplayer/trunk/

or

  http://anonscm.debian.org/viewvc/python-modules/packages/python-mplayer/trunk/

Best regards,

Olivier Schwander


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20111218133410.ga10...@bugaga.lan



Re: RFS: python-mplayer

2011-12-18 Thread Jakub Wilk

(I don't intend to sponsor this package.)

* Olivier Schwander olivier.schwan...@ens-lyon.org, 2011-12-18, 14:34:

 http://mentors.debian.net/package/python-mplayer

Alternatively, one can download the package with dget using this
command:

 dget -x
 
http://mentors.debian.net/debian/pool/main/p/python-mplayer/python-mplayer_0.7.0-1.dsc


I'd recommend using the upstream name (mplayer.py) for the source 
package name.


Unless there's a compelling reason not do so, I'd merge both changelog 
entries into one.


What is the debian/python-module-stampdir directory for?

Why Priority: extra?

It should be mplayer (= 1.0~rc3) rather than mplayer (= 1.0rc3).

Architecture should be all, not any.

${shlibs:Depends} can be removed from Depends, it's unused.

The module doesn't handle filenames with special characters correctly:
|  mplayer.Player('eggsham.avi')
| Traceback (most recent call last):
|   File stdin, line 1, in module
|   File /usr/lib/python2.7/dist-packages/mplayer/core.py, line 102, in 
__init__
| self.args = args
|   File /usr/lib/python2.7/dist-packages/mplayer/core.py, line 142, in args
| args = shlex.split(args)
|   File /usr/lib/python2.7/shlex.py, line 279, in split
| return list(lex)
|   File /usr/lib/python2.7/shlex.py, line 269, in next
| token = self.get_token()
|   File /usr/lib/python2.7/shlex.py, line 96, in get_token
| raw = self.read_token()
|   File /usr/lib/python2.7/shlex.py, line 172, in read_token
| raise ValueError, No closing quotation
| ValueError: No closing quotation

It looks like upstream supports also Python 3.X. Please consider 
supporting it in Debian, too (in a separate binary package, 
python3-mplayer).


The comment at the top of debian/rules doesn't make sense.

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20111218221258.ga6...@jwilk.net