Re: RFS: s3ql (new python application)

2011-06-30 Thread Kilian Krause
Nikolaus,

On Wed, 2011-06-29 at 21:09 -0400, Nikolaus Rath wrote:
 On 06/29/2011 09:37 AM, Kilian Krause wrote:
  2. You symlink your contrib scripts from /usr/share/doc (!)
  into /usr/bin which is not really the best solution out there. Please
  decide whether these shall either go as examples (and not symlinked
  to /usr/bin/) or whether they are official applications - in which case
  they don't belong into /usr/share/doc.
 
  Well, I think they are certainly not examples. I would be fine to put
  expire_backups and pcp into /usr/bin, but I think that benchmark.py and
  make_dummy.py are relatively unlikely to be called in day to day use, so
  I am hesitant to put them there.
 
  How about putting the former into /usr/bin and symlinking them from
  /usr/share/doc/s3ql/contrib (i.e., to the links the other way around)?
  
  If it's not share/doc/s3ql but share/s3ql I'm perfectly agreed with your
  proposal. ;-)
 
 Ok, new package is on mentors:
 dget http://mentors.debian.net/debian/pool/main/s/s3ql/s3ql_1.0.1-2.dsc

thanks!
Built, signed, uploaded.

-- 
Cheers,
Kilian


signature.asc
Description: This is a digitally signed message part


Re: RFS: s3ql (new python application)

2011-06-29 Thread Kilian Krause
Nikolaus,

On Tue, 2011-06-28 at 14:56 -0400, Nikolaus Rath wrote:
 dget http://mentors.debian.net/debian/pool/main/s/s3ql/s3ql_1.0.1-1.dsc

thanks for the update.

1. Regarding the example scrips you ship I'm sort of undecided whether
they would actually fit better in examples rather than contrib. I
guess yes.

 usr/share/doc/s3ql/contrib/benchmark.py
 usr/share/doc/s3ql/contrib/expire_backups.py
 usr/share/doc/s3ql/contrib/make_dummy.py
 usr/share/doc/s3ql/contrib/pcp.py
 usr/share/doc/s3ql/contrib/s3ql_backup.sh

2. You symlink your contrib scripts from /usr/share/doc (!)
into /usr/bin which is not really the best solution out there. Please
decide whether these shall either go as examples (and not symlinked
to /usr/bin/) or whether they are official applications - in which case
they don't belong into /usr/share/doc.

Anyway, built, signed, uploaded.

As we'll be landing in NEW anyway, please prepare any new upload with
1.0.1-2 version fixing these bugs. We don't even need to wait until
we'll be accepted from NEW into main to push this into incoming.

Thanks!

-- 
Cheers,
Kilian


signature.asc
Description: This is a digitally signed message part


Re: RFS: s3ql (new python application)

2011-06-29 Thread Kilian Krause
Hi Nikolaus,

On Wed, 2011-06-29 at 09:30 -0400, Nikolaus Rath wrote:
 On 06/29/2011 03:02 AM, Kilian Krause wrote:
  Nikolaus,
  
  On Tue, 2011-06-28 at 14:56 -0400, Nikolaus Rath wrote:
  dget http://mentors.debian.net/debian/pool/main/s/s3ql/s3ql_1.0.1-1.dsc
  
  thanks for the update.
  
  1. Regarding the example scrips you ship I'm sort of undecided whether
  they would actually fit better in examples rather than contrib. I
  guess yes.
  
   usr/share/doc/s3ql/contrib/benchmark.py
   usr/share/doc/s3ql/contrib/expire_backups.py
   usr/share/doc/s3ql/contrib/make_dummy.py
   usr/share/doc/s3ql/contrib/pcp.py
 
 I don't quite agree. These are not examples of any sort, but programs
 that can be useful in combination with S3QL.

Then they are IMHO still wrong in *DOC* and belong into /usr/share/s3ql
(instead of /usr/share/doc/s3ql) - with or without a symlink
to /usr/bin.


   usr/share/doc/s3ql/contrib/s3ql_backup.sh
 
 This could arguably be called an example, yes. But I think it would be
 nice to stick with the upstream layout (where all these are in contrib),
 so that people can use e.g. the online documentation (which explicitly
 refers to scripts in contrib).

in contrib under doc/?


  2. You symlink your contrib scripts from /usr/share/doc (!)
  into /usr/bin which is not really the best solution out there. Please
  decide whether these shall either go as examples (and not symlinked
  to /usr/bin/) or whether they are official applications - in which case
  they don't belong into /usr/share/doc.
 
 Well, I think they are certainly not examples. I would be fine to put
 expire_backups and pcp into /usr/bin, but I think that benchmark.py and
 make_dummy.py are relatively unlikely to be called in day to day use, so
 I am hesitant to put them there.
 
 How about putting the former into /usr/bin and symlinking them from
 /usr/share/doc/s3ql/contrib (i.e., to the links the other way around)?

If it's not share/doc/s3ql but share/s3ql I'm perfectly agreed with your
proposal. ;-)


-- 
Best regards,
Kilian


signature.asc
Description: This is a digitally signed message part


Re: RFS: s3ql (new python application)

2011-06-29 Thread Nikolaus Rath
On 06/29/2011 03:02 AM, Kilian Krause wrote:
 Nikolaus,
 
 On Tue, 2011-06-28 at 14:56 -0400, Nikolaus Rath wrote:
 dget http://mentors.debian.net/debian/pool/main/s/s3ql/s3ql_1.0.1-1.dsc
 
 thanks for the update.
 
 1. Regarding the example scrips you ship I'm sort of undecided whether
 they would actually fit better in examples rather than contrib. I
 guess yes.
 
  usr/share/doc/s3ql/contrib/benchmark.py
  usr/share/doc/s3ql/contrib/expire_backups.py
  usr/share/doc/s3ql/contrib/make_dummy.py
  usr/share/doc/s3ql/contrib/pcp.py

I don't quite agree. These are not examples of any sort, but programs
that can be useful in combination with S3QL.

  usr/share/doc/s3ql/contrib/s3ql_backup.sh

This could arguably be called an example, yes. But I think it would be
nice to stick with the upstream layout (where all these are in contrib),
so that people can use e.g. the online documentation (which explicitly
refers to scripts in contrib).


 
 2. You symlink your contrib scripts from /usr/share/doc (!)
 into /usr/bin which is not really the best solution out there. Please
 decide whether these shall either go as examples (and not symlinked
 to /usr/bin/) or whether they are official applications - in which case
 they don't belong into /usr/share/doc.

Well, I think they are certainly not examples. I would be fine to put
expire_backups and pcp into /usr/bin, but I think that benchmark.py and
make_dummy.py are relatively unlikely to be called in day to day use, so
I am hesitant to put them there.

How about putting the former into /usr/bin and symlinking them from
/usr/share/doc/s3ql/contrib (i.e., to the links the other way around)?


 Anyway, built, signed, uploaded.

Thanks!


Best,

   -Nikolaus

-- 
 »Time flies like an arrow, fruit flies like a Banana.«

  PGP fingerprint: 5B93 61F8 4EA2 E279 ABF6  02CF A9AD B7F8 AE4E 425C


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4e0b28f3.10...@rath.org



Re: RFS: s3ql (new python application)

2011-06-29 Thread Nikolaus Rath
On 06/29/2011 09:37 AM, Kilian Krause wrote:
 2. You symlink your contrib scripts from /usr/share/doc (!)
 into /usr/bin which is not really the best solution out there. Please
 decide whether these shall either go as examples (and not symlinked
 to /usr/bin/) or whether they are official applications - in which case
 they don't belong into /usr/share/doc.

 Well, I think they are certainly not examples. I would be fine to put
 expire_backups and pcp into /usr/bin, but I think that benchmark.py and
 make_dummy.py are relatively unlikely to be called in day to day use, so
 I am hesitant to put them there.

 How about putting the former into /usr/bin and symlinking them from
 /usr/share/doc/s3ql/contrib (i.e., to the links the other way around)?
 
 If it's not share/doc/s3ql but share/s3ql I'm perfectly agreed with your
 proposal. ;-)

Ok, new package is on mentors:


dget http://mentors.debian.net/debian/pool/main/s/s3ql/s3ql_1.0.1-2.dsc


   -Nikolaus

-- 
 »Time flies like an arrow, fruit flies like a Banana.«

  PGP fingerprint: 5B93 61F8 4EA2 E279 ABF6  02CF A9AD B7F8 AE4E 425C


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4e0bccdb.5090...@rath.org



Re: RFS: s3ql (new python application)

2011-06-28 Thread Nikolaus Rath
On 06/28/2011 01:47 AM, Kilian Krause wrote:
 Nikolaus,
 
 On Mon, 2011-06-27 at 18:46 -0400, Nikolaus Rath wrote:
 On 06/27/2011 05:32 PM, Kilian Krause wrote:
 5. Your package doesn't build in pbuilder:

 dpkg-source: warning: ignoring deletion of directory doc
 dpkg-source: error: cannot represent change to
 s3ql-1.0.1/distribute-0.6.14.tar.gz: binary file contents changed

 That's weird, it works just fine here, and it also does not download
 anything but uses the existing python-setuptools. Can you tell me what
 commands you used to get this?

 dpkg-source -x s3ql_1.0.1-1.dsc;cd s3ql-1.0.1;pdebuild

 which spawns a fresh unstable pbuilder chroot and installs your listed
 build-deps.

 Hmm. On my system:

 dget http://mentors.debian.net/debian/pool/main/s/s3ql/s3ql_1.0.1-1.dsc
 dpkg-source -x s3ql_1.0.1-1.dsc;cd s3ql-1.0.1;pdebuild

 runs perfectly. I do not have any extra stuff installed in my chroot
 except for vim.

 The complete build output is at

 http://pastebin.com/3na83pQT

 I don't quite know what to do here... do you have any idea? Could you
 post the complete output on your system as well?
 
 the missing build-deps on my system are:
 dpkg-checkbuilddeps: Unmet build dependencies: python-setuptools (=
 0.6.14) python-apsw (= 3.7.0) python-sphinx python-argparse
 python-llfuse (= 0.31) python-pycryptopp python-paramiko python-lzma
 (= 0.5.3)
 
 full build log is at:
 http://people.debian.org/~kilian/s3ql_1.0.1-1_amd64.build

Well, this seems to make this a problem with your chroot rather than
with the S3QL package. The missing build-deps are certainly available in
unstable, see e.g. http://packages.debian.org/sid/python-setuptools

Are you sure you are running an up-to-date unstable pbuilder chroot?


Best,

   -Nikolaus

-- 
 »Time flies like an arrow, fruit flies like a Banana.«

  PGP fingerprint: 5B93 61F8 4EA2 E279 ABF6  02CF A9AD B7F8 AE4E 425C


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4e0a1924.9090...@rath.org



Re: RFS: s3ql (new python application)

2011-06-28 Thread Kilian Krause
Nikolaus,

On Tue, Jun 28, 2011 at 02:10:44PM -0400, Nikolaus Rath wrote:
 On 06/28/2011 01:47 AM, Kilian Krause wrote:
  Nikolaus,
  
  On Mon, 2011-06-27 at 18:46 -0400, Nikolaus Rath wrote:
  On 06/27/2011 05:32 PM, Kilian Krause wrote:
  5. Your package doesn't build in pbuilder:
 
  dpkg-source: warning: ignoring deletion of directory doc
  dpkg-source: error: cannot represent change to
  s3ql-1.0.1/distribute-0.6.14.tar.gz: binary file contents changed
 
  That's weird, it works just fine here, and it also does not download
  anything but uses the existing python-setuptools. Can you tell me what
  commands you used to get this?
 
  dpkg-source -x s3ql_1.0.1-1.dsc;cd s3ql-1.0.1;pdebuild
 
  which spawns a fresh unstable pbuilder chroot and installs your listed
  build-deps.
 
  Hmm. On my system:
 
  dget http://mentors.debian.net/debian/pool/main/s/s3ql/s3ql_1.0.1-1.dsc
  dpkg-source -x s3ql_1.0.1-1.dsc;cd s3ql-1.0.1;pdebuild
 
  runs perfectly. I do not have any extra stuff installed in my chroot
  except for vim.
 
  The complete build output is at
 
  http://pastebin.com/3na83pQT
 
  I don't quite know what to do here... do you have any idea? Could you
  post the complete output on your system as well?
  
  the missing build-deps on my system are:
  dpkg-checkbuilddeps: Unmet build dependencies: python-setuptools (=
  0.6.14) python-apsw (= 3.7.0) python-sphinx python-argparse
  python-llfuse (= 0.31) python-pycryptopp python-paramiko python-lzma
  (= 0.5.3)
  
  full build log is at:
  http://people.debian.org/~kilian/s3ql_1.0.1-1_amd64.build
 
 Well, this seems to make this a problem with your chroot rather than
 with the S3QL package. The missing build-deps are certainly available in
 unstable, see e.g. http://packages.debian.org/sid/python-setuptools
 
 Are you sure you are running an up-to-date unstable pbuilder chroot?

as was already mentioned previously the pbuild command runs 
fakeroot debian/rules clean in the local user's context *before* it spawns
off into the chroot. Thus the clean target in a best practice shouldn't fail
if build-deps aren't installed and only undo what really needs to be cleaned
up. This has nothing to do with the chroot itself.

That's why I mentioned the build-deps that are missing on my user's
environment (and clearly they would be installed in the pbuilder chroot once
the build begins).

If the clean target wouldn't pull in extra stuff I'd not care that fails
before the build actually begins. The only problem is that it downloads
stuff off the internet which is not what I'd expect from a clean target
under *any* circumstance (and not of any other target for that matter).

-- 
Best regards,
Kilian


signature.asc
Description: Digital signature


Re: RFS: s3ql (new python application)

2011-06-28 Thread Nikolaus Rath
On 06/28/2011 02:38 PM, Kilian Krause wrote:
 Nikolaus,
 
 On Tue, Jun 28, 2011 at 02:10:44PM -0400, Nikolaus Rath wrote:
 On 06/28/2011 01:47 AM, Kilian Krause wrote:
 Nikolaus,

 On Mon, 2011-06-27 at 18:46 -0400, Nikolaus Rath wrote:
 On 06/27/2011 05:32 PM, Kilian Krause wrote:
 5. Your package doesn't build in pbuilder:

 dpkg-source: warning: ignoring deletion of directory doc
 dpkg-source: error: cannot represent change to
 s3ql-1.0.1/distribute-0.6.14.tar.gz: binary file contents changed

 That's weird, it works just fine here, and it also does not download
 anything but uses the existing python-setuptools. Can you tell me what
 commands you used to get this?

 dpkg-source -x s3ql_1.0.1-1.dsc;cd s3ql-1.0.1;pdebuild

 which spawns a fresh unstable pbuilder chroot and installs your listed
 build-deps.

 Hmm. On my system:

 dget http://mentors.debian.net/debian/pool/main/s/s3ql/s3ql_1.0.1-1.dsc
 dpkg-source -x s3ql_1.0.1-1.dsc;cd s3ql-1.0.1;pdebuild

 runs perfectly. I do not have any extra stuff installed in my chroot
 except for vim.

 The complete build output is at

 http://pastebin.com/3na83pQT

 I don't quite know what to do here... do you have any idea? Could you
 post the complete output on your system as well?

 the missing build-deps on my system are:
 dpkg-checkbuilddeps: Unmet build dependencies: python-setuptools (=
 0.6.14) python-apsw (= 3.7.0) python-sphinx python-argparse
 python-llfuse (= 0.31) python-pycryptopp python-paramiko python-lzma
 (= 0.5.3)

 full build log is at:
 http://people.debian.org/~kilian/s3ql_1.0.1-1_amd64.build

 Well, this seems to make this a problem with your chroot rather than
 with the S3QL package. The missing build-deps are certainly available in
 unstable, see e.g. http://packages.debian.org/sid/python-setuptools

 Are you sure you are running an up-to-date unstable pbuilder chroot?
 
 as was already mentioned previously the pbuild command runs 
 fakeroot debian/rules clean in the local user's context *before* it spawns
 off into the chroot. Thus the clean target in a best practice shouldn't fail
 if build-deps aren't installed and only undo what really needs to be cleaned
 up. This has nothing to do with the chroot itself.
 
 That's why I mentioned the build-deps that are missing on my user's
 environment (and clearly they would be installed in the pbuilder chroot once
 the build begins).
 
 If the clean target wouldn't pull in extra stuff I'd not care that fails
 before the build actually begins. The only problem is that it downloads
 stuff off the internet which is not what I'd expect from a clean target
 under *any* circumstance (and not of any other target for that matter).


Ah, now I get it, thanks!

I've just uploaded a new version that doesn't use setup.py for cleaning
up, this should solve the problem.

Version number is still the same,

dget http://mentors.debian.net/debian/pool/main/s/s3ql/s3ql_1.0.1-1.dsc


Best,

   -Nikolaus

-- 
 »Time flies like an arrow, fruit flies like a Banana.«

  PGP fingerprint: 5B93 61F8 4EA2 E279 ABF6  02CF A9AD B7F8 AE4E 425C


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4e0a23c4.6030...@rath.org



Re: RFS: s3ql (new python application)

2011-06-27 Thread Kilian Krause
Hi Nikolaus,

On Sat, 2011-06-25 at 21:05 -0400, Nikolaus Rath wrote:
 I am looking for a sponsor for my package s3ql.
 
 * Package name: s3ql
   Version : 1.0.1-1
   Upstream Author : me (Nikolaus Rath nikol...@rath.org)
 * URL : http://code.google.com/p/s3ql/
 * License : GPLv3
   Section : misc
 
 It builds these binary packages:
 s3ql   - Full-featured file system for online data storage
 
 The package appears to be lintian clean.
 
 ITP: 626651
 
 I'd be happy to join the python-apps-team and have this team maintained,
 but so far I did not get any response on my request to join the team on
 Alioth. Should I be doing anything else?
 
 
 At the moment, the package can be found on mentors.debian.net:
 - URL: http://mentors.debian.net/debian/pool/main/s/s3ql
 - Source repository: deb-src http://mentors.debian.net/debian unstable main 
 contrib non-free
 - dget http://mentors.debian.net/debian/pool/main/s/s3ql/s3ql_1.0.1-1.dsc
 
 I would be glad if someone uploaded this package for me.

Thanks for your work. Here goes my comments:

1. You use quilt as build-depends. This should not be neccessary with
dpkg-source v3.

2. fix-sys-path.patch feels like you should split out the python modules
into the standard python path. That may also cause ${python:Depends} to
match further packages directly without having them explicitly spelled
out on the Depends line in debian/control

Setting --install-lib=/usr/share/s3ql to something more sensible
(according to [1] would be /usr/lib/s3ql) will help here.

3. debian/README.Debian doesn't need to be in *.docs. See man
dh_installdocs:
 Each of these files is automatically installed if present for a
 package.

4. Downloading
http://pypi.python.org/packages/source/d/distribute/distribute-0.6.14.tar.gz
Extracting in /tmp/tmpeY0G4V

OUCH! buildds do not all have internet access. Your package should build
fine without that. Moreover the contents of the pulled in tarball could
be anything. Thus ensuring DFSG-free sources is virtually impossible
when external sources are pulled in.

5. Your package doesn't build in pbuilder:

dpkg-source: warning: ignoring deletion of directory doc
dpkg-source: error: cannot represent change to
s3ql-1.0.1/distribute-0.6.14.tar.gz: binary file contents changed
dpkg-source: error: add distribute-0.6.14.tar.gz in
debian/source/include-binaries if you want to store the modified binary
in the debian tarball
dpkg-source: error: cannot represent change to
s3ql-1.0.1/distribute-0.6.14-py2.6.egg: binary file contents changed
dpkg-source: error: add distribute-0.6.14-py2.6.egg in
debian/source/include-binaries if you want to store the modified binary
in the debian tarball
dpkg-source: error: cannot represent change to
s3ql-1.0.1/distribute-0.6.14-py2.7.egg: binary file contents changed
dpkg-source: error: add distribute-0.6.14-py2.7.egg in
debian/source/include-binaries if you want to store the modified binary
in the debian tarball
dpkg-source: error: unrepresentable changes to source
dpkg-buildpackage: error: dpkg-source -b s3ql-1.0.1 gave error exit
status 2


[1]:
http://www.debian.org/doc/packaging-manuals/python-policy/ch-module_packages.html

Sorry!

-- 
Regards,
Kilian


signature.asc
Description: This is a digitally signed message part


Re: RFS: s3ql (new python application)

2011-06-27 Thread Jakub Wilk

* Kilian Krause kil...@debian.org, 2011-06-27, 11:20:
2. fix-sys-path.patch feels like you should split out the python 
modules into the standard python path.


No. Putting private modules into, well, a private directory is the best 
practice.



Setting --install-lib=/usr/share/s3ql to something more sensible
(according to [1] would be /usr/lib/s3ql) will help here.


Again, no. Even the Python Policy chapter you quotes explicitly says 
/usr/share/s3ql is all right:



http://www.debian.org/doc/packaging-manuals/python-policy/ch-module_packages.html


The more relevant Python Policy chapter would be
http://www.debian.org/doc/packaging-manuals/python-policy/ch-programs.html
however.

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110627095400.ga9...@jwilk.net



Re: RFS: s3ql (new python application)

2011-06-27 Thread Kilian Krause
Jakub,

On Mon, 2011-06-27 at 11:54 +0200, Jakub Wilk wrote:
 * Kilian Krause kil...@debian.org, 2011-06-27, 11:20:
 2. fix-sys-path.patch feels like you should split out the python 
 modules into the standard python path.
 
 No. Putting private modules into, well, a private directory is the best 
 practice.
 
 Setting --install-lib=/usr/share/s3ql to something more sensible
 (according to [1] would be /usr/lib/s3ql) will help here.
 
 Again, no. Even the Python Policy chapter you quotes explicitly says 
 /usr/share/s3ql is all right:
 
 http://www.debian.org/doc/packaging-manuals/python-policy/ch-module_packages.html
 
 The more relevant Python Policy chapter would be
 http://www.debian.org/doc/packaging-manuals/python-policy/ch-programs.html
 however.

thanks for double checking. I was somewhat under the impression that
these modules might be used sort of as a library by other programs too.
But I admit that I had a too brief look and should have checked closer.

In any case if upstream foresees this as lib for other python scripts
to use (as is suggested by the configure parameter) then it should be
consequently installed as public lib. If it's private then upstream
should foresee that option consistently in the configure script and
sources. The correct path set for configure PLUS patching still feels
wrong.

-- 
Best regards,
Kilian


signature.asc
Description: This is a digitally signed message part


Re: RFS: s3ql (new python application)

2011-06-27 Thread Nikolaus Rath
Kilian Krause kilian-8fiuurrzop0dnm+yrof...@public.gmane.org writes:
 Hi Nikolaus,

 On Sat, 2011-06-25 at 21:05 -0400, Nikolaus Rath wrote:
 I am looking for a sponsor for my package s3ql.
 
 * Package name: s3ql
   Version : 1.0.1-1
   Upstream Author : me (Nikolaus Rath 
 nikolaus-bth8mxji...@public.gmane.org)
 * URL : http://code.google.com/p/s3ql/
 * License : GPLv3
   Section : misc
 
 It builds these binary packages:
 s3ql   - Full-featured file system for online data storage
 
 The package appears to be lintian clean.
 
 ITP: 626651
 
 I'd be happy to join the python-apps-team and have this team maintained,
 but so far I did not get any response on my request to join the team on
 Alioth. Should I be doing anything else?
 
 
 At the moment, the package can be found on mentors.debian.net:
 - URL: http://mentors.debian.net/debian/pool/main/s/s3ql
 - Source repository: deb-src http://mentors.debian.net/debian unstable main 
 contrib non-free
 - dget http://mentors.debian.net/debian/pool/main/s/s3ql/s3ql_1.0.1-1.dsc
 
 I would be glad if someone uploaded this package for me.

 Thanks for your work. Here goes my comments:

 1. You use quilt as build-depends. This should not be neccessary with
 dpkg-source v3.

It seems to be. Without quilt:

dh clean --with python2,quilt
dh: unable to load addon quilt: Can't locate Debian/Debhelper/Sequence/quilt.pm 
in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.12.3 
/usr/local/share/perl/5.12.3 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.12 
/usr/share/perl/5.12 /usr/local/lib/site_perl .) at (eval 23) line 2.
BEGIN failed--compilation aborted at (eval 23) line 2.


 3. debian/README.Debian doesn't need to be in *.docs. See man
 dh_installdocs:

Thanks, fixed.

 4. Downloading
 http://pypi.python.org/packages/source/d/distribute/distribute-0.6.14.tar.gz
 Extracting in /tmp/tmpeY0G4V

 OUCH! buildds do not all have internet access. Your package should build
 fine without that. Moreover the contents of the pulled in tarball could
 be anything. Thus ensuring DFSG-free sources is virtually impossible
 when external sources are pulled in.

 5. Your package doesn't build in pbuilder:

 dpkg-source: warning: ignoring deletion of directory doc
 dpkg-source: error: cannot represent change to
 s3ql-1.0.1/distribute-0.6.14.tar.gz: binary file contents changed

That's weird, it works just fine here, and it also does not download
anything but uses the existing python-setuptools. Can you tell me what
commands you used to get this?


Best,

   -Nikolaus

-- 
 »Time flies like an arrow, fruit flies like a Banana.«

  PGP fingerprint: 5B93 61F8 4EA2 E279 ABF6  02CF A9AD B7F8 AE4E 425C


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/87iprrozkq@inspiron.ap.columbia.edu



Re: RFS: s3ql (new python application)

2011-06-27 Thread Arno Töll
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi Nikolaus,

On 27.06.2011 21:15, Nikolaus Rath wrote:
 It seems to be. Without quilt:
 
 dh clean --with python2,quilt
 dh: unable to load addon quilt: Can't locate 
 Debian/Debhelper/Sequence/quilt.pm in @INC (@INC contains: /etc/perl 
 /usr/local/lib/perl/5.12.3 /usr/local/share/perl/5.12.3 /usr/lib/perl5 
 /usr/share/perl5 /usr/lib/perl/5.12 /usr/share/perl/5.12 
 /usr/local/lib/site_perl .) at (eval 23) line 2.
 BEGIN failed--compilation aborted at (eval 23) line 2.

this is, because you configured:

%:
dh $@ --with python2,quilt

which runs dh_quilt_patch upon creation of the source directory. This is
not necessary when using the new quilt 3.0 format which does this
implicitly.

That said, you should be able to remove the quilt addon from dh and
everything should still work (untested).

- -- 
with kind regards,
Arno Töll
IRC: daemonkeeper on Freenode/OFTC
GnuPG Key-ID: 0x9D80F36D
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOCOHFAAoJEMcrUe6dgPNt+HYP/2ZuwNIS7dQTslXxd+LWBpdd
8N+9AHYSOyfimdL8aM5LhXqNsasd7J8fqDWabYVOfL/HSh3RkHJ58ITZrqLBdaoL
qRjok8G76RAcYStba+LHv+rUI4v3YI5nAZVRi/+nZ43dHLWHHFRsHQp02kzB8VQp
PZAqoSSAw6uxK+bekq36yVlmJE6efezuPa+T7Q4WdPmSadJRbKu0ry7/rK5qTvbF
eLGISJSzvpoIUmanxRLjS5a1zoHe258tWU0q/wjXDJ5x/AOtVkGQpoT9P+rLGwoE
LrbOzy0ZTPj+x85cLt/X7CusNFAlbB5BvrlDHzD/3wrQt3J3OfOG4iP2Uw9cIngY
OoxS7lbN8s6sdKWMLueKb6m+tH2gTTuX+oohtPge0I4LCKxsP/f5bfYTrtv23CJQ
NDiW05uYXXglZAaIh56vmpR/UBdkkjk11s0+VAho3azbzbLJb5ZwtVMtO/4FPAp+
Sd5YTwGKFOxFqLm4SeJGkonjqd0jENYrOhkVvhkrFXKqUYXJudklQJaGzdQsBvgK
bZMIhD6EvFpZTUNFX14ajfjXysPSoojiAeq4az0bepgLn9KNdLNuSG6cki7inIYw
WsOwuorL6oSyABMRkkegeYP0TSXmKkVjIr5SQ0p5ATLX0OlqdH/jdTBGvsYFHRur
rVbpBs1NdZDLs8zs9X3D
=t7TR
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4e08e1c6.5040...@toell.net



Re: RFS: s3ql (new python application)

2011-06-27 Thread Kilian Krause
Hi Nikolaus,

On Mon, Jun 27, 2011 at 03:15:49PM -0400, Nikolaus Rath wrote:
  1. You use quilt as build-depends. This should not be neccessary with
  dpkg-source v3.
 
 It seems to be. Without quilt:
 
 dh clean --with python2,quilt
 dh: unable to load addon quilt: Can't locate 
 Debian/Debhelper/Sequence/quilt.pm in @INC (@INC contains: /etc/perl 
 /usr/local/lib/perl/5.12.3 /usr/local/share/perl/5.12.3 /usr/lib/perl5 
 /usr/share/perl5 /usr/lib/perl/5.12 /usr/share/perl/5.12 
 /usr/local/lib/site_perl .) at (eval 23) line 2.
 BEGIN failed--compilation aborted at (eval 23) line 2.

my suggestion would be the same as Arno already pointed out. The --with
quilt part should not be needed - I hope.


  3. debian/README.Debian doesn't need to be in *.docs. See man
  dh_installdocs:
 
 Thanks, fixed.
 
  4. Downloading
  http://pypi.python.org/packages/source/d/distribute/distribute-0.6.14.tar.gz
  Extracting in /tmp/tmpeY0G4V
 
  OUCH! buildds do not all have internet access. Your package should build
  fine without that. Moreover the contents of the pulled in tarball could
  be anything. Thus ensuring DFSG-free sources is virtually impossible
  when external sources are pulled in.
 
  5. Your package doesn't build in pbuilder:
 
  dpkg-source: warning: ignoring deletion of directory doc
  dpkg-source: error: cannot represent change to
  s3ql-1.0.1/distribute-0.6.14.tar.gz: binary file contents changed
 
 That's weird, it works just fine here, and it also does not download
 anything but uses the existing python-setuptools. Can you tell me what
 commands you used to get this?

dpkg-source -x s3ql_1.0.1-1.dsc;cd s3ql-1.0.1;pdebuild

which spawns a fresh unstable pbuilder chroot and installs your listed
build-deps.

-- 
Best regards,
Kilian


signature.asc
Description: Digital signature


Re: RFS: s3ql (new python application)

2011-06-27 Thread Nikolaus Rath
On 06/27/2011 05:32 PM, Kilian Krause wrote:
 5. Your package doesn't build in pbuilder:

 dpkg-source: warning: ignoring deletion of directory doc
 dpkg-source: error: cannot represent change to
 s3ql-1.0.1/distribute-0.6.14.tar.gz: binary file contents changed

 That's weird, it works just fine here, and it also does not download
 anything but uses the existing python-setuptools. Can you tell me what
 commands you used to get this?
 
 dpkg-source -x s3ql_1.0.1-1.dsc;cd s3ql-1.0.1;pdebuild
 
 which spawns a fresh unstable pbuilder chroot and installs your listed
 build-deps.

Hmm. On my system:

dget http://mentors.debian.net/debian/pool/main/s/s3ql/s3ql_1.0.1-1.dsc
dpkg-source -x s3ql_1.0.1-1.dsc;cd s3ql-1.0.1;pdebuild

runs perfectly. I do not have any extra stuff installed in my chroot
except for vim.

The complete build output is at

http://pastebin.com/3na83pQT

I don't quite know what to do here... do you have any idea? Could you
post the complete output on your system as well?


Best,

   -Nikolaus

-- 
 »Time flies like an arrow, fruit flies like a Banana.«

  PGP fingerprint: 5B93 61F8 4EA2 E279 ABF6  02CF A9AD B7F8 AE4E 425C


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4e090860.8010...@rath.org



Re: RFS: s3ql (new python application)

2011-06-27 Thread Jakub Wilk

* Nikolaus Rath nikol...@rath.org, 2011-06-27, 18:46:

5. Your package doesn't build in pbuilder:

dpkg-source: warning: ignoring deletion of directory doc
dpkg-source: error: cannot represent change to
s3ql-1.0.1/distribute-0.6.14.tar.gz: binary file contents changed


That's weird, it works just fine here, and it also does not download
anything but uses the existing python-setuptools. Can you tell me 
what commands you used to get this?


dpkg-source -x s3ql_1.0.1-1.dsc;cd s3ql-1.0.1;pdebuild

which spawns a fresh unstable pbuilder chroot and installs your 
listed build-deps.


Hmm. On my system:

dget http://mentors.debian.net/debian/pool/main/s/s3ql/s3ql_1.0.1-1.dsc
dpkg-source -x s3ql_1.0.1-1.dsc;cd s3ql-1.0.1;pdebuild

runs perfectly. I do not have any extra stuff installed in my chroot 
except for vim.


My wild[0] guess is that bad thing happen _outside_ chroot: pdebuild 
runs the clean target without build-dependencies installed.



[0] I didn't look at the package lately and I've never user pdebuild.

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110627231458.ga7...@jwilk.net



Re: RFS: s3ql (new python application)

2011-06-27 Thread Kilian Krause
Nikolaus,

On Mon, 2011-06-27 at 18:46 -0400, Nikolaus Rath wrote:
 On 06/27/2011 05:32 PM, Kilian Krause wrote:
  5. Your package doesn't build in pbuilder:
 
  dpkg-source: warning: ignoring deletion of directory doc
  dpkg-source: error: cannot represent change to
  s3ql-1.0.1/distribute-0.6.14.tar.gz: binary file contents changed
 
  That's weird, it works just fine here, and it also does not download
  anything but uses the existing python-setuptools. Can you tell me what
  commands you used to get this?
  
  dpkg-source -x s3ql_1.0.1-1.dsc;cd s3ql-1.0.1;pdebuild
  
  which spawns a fresh unstable pbuilder chroot and installs your listed
  build-deps.
 
 Hmm. On my system:
 
 dget http://mentors.debian.net/debian/pool/main/s/s3ql/s3ql_1.0.1-1.dsc
 dpkg-source -x s3ql_1.0.1-1.dsc;cd s3ql-1.0.1;pdebuild
 
 runs perfectly. I do not have any extra stuff installed in my chroot
 except for vim.
 
 The complete build output is at
 
 http://pastebin.com/3na83pQT
 
 I don't quite know what to do here... do you have any idea? Could you
 post the complete output on your system as well?

the missing build-deps on my system are:
dpkg-checkbuilddeps: Unmet build dependencies: python-setuptools (=
0.6.14) python-apsw (= 3.7.0) python-sphinx python-argparse
python-llfuse (= 0.31) python-pycryptopp python-paramiko python-lzma
(= 0.5.3)

full build log is at:
http://people.debian.org/~kilian/s3ql_1.0.1-1_amd64.build

-- 
Regards,
Kilian


signature.asc
Description: This is a digitally signed message part


RFS: s3ql (new python application)

2011-06-25 Thread Nikolaus Rath
Hello,

I am looking for a sponsor for my package s3ql.

* Package name: s3ql
  Version : 1.0.1-1
  Upstream Author : me (Nikolaus Rath nikol...@rath.org)
* URL : http://code.google.com/p/s3ql/
* License : GPLv3
  Section : misc

It builds these binary packages:
s3ql   - Full-featured file system for online data storage

The package appears to be lintian clean.

ITP: 626651

I'd be happy to join the python-apps-team and have this team maintained,
but so far I did not get any response on my request to join the team on
Alioth. Should I be doing anything else?


At the moment, the package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/s/s3ql
- Source repository: deb-src http://mentors.debian.net/debian unstable main 
contrib non-free
- dget http://mentors.debian.net/debian/pool/main/s/s3ql/s3ql_1.0.1-1.dsc

I would be glad if someone uploaded this package for me.

Best,

   -Nikolaus

-- 
 »Time flies like an arrow, fruit flies like a Banana.«

  PGP fingerprint: 5B93 61F8 4EA2 E279 ABF6  02CF A9AD B7F8 AE4E 425C


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/87d3i1v1un@vostro.rath.org



RFS: s3ql (new python application)

2011-06-17 Thread Nikolaus Rath
Hello,

I am looking for a sponsor for my package s3ql.

* Package name: s3ql
  Version : 1.0.1-1
  Upstream Author : me (Nikolaus Rath nikol...@rath.org)
* URL : http://code.google.com/p/s3ql/
* License : GPLv3
  Section : misc

It builds these binary packages:
s3ql   - Full-featured file system for online data storage

The package appears to be lintian clean.

ITP: 626651

I'd be happy to join the python-apps-team and have this team maintained,
but so far I did not get any response on my request to join the team on
Alioth. Should I be doing anything else?


At the moment, the package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/s/s3ql
- Source repository: deb-src http://mentors.debian.net/debian unstable main 
contrib non-free
- dget http://mentors.debian.net/debian/pool/main/s/s3ql/s3ql_1.0.1-1.dsc

I would be glad if someone uploaded this package for me.

Best,

   -Nikolaus

-- 
 »Time flies like an arrow, fruit flies like a Banana.«

  PGP fingerprint: 5B93 61F8 4EA2 E279 ABF6  02CF A9AD B7F8 AE4E 425C


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/87hb7nq3ch@vostro.rath.org